)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"a1ad814af87f32fafd62ac962bd4b06f5d428feb","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Hamdy Khader \u003chamdyk@mellanox.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-02-11 16:52:28 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Replace target_protocol values iscsi, iser with tcp, rdma."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Since NVME target driver will be implemented, it\u0027s better"},{"line_number":10,"context_line":"to use [tcp, rdma] as values for target_protocol."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3fa0c359_df9d6dbc","line":7,"range":{"start_line":7,"start_character":57,"end_line":7,"end_character":58},"updated":"2018-02-13 03:18:51.000000000","message":"remove the dot","commit_id":"4884c9ec1d3b41fb0b1d4fed1c095f239a34cb0a"}],"cinder/volume/driver.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"2f6331749a981675f9bd60f21bafa28356029f13","unresolved":false,"context_lines":[{"line_number":146,"context_line":"    cfg.StrOpt(\u0027target_protocol\u0027,"},{"line_number":147,"context_line":"               deprecated_name\u003d\u0027iscsi_protocol\u0027,"},{"line_number":148,"context_line":"               default\u003d\u0027tcp\u0027,"},{"line_number":149,"context_line":"               choices\u003d[\u0027tcp\u0027, \u0027rdma\u0027],"},{"line_number":150,"context_line":"               help\u003d\u0027Determines the iSCSI protocol for new iSCSI volumes, \u0027"},{"line_number":151,"context_line":"                    \u0027created with tgtadm or lioadm target helpers. In \u0027"},{"line_number":152,"context_line":"                    \u0027order to enable RDMA, this parameter should be set \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f93b717_1df2d307","line":149,"updated":"2018-01-24 15:38:41.000000000","message":"This isn\u0027t deprecation, this is removal of options -- you have to maintain compatibility with existing config files for now.","commit_id":"f4a7e48bf2a4b62315ce94f9e90735ec6352f29f"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"a1ad814af87f32fafd62ac962bd4b06f5d428feb","unresolved":false,"context_lines":[{"line_number":152,"context_line":"                    \u0027order to enable RDMA, this parameter should be set \u0027"},{"line_number":153,"context_line":"                    \u0027with the value \"iser\". The supported iSCSI protocol \u0027"},{"line_number":154,"context_line":"                    \u0027values are \"iscsi\" and \"iser\".\u0027),"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    cfg.StrOpt(\u0027driver_client_cert_key\u0027,"},{"line_number":157,"context_line":"               help\u003d\u0027The path to the client certificate key for verification, \u0027"},{"line_number":158,"context_line":"                    \u0027if the driver supports it.\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa0c359_dfeb2d10","line":155,"updated":"2018-02-13 03:18:51.000000000","message":"please remove the line","commit_id":"4884c9ec1d3b41fb0b1d4fed1c095f239a34cb0a"},{"author":{"_account_id":22948,"name":"Hamdy Khader","email":"hamdyk@mellanox.com","username":"hamdyk"},"change_message_id":"51ef59454d19a5dc60d36e4a297e39223aaf4d93","unresolved":false,"context_lines":[{"line_number":152,"context_line":"                    \u0027order to enable RDMA, this parameter should be set \u0027"},{"line_number":153,"context_line":"                    \u0027with the value \"iser\". The supported iSCSI protocol \u0027"},{"line_number":154,"context_line":"                    \u0027values are \"iscsi\" and \"iser\".\u0027),"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    cfg.StrOpt(\u0027driver_client_cert_key\u0027,"},{"line_number":157,"context_line":"               help\u003d\u0027The path to the client certificate key for verification, \u0027"},{"line_number":158,"context_line":"                    \u0027if the driver supports it.\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa0c359_2caa2618","line":155,"in_reply_to":"3fa0c359_dfeb2d10","updated":"2018-02-19 13:37:55.000000000","message":"Done","commit_id":"4884c9ec1d3b41fb0b1d4fed1c095f239a34cb0a"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"a1ad814af87f32fafd62ac962bd4b06f5d428feb","unresolved":false,"context_lines":[{"line_number":2502,"context_line":"      `CHAP` is the only auth_method in use at the moment."},{"line_number":2503,"context_line":"    \"\"\""},{"line_number":2504,"context_line":""},{"line_number":2505,"context_line":"    # Mapping target protocol to storage protocol"},{"line_number":2506,"context_line":"    target_protocol_mapping \u003d {"},{"line_number":2507,"context_line":"        \u0027tcp\u0027: \u0027iscsi\u0027,"},{"line_number":2508,"context_line":"        \u0027rdma\u0027: \u0027iser\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa0c359_3fb9f113","line":2505,"range":{"start_line":2505,"start_character":6,"end_line":2505,"end_character":49},"updated":"2018-02-13 03:18:51.000000000","message":"just put a comment why this is need.\nbecause we want to deprecate iser and iscsi and use generic transport protocol such as tcp and rdma to fit the nvmeof","commit_id":"4884c9ec1d3b41fb0b1d4fed1c095f239a34cb0a"},{"author":{"_account_id":22948,"name":"Hamdy Khader","email":"hamdyk@mellanox.com","username":"hamdyk"},"change_message_id":"51ef59454d19a5dc60d36e4a297e39223aaf4d93","unresolved":false,"context_lines":[{"line_number":2502,"context_line":"      `CHAP` is the only auth_method in use at the moment."},{"line_number":2503,"context_line":"    \"\"\""},{"line_number":2504,"context_line":""},{"line_number":2505,"context_line":"    # Mapping target protocol to storage protocol"},{"line_number":2506,"context_line":"    target_protocol_mapping \u003d {"},{"line_number":2507,"context_line":"        \u0027tcp\u0027: \u0027iscsi\u0027,"},{"line_number":2508,"context_line":"        \u0027rdma\u0027: \u0027iser\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa0c359_6c102e58","line":2505,"range":{"start_line":2505,"start_character":6,"end_line":2505,"end_character":49},"in_reply_to":"3fa0c359_3fb9f113","updated":"2018-02-19 13:37:55.000000000","message":"Done","commit_id":"4884c9ec1d3b41fb0b1d4fed1c095f239a34cb0a"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"b451af61e5b5b814e3e34a9cd91330b06a3f2471","unresolved":false,"context_lines":[{"line_number":150,"context_line":"               help\u003d\u0027Determines the iSCSI protocol for new iSCSI volumes, \u0027"},{"line_number":151,"context_line":"                    \u0027created with tgtadm or lioadm target helpers. In \u0027"},{"line_number":152,"context_line":"                    \u0027order to enable RDMA, this parameter should be set \u0027"},{"line_number":153,"context_line":"                    \u0027with the value \"iser\". The supported iSCSI protocol \u0027"},{"line_number":154,"context_line":"                    \u0027values are \"iscsi\" and \"iser\".\u0027),"},{"line_number":155,"context_line":"    cfg.StrOpt(\u0027driver_client_cert_key\u0027,"},{"line_number":156,"context_line":"               help\u003d\u0027The path to the client certificate key for verification, \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa0c359_69942be9","line":153,"range":{"start_line":153,"start_character":37,"end_line":153,"end_character":41},"updated":"2018-02-18 11:39:45.000000000","message":"If we want to deprecate these options, then it should state that information in the help message.\n\nThere should also be a check where it is used that will emit a warning if a deprecated option is being used.","commit_id":"8e6b4600be342609c42783655dc3a2deecb5b2df"},{"author":{"_account_id":22948,"name":"Hamdy Khader","email":"hamdyk@mellanox.com","username":"hamdyk"},"change_message_id":"51ef59454d19a5dc60d36e4a297e39223aaf4d93","unresolved":false,"context_lines":[{"line_number":150,"context_line":"               help\u003d\u0027Determines the iSCSI protocol for new iSCSI volumes, \u0027"},{"line_number":151,"context_line":"                    \u0027created with tgtadm or lioadm target helpers. In \u0027"},{"line_number":152,"context_line":"                    \u0027order to enable RDMA, this parameter should be set \u0027"},{"line_number":153,"context_line":"                    \u0027with the value \"iser\". The supported iSCSI protocol \u0027"},{"line_number":154,"context_line":"                    \u0027values are \"iscsi\" and \"iser\".\u0027),"},{"line_number":155,"context_line":"    cfg.StrOpt(\u0027driver_client_cert_key\u0027,"},{"line_number":156,"context_line":"               help\u003d\u0027The path to the client certificate key for verification, \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa0c359_786385dd","line":153,"range":{"start_line":153,"start_character":37,"end_line":153,"end_character":41},"in_reply_to":"3fa0c359_69942be9","updated":"2018-02-19 13:37:55.000000000","message":"updated the help message to be more clear of how to use the values.","commit_id":"8e6b4600be342609c42783655dc3a2deecb5b2df"}],"cinder/volume/drivers/synology/synology_iscsi.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"b451af61e5b5b814e3e34a9cd91330b06a3f2471","unresolved":false,"context_lines":[{"line_number":158,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":159,"context_line":"                LOG.exception(\u0027Failed to initialize_connection.\u0027)"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"        target_protocol \u003d \\"},{"line_number":162,"context_line":"            self.configuration.safe_get(\u0027target_protocol\u0027) or \u0027tcp\u0027"},{"line_number":163,"context_line":"        volume_type \u003d target_protocol_mapping[target_protocol]"},{"line_number":164,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa0c359_e987dbb5","line":161,"range":{"start_line":161,"start_character":26,"end_line":161,"end_character":27},"updated":"2018-02-18 11:39:45.000000000","message":"Do not use \\ to span multiple lines. Wrap values in () if needed.","commit_id":"8e6b4600be342609c42783655dc3a2deecb5b2df"},{"author":{"_account_id":22948,"name":"Hamdy Khader","email":"hamdyk@mellanox.com","username":"hamdyk"},"change_message_id":"51ef59454d19a5dc60d36e4a297e39223aaf4d93","unresolved":false,"context_lines":[{"line_number":158,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":159,"context_line":"                LOG.exception(\u0027Failed to initialize_connection.\u0027)"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"        target_protocol \u003d \\"},{"line_number":162,"context_line":"            self.configuration.safe_get(\u0027target_protocol\u0027) or \u0027tcp\u0027"},{"line_number":163,"context_line":"        volume_type \u003d target_protocol_mapping[target_protocol]"},{"line_number":164,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa0c359_01d0d3f6","line":161,"range":{"start_line":161,"start_character":26,"end_line":161,"end_character":27},"in_reply_to":"3fa0c359_e987dbb5","updated":"2018-02-19 13:37:55.000000000","message":"Done","commit_id":"8e6b4600be342609c42783655dc3a2deecb5b2df"}],"cinder/volume/targets/iscsi.py":[{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"a1ad814af87f32fafd62ac962bd4b06f5d428feb","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    etc."},{"line_number":34,"context_line":"    \"\"\""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    # Mapping target protocol to storage protocol"},{"line_number":37,"context_line":"    target_protocol_mapping \u003d {"},{"line_number":38,"context_line":"        \u0027tcp\u0027: \u0027iscsi\u0027,"},{"line_number":39,"context_line":"        \u0027rdma\u0027: \u0027iser\u0027,"},{"line_number":40,"context_line":"        \u0027iscsi\u0027: \u0027iscsi\u0027,"},{"line_number":41,"context_line":"        \u0027iser\u0027: \u0027iser\u0027"},{"line_number":42,"context_line":"    }"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":45,"context_line":"        super(ISCSITarget, self).__init__(*args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa0c359_9f0da5e9","line":42,"range":{"start_line":36,"start_character":0,"end_line":42,"end_character":5},"updated":"2018-02-13 03:18:51.000000000","message":"why again the mapping???","commit_id":"4884c9ec1d3b41fb0b1d4fed1c095f239a34cb0a"},{"author":{"_account_id":22948,"name":"Hamdy Khader","email":"hamdyk@mellanox.com","username":"hamdyk"},"change_message_id":"51ef59454d19a5dc60d36e4a297e39223aaf4d93","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    etc."},{"line_number":34,"context_line":"    \"\"\""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    # Mapping target protocol to storage protocol"},{"line_number":37,"context_line":"    target_protocol_mapping \u003d {"},{"line_number":38,"context_line":"        \u0027tcp\u0027: \u0027iscsi\u0027,"},{"line_number":39,"context_line":"        \u0027rdma\u0027: \u0027iser\u0027,"},{"line_number":40,"context_line":"        \u0027iscsi\u0027: \u0027iscsi\u0027,"},{"line_number":41,"context_line":"        \u0027iser\u0027: \u0027iser\u0027"},{"line_number":42,"context_line":"    }"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":45,"context_line":"        super(ISCSITarget, self).__init__(*args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa0c359_a2a39dff","line":42,"range":{"start_line":36,"start_character":0,"end_line":42,"end_character":5},"in_reply_to":"3fa0c359_9f0da5e9","updated":"2018-02-19 13:37:55.000000000","message":"we need the mapping here as well, but we can import the from volume.driver","commit_id":"4884c9ec1d3b41fb0b1d4fed1c095f239a34cb0a"}]}