)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"424b99f83b85cc28b18c70b765cb124662d63d31","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Similar to change I0857cecd7d8ab0ee7e3e9bd6e15f4987ede4d653, the"},{"line_number":10,"context_line":"swift backup driver cannot be logging stuff while in a thread during"},{"line_number":11,"context_line":"read and write operations. swiftclient logs requests and responses"},{"line_number":12,"context_line":"at DEBUG level, which can cause a thread switch and break the backup"},{"line_number":13,"context_line":"operation."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This sets a default log level of WARN for swiftclient for the"},{"line_number":16,"context_line":"cinder-backup service."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f93b717_34077d1f","line":13,"range":{"start_line":12,"start_character":26,"end_line":13,"end_character":10},"updated":"2018-01-25 20:59:46.000000000","message":"Cite the eventlet bug [1]?\n\n[1] https://github.com/eventlet/eventlet/issues/432","commit_id":"e4989c103ff23cbf937faa8cc12c39e9720f9fd7"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"506f970ad00de7c69ea5161fba0e754a8687b238","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Similar to change I0857cecd7d8ab0ee7e3e9bd6e15f4987ede4d653, the"},{"line_number":10,"context_line":"swift backup driver cannot be logging stuff while in a thread during"},{"line_number":11,"context_line":"read and write operations. swiftclient logs requests and responses"},{"line_number":12,"context_line":"at DEBUG level, which can cause a thread switch and break the backup"},{"line_number":13,"context_line":"operation."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This sets a default log level of WARN for swiftclient for the"},{"line_number":16,"context_line":"cinder-backup service."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f93b717_af081428","line":13,"range":{"start_line":12,"start_character":26,"end_line":13,"end_character":10},"in_reply_to":"5f93b717_34077d1f","updated":"2018-01-25 21:01:19.000000000","message":"meh; the whole \u0027don\u0027t log in something running in an eventlet thread\u0027 has been a thing since as long as I\u0027ve been working on openstack, it\u0027s pretty well known.","commit_id":"e4989c103ff23cbf937faa8cc12c39e9720f9fd7"}],"cinder/cmd/backup.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"424b99f83b85cc28b18c70b765cb124662d63d31","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"# NOTE(mriedem): The default backup driver uses swift and performs read/write"},{"line_number":51,"context_line":"# operations in a thread. swiftclient will log requests and responses at DEBUG"},{"line_number":52,"context_line":"# level, which can cause a thread switch and break the backup operation. So we"},{"line_number":53,"context_line":"# set a default log level of WARN for swiftclient to try and avoid this issue."},{"line_number":54,"context_line":"_EXTRA_DEFAULT_LOG_LEVELS \u003d [\u0027swiftclient\u003dWARN\u0027]"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f93b717_14360105","line":52,"range":{"start_line":52,"start_character":45,"end_line":52,"end_character":71},"updated":"2018-01-25 20:59:46.000000000","message":"Cite the eventlet bug [1]?\n\n[1] https://github.com/eventlet/eventlet/issues/432","commit_id":"e4989c103ff23cbf937faa8cc12c39e9720f9fd7"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"506f970ad00de7c69ea5161fba0e754a8687b238","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"# NOTE(mriedem): The default backup driver uses swift and performs read/write"},{"line_number":51,"context_line":"# operations in a thread. swiftclient will log requests and responses at DEBUG"},{"line_number":52,"context_line":"# level, which can cause a thread switch and break the backup operation. So we"},{"line_number":53,"context_line":"# set a default log level of WARN for swiftclient to try and avoid this issue."},{"line_number":54,"context_line":"_EXTRA_DEFAULT_LOG_LEVELS \u003d [\u0027swiftclient\u003dWARN\u0027]"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f93b717_6f120c5b","line":52,"range":{"start_line":52,"start_character":45,"end_line":52,"end_character":71},"in_reply_to":"5f93b717_14360105","updated":"2018-01-25 21:01:19.000000000","message":"double meh","commit_id":"e4989c103ff23cbf937faa8cc12c39e9720f9fd7"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"424b99f83b85cc28b18c70b765cb124662d63d31","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    gmr_opts.set_defaults(CONF)"},{"line_number":60,"context_line":"    CONF(sys.argv[1:], project\u003d\u0027cinder\u0027,"},{"line_number":61,"context_line":"         version\u003dversion.version_string())"},{"line_number":62,"context_line":"    logging.set_defaults("},{"line_number":63,"context_line":"        default_log_levels\u003dlogging.get_default_log_levels() +"},{"line_number":64,"context_line":"        _EXTRA_DEFAULT_LOG_LEVELS)"},{"line_number":65,"context_line":"    logging.setup(CONF, \"cinder\")"},{"line_number":66,"context_line":"    python_logging.captureWarnings(True)"},{"line_number":67,"context_line":"    priv_context.init(root_helper\u003dshlex.split(utils.get_root_helper()))"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f93b717_14512137","line":64,"range":{"start_line":62,"start_character":0,"end_line":64,"end_character":34},"updated":"2018-01-25 20:59:46.000000000","message":"Do we need to check whether there\u0027s already a swiftclient\u003dSOMETHING_ELSE default in there?  Presumably from a custom conf.","commit_id":"e4989c103ff23cbf937faa8cc12c39e9720f9fd7"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"506f970ad00de7c69ea5161fba0e754a8687b238","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    gmr_opts.set_defaults(CONF)"},{"line_number":60,"context_line":"    CONF(sys.argv[1:], project\u003d\u0027cinder\u0027,"},{"line_number":61,"context_line":"         version\u003dversion.version_string())"},{"line_number":62,"context_line":"    logging.set_defaults("},{"line_number":63,"context_line":"        default_log_levels\u003dlogging.get_default_log_levels() +"},{"line_number":64,"context_line":"        _EXTRA_DEFAULT_LOG_LEVELS)"},{"line_number":65,"context_line":"    logging.setup(CONF, \"cinder\")"},{"line_number":66,"context_line":"    python_logging.captureWarnings(True)"},{"line_number":67,"context_line":"    priv_context.init(root_helper\u003dshlex.split(utils.get_root_helper()))"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f93b717_2f1c0469","line":64,"range":{"start_line":62,"start_character":0,"end_line":64,"end_character":34},"in_reply_to":"5f93b717_14512137","updated":"2018-01-25 21:01:19.000000000","message":"This is just default_log_levels, so I think if someone overwrites it in config, oslo.log should do the right thing and take that over the default passed in here.","commit_id":"e4989c103ff23cbf937faa8cc12c39e9720f9fd7"}]}