)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"2808fed1550e9dc49ad821e4bb05e38b90b4140a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"QNAP Drivers - Move from httplib to requests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adding new conf entry qnap_verify_ssl to enable or disable"},{"line_number":10,"context_line":"SSL verification when using HTTPS protocol."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Iba886fd0bd401052a444eb7a4427607e693d7c81"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f93b717_de48a1cd","line":9,"updated":"2018-01-26 14:04:51.000000000","message":"We already have a common config option for this, so please don\u0027t add a new one. Unfortunately I can\u0027t pull up a reference to that at the moment, but if you can\u0027t find it, I will look for it later.","commit_id":"bc10cf77ae9ace1fa7c87408d1b54027760b96d7"},{"author":{"_account_id":11651,"name":"Ibad Khan","email":"ik.ibadkhan@gmail.com","username":"kibad"},"change_message_id":"781e36689782d68232b3c7556934f5ef11f3f4f9","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"QNAP Drivers - Move from httplib to requests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adding new conf entry qnap_verify_ssl to enable or disable"},{"line_number":10,"context_line":"SSL verification when using HTTPS protocol."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Iba886fd0bd401052a444eb7a4427607e693d7c81"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f93b717_2922ad53","line":9,"in_reply_to":"5f93b717_de48a1cd","updated":"2018-01-26 14:27:17.000000000","message":"Generating config file, let me see if I can find it.","commit_id":"bc10cf77ae9ace1fa7c87408d1b54027760b96d7"}],"cinder/tests/unit/volume/drivers/test_qnap.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"62fddec0041aec88beae02a36fd9ddc940859b62","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from oslo_utils import units"},{"line_number":26,"context_line":"import six"},{"line_number":27,"context_line":"from six.moves import urllib"},{"line_number":28,"context_line":"import requests"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"from cinder import exception"},{"line_number":31,"context_line":"from cinder import test"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f93b717_e8791693","line":28,"updated":"2018-01-26 21:49:54.000000000","message":"Not sure if it will complain (haven\u0027t looked yet) byt this should be moved above the six imports so they are in alphabetical order.","commit_id":"549d3ba112e4ffc2e8b034569e014da89137c4dc"}],"cinder/volume/drivers/qnap.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"5f062ec38ef906d77e8961b3e1f31f5412b8cd7f","unresolved":false,"context_lines":[{"line_number":20,"context_line":"import eventlet"},{"line_number":21,"context_line":"import functools"},{"line_number":22,"context_line":"import re"},{"line_number":23,"context_line":"import requests"},{"line_number":24,"context_line":"import threading"},{"line_number":25,"context_line":"import time"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5f93b717_6b2a52db","line":23,"updated":"2018-02-01 20:30:23.000000000","message":"Should be below with the third party imports.","commit_id":"1fc3c6064e6f24ed3f5d75560632d9107d8081ea"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"8264e1dfeaa65525cde838f69bcf9e8ab5c601d2","unresolved":false,"context_lines":[{"line_number":1161,"context_line":"        headers \u003d None"},{"line_number":1162,"context_line":"        protocol \u003d \u0027https\u0027 if use_ssl else \u0027http\u0027"},{"line_number":1163,"context_line":"        verify \u003d self.verify_ssl if use_ssl else False"},{"line_number":1164,"context_line":"        url \u003d \u0027%s://%s:%s%s\u0027 % (protocol, host_ip, host_port, action)"},{"line_number":1165,"context_line":""},{"line_number":1166,"context_line":"        if body:"},{"line_number":1167,"context_line":"            method \u003d \u0027POST\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa0c359_300b947d","line":1164,"updated":"2018-02-09 19:19:27.000000000","message":"This code is going to break if host_ip is an IPv6 address.\n\nI\u0027m not sure this needs to be fixed in this patchset (since it looks like parse_management_url was already broken for IPv6), but this should be commented here and documented somewhere if not supported.\n\nMaybe add a note on the qnap_management_url option about this?","commit_id":"c044cf153ac4d1502e04b3db99512dc4e559018a"},{"author":{"_account_id":11651,"name":"Ibad Khan","email":"ik.ibadkhan@gmail.com","username":"kibad"},"change_message_id":"39e4f8232097425e77bd6ff6117ff57d982b27fe","unresolved":false,"context_lines":[{"line_number":1161,"context_line":"        headers \u003d None"},{"line_number":1162,"context_line":"        protocol \u003d \u0027https\u0027 if use_ssl else \u0027http\u0027"},{"line_number":1163,"context_line":"        verify \u003d self.verify_ssl if use_ssl else False"},{"line_number":1164,"context_line":"        url \u003d \u0027%s://%s:%s%s\u0027 % (protocol, host_ip, host_port, action)"},{"line_number":1165,"context_line":""},{"line_number":1166,"context_line":"        if body:"},{"line_number":1167,"context_line":"            method \u003d \u0027POST\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa0c359_7532dca9","line":1164,"in_reply_to":"3fa0c359_300b947d","updated":"2018-02-16 06:23:13.000000000","message":"Done","commit_id":"c044cf153ac4d1502e04b3db99512dc4e559018a"}]}