)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"c89e7eef80f5217b7e6ae02d8358b5ba7fe6f7f6","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add rbd_data_pool"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add a configuration option to specify the RBD data pool"},{"line_number":10,"context_line":"It can be used to RBD data and metadat in different storage tiers."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ia6553ecb22c27b50f7cf970bb00229ab3766c2fb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3f79a3b5_5c120358","line":10,"range":{"start_line":10,"start_character":31,"end_line":10,"end_character":38},"updated":"2018-11-22 05:14:01.000000000","message":"metadata","commit_id":"0bef571d10b69e0dd260c6dd9a77877840ab548e"}],"cinder/tests/unit/volume/drivers/test_rbd.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"c89e7eef80f5217b7e6ae02d8358b5ba7fe6f7f6","unresolved":false,"context_lines":[{"line_number":180,"context_line":"        self.cfg.image_conversion_dir \u003d None"},{"line_number":181,"context_line":"        self.cfg.rbd_cluster_name \u003d \u0027nondefault\u0027"},{"line_number":182,"context_line":"        self.cfg.rbd_pool \u003d \u0027rbd\u0027"},{"line_number":183,"context_line":"        self.cfg.rbd_pool \u003d None"},{"line_number":184,"context_line":"        self.cfg.rbd_ceph_conf \u003d \u0027/etc/ceph/my_ceph.conf\u0027"},{"line_number":185,"context_line":"        self.cfg.rbd_keyring_conf \u003d \u0027/etc/ceph/my_ceph.client.keyring\u0027"},{"line_number":186,"context_line":"        self.cfg.rbd_secret_uuid \u003d None"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_bc09d729","line":183,"range":{"start_line":183,"start_character":17,"end_line":183,"end_character":25},"updated":"2018-11-22 05:14:01.000000000","message":"rbd_data_pool ?","commit_id":"0bef571d10b69e0dd260c6dd9a77877840ab548e"},{"author":{"_account_id":15961,"name":"lisali","email":"xiaoyan.li@intel.com","username":"lisali"},"change_message_id":"a454ba2fe2a5415cb7100890775111cebfd14e3e","unresolved":false,"context_lines":[{"line_number":180,"context_line":"        self.cfg.image_conversion_dir \u003d None"},{"line_number":181,"context_line":"        self.cfg.rbd_cluster_name \u003d \u0027nondefault\u0027"},{"line_number":182,"context_line":"        self.cfg.rbd_pool \u003d \u0027rbd\u0027"},{"line_number":183,"context_line":"        self.cfg.rbd_data_pool \u003d None"},{"line_number":184,"context_line":"        self.cfg.rbd_ceph_conf \u003d \u0027/etc/ceph/my_ceph.conf\u0027"},{"line_number":185,"context_line":"        self.cfg.rbd_keyring_conf \u003d \u0027/etc/ceph/my_ceph.client.keyring\u0027"},{"line_number":186,"context_line":"        self.cfg.rbd_secret_uuid \u003d None"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_eb3e4e25","line":183,"updated":"2018-11-28 08:13:07.000000000","message":"Is it better to set rbd_data_pool not none and do unit?","commit_id":"2d31f44d993b867bef932c676875531bcc719de6"}],"cinder/volume/drivers/rbd.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"973b5e157170c131bfc928161943b55b6a1fafe0","unresolved":false,"context_lines":[{"line_number":779,"context_line":"                                   vol_name,"},{"line_number":780,"context_line":"                                   size,"},{"line_number":781,"context_line":"                                   order,"},{"line_number":782,"context_line":"                                   data_pool\u003d"},{"line_number":783,"context_line":"                                   old_format\u003dFalse,"},{"line_number":784,"context_line":"                                   features\u003dclient.features,"},{"line_number":785,"context_line":"                                   data_pool\u003dself.configuration.rbd_data_pool)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f93b717_6887e1b6","line":782,"updated":"2018-01-31 15:09:44.000000000","message":"Missing ,","commit_id":"12d157322bfa00898e2cdf2471c6ba6158b1037a"},{"author":{"_account_id":15961,"name":"lisali","email":"xiaoyan.li@intel.com","username":"lisali"},"change_message_id":"a454ba2fe2a5415cb7100890775111cebfd14e3e","unresolved":false,"context_lines":[{"line_number":584,"context_line":"        src_name \u003d utils.convert_str(src_vref.name)"},{"line_number":585,"context_line":"        dest_name \u003d utils.convert_str(volume.name)"},{"line_number":586,"context_line":"        clone_snap \u003d \"%s.clone_snap\" % dest_name"},{"line_number":587,"context_line":"        data_pool \u003d self.configuration.rbd_data_pool"},{"line_number":588,"context_line":""},{"line_number":589,"context_line":"        # Do full copy if requested"},{"line_number":590,"context_line":"        if self.configuration.rbd_max_clone_depth \u003c\u003d 0:"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_4b7e62c0","line":587,"updated":"2018-11-28 08:13:07.000000000","message":"-1, we set data_pool here, and use it in Line 612, why not in Line 593.\nBetter to delete this line, and update line 612 like line 593.","commit_id":"2d31f44d993b867bef932c676875531bcc719de6"},{"author":{"_account_id":24132,"name":"Maxime Guyot","email":"maxime@root314.com","username":"miouge"},"change_message_id":"5b0cd0034a464233043fcd8f467e21dcec377410","unresolved":false,"context_lines":[{"line_number":584,"context_line":"        src_name \u003d utils.convert_str(src_vref.name)"},{"line_number":585,"context_line":"        dest_name \u003d utils.convert_str(volume.name)"},{"line_number":586,"context_line":"        clone_snap \u003d \"%s.clone_snap\" % dest_name"},{"line_number":587,"context_line":"        data_pool \u003d self.configuration.rbd_data_pool"},{"line_number":588,"context_line":""},{"line_number":589,"context_line":"        # Do full copy if requested"},{"line_number":590,"context_line":"        if self.configuration.rbd_max_clone_depth \u003c\u003d 0:"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_fce132fb","line":587,"in_reply_to":"3f79a3b5_4b7e62c0","updated":"2018-11-28 10:27:01.000000000","message":"Using the self.configuration.rbd_data_pool in line 612 results will result in a line longer than 80 char which will be a problem for pep8.\n\nIn the latest patch I changed line 593 to use the data_pool variable for consistency instead. What do you think?","commit_id":"2d31f44d993b867bef932c676875531bcc719de6"},{"author":{"_account_id":15961,"name":"lisali","email":"xiaoyan.li@intel.com","username":"lisali"},"change_message_id":"1f99e31da2531c74868e0913044bc442156cbbc8","unresolved":false,"context_lines":[{"line_number":584,"context_line":"        src_name \u003d utils.convert_str(src_vref.name)"},{"line_number":585,"context_line":"        dest_name \u003d utils.convert_str(volume.name)"},{"line_number":586,"context_line":"        clone_snap \u003d \"%s.clone_snap\" % dest_name"},{"line_number":587,"context_line":"        data_pool \u003d self.configuration.rbd_data_pool"},{"line_number":588,"context_line":""},{"line_number":589,"context_line":"        # Do full copy if requested"},{"line_number":590,"context_line":"        if self.configuration.rbd_max_clone_depth \u003c\u003d 0:"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_6387050c","line":587,"in_reply_to":"3f79a3b5_fce132fb","updated":"2018-12-18 01:17:50.000000000","message":"It\u0027s ok.","commit_id":"2d31f44d993b867bef932c676875531bcc719de6"}]}