)]}'
{"cinder/brick/initiator/connector.py":[{"author":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"change_message_id":"11d0a689959274b8a3405d0ab7f79fdf3eaf8e39","unresolved":false,"context_lines":[{"line_number":797,"context_line":"                 execute\u003dputils.execute,"},{"line_number":798,"context_line":"                 device_scan_attempts\u003dDEVICE_SCAN_ATTEMPTS_DEFAULT,"},{"line_number":799,"context_line":"                 *args, **kwargs):"},{"line_number":800,"context_line":"        if mount_type.lower() \u003d\u003d \u0027nfs\u0027:"},{"line_number":801,"context_line":"            kwargs \u003d kwargs or {}"},{"line_number":802,"context_line":"            volume_driver \u003d kwargs.get(\u0027volume_driver\u0027)"},{"line_number":803,"context_line":"            if volume_driver:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FzOg%3D","line":800,"updated":"2013-10-28 20:57:40.000000000","message":"We might also want to check for glusterfs here and pass through the appropriate option, assuming it\u0027s available.","commit_id":"545c6a7fe7e80aa7701929898cf3dc7d7333652c"},{"author":{"_account_id":6094,"name":"Navneet Singh","email":"navsinghnitd@gmail.com","username":"singn"},"change_message_id":"55c3e2316bc35f87fa455ceeb8654bc1664f8967","unresolved":false,"context_lines":[{"line_number":797,"context_line":"                 execute\u003dputils.execute,"},{"line_number":798,"context_line":"                 device_scan_attempts\u003dDEVICE_SCAN_ATTEMPTS_DEFAULT,"},{"line_number":799,"context_line":"                 *args, **kwargs):"},{"line_number":800,"context_line":"        if mount_type.lower() \u003d\u003d \u0027nfs\u0027:"},{"line_number":801,"context_line":"            kwargs \u003d kwargs or {}"},{"line_number":802,"context_line":"            volume_driver \u003d kwargs.get(\u0027volume_driver\u0027)"},{"line_number":803,"context_line":"            if volume_driver:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FyJE%3D","line":800,"in_reply_to":"AAAATn%2F%2FzOE%3D","updated":"2013-10-29 06:01:56.000000000","message":"I have updated the info about GlusterFS in the bug at that time. Hope you guys had a look at it. GlusterFS is probably not my area of expertise so I think it would be good if you can assess and submit a patch if required. I will resubmit it as partial fix.","commit_id":"545c6a7fe7e80aa7701929898cf3dc7d7333652c"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"2dd66ab9a83a0f623a5be61bd21fbacff3eedfe7","unresolved":false,"context_lines":[{"line_number":797,"context_line":"                 execute\u003dputils.execute,"},{"line_number":798,"context_line":"                 device_scan_attempts\u003dDEVICE_SCAN_ATTEMPTS_DEFAULT,"},{"line_number":799,"context_line":"                 *args, **kwargs):"},{"line_number":800,"context_line":"        if mount_type.lower() \u003d\u003d \u0027nfs\u0027:"},{"line_number":801,"context_line":"            kwargs \u003d kwargs or {}"},{"line_number":802,"context_line":"            volume_driver \u003d kwargs.get(\u0027volume_driver\u0027)"},{"line_number":803,"context_line":"            if volume_driver:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FzOE%3D","line":800,"in_reply_to":"AAAATn%2F%2FzOg%3D","updated":"2013-10-28 21:04:22.000000000","message":"Yes, I had asked for more info about GlusterFS impact in the bug, but, I think we do need to do this, at least with this as Partial-Bug #1238085 and a follow-up patch if not in this one.","commit_id":"545c6a7fe7e80aa7701929898cf3dc7d7333652c"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"2dd66ab9a83a0f623a5be61bd21fbacff3eedfe7","unresolved":false,"context_lines":[{"line_number":832,"context_line":"        \"\"\""},{"line_number":833,"context_line":""},{"line_number":834,"context_line":"        mnt_flags \u003d []"},{"line_number":835,"context_line":"        if (\u0027options\u0027 in connection_properties and"},{"line_number":836,"context_line":"                connection_properties[\u0027options\u0027]):"},{"line_number":837,"context_line":"            mnt_flags \u003d connection_properties[\u0027options\u0027].split()"},{"line_number":838,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FzN4%3D","line":835,"updated":"2013-10-28 21:04:22.000000000","message":"There\u0027s probably a simpler/cleaner way to do this with .get().","commit_id":"545c6a7fe7e80aa7701929898cf3dc7d7333652c"},{"author":{"_account_id":6094,"name":"Navneet Singh","email":"navsinghnitd@gmail.com","username":"singn"},"change_message_id":"55c3e2316bc35f87fa455ceeb8654bc1664f8967","unresolved":false,"context_lines":[{"line_number":832,"context_line":"        \"\"\""},{"line_number":833,"context_line":""},{"line_number":834,"context_line":"        mnt_flags \u003d []"},{"line_number":835,"context_line":"        if (\u0027options\u0027 in connection_properties and"},{"line_number":836,"context_line":"                connection_properties[\u0027options\u0027]):"},{"line_number":837,"context_line":"            mnt_flags \u003d connection_properties[\u0027options\u0027].split()"},{"line_number":838,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FyJ4%3D","line":835,"in_reply_to":"AAAATn%2F%2FzN4%3D","updated":"2013-10-29 06:01:56.000000000","message":"I agree. I sort of just added some more code to the existing one without thinking on shortening it.","commit_id":"545c6a7fe7e80aa7701929898cf3dc7d7333652c"}],"cinder/volume/drivers/nfs.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"2dd66ab9a83a0f623a5be61bd21fbacff3eedfe7","unresolved":false,"context_lines":[{"line_number":373,"context_line":"        super(NfsDriver, self).__init__(*args, **kwargs)"},{"line_number":374,"context_line":"        self.configuration.append_config_values(volume_opts)"},{"line_number":375,"context_line":"        root_helper \u003d utils.get_root_helper()"},{"line_number":376,"context_line":"        #base bound to instance is used in RemoteFsConnector."},{"line_number":377,"context_line":"        #Not to be changed."},{"line_number":378,"context_line":"        self.base \u003d getattr(self.configuration,"},{"line_number":379,"context_line":"                            \u0027nfs_mount_point_base\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FzNo%3D","line":376,"updated":"2013-10-28 21:04:22.000000000","message":"The first line here is probably sufficient, but at least needs a space added to the beginning to match style elsewhere.","commit_id":"545c6a7fe7e80aa7701929898cf3dc7d7333652c"},{"author":{"_account_id":6094,"name":"Navneet Singh","email":"navsinghnitd@gmail.com","username":"singn"},"change_message_id":"55c3e2316bc35f87fa455ceeb8654bc1664f8967","unresolved":false,"context_lines":[{"line_number":373,"context_line":"        super(NfsDriver, self).__init__(*args, **kwargs)"},{"line_number":374,"context_line":"        self.configuration.append_config_values(volume_opts)"},{"line_number":375,"context_line":"        root_helper \u003d utils.get_root_helper()"},{"line_number":376,"context_line":"        #base bound to instance is used in RemoteFsConnector."},{"line_number":377,"context_line":"        #Not to be changed."},{"line_number":378,"context_line":"        self.base \u003d getattr(self.configuration,"},{"line_number":379,"context_line":"                            \u0027nfs_mount_point_base\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FyIw%3D","line":376,"in_reply_to":"AAAATn%2F%2FzNo%3D","updated":"2013-10-29 06:01:56.000000000","message":"will change it.","commit_id":"545c6a7fe7e80aa7701929898cf3dc7d7333652c"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"6d60a8bf52e23d898adcd73cf1fc5348b053ee4e","unresolved":false,"context_lines":[{"line_number":107,"context_line":"           raising exception to continue working for cases"},{"line_number":108,"context_line":"           when not used with brick."},{"line_number":109,"context_line":"        \"\"\""},{"line_number":110,"context_line":"        LOG.warn(_(\"mount point base not found.\"))"},{"line_number":111,"context_line":"        return None"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    def create_volume(self, volume):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2Flvc%3D","line":110,"updated":"2013-10-31 19:07:51.000000000","message":"Probably should use a different phrase here, since we didn\u0027t actually look for a mount point base.","commit_id":"346fb5ab17de0ab171d985160b63ec3ee97b1aba"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"67805c926b2b0e6cde7e469b590aec1c2f626592","unresolved":false,"context_lines":[{"line_number":107,"context_line":"           raising exception to continue working for cases"},{"line_number":108,"context_line":"           when not used with brick."},{"line_number":109,"context_line":"        \"\"\""},{"line_number":110,"context_line":"        LOG.warn(_(\"Driver specific implementation needed to return\""},{"line_number":111,"context_line":"                   \" mount_point_base.\"))"},{"line_number":112,"context_line":"        return None"},{"line_number":113,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2Fkiw%3D","line":110,"updated":"2013-11-01 05:30:07.000000000","message":"This will get annoying and not helpful for the end users. I think instead the appropriate reps from related drivers should just be notified.","commit_id":"86c8f0c29e1ffd99bec015d13ccb25f2af2be4c2"},{"author":{"_account_id":6094,"name":"Navneet Singh","email":"navsinghnitd@gmail.com","username":"singn"},"change_message_id":"ae52fc67c634dbe068d81ba2e5abbba97f68d691","unresolved":false,"context_lines":[{"line_number":107,"context_line":"           raising exception to continue working for cases"},{"line_number":108,"context_line":"           when not used with brick."},{"line_number":109,"context_line":"        \"\"\""},{"line_number":110,"context_line":"        LOG.warn(_(\"Driver specific implementation needed to return\""},{"line_number":111,"context_line":"                   \" mount_point_base.\"))"},{"line_number":112,"context_line":"        return None"},{"line_number":113,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2FkOc%3D","line":110,"in_reply_to":"AAAATn%2F%2Fkiw%3D","updated":"2013-11-01 08:06:22.000000000","message":"Currently the other one is GlusterFs and eric harney is already on the reviewers list. I will change warning to debug so as to atleast help find root cause in case of issue.","commit_id":"86c8f0c29e1ffd99bec015d13ccb25f2af2be4c2"}]}