)]}'
{"cinder/api/v3/attachments.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"14022ce41d37af762c4a58914a8b697d76ece593","unresolved":false,"context_lines":[{"line_number":97,"context_line":"                sort_direction\u003dsort_dirs)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    @wsgi.Controller.api_version(mv.NEW_ATTACH)"},{"line_number":100,"context_line":"    @wsgi.response(200)"},{"line_number":101,"context_line":"    @validation.schema(attachment.create)"},{"line_number":102,"context_line":"    def create(self, req, body):"},{"line_number":103,"context_line":"        \"\"\"Create an attachment."}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_df3be299","line":100,"updated":"2018-02-05 20:15:05.000000000","message":"Technically this changes the API behavior if client code was expecting a 202. Are you OK with that? If so, what about at least adding a simple release note?","commit_id":"b554203ac471f2d926f7a2498c25dbe4de6ab61b"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"ab30fac82601a5c0a7c02c69dde703821414e25d","unresolved":false,"context_lines":[{"line_number":97,"context_line":"                sort_direction\u003dsort_dirs)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    @wsgi.Controller.api_version(mv.NEW_ATTACH)"},{"line_number":100,"context_line":"    @wsgi.response(200)"},{"line_number":101,"context_line":"    @validation.schema(attachment.create)"},{"line_number":102,"context_line":"    def create(self, req, body):"},{"line_number":103,"context_line":"        \"\"\"Create an attachment."}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_0037aab2","line":100,"in_reply_to":"3fa0c359_c06f82c3","updated":"2018-02-05 21:25:54.000000000","message":"OK, actually this was out in pike. But we\u0027ve had these before and the api-wg has said it is acceptable to switch between 20x version.","commit_id":"b554203ac471f2d926f7a2498c25dbe4de6ab61b"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"645860002760df3d7187540709511cf8a0e59d90","unresolved":false,"context_lines":[{"line_number":97,"context_line":"                sort_direction\u003dsort_dirs)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    @wsgi.Controller.api_version(mv.NEW_ATTACH)"},{"line_number":100,"context_line":"    @wsgi.response(200)"},{"line_number":101,"context_line":"    @validation.schema(attachment.create)"},{"line_number":102,"context_line":"    def create(self, req, body):"},{"line_number":103,"context_line":"        \"\"\"Create an attachment."}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_c06f82c3","line":100,"in_reply_to":"3fa0c359_df3be299","updated":"2018-02-05 21:21:15.000000000","message":"I thought about that, but since this is new in Queens, and I am not going to do extra work for a non-existent CD policy, nope.","commit_id":"b554203ac471f2d926f7a2498c25dbe4de6ab61b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"dd8f11307c2fb6893c46e4ccbc3c353c3bb658d7","unresolved":false,"context_lines":[{"line_number":258,"context_line":"        attachments \u003d self.volume_api.attachment_delete(context, attachment)"},{"line_number":259,"context_line":"        return attachment_views.ViewBuilder.list(attachments)"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"    @wsgi.response(202)"},{"line_number":262,"context_line":"    @wsgi.Controller.api_version(mv.NEW_ATTACH_COMPLETION)"},{"line_number":263,"context_line":"    @wsgi.action(\u0027os-complete\u0027)"},{"line_number":264,"context_line":"    def complete(self, req, id, body):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_ff6c9e9d","line":261,"range":{"start_line":261,"start_character":4,"end_line":261,"end_character":23},"updated":"2018-02-05 20:19:25.000000000","message":"This is also wrong. There is nothing async about this. It\u0027s likely a 204 yeah?","commit_id":"b554203ac471f2d926f7a2498c25dbe4de6ab61b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"47fa6e334e34ac0a6a5e49be67f43203d4007040","unresolved":false,"context_lines":[{"line_number":258,"context_line":"        attachments \u003d self.volume_api.attachment_delete(context, attachment)"},{"line_number":259,"context_line":"        return attachment_views.ViewBuilder.list(attachments)"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"    @wsgi.response(202)"},{"line_number":262,"context_line":"    @wsgi.Controller.api_version(mv.NEW_ATTACH_COMPLETION)"},{"line_number":263,"context_line":"    @wsgi.action(\u0027os-complete\u0027)"},{"line_number":264,"context_line":"    def complete(self, req, id, body):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_350a1e8a","line":261,"range":{"start_line":261,"start_character":4,"end_line":261,"end_character":23},"in_reply_to":"3fa0c359_a066f6ec","updated":"2018-02-15 18:25:12.000000000","message":"I wouldn\u0027t really consider this out of scope, there are two methods in this API that are returning the wrong response code. I just didn\u0027t realize it was also a problem for os-complete when I wrote the bug for create.","commit_id":"b554203ac471f2d926f7a2498c25dbe4de6ab61b"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"645860002760df3d7187540709511cf8a0e59d90","unresolved":false,"context_lines":[{"line_number":258,"context_line":"        attachments \u003d self.volume_api.attachment_delete(context, attachment)"},{"line_number":259,"context_line":"        return attachment_views.ViewBuilder.list(attachments)"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"    @wsgi.response(202)"},{"line_number":262,"context_line":"    @wsgi.Controller.api_version(mv.NEW_ATTACH_COMPLETION)"},{"line_number":263,"context_line":"    @wsgi.action(\u0027os-complete\u0027)"},{"line_number":264,"context_line":"    def complete(self, req, id, body):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_a066f6ec","line":261,"range":{"start_line":261,"start_character":4,"end_line":261,"end_character":23},"in_reply_to":"3fa0c359_ff6c9e9d","updated":"2018-02-05 21:21:15.000000000","message":"Downvoting for out of patch scope issues?","commit_id":"b554203ac471f2d926f7a2498c25dbe4de6ab61b"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"bc5b4751195a0efb07bab560b1938f00d972d0b0","unresolved":false,"context_lines":[{"line_number":258,"context_line":"        attachments \u003d self.volume_api.attachment_delete(context, attachment)"},{"line_number":259,"context_line":"        return attachment_views.ViewBuilder.list(attachments)"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"    @wsgi.response(204)"},{"line_number":262,"context_line":"    @wsgi.Controller.api_version(mv.NEW_ATTACH_COMPLETION)"},{"line_number":263,"context_line":"    @wsgi.action(\u0027os-complete\u0027)"},{"line_number":264,"context_line":"    def complete(self, req, id, body):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa0c359_4ff07dca","line":261,"range":{"start_line":261,"start_character":18,"end_line":261,"end_character":23},"updated":"2018-02-06 01:27:37.000000000","message":"API Document needs another update now:)","commit_id":"ab60c61fb39f4341ec95f8ffacb1b623a5fcecfe"}]}