)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"e900c9a7874f2d4e6c7a7eee628ad55f93f2c325","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Gorka Eguileor \u003cgeguileo@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-02-06 14:54:57 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"RBD: Don\u0027t query Ceph on stats for exlusive pools"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Collecting stats for provisioned_capacity_gb takes a long time since we"},{"line_number":10,"context_line":"have to query each individual image for the provisioned size.  If we are"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa0c359_5b6031a6","line":7,"range":{"start_line":7,"start_character":35,"end_line":7,"end_character":43},"updated":"2018-02-06 14:26:04.000000000","message":"exclusive","commit_id":"fa14fc481654948cda0aaeaf6dedf41b89acbae9"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"286d8a40b08fa0cca49fa847f43a6be9e7dd158a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Gorka Eguileor \u003cgeguileo@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-02-06 14:54:57 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"RBD: Don\u0027t query Ceph on stats for exlusive pools"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Collecting stats for provisioned_capacity_gb takes a long time since we"},{"line_number":10,"context_line":"have to query each individual image for the provisioned size.  If we are"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa0c359_ccf9e980","line":7,"range":{"start_line":7,"start_character":35,"end_line":7,"end_character":43},"in_reply_to":"3fa0c359_5b6031a6","updated":"2018-02-06 16:51:01.000000000","message":"Done","commit_id":"fa14fc481654948cda0aaeaf6dedf41b89acbae9"}],"cinder/volume/drivers/rbd.py":[{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"df7befa8aaa5a2359675ea81279f3e74526e80b6","unresolved":false,"context_lines":[{"line_number":104,"context_line":"                     \u0027report a static value -quota max bytes if defined and \u0027"},{"line_number":105,"context_line":"                     \u0027global size of cluster if not-.\u0027),"},{"line_number":106,"context_line":"    cfg.BoolOpt(\u0027rbd_exclusive_cinder_pool\u0027, default\u003dFalse,"},{"line_number":107,"context_line":"                help\u003d\"Set to True if the pool is used exclusively by Cinder. \""},{"line_number":108,"context_line":"                     \"On exclusive use driver won\u0027t query images\u0027 provisioned \""},{"line_number":109,"context_line":"                     \"size as they will match the value calculated by the \""},{"line_number":110,"context_line":"                     \"Cinder core code for allocated_capacity_gb. This \""},{"line_number":111,"context_line":"                     \"reduces the load on the Ceph cluster as well as the \""},{"line_number":112,"context_line":"                     \"volume service.\"),"},{"line_number":113,"context_line":"]"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_fb249d0f","line":112,"range":{"start_line":107,"start_character":21,"end_line":112,"end_character":38},"updated":"2018-02-06 14:41:46.000000000","message":"Gorka, \n\nThanks for working on this!\n\nTwo nit-picks:\n- use single quotes as for the other help texts\n- add \u0027on\u0027 here: \"... cluster as well as on the volume service.\"","commit_id":"fa14fc481654948cda0aaeaf6dedf41b89acbae9"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"286d8a40b08fa0cca49fa847f43a6be9e7dd158a","unresolved":false,"context_lines":[{"line_number":104,"context_line":"                     \u0027report a static value -quota max bytes if defined and \u0027"},{"line_number":105,"context_line":"                     \u0027global size of cluster if not-.\u0027),"},{"line_number":106,"context_line":"    cfg.BoolOpt(\u0027rbd_exclusive_cinder_pool\u0027, default\u003dFalse,"},{"line_number":107,"context_line":"                help\u003d\"Set to True if the pool is used exclusively by Cinder. \""},{"line_number":108,"context_line":"                     \"On exclusive use driver won\u0027t query images\u0027 provisioned \""},{"line_number":109,"context_line":"                     \"size as they will match the value calculated by the \""},{"line_number":110,"context_line":"                     \"Cinder core code for allocated_capacity_gb. This \""},{"line_number":111,"context_line":"                     \"reduces the load on the Ceph cluster as well as the \""},{"line_number":112,"context_line":"                     \"volume service.\"),"},{"line_number":113,"context_line":"]"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_2c05ed77","line":112,"range":{"start_line":107,"start_character":21,"end_line":112,"end_character":38},"in_reply_to":"3fa0c359_fb249d0f","updated":"2018-02-06 16:51:01.000000000","message":"To use single quotes I would have to escape the \u0027 on L108 which we don\u0027t usually do in Cinder, and using single quote on all lines except one just hurts my eyes.\n\nThanks for noticing the missing \"on\"","commit_id":"fa14fc481654948cda0aaeaf6dedf41b89acbae9"},{"author":{"_account_id":27248,"name":"Prateek Goel","email":"prateek.goel2@tatacommunications.com","username":"prateek.goel"},"change_message_id":"e7630b171128c842226ae043fc2368d135b5390f","unresolved":false,"context_lines":[{"line_number":502,"context_line":"                total_gbi \u003d self._get_usage_info()"},{"line_number":503,"context_line":"                stats[\u0027provisioned_capacity_gb\u0027] \u003d total_gbi"},{"line_number":504,"context_line":"        except self.rados.Error:"},{"line_number":505,"context_line":"            # just log and return unknown capacities and let scheduler set"},{"line_number":506,"context_line":"            # provisioned_capacity_gb \u003d allocated_capacity_gb"},{"line_number":507,"context_line":"            LOG.exception(\u0027error refreshing volume stats\u0027)"},{"line_number":508,"context_line":"        self._stats \u003d stats"},{"line_number":509,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa0c359_98a771a8","line":506,"range":{"start_line":505,"start_character":57,"end_line":506,"end_character":61},"updated":"2018-02-19 13:49:45.000000000","message":"This comment can come out as it applies to if we are not setting provisioned_capacity_gb.","commit_id":"e47776f337ab21d6a5fd32823fd205e9385faaed"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"6938c2c7673d9aeabbb47a4cad6723c6c26b5631","unresolved":false,"context_lines":[{"line_number":502,"context_line":"                total_gbi \u003d self._get_usage_info()"},{"line_number":503,"context_line":"                stats[\u0027provisioned_capacity_gb\u0027] \u003d total_gbi"},{"line_number":504,"context_line":"        except self.rados.Error:"},{"line_number":505,"context_line":"            # just log and return unknown capacities and let scheduler set"},{"line_number":506,"context_line":"            # provisioned_capacity_gb \u003d allocated_capacity_gb"},{"line_number":507,"context_line":"            LOG.exception(\u0027error refreshing volume stats\u0027)"},{"line_number":508,"context_line":"        self._stats \u003d stats"},{"line_number":509,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa0c359_a760da02","line":506,"range":{"start_line":505,"start_character":57,"end_line":506,"end_character":61},"in_reply_to":"3fa0c359_048f6823","updated":"2018-02-21 09:37:35.000000000","message":"Sounds good, I\u0027ll add another comment before L501 as well so it\u0027s clearer.","commit_id":"e47776f337ab21d6a5fd32823fd205e9385faaed"},{"author":{"_account_id":27248,"name":"Prateek Goel","email":"prateek.goel2@tatacommunications.com","username":"prateek.goel"},"change_message_id":"93c5f6ba6c1ae595f9badd5bb1aff7bb56e0525c","unresolved":false,"context_lines":[{"line_number":502,"context_line":"                total_gbi \u003d self._get_usage_info()"},{"line_number":503,"context_line":"                stats[\u0027provisioned_capacity_gb\u0027] \u003d total_gbi"},{"line_number":504,"context_line":"        except self.rados.Error:"},{"line_number":505,"context_line":"            # just log and return unknown capacities and let scheduler set"},{"line_number":506,"context_line":"            # provisioned_capacity_gb \u003d allocated_capacity_gb"},{"line_number":507,"context_line":"            LOG.exception(\u0027error refreshing volume stats\u0027)"},{"line_number":508,"context_line":"        self._stats \u003d stats"},{"line_number":509,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa0c359_048f6823","line":506,"range":{"start_line":505,"start_character":57,"end_line":506,"end_character":61},"in_reply_to":"3fa0c359_199ef1b7","updated":"2018-02-20 09:48:15.000000000","message":"I intended to mention that, since we set provisioned_capacity_gb only if rbd_exclusive_cinder_pool is set, otherwise we do not hence we could mention in an outside comment provisioned_capacity_gb \u003d allocated_capacity_gb is set by scheduler.","commit_id":"e47776f337ab21d6a5fd32823fd205e9385faaed"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"33a580cef3a0d92fa94492f2f6f5f67e0069fc10","unresolved":false,"context_lines":[{"line_number":502,"context_line":"                total_gbi \u003d self._get_usage_info()"},{"line_number":503,"context_line":"                stats[\u0027provisioned_capacity_gb\u0027] \u003d total_gbi"},{"line_number":504,"context_line":"        except self.rados.Error:"},{"line_number":505,"context_line":"            # just log and return unknown capacities and let scheduler set"},{"line_number":506,"context_line":"            # provisioned_capacity_gb \u003d allocated_capacity_gb"},{"line_number":507,"context_line":"            LOG.exception(\u0027error refreshing volume stats\u0027)"},{"line_number":508,"context_line":"        self._stats \u003d stats"},{"line_number":509,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa0c359_199ef1b7","line":506,"range":{"start_line":505,"start_character":57,"end_line":506,"end_character":61},"in_reply_to":"3fa0c359_98a771a8","updated":"2018-02-20 09:05:18.000000000","message":"Please properly read the comment before voting, it\u0027s only 2 lines.  It is not saying that we are setting the value here, it says that the scheduler will do it because we are returning unknown total and free.","commit_id":"e47776f337ab21d6a5fd32823fd205e9385faaed"}]}