)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"57a139bbf4491956d7a049187ce86b06e910278e","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2018-02-08 16:19:46 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix mocks in unit tests"},{"line_number":8,"context_line":" We should not use @mock.patch for setUp methods. They will be ignored"},{"line_number":9,"context_line":" for most cases. This patch adds mocks explicitly into the setUp methods"},{"line_number":10,"context_line":" to the next tests:"},{"line_number":11,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3fa0c359_39c64d4a","line":8,"updated":"2018-02-08 14:22:26.000000000","message":"You need a blank line here.  This is being all treated as a long summary line.","commit_id":"12b457008eb39a8dd742a05541f7878d48eace85"},{"author":{"_account_id":27759,"name":"Daniil","email":"dsvystunov@mirantis.com","username":"dsvystunov"},"change_message_id":"21612ffb5fafaac293ce28a461be60799b59d8e2","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2018-02-08 16:19:46 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix mocks in unit tests"},{"line_number":8,"context_line":" We should not use @mock.patch for setUp methods. They will be ignored"},{"line_number":9,"context_line":" for most cases. This patch adds mocks explicitly into the setUp methods"},{"line_number":10,"context_line":" to the next tests:"},{"line_number":11,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3fa0c359_6418ac74","line":8,"in_reply_to":"3fa0c359_39c64d4a","updated":"2018-02-09 19:34:22.000000000","message":"Thanks. I fixed it.","commit_id":"12b457008eb39a8dd742a05541f7878d48eace85"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"f69cbf2acdb97e2514ed69d8a32ae74fc0d3a5c1","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix mocks in unit tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":" We should not use @mock.patch and @mock.patch.object for setUp methods."},{"line_number":10,"context_line":" They will be ignored for most cases. This patch adds mocks explicitly into"},{"line_number":11,"context_line":" the setUp methods."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3fa0c359_e04ca19f","line":9,"updated":"2018-02-08 18:51:11.000000000","message":"Please, remove spaces in the beginning of lines","commit_id":"ad44a9331beb4a7a93c47120cf6dfdfa1850cf4f"}],"cinder/tests/unit/volume/drivers/nec/test_volume.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"f69cbf2acdb97e2514ed69d8a32ae74fc0d3a5c1","unresolved":false,"context_lines":[{"line_number":810,"context_line":"                   \u0027_create_ismview_dir\u0027, new\u003dmock.Mock())"},{"line_number":811,"context_line":"        self.patch(\u0027cinder.volume.drivers.nec.cli.MStorageISMCLI.\u0027"},{"line_number":812,"context_line":"                   \u0027view_all\u0027, patch_view_all)"},{"line_number":813,"context_line":"        "},{"line_number":814,"context_line":"        self._set_config(conf.Configuration(None), \u0027dummy\u0027, \u0027dummy\u0027)"},{"line_number":815,"context_line":"        self.do_setup(None)"},{"line_number":816,"context_line":"        self.vol \u003d DummyVolume()"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa0c359_c0172551","line":813,"updated":"2018-02-08 18:51:11.000000000","message":"Please, remove  trailing spaces","commit_id":"ad44a9331beb4a7a93c47120cf6dfdfa1850cf4f"}],"cinder/tests/unit/volume/drivers/test_vrtshyperscale.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"f69cbf2acdb97e2514ed69d8a32ae74fc0d3a5c1","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        # Initialise a test seup"},{"line_number":80,"context_line":"        super(VRTSHyperScaleDriverTestCase, self).setUp()"},{"line_number":81,"context_line":"        "},{"line_number":82,"context_line":"        self.patch(\u0027cinder.volume.drivers.veritas.vrtshyperscale.HyperScaleDriver\u0027"},{"line_number":83,"context_line":"                   \u0027._fetch_config_for_compute\u0027)"},{"line_number":84,"context_line":"        self.patch(\u0027cinder.volume.drivers.veritas.vrtshyperscale.HyperScaleDriver\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa0c359_db7636a5","line":81,"updated":"2018-02-08 18:51:11.000000000","message":"Please, remove trailing spaces","commit_id":"ad44a9331beb4a7a93c47120cf6dfdfa1850cf4f"}],"cinder/tests/unit/volume/drivers/test_zadara.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"f69cbf2acdb97e2514ed69d8a32ae74fc0d3a5c1","unresolved":false,"context_lines":[{"line_number":448,"context_line":""},{"line_number":449,"context_line":"class ZadaraVPSADriverTestCase(test.TestCase):"},{"line_number":450,"context_line":"    \"\"\"Test case for Zadara VPSA volume driver.\"\"\""},{"line_number":451,"context_line":"    "},{"line_number":452,"context_line":"    def setUp(self):"},{"line_number":453,"context_line":"        super(ZadaraVPSADriverTestCase, self).setUp()"},{"line_number":454,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa0c359_5b6a26b3","line":451,"updated":"2018-02-08 18:51:11.000000000","message":"The same here","commit_id":"ad44a9331beb4a7a93c47120cf6dfdfa1850cf4f"}],"cinder/tests/unit/volume/drivers/test_zfssa.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"f69cbf2acdb97e2514ed69d8a32ae74fc0d3a5c1","unresolved":false,"context_lines":[{"line_number":1718,"context_line":"        self.share \u003d \u0027fakeshare\u0027"},{"line_number":1719,"context_line":"        self.snap \u003d \u0027fakesnapshot\u0027"},{"line_number":1720,"context_line":"        self.targetalias \u003d \u0027fakealias\u0027"},{"line_number":1721,"context_line":"        "},{"line_number":1722,"context_line":"        self.webdavclient \u003d mock.MagicMock(spec\u003dwebdavclient.ZFSSAWebDAVClient)"},{"line_number":1723,"context_line":"        self.zfssa \u003d rest.ZFSSANfsApi()"},{"line_number":1724,"context_line":"        self.zfssa.set_host(\u0027fakehost\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa0c359_1b649ee3","line":1721,"updated":"2018-02-08 18:51:11.000000000","message":"ditto","commit_id":"ad44a9331beb4a7a93c47120cf6dfdfa1850cf4f"}],"cinder/tests/unit/windows/test_smbfs.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"f69cbf2acdb97e2514ed69d8a32ae74fc0d3a5c1","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        self.mock_object(smbfs, \u0027utilsfactory\u0027)"},{"line_number":61,"context_line":"        self.mock_object(smbfs, \u0027remotefs_brick\u0027)"},{"line_number":62,"context_line":"        self.context \u003d context.get_admin_context()"},{"line_number":63,"context_line":"        "},{"line_number":64,"context_line":"        self._FAKE_SMBFS_CONFIG \u003d mock.MagicMock("},{"line_number":65,"context_line":"            smbfs_shares_config\u003dmock.sentinel.share_config_file,"},{"line_number":66,"context_line":"            smbfs_default_volume_format\u003d\u0027vhdx\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa0c359_3b5f1a0f","line":63,"updated":"2018-02-08 18:51:11.000000000","message":"the same","commit_id":"ad44a9331beb4a7a93c47120cf6dfdfa1850cf4f"}]}
