)]}'
{"cinder/ssh_utils.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"efe0579df2c39cafa42ed6464caad2f82eee15f5","unresolved":false,"context_lines":[{"line_number":102,"context_line":"    def __del__(self):"},{"line_number":103,"context_line":"        # if we where called before the object got completely initialize"},{"line_number":104,"context_line":"        # nothing todo."},{"line_number":105,"context_line":"        if not hasattr(self, \"current_size\"):"},{"line_number":106,"context_line":"            return"},{"line_number":107,"context_line":"        # change the size of the pool to reduce the number"},{"line_number":108,"context_line":"        # of elements on the pool via puts."}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_2d9b1d18","line":105,"updated":"2018-02-12 15:50:09.000000000","message":"__init__ should initialize self.current_size to None anyway, then you could just test for that instead of hasattr().","commit_id":"c43802b3f3b758097d96694c3f83770473303c57"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"c06d6633c7f4e43eb937ab1f56f85b2b780208db","unresolved":false,"context_lines":[{"line_number":102,"context_line":"    def __del__(self):"},{"line_number":103,"context_line":"        # if we where called before the object got completely initialize"},{"line_number":104,"context_line":"        # nothing todo."},{"line_number":105,"context_line":"        if not hasattr(self, \"current_size\"):"},{"line_number":106,"context_line":"            return"},{"line_number":107,"context_line":"        # change the size of the pool to reduce the number"},{"line_number":108,"context_line":"        # of elements on the pool via puts."}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_f75e1711","line":105,"in_reply_to":"3fa0c359_0ee974b5","updated":"2018-02-14 21:36:14.000000000","message":"This would be in this classes initialization though, not the super class. So if you add it at the beginning of __init__ with the other class variable initialization, there shouldn\u0027t be anywhere that it could raise before it is initialized.","commit_id":"c43802b3f3b758097d96694c3f83770473303c57"},{"author":{"_account_id":14532,"name":"Gerald McBrearty","email":"gfm@us.ibm.com","username":"gfm"},"change_message_id":"afd7627ee7066fdf8fec4d4f736f7a1bef6d3b79","unresolved":false,"context_lines":[{"line_number":102,"context_line":"    def __del__(self):"},{"line_number":103,"context_line":"        # if we where called before the object got completely initialize"},{"line_number":104,"context_line":"        # nothing todo."},{"line_number":105,"context_line":"        if not hasattr(self, \"current_size\"):"},{"line_number":106,"context_line":"            return"},{"line_number":107,"context_line":"        # change the size of the pool to reduce the number"},{"line_number":108,"context_line":"        # of elements on the pool via puts."}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_0ee974b5","line":105,"in_reply_to":"3fa0c359_2d9b1d18","updated":"2018-02-12 19:19:09.000000000","message":"When SSHPool raises an exception before calling the super all the properties the super sets are not initialized, so when I was scanning through the tox output there was a new attribute error on stderr.\n\nSo I just picked a property that the super was initializing so I wouldn\u0027t introduce new stderr.","commit_id":"c43802b3f3b758097d96694c3f83770473303c57"}]}