)]}'
{"cinder/scheduler/filters/capacity_filter.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"b39bd23aa547d9a2f4612079a83fa05196658e84","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        if provision_type \u003d\u003d \u0027thick\u0027:"},{"line_number":119,"context_line":"            thin \u003d False"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        msg_args \u003d {\"grouping_name\": backend_state.backend_id,"},{"line_number":122,"context_line":"                    \"grouping\": grouping,"},{"line_number":123,"context_line":"                    \"requested\": requested_size,"},{"line_number":124,"context_line":"                    \"available\": free}"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_eeb448f4","line":121,"updated":"2018-02-12 19:10:35.000000000","message":"This assignment will only be used in the else block below on line 169. It should just be moved down there.","commit_id":"b463147429ceff48aa658a3dd7a9092a426a9ef3"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"232cbf3828200631a6ab9177cd2283477a195280","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        if provision_type \u003d\u003d \u0027thick\u0027:"},{"line_number":119,"context_line":"            thin \u003d False"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        msg_args \u003d {\"grouping_name\": backend_state.backend_id,"},{"line_number":122,"context_line":"                    \"grouping\": grouping,"},{"line_number":123,"context_line":"                    \"requested\": requested_size,"},{"line_number":124,"context_line":"                    \"available\": free}"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_2102410b","line":121,"in_reply_to":"3fa0c359_4ecd3c2f","updated":"2018-02-12 19:38:17.000000000","message":"Done","commit_id":"b463147429ceff48aa658a3dd7a9092a426a9ef3"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"232cbf3828200631a6ab9177cd2283477a195280","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        if provision_type \u003d\u003d \u0027thick\u0027:"},{"line_number":119,"context_line":"            thin \u003d False"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        msg_args \u003d {\"grouping_name\": backend_state.backend_id,"},{"line_number":122,"context_line":"                    \"grouping\": grouping,"},{"line_number":123,"context_line":"                    \"requested\": requested_size,"},{"line_number":124,"context_line":"                    \"available\": free}"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_ee33e860","line":121,"in_reply_to":"3fa0c359_eeb448f4","updated":"2018-02-12 19:38:17.000000000","message":"Done","commit_id":"b463147429ceff48aa658a3dd7a9092a426a9ef3"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"a6f55b698bc74c304c6f4d1f626612c820f38203","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        if provision_type \u003d\u003d \u0027thick\u0027:"},{"line_number":119,"context_line":"            thin \u003d False"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        msg_args \u003d {\"grouping_name\": backend_state.backend_id,"},{"line_number":122,"context_line":"                    \"grouping\": grouping,"},{"line_number":123,"context_line":"                    \"requested\": requested_size,"},{"line_number":124,"context_line":"                    \"available\": free}"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_4ecd3c2f","line":121,"in_reply_to":"3fa0c359_eeb448f4","updated":"2018-02-12 19:26:53.000000000","message":"Here is fine, we just need to remove duplicate that we have on L185","commit_id":"b463147429ceff48aa658a3dd7a9092a426a9ef3"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"a6f55b698bc74c304c6f4d1f626612c820f38203","unresolved":false,"context_lines":[{"line_number":182,"context_line":"                         \"grouping_name\": backend_state.backend_id})"},{"line_number":183,"context_line":"            return False"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"        msg_args \u003d {\"grouping_name\": backend_state.backend_id,"},{"line_number":186,"context_line":"                    \"grouping\": grouping,"},{"line_number":187,"context_line":"                    \"requested\": requested_size,"},{"line_number":188,"context_line":"                    \"available\": free}"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"        if free \u003c requested_size:"},{"line_number":191,"context_line":"            LOG.warning(\"Insufficient free space for volume creation \""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_0e37344f","line":188,"range":{"start_line":185,"start_character":0,"end_line":188,"end_character":38},"updated":"2018-02-12 19:26:53.000000000","message":"-1: Remove this, it is redefining the same thing from above","commit_id":"b463147429ceff48aa658a3dd7a9092a426a9ef3"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"232cbf3828200631a6ab9177cd2283477a195280","unresolved":false,"context_lines":[{"line_number":182,"context_line":"                         \"grouping_name\": backend_state.backend_id})"},{"line_number":183,"context_line":"            return False"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"        msg_args \u003d {\"grouping_name\": backend_state.backend_id,"},{"line_number":186,"context_line":"                    \"grouping\": grouping,"},{"line_number":187,"context_line":"                    \"requested\": requested_size,"},{"line_number":188,"context_line":"                    \"available\": free}"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"        if free \u003c requested_size:"},{"line_number":191,"context_line":"            LOG.warning(\"Insufficient free space for volume creation \""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_611b6972","line":188,"range":{"start_line":185,"start_character":0,"end_line":188,"end_character":38},"in_reply_to":"3fa0c359_0e37344f","updated":"2018-02-12 19:38:17.000000000","message":"Done","commit_id":"b463147429ceff48aa658a3dd7a9092a426a9ef3"}],"cinder/scheduler/host_manager.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"a6f55b698bc74c304c6f4d1f626612c820f38203","unresolved":false,"context_lines":[{"line_number":313,"context_line":"            self.free_capacity_gb -\u003d volume_gb"},{"line_number":314,"context_line":"        if update_time:"},{"line_number":315,"context_line":"            self.updated \u003d timeutils.utcnow()"},{"line_number":316,"context_line":"        LOG.debug(\"Consumed %s GB from backend: %s\", volume[\u0027size\u0027], self)"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"    def __repr__(self):"},{"line_number":319,"context_line":"        # FIXME(zhiteng) backend level free_capacity_gb isn\u0027t as"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_aee960e6","line":316,"range":{"start_line":316,"start_character":53,"end_line":316,"end_character":67},"updated":"2018-02-12 19:26:53.000000000","message":"Isn\u0027t this always an OVO?  In that case it should be volume.size","commit_id":"b463147429ceff48aa658a3dd7a9092a426a9ef3"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"89af9f7e793fae12d8811ca5d59008123bf3f3fe","unresolved":false,"context_lines":[{"line_number":313,"context_line":"            self.free_capacity_gb -\u003d volume_gb"},{"line_number":314,"context_line":"        if update_time:"},{"line_number":315,"context_line":"            self.updated \u003d timeutils.utcnow()"},{"line_number":316,"context_line":"        LOG.debug(\"Consumed %s GB from backend: %s\", volume[\u0027size\u0027], self)"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"    def __repr__(self):"},{"line_number":319,"context_line":"        # FIXME(zhiteng) backend level free_capacity_gb isn\u0027t as"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_c4f60bd8","line":316,"range":{"start_line":316,"start_character":53,"end_line":316,"end_character":67},"in_reply_to":"3fa0c359_2e4f9093","updated":"2018-02-12 20:28:09.000000000","message":"That\u0027s usually because our unit tests still have code that pass dictionaries instead of ORM objects or OVOs like they should.  But I think we can let it pass on this patch if the changes in the unit tests are too many.","commit_id":"b463147429ceff48aa658a3dd7a9092a426a9ef3"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"232cbf3828200631a6ab9177cd2283477a195280","unresolved":false,"context_lines":[{"line_number":313,"context_line":"            self.free_capacity_gb -\u003d volume_gb"},{"line_number":314,"context_line":"        if update_time:"},{"line_number":315,"context_line":"            self.updated \u003d timeutils.utcnow()"},{"line_number":316,"context_line":"        LOG.debug(\"Consumed %s GB from backend: %s\", volume[\u0027size\u0027], self)"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"    def __repr__(self):"},{"line_number":319,"context_line":"        # FIXME(zhiteng) backend level free_capacity_gb isn\u0027t as"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_2e4f9093","line":316,"range":{"start_line":316,"start_character":53,"end_line":316,"end_character":67},"in_reply_to":"3fa0c359_aee960e6","updated":"2018-02-12 19:38:17.000000000","message":"Not sure if that will be true in all branches we backport. And, its already complaining even on master[1].\n\n [1] http://logs.openstack.netapp.com/logs/90/590/1/downstream-check/check-cinder-pep8-and-py27/9bc0c07/console.html#_2018-02-12_17_49_55_706883","commit_id":"b463147429ceff48aa658a3dd7a9092a426a9ef3"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"b39bd23aa547d9a2f4612079a83fa05196658e84","unresolved":false,"context_lines":[{"line_number":323,"context_line":"        grouping_name \u003d self.backend_id"},{"line_number":324,"context_line":"        return (\"%s \u0027%s\u0027: free_capacity_gb: %s, \""},{"line_number":325,"context_line":"                \"total_capacity_gb: %s, allocated_capacity_gb %s, \""},{"line_number":326,"context_line":"                \"max_over_subscription_ratio: %s, reserved_percentage: %s, \""},{"line_number":327,"context_line":"                \"provisioned_capacity_gb: %s, thin_provisioning_support: %s, \""},{"line_number":328,"context_line":"                \"thick_provisioning_support: %s, pools: %s, updated at: %s\" %"},{"line_number":329,"context_line":"                (grouping, grouping_name, self.free_capacity_gb,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_aed2c026","line":326,"updated":"2018-02-12 19:10:35.000000000","message":"This needs to use named values since there are more than 2.","commit_id":"b463147429ceff48aa658a3dd7a9092a426a9ef3"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"232cbf3828200631a6ab9177cd2283477a195280","unresolved":false,"context_lines":[{"line_number":323,"context_line":"        grouping_name \u003d self.backend_id"},{"line_number":324,"context_line":"        return (\"%s \u0027%s\u0027: free_capacity_gb: %s, \""},{"line_number":325,"context_line":"                \"total_capacity_gb: %s, allocated_capacity_gb %s, \""},{"line_number":326,"context_line":"                \"max_over_subscription_ratio: %s, reserved_percentage: %s, \""},{"line_number":327,"context_line":"                \"provisioned_capacity_gb: %s, thin_provisioning_support: %s, \""},{"line_number":328,"context_line":"                \"thick_provisioning_support: %s, pools: %s, updated at: %s\" %"},{"line_number":329,"context_line":"                (grouping, grouping_name, self.free_capacity_gb,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_e120d99d","line":326,"in_reply_to":"3fa0c359_aed2c026","updated":"2018-02-12 19:38:17.000000000","message":"Done","commit_id":"b463147429ceff48aa658a3dd7a9092a426a9ef3"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"a6f55b698bc74c304c6f4d1f626612c820f38203","unresolved":false,"context_lines":[{"line_number":321,"context_line":"        # come up with better representation of HostState."},{"line_number":322,"context_line":"        grouping \u003d \u0027cluster\u0027 if self.cluster_name else \u0027host\u0027"},{"line_number":323,"context_line":"        grouping_name \u003d self.backend_id"},{"line_number":324,"context_line":"        return (\"%s \u0027%s\u0027: free_capacity_gb: %s, \""},{"line_number":325,"context_line":"                \"total_capacity_gb: %s, allocated_capacity_gb %s, \""},{"line_number":326,"context_line":"                \"max_over_subscription_ratio: %s, reserved_percentage: %s, \""},{"line_number":327,"context_line":"                \"provisioned_capacity_gb: %s, thin_provisioning_support: %s, \""},{"line_number":328,"context_line":"                \"thick_provisioning_support: %s, pools: %s, updated at: %s\" %"},{"line_number":329,"context_line":"                (grouping, grouping_name, self.free_capacity_gb,"},{"line_number":330,"context_line":"                 self.total_capacity_gb, self.allocated_capacity_gb,"},{"line_number":331,"context_line":"                 self.max_over_subscription_ratio, self.reserved_percentage,"},{"line_number":332,"context_line":"                 self.provisioned_capacity_gb, self.thin_provisioning_support,"},{"line_number":333,"context_line":"                 self.thick_provisioning_support, self.pools, self.updated))"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"class PoolState(BackendState):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_ee820800","line":333,"range":{"start_line":324,"start_character":0,"end_line":333,"end_character":76},"updated":"2018-02-12 19:26:53.000000000","message":"-1:\n\nWe define a class constant with the fields we want to report:\n\n  REPR_FIELDS \u003d (\u0027free_capacity_gb\u0027, \u0027total_capacity_gb\u0027, \u0027allocated_capacity_gb\u0027, ...)\n\nAnd then we can do:\n\n  str_data \u003d \u0027, \u0027.join(\u0027%s: %s\u0027 % (f, getattr(self, f)) for f in self.REPR_FIELDS\u0027)\n\nIt\u0027s that or use key words instead of positional parameters, because this is too easy to get wrong.","commit_id":"b463147429ceff48aa658a3dd7a9092a426a9ef3"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"232cbf3828200631a6ab9177cd2283477a195280","unresolved":false,"context_lines":[{"line_number":321,"context_line":"        # come up with better representation of HostState."},{"line_number":322,"context_line":"        grouping \u003d \u0027cluster\u0027 if self.cluster_name else \u0027host\u0027"},{"line_number":323,"context_line":"        grouping_name \u003d self.backend_id"},{"line_number":324,"context_line":"        return (\"%s \u0027%s\u0027: free_capacity_gb: %s, \""},{"line_number":325,"context_line":"                \"total_capacity_gb: %s, allocated_capacity_gb %s, \""},{"line_number":326,"context_line":"                \"max_over_subscription_ratio: %s, reserved_percentage: %s, \""},{"line_number":327,"context_line":"                \"provisioned_capacity_gb: %s, thin_provisioning_support: %s, \""},{"line_number":328,"context_line":"                \"thick_provisioning_support: %s, pools: %s, updated at: %s\" %"},{"line_number":329,"context_line":"                (grouping, grouping_name, self.free_capacity_gb,"},{"line_number":330,"context_line":"                 self.total_capacity_gb, self.allocated_capacity_gb,"},{"line_number":331,"context_line":"                 self.max_over_subscription_ratio, self.reserved_percentage,"},{"line_number":332,"context_line":"                 self.provisioned_capacity_gb, self.thin_provisioning_support,"},{"line_number":333,"context_line":"                 self.thick_provisioning_support, self.pools, self.updated))"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"class PoolState(BackendState):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_6e2d98a6","line":333,"range":{"start_line":324,"start_character":0,"end_line":333,"end_character":76},"in_reply_to":"3fa0c359_ee820800","updated":"2018-02-12 19:38:17.000000000","message":"Went for the first. Already was doing the first suggestion and is easier for the reader.","commit_id":"b463147429ceff48aa658a3dd7a9092a426a9ef3"}]}