)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"e03ec6a8637261780d94eb86dfe9e462dbb4d5c4","unresolved":false,"context_lines":[{"line_number":10,"context_line":"check statements, and it could lead to the failure of"},{"line_number":11,"context_line":"enforce \"owner\" policy."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I351b3ddf8dfe29da8d854d4038d64ca7be17390f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1f9dbf25_d45f343f","line":13,"updated":"2018-03-01 17:19:26.000000000","message":"-1: Missing the CVE flag and the link to the LP bug.","commit_id":"2e030b703f9cb879797798102a7244615355f627"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"bfa09c12a875b6c33f616951ae7c5cea63b87c96","unresolved":false,"context_lines":[{"line_number":10,"context_line":"check statements, and it could lead to the failure of"},{"line_number":11,"context_line":"enforce \"owner\" policy."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: #1714858"},{"line_number":14,"context_line":"Change-Id: I351b3ddf8dfe29da8d854d4038d64ca7be17390f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"df7087c5_d45a88f1","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":20},"updated":"2018-03-12 14:52:57.000000000","message":"Based on Gorka\u0027s and Sean\u0027s comments here, and other irc discussions surrounding this issue, it\u0027s not clear that this patch alone is sufficient to close out this bug, so Closes-Bug may not be appropriate here.\n\n(Which is significant since it is currently a security bug.)","commit_id":"6a5b097bd9e23aa15e74603caa312deb4fb8712f"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"4519659fcd8917cc301d9ba56ead18e649681e3f","unresolved":false,"context_lines":[{"line_number":24,"context_line":"This patch intends to correct most of cases which can be"},{"line_number":25,"context_line":"easily figured out in case of future code changes."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"[1]: https://github.com/openstack/cinder/blob/master/cinder/context.py#L206"},{"line_number":28,"context_line":"[2]: https://github.com/openstack/cinder/blob/master/cinder/db/sqlalchemy/api.py#L3058"},{"line_number":29,"context_line":"[3]: https://github.com/openstack/cinder/blob/master/cinder/api/contrib/admin_actions.py#L161"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"df7087c5_d1fd966e","line":27,"updated":"2018-03-13 14:03:55.000000000","message":"These aren\u0027t stable links and so they shouldn\u0027t be in a (permanent) commit message.\n\nIf you want to link to code, link to a specific git sha (and please use git.openstack.org instead of github...)","commit_id":"4be73125bf286ab42c3d7c652327f1107a042cf7"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"b558dea2cad7bdad3df87314ed844b107bbf490a","unresolved":false,"context_lines":[{"line_number":25,"context_line":"This patch intends to correct most of cases which can be"},{"line_number":26,"context_line":"easily figured out in case of future code changes."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"[1]:"},{"line_number":29,"context_line":"https://github.com/openstack/cinder/blob/73e6e3c147fc357031834d0ac28478d061e6120c/cinder/context.py#L206"},{"line_number":30,"context_line":"[2]:"},{"line_number":31,"context_line":"https://github.com/openstack/cinder/blob/73e6e3c147fc357031834d0ac28478d061e6120c/cinder/db/sqlalchemy/api.py#L3058"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"df7087c5_b45002d7","line":28,"updated":"2018-03-23 14:03:33.000000000","message":"Please keep in mind that Cinder is not a github-based project when documenting these things...","commit_id":"7391070474269dc247fc1d1f43520087a6a10267"}],"cinder/tests/unit/group/test_groups_api.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"e03ec6a8637261780d94eb86dfe9e462dbb4d5c4","unresolved":false,"context_lines":[{"line_number":298,"context_line":""},{"line_number":299,"context_line":"    @mock.patch(\u0027cinder.objects.GroupSnapshot.get_by_id\u0027)"},{"line_number":300,"context_line":"    @mock.patch(\u0027cinder.context.RequestContext.authorize\u0027)"},{"line_number":301,"context_line":"    def test_get_group_snapshot(self, mock_authorize, mock_group_snap):"},{"line_number":302,"context_line":"        fake_group_snap \u003d \u0027fake_group_snap\u0027"},{"line_number":303,"context_line":"        mock_group_snap.return_value \u003d fake_group_snap"},{"line_number":304,"context_line":"        grp_snap \u003d self.group_api.get_group_snapshot("}],"source_content_type":"text/x-python","patch_set":5,"id":"1f9dbf25_570566c1","line":301,"range":{"start_line":301,"start_character":38,"end_line":301,"end_character":52},"updated":"2018-03-01 17:19:26.000000000","message":"-1: We need to assert that we are calling it with the right values","commit_id":"2e030b703f9cb879797798102a7244615355f627"}],"cinder/tests/unit/volume/test_volume_retype.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"e03ec6a8637261780d94eb86dfe9e462dbb4d5c4","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    @mock.patch(\u0027cinder.context.RequestContext.authorize\u0027)"},{"line_number":67,"context_line":"    @mock.patch.object(volume_types, \u0027get_by_name_or_id\u0027)"},{"line_number":68,"context_line":"    def test_retype_multiattach(self, _mock_get_types, mock_authorize):"},{"line_number":69,"context_line":"        \"\"\"Verify multiattach retype restrictions.\"\"\""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        _mock_get_types.side_effect \u003d self.fake_get_vtype"}],"source_content_type":"text/x-python","patch_set":5,"id":"1f9dbf25_f7f592cc","line":68,"range":{"start_line":68,"start_character":55,"end_line":68,"end_character":69},"updated":"2018-03-01 17:19:26.000000000","message":"-1: We need to assert that we are calling it with the right values","commit_id":"2e030b703f9cb879797798102a7244615355f627"}]}