)]}'
{"cinder/volume/drivers/hpe/hpe_3par_common.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"e86fb9a71d1654924ef95f0cb4f8491bce18e79e","unresolved":false,"context_lines":[{"line_number":2962,"context_line":"                else:"},{"line_number":2963,"context_line":"                    if hosts is None:"},{"line_number":2964,"context_line":"                        # In case of \u0027force detach\u0027, hosts is None"},{"line_number":2965,"context_line":"                        LOG.error(\"Exception: %s\", e)"},{"line_number":2966,"context_line":"                        raise"},{"line_number":2967,"context_line":"                    else:"},{"line_number":2968,"context_line":"                        # use the wwn to see if we can find the hostname"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f9dbf25_f2192588","line":2965,"updated":"2018-03-01 14:42:41.000000000","message":"Please, change LOG.error to LOG.exception here and below","commit_id":"5d91b0170eed5bd3f4e7557f2a7c9c922efec66f"},{"author":{"_account_id":24952,"name":"Vivek Soni","email":"viveksoni31390@gmail.com","username":"sonivi"},"change_message_id":"6735316e3bc07cd32c1c7bcaa4d7b8744bf2bb41","unresolved":false,"context_lines":[{"line_number":2962,"context_line":"                else:"},{"line_number":2963,"context_line":"                    if hosts is None:"},{"line_number":2964,"context_line":"                        # In case of \u0027force detach\u0027, hosts is None"},{"line_number":2965,"context_line":"                        LOG.error(\"Exception: %s\", e)"},{"line_number":2966,"context_line":"                        raise"},{"line_number":2967,"context_line":"                    else:"},{"line_number":2968,"context_line":"                        # use the wwn to see if we can find the hostname"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f9dbf25_05d1e8cd","line":2965,"in_reply_to":"1f9dbf25_f2192588","updated":"2018-03-01 19:24:02.000000000","message":"Done","commit_id":"5d91b0170eed5bd3f4e7557f2a7c9c922efec66f"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"2fb2d394b53e39af9f619826c70bde266b848417","unresolved":false,"context_lines":[{"line_number":2962,"context_line":"                else:"},{"line_number":2963,"context_line":"                    if hosts is None:"},{"line_number":2964,"context_line":"                        # In case of \u0027force detach\u0027, hosts is None"},{"line_number":2965,"context_line":"                        LOG.exception(\"Exception: %s\", e)"},{"line_number":2966,"context_line":"                        raise"},{"line_number":2967,"context_line":"                    else:"},{"line_number":2968,"context_line":"                        # use the wwn to see if we can find the hostname"}],"source_content_type":"text/x-python","patch_set":2,"id":"df7087c5_6cf668fc","line":2965,"range":{"start_line":2965,"start_character":28,"end_line":2965,"end_character":37},"updated":"2018-03-10 21:34:37.000000000","message":"This should not have been changed, or the exception should have been removed from the passed args.","commit_id":"abca1abc7b01fc1d85af8b9cfa5b646abafc9d4a"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"2fb2d394b53e39af9f619826c70bde266b848417","unresolved":false,"context_lines":[{"line_number":2971,"context_line":"                            iqn)"},{"line_number":2972,"context_line":"                        # no 3par host, re-throw"},{"line_number":2973,"context_line":"                        if hostname is None:"},{"line_number":2974,"context_line":"                            LOG.exception(\"Exception: %s\", e)"},{"line_number":2975,"context_line":"                            raise"},{"line_number":2976,"context_line":"            else:"},{"line_number":2977,"context_line":"                # not a \u0027host does not exist\u0027 HTTPNotFound exception, re-throw"}],"source_content_type":"text/x-python","patch_set":2,"id":"df7087c5_0cdd6c6f","line":2974,"range":{"start_line":2974,"start_character":32,"end_line":2974,"end_character":41},"updated":"2018-03-10 21:34:37.000000000","message":"Same.","commit_id":"abca1abc7b01fc1d85af8b9cfa5b646abafc9d4a"}],"cinder/volume/drivers/hpe/hpe_3par_fc.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"e86fb9a71d1654924ef95f0cb4f8491bce18e79e","unresolved":false,"context_lines":[{"line_number":218,"context_line":"                common.terminate_connection(volume, hostname,"},{"line_number":219,"context_line":"                                            wwn\u003dconnector[\u0027wwpns\u0027])"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"            info \u003d {\u0027driver_volume_type\u0027: \u0027fibre_channel\u0027,"},{"line_number":222,"context_line":"                    \u0027data\u0027: {}}"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"            if is_force_detach:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f9dbf25_cd0d6c38","line":221,"range":{"start_line":221,"start_character":12,"end_line":221,"end_character":16},"updated":"2018-03-01 14:42:41.000000000","message":"we can move it to the line #243 and omit one more if statement","commit_id":"5d91b0170eed5bd3f4e7557f2a7c9c922efec66f"},{"author":{"_account_id":24952,"name":"Vivek Soni","email":"viveksoni31390@gmail.com","username":"sonivi"},"change_message_id":"6735316e3bc07cd32c1c7bcaa4d7b8744bf2bb41","unresolved":false,"context_lines":[{"line_number":218,"context_line":"                common.terminate_connection(volume, hostname,"},{"line_number":219,"context_line":"                                            wwn\u003dconnector[\u0027wwpns\u0027])"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"            info \u003d {\u0027driver_volume_type\u0027: \u0027fibre_channel\u0027,"},{"line_number":222,"context_line":"                    \u0027data\u0027: {}}"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"            if is_force_detach:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f9dbf25_c5da20e8","line":221,"range":{"start_line":221,"start_character":12,"end_line":221,"end_character":16},"in_reply_to":"1f9dbf25_cd0d6c38","updated":"2018-03-01 19:24:02.000000000","message":"Done","commit_id":"5d91b0170eed5bd3f4e7557f2a7c9c922efec66f"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"e86fb9a71d1654924ef95f0cb4f8491bce18e79e","unresolved":false,"context_lines":[{"line_number":237,"context_line":"                    for wwpn in connector.get(\u0027wwpns\u0027):"},{"line_number":238,"context_line":"                        for vlun in vluns:"},{"line_number":239,"context_line":"                            if vlun.get(\u0027active\u0027) and \\"},{"line_number":240,"context_line":"                                    vlun.get(\u0027remoteName\u0027) \u003d\u003d wwpn.upper():"},{"line_number":241,"context_line":"                                zone_remove \u003d False"},{"line_number":242,"context_line":"                                break"},{"line_number":243,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1f9dbf25_6d3bf8d0","line":240,"updated":"2018-03-01 14:42:41.000000000","message":"Please, do not use \u0027\\\u0027 for multiline statements. You should use () instead","commit_id":"5d91b0170eed5bd3f4e7557f2a7c9c922efec66f"},{"author":{"_account_id":24952,"name":"Vivek Soni","email":"viveksoni31390@gmail.com","username":"sonivi"},"change_message_id":"6735316e3bc07cd32c1c7bcaa4d7b8744bf2bb41","unresolved":false,"context_lines":[{"line_number":237,"context_line":"                    for wwpn in connector.get(\u0027wwpns\u0027):"},{"line_number":238,"context_line":"                        for vlun in vluns:"},{"line_number":239,"context_line":"                            if vlun.get(\u0027active\u0027) and \\"},{"line_number":240,"context_line":"                                    vlun.get(\u0027remoteName\u0027) \u003d\u003d wwpn.upper():"},{"line_number":241,"context_line":"                                zone_remove \u003d False"},{"line_number":242,"context_line":"                                break"},{"line_number":243,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1f9dbf25_e5d71cbf","line":240,"in_reply_to":"1f9dbf25_6d3bf8d0","updated":"2018-03-01 19:24:02.000000000","message":"Done","commit_id":"5d91b0170eed5bd3f4e7557f2a7c9c922efec66f"}]}