)]}'
{"cinder/volume/drivers/dell_emc/vmax/common.py":[{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"b745aa8a876a50b3aab04d4a87d7e407efbc21fa","unresolved":false,"context_lines":[{"line_number":2236,"context_line":"        \"\"\""},{"line_number":2237,"context_line":"        vol_is_replicated \u003d self.utils.is_replication_enabled(extra_specs)"},{"line_number":2238,"context_line":"        # Check if old type and new type have different replication types"},{"line_number":2239,"context_line":"        do_change_replication \u003d (self.utils.change_replication("},{"line_number":2240,"context_line":"            vol_is_replicated, new_type))"},{"line_number":2241,"context_line":"        is_compression_disabled \u003d self.utils.is_compression_disabled("},{"line_number":2242,"context_line":"            extra_specs)"}],"source_content_type":"text/x-python","patch_set":1,"id":"df7087c5_f00ebd8b","line":2239,"range":{"start_line":2239,"start_character":33,"end_line":2239,"end_character":37},"updated":"2018-03-12 12:27:11.000000000","message":"nit - bracket before self unnecessary","commit_id":"882d14d5995504505fd3363b9ce04482cb9d0de1"},{"author":{"_account_id":23414,"name":"Ciara Stacke","email":"ciara.stacke@emc.com","username":"cstacke"},"change_message_id":"2a97ba52ce7cae27f6bd37313a8b9cc3d07631a5","unresolved":false,"context_lines":[{"line_number":2236,"context_line":"        \"\"\""},{"line_number":2237,"context_line":"        vol_is_replicated \u003d self.utils.is_replication_enabled(extra_specs)"},{"line_number":2238,"context_line":"        # Check if old type and new type have different replication types"},{"line_number":2239,"context_line":"        do_change_replication \u003d (self.utils.change_replication("},{"line_number":2240,"context_line":"            vol_is_replicated, new_type))"},{"line_number":2241,"context_line":"        is_compression_disabled \u003d self.utils.is_compression_disabled("},{"line_number":2242,"context_line":"            extra_specs)"}],"source_content_type":"text/x-python","patch_set":1,"id":"df7087c5_8b73904d","line":2239,"range":{"start_line":2239,"start_character":33,"end_line":2239,"end_character":37},"in_reply_to":"df7087c5_f00ebd8b","updated":"2018-03-12 12:43:14.000000000","message":"Sure, I\u0027ll fix this","commit_id":"882d14d5995504505fd3363b9ce04482cb9d0de1"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"b745aa8a876a50b3aab04d4a87d7e407efbc21fa","unresolved":false,"context_lines":[{"line_number":2306,"context_line":"        is_rep_enabled \u003d self.utils.is_replication_enabled(target_extra_specs)"},{"line_number":2307,"context_line":"        if was_rep_enabled:"},{"line_number":2308,"context_line":"            if not is_rep_enabled:"},{"line_number":2309,"context_line":"                # disable replication is True"},{"line_number":2310,"context_line":"                self._remove_vol_and_cleanup_replication("},{"line_number":2311,"context_line":"                    array, device_id, volume_name, extra_specs, volume)"},{"line_number":2312,"context_line":"                model_update \u003d {\u0027replication_status\u0027: REPLICATION_DISABLED,"}],"source_content_type":"text/x-python","patch_set":1,"id":"df7087c5_f05c7d7f","line":2309,"updated":"2018-03-12 12:27:11.000000000","message":"nit, Disable/disable","commit_id":"882d14d5995504505fd3363b9ce04482cb9d0de1"},{"author":{"_account_id":23414,"name":"Ciara Stacke","email":"ciara.stacke@emc.com","username":"cstacke"},"change_message_id":"2a97ba52ce7cae27f6bd37313a8b9cc3d07631a5","unresolved":false,"context_lines":[{"line_number":2306,"context_line":"        is_rep_enabled \u003d self.utils.is_replication_enabled(target_extra_specs)"},{"line_number":2307,"context_line":"        if was_rep_enabled:"},{"line_number":2308,"context_line":"            if not is_rep_enabled:"},{"line_number":2309,"context_line":"                # disable replication is True"},{"line_number":2310,"context_line":"                self._remove_vol_and_cleanup_replication("},{"line_number":2311,"context_line":"                    array, device_id, volume_name, extra_specs, volume)"},{"line_number":2312,"context_line":"                model_update \u003d {\u0027replication_status\u0027: REPLICATION_DISABLED,"}],"source_content_type":"text/x-python","patch_set":1,"id":"df7087c5_4b933850","line":2309,"in_reply_to":"df7087c5_f05c7d7f","updated":"2018-03-12 12:43:14.000000000","message":"Sure","commit_id":"882d14d5995504505fd3363b9ce04482cb9d0de1"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"b745aa8a876a50b3aab04d4a87d7e407efbc21fa","unresolved":false,"context_lines":[{"line_number":2312,"context_line":"                model_update \u003d {\u0027replication_status\u0027: REPLICATION_DISABLED,"},{"line_number":2313,"context_line":"                                \u0027replication_driver_data\u0027: None}"},{"line_number":2314,"context_line":"            else:"},{"line_number":2315,"context_line":"                # ensure both source and target volumes are retyped"},{"line_number":2316,"context_line":"                move_target \u003d True"},{"line_number":2317,"context_line":"        else:"},{"line_number":2318,"context_line":"            if is_rep_enabled:"}],"source_content_type":"text/x-python","patch_set":1,"id":"df7087c5_70e5cda7","line":2315,"updated":"2018-03-12 12:27:11.000000000","message":"nit, Ensure/ensure","commit_id":"882d14d5995504505fd3363b9ce04482cb9d0de1"},{"author":{"_account_id":23414,"name":"Ciara Stacke","email":"ciara.stacke@emc.com","username":"cstacke"},"change_message_id":"2a97ba52ce7cae27f6bd37313a8b9cc3d07631a5","unresolved":false,"context_lines":[{"line_number":2312,"context_line":"                model_update \u003d {\u0027replication_status\u0027: REPLICATION_DISABLED,"},{"line_number":2313,"context_line":"                                \u0027replication_driver_data\u0027: None}"},{"line_number":2314,"context_line":"            else:"},{"line_number":2315,"context_line":"                # ensure both source and target volumes are retyped"},{"line_number":2316,"context_line":"                move_target \u003d True"},{"line_number":2317,"context_line":"        else:"},{"line_number":2318,"context_line":"            if is_rep_enabled:"}],"source_content_type":"text/x-python","patch_set":1,"id":"df7087c5_0b9d4058","line":2315,"in_reply_to":"df7087c5_70e5cda7","updated":"2018-03-12 12:43:14.000000000","message":"Sure","commit_id":"882d14d5995504505fd3363b9ce04482cb9d0de1"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"b745aa8a876a50b3aab04d4a87d7e407efbc21fa","unresolved":false,"context_lines":[{"line_number":2345,"context_line":""},{"line_number":2346,"context_line":"    def _retype_volume(self, array, device_id, volume_name, target_sg_name,"},{"line_number":2347,"context_line":"                       volume, extra_specs):"},{"line_number":2348,"context_line":"        \"\"\"Move the volume to the correct default storagegroup."},{"line_number":2349,"context_line":""},{"line_number":2350,"context_line":"        :param array: the array serial"},{"line_number":2351,"context_line":"        :param device_id: the device id"}],"source_content_type":"text/x-python","patch_set":1,"id":"df7087c5_10bc9167","line":2348,"updated":"2018-03-12 12:27:11.000000000","message":"Please clarify this comment, not sure if it goes to the default SG in all cases.","commit_id":"882d14d5995504505fd3363b9ce04482cb9d0de1"},{"author":{"_account_id":23414,"name":"Ciara Stacke","email":"ciara.stacke@emc.com","username":"cstacke"},"change_message_id":"2a97ba52ce7cae27f6bd37313a8b9cc3d07631a5","unresolved":false,"context_lines":[{"line_number":2345,"context_line":""},{"line_number":2346,"context_line":"    def _retype_volume(self, array, device_id, volume_name, target_sg_name,"},{"line_number":2347,"context_line":"                       volume, extra_specs):"},{"line_number":2348,"context_line":"        \"\"\"Move the volume to the correct default storagegroup."},{"line_number":2349,"context_line":""},{"line_number":2350,"context_line":"        :param array: the array serial"},{"line_number":2351,"context_line":"        :param device_id: the device id"}],"source_content_type":"text/x-python","patch_set":1,"id":"df7087c5_eb000c6a","line":2348,"in_reply_to":"df7087c5_10bc9167","updated":"2018-03-12 12:43:14.000000000","message":"Will do, although I don\u0027t think there is a situation where it does not go to the default storage group.","commit_id":"882d14d5995504505fd3363b9ce04482cb9d0de1"}]}