)]}'
{"cinder/tests/unit/volume/drivers/nec/test_volume.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"ae9157d5786c8df153efb6d07d709ce81b433959","unresolved":false,"context_lines":[{"line_number":887,"context_line":"                     \u0027multipath\u0027: True}"},{"line_number":888,"context_line":"        ret \u003d self._iscsi_terminate_connection(self.vol, connector)"},{"line_number":889,"context_line":"        self.assertIsNone(ret)"},{"line_number":890,"context_line":"        with self.assertRaisesRegexp(exception.VolumeBackendAPIException,"},{"line_number":891,"context_line":"                                     r\u0027Failed to unregister Logical Disk from\u0027"},{"line_number":892,"context_line":"                                     r\u0027 Logical Disk Set \\(iSM31064\\)\u0027):"},{"line_number":893,"context_line":"            mock_del \u003d mock.Mock()"}],"source_content_type":"text/x-python","patch_set":3,"id":"df7087c5_212d0da8","line":890,"updated":"2018-03-19 18:48:12.000000000","message":"Please, split this test to have separate tests for positive and negative scenarios","commit_id":"f839fd8e547cae425929cb64ae0ef04db986acf6"},{"author":{"_account_id":23885,"name":"Shunei Shiono","email":"shunei.shiono@gmail.com","username":"s-shiono"},"change_message_id":"5264350371bdddf13ea18e70a9dbc266aea3c428","unresolved":false,"context_lines":[{"line_number":887,"context_line":"                     \u0027multipath\u0027: True}"},{"line_number":888,"context_line":"        ret \u003d self._iscsi_terminate_connection(self.vol, connector)"},{"line_number":889,"context_line":"        self.assertIsNone(ret)"},{"line_number":890,"context_line":"        with self.assertRaisesRegexp(exception.VolumeBackendAPIException,"},{"line_number":891,"context_line":"                                     r\u0027Failed to unregister Logical Disk from\u0027"},{"line_number":892,"context_line":"                                     r\u0027 Logical Disk Set \\(iSM31064\\)\u0027):"},{"line_number":893,"context_line":"            mock_del \u003d mock.Mock()"}],"source_content_type":"text/x-python","patch_set":3,"id":"df7087c5_059528e4","line":890,"in_reply_to":"df7087c5_212d0da8","updated":"2018-03-22 05:19:33.000000000","message":"Done","commit_id":"f839fd8e547cae425929cb64ae0ef04db986acf6"}],"cinder/volume/drivers/nec/volume_helper.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"4d2c51632b97f71436cf9e84b06a388a46995627","unresolved":false,"context_lines":[{"line_number":1184,"context_line":"        try:"},{"line_number":1185,"context_line":"            self._iscsi_terminate_connection(volume, connector)"},{"line_number":1186,"context_line":"            LOG.info(\u0027Terminated iSCSI Connection (%s)\u0027, msgparm)"},{"line_number":1187,"context_line":"            return"},{"line_number":1188,"context_line":"        except exception.CinderException as e:"},{"line_number":1189,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":1190,"context_line":"                LOG.warning(\u0027Failed to Terminate iSCSI Connection \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"df7087c5_4d74d468","line":1187,"updated":"2018-03-09 14:51:26.000000000","message":"We don\u0027t need \u0027return\u0027 here","commit_id":"7446491466ca325d931945d7bc9f7a839761dcef"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"09db7736a7b2715d21936f64ac5f10e9aae96c67","unresolved":false,"context_lines":[{"line_number":1393,"context_line":"                LOG.debug(\u0027Logical Disk `%s` has unbound already.\u0027, ldname)"},{"line_number":1394,"context_line":"                return info"},{"line_number":1395,"context_line":""},{"line_number":1396,"context_line":"            ldset \u003d self._validate_fcldset_exist(ldsets, connector)"},{"line_number":1397,"context_line":"            retnum, errnum \u003d self._cli.delldsetld(ldset[\u0027ldsetname\u0027], ldname)"},{"line_number":1398,"context_line":"            if retnum is not True:"},{"line_number":1399,"context_line":"                if \u0027iSM31065\u0027 in errnum:"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf659307_df6bdd82","line":1396,"updated":"2018-04-05 13:26:37.000000000","message":"This block is the same as the one starting on line 1214. Maybe a good thing to refactor out into a separate function that both can call?","commit_id":"fcf09dedba94ea8eb41066345d5a8c2d69673384"}]}