)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"75ad33062db60bfa0a08f640149cd2c54a9af541","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Move scheduler filters/weights logic to cinder.scheduler.filters"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Some of the filters/weights logic are now reside in cinder.openstack."},{"line_number":10,"context_line":"common.scheduler, but there are also some filters/weights logic reside"},{"line_number":11,"context_line":"in cinder.scheduler, it is not consistent and difficult to maintain."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAATn%2F%2Faow%3D","line":9,"updated":"2013-11-06 19:15:03.000000000","message":"reword:  \u0027logic are now reside in \u0027 -\u003e \u0027logic now resides in\u0027","commit_id":"0b841a6a2b93d0d733e15b49710ce57935a50325"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"45ac4348a3060d40f6409b644e12087151e6fc05","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Move scheduler filters/weights logic to cinder.scheduler.filters"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Some of the filters/weights logic are now reside in cinder.openstack."},{"line_number":10,"context_line":"common.scheduler, but there are also some filters/weights logic reside"},{"line_number":11,"context_line":"in cinder.scheduler, it is not consistent and difficult to maintain."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAATn%2F%2FZIE%3D","line":9,"in_reply_to":"AAAATn%2F%2Faow%3D","updated":"2013-11-07 11:35:53.000000000","message":"Done","commit_id":"0b841a6a2b93d0d733e15b49710ce57935a50325"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"75ad33062db60bfa0a08f640149cd2c54a9af541","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Move scheduler filters/weights logic to cinder.scheduler.filters"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Some of the filters/weights logic are now reside in cinder.openstack."},{"line_number":10,"context_line":"common.scheduler, but there are also some filters/weights logic reside"},{"line_number":11,"context_line":"in cinder.scheduler, it is not consistent and difficult to maintain."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Also we should not put filters/weights logic to openstack common as it"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAATn%2F%2Faos%3D","line":10,"updated":"2013-11-06 19:15:03.000000000","message":"remove \u0027reside\u0027","commit_id":"0b841a6a2b93d0d733e15b49710ce57935a50325"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"45ac4348a3060d40f6409b644e12087151e6fc05","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Move scheduler filters/weights logic to cinder.scheduler.filters"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Some of the filters/weights logic are now reside in cinder.openstack."},{"line_number":10,"context_line":"common.scheduler, but there are also some filters/weights logic reside"},{"line_number":11,"context_line":"in cinder.scheduler, it is not consistent and difficult to maintain."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Also we should not put filters/weights logic to openstack common as it"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAATn%2F%2FZHs%3D","line":10,"in_reply_to":"AAAATn%2F%2Faos%3D","updated":"2013-11-07 11:35:53.000000000","message":"Done","commit_id":"0b841a6a2b93d0d733e15b49710ce57935a50325"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"75ad33062db60bfa0a08f640149cd2c54a9af541","unresolved":false,"context_lines":[{"line_number":10,"context_line":"common.scheduler, but there are also some filters/weights logic reside"},{"line_number":11,"context_line":"in cinder.scheduler, it is not consistent and difficult to maintain."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Also we should not put filters/weights logic to openstack common as it"},{"line_number":14,"context_line":"is not common code for cinder but special for scheduler, so we should"},{"line_number":15,"context_line":"move all of those logic from cinder.openstack.common.scheduler to"},{"line_number":16,"context_line":"cinder.scheduler."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAATn%2F%2Faoo%3D","line":13,"updated":"2013-11-06 19:15:03.000000000","message":"change \u0027to\u0027 to \u0027in\u0027","commit_id":"0b841a6a2b93d0d733e15b49710ce57935a50325"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"45ac4348a3060d40f6409b644e12087151e6fc05","unresolved":false,"context_lines":[{"line_number":10,"context_line":"common.scheduler, but there are also some filters/weights logic reside"},{"line_number":11,"context_line":"in cinder.scheduler, it is not consistent and difficult to maintain."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Also we should not put filters/weights logic to openstack common as it"},{"line_number":14,"context_line":"is not common code for cinder but special for scheduler, so we should"},{"line_number":15,"context_line":"move all of those logic from cinder.openstack.common.scheduler to"},{"line_number":16,"context_line":"cinder.scheduler."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAATn%2F%2FZHQ%3D","line":13,"in_reply_to":"AAAATn%2F%2Faoo%3D","updated":"2013-11-07 11:35:53.000000000","message":"Done","commit_id":"0b841a6a2b93d0d733e15b49710ce57935a50325"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"75ad33062db60bfa0a08f640149cd2c54a9af541","unresolved":false,"context_lines":[{"line_number":11,"context_line":"in cinder.scheduler, it is not consistent and difficult to maintain."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Also we should not put filters/weights logic to openstack common as it"},{"line_number":14,"context_line":"is not common code for cinder but special for scheduler, so we should"},{"line_number":15,"context_line":"move all of those logic from cinder.openstack.common.scheduler to"},{"line_number":16,"context_line":"cinder.scheduler."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAATn%2F%2Faog%3D","line":14,"updated":"2013-11-06 19:15:03.000000000","message":"reword:  \u0027scheduler, so we\u0027 to \u0027scheduler.  We should\u0027","commit_id":"0b841a6a2b93d0d733e15b49710ce57935a50325"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"45ac4348a3060d40f6409b644e12087151e6fc05","unresolved":false,"context_lines":[{"line_number":11,"context_line":"in cinder.scheduler, it is not consistent and difficult to maintain."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Also we should not put filters/weights logic to openstack common as it"},{"line_number":14,"context_line":"is not common code for cinder but special for scheduler, so we should"},{"line_number":15,"context_line":"move all of those logic from cinder.openstack.common.scheduler to"},{"line_number":16,"context_line":"cinder.scheduler."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAATn%2F%2FZG8%3D","line":14,"in_reply_to":"AAAATn%2F%2Faog%3D","updated":"2013-11-07 11:35:53.000000000","message":"Done","commit_id":"0b841a6a2b93d0d733e15b49710ce57935a50325"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"75ad33062db60bfa0a08f640149cd2c54a9af541","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Also we should not put filters/weights logic to openstack common as it"},{"line_number":14,"context_line":"is not common code for cinder but special for scheduler, so we should"},{"line_number":15,"context_line":"move all of those logic from cinder.openstack.common.scheduler to"},{"line_number":16,"context_line":"cinder.scheduler."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This can make sure cinder.scheduler become the central point for"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAATn%2F%2Faoc%3D","line":15,"updated":"2013-11-06 19:15:03.000000000","message":"change \u0027those\u0027 to \u0027the\u0027","commit_id":"0b841a6a2b93d0d733e15b49710ce57935a50325"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"45ac4348a3060d40f6409b644e12087151e6fc05","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Also we should not put filters/weights logic to openstack common as it"},{"line_number":14,"context_line":"is not common code for cinder but special for scheduler, so we should"},{"line_number":15,"context_line":"move all of those logic from cinder.openstack.common.scheduler to"},{"line_number":16,"context_line":"cinder.scheduler."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This can make sure cinder.scheduler become the central point for"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAATn%2F%2FZG4%3D","line":15,"in_reply_to":"AAAATn%2F%2Faoc%3D","updated":"2013-11-07 11:35:53.000000000","message":"Done","commit_id":"0b841a6a2b93d0d733e15b49710ce57935a50325"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"75ad33062db60bfa0a08f640149cd2c54a9af541","unresolved":false,"context_lines":[{"line_number":15,"context_line":"move all of those logic from cinder.openstack.common.scheduler to"},{"line_number":16,"context_line":"cinder.scheduler."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This can make sure cinder.scheduler become the central point for"},{"line_number":19,"context_line":"filters/weights logic and can also improve code consistency."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Implements bp scheduler-code-refactor"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAATn%2F%2FaoQ%3D","line":18,"updated":"2013-11-06 19:15:03.000000000","message":"change \u0027can\u0027 to \u0027will\u0027\nchange \u0027become\u0027 to \u0027becomes\u0027","commit_id":"0b841a6a2b93d0d733e15b49710ce57935a50325"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"45ac4348a3060d40f6409b644e12087151e6fc05","unresolved":false,"context_lines":[{"line_number":15,"context_line":"move all of those logic from cinder.openstack.common.scheduler to"},{"line_number":16,"context_line":"cinder.scheduler."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This can make sure cinder.scheduler become the central point for"},{"line_number":19,"context_line":"filters/weights logic and can also improve code consistency."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Implements bp scheduler-code-refactor"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAATn%2F%2FZGw%3D","line":18,"in_reply_to":"AAAATn%2F%2FaoQ%3D","updated":"2013-11-07 11:35:53.000000000","message":"Done","commit_id":"0b841a6a2b93d0d733e15b49710ce57935a50325"}],"cinder/openstack/common/scheduler/weights/__init__.py":[{"author":{"_account_id":7536,"name":"Ilya Pekelny","email":"ipekelny@mirantis.com","username":"I159"},"change_message_id":"8f87c364327b1d15836db2cf38d0717ae4916f3a","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"\"\"\""},{"line_number":17,"context_line":"Scheduler host weights"},{"line_number":18,"context_line":"\"\"\""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2FZB0%3D","side":"PARENT","line":17,"updated":"2013-11-07 12:57:09.000000000","message":"Needs better documentation. Describe what it does and why.","commit_id":"54b117d26e3e61e639c334e2e1c47fcd481745ab"},{"author":{"_account_id":7536,"name":"Ilya Pekelny","email":"ipekelny@mirantis.com","username":"I159"},"change_message_id":"8f57836300d8f0b9744be2429ccfacf9ac917e6f","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"class BaseHostWeigher(weight.BaseWeigher):"},{"line_number":37,"context_line":"    \"\"\"Base class for host weights.\"\"\""},{"line_number":38,"context_line":"    pass"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2FYn4%3D","side":"PARENT","line":37,"updated":"2013-11-07 15:46:09.000000000","message":"Me too can\u0027t see my comments. Anyway I\u0027m sorry I\u0027ve got a typo. I mean weight.BaseWeigher class. You do not do anything in the subclass. Why do not you use weight.BaseWeigher instead of subclass?","commit_id":"54b117d26e3e61e639c334e2e1c47fcd481745ab"},{"author":{"_account_id":7536,"name":"Ilya Pekelny","email":"ipekelny@mirantis.com","username":"I159"},"change_message_id":"8f87c364327b1d15836db2cf38d0717ae4916f3a","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"class BaseHostWeigher(weight.BaseWeigher):"},{"line_number":37,"context_line":"    \"\"\"Base class for host weights.\"\"\""},{"line_number":38,"context_line":"    pass"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2FZCE%3D","side":"PARENT","line":37,"updated":"2013-11-07 12:57:09.000000000","message":"Please explain to me, why don\u0027t you use weight.BaseWeighter as base class for host weights?","commit_id":"54b117d26e3e61e639c334e2e1c47fcd481745ab"}]}