)]}'
{"doc/source/contributor/gerrit.rst":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"eb4bcb8f2280d6fc822f4b1ff66d27b33cdce3e6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Code Reviews"},{"line_number":2,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"Cinder follows the same `Review guidelines`_ outlined by the Open Stack community."},{"line_number":5,"context_line":"This page provides additional information that is helpful for reviewers of"},{"line_number":6,"context_line":"patches to Cinder."},{"line_number":7,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"df7087c5_880e2830","line":4,"range":{"start_line":4,"start_character":61,"end_line":4,"end_character":71},"updated":"2018-03-12 20:35:58.000000000","message":"OpenStack","commit_id":"614bc65d6ecbb7f248ba6a5e93a1c68b992d131e"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"1acaba3c1c6a7afc4094184a716c2b9d449e97fc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Code Reviews"},{"line_number":2,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"Cinder follows the same `Review guidelines`_ outlined by the Open Stack community."},{"line_number":5,"context_line":"This page provides additional information that is helpful for reviewers of"},{"line_number":6,"context_line":"patches to Cinder."},{"line_number":7,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"df7087c5_633f3725","line":4,"range":{"start_line":4,"start_character":61,"end_line":4,"end_character":71},"in_reply_to":"df7087c5_880e2830","updated":"2018-03-12 21:39:49.000000000","message":"Done","commit_id":"614bc65d6ecbb7f248ba6a5e93a1c68b992d131e"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"a4afa142185d00923d12d94a461b6ef960596f22","unresolved":false,"context_lines":[{"line_number":24,"context_line":"In an effort to guide team review priorities the Cinder team has"},{"line_number":25,"context_line":"adopted the process of adding comments to reviews to target a"},{"line_number":26,"context_line":"milestone for a particular patch.  This process is not required"},{"line_number":27,"context_line":"for all patches but is benefical for patches that may be time sensitive."},{"line_number":28,"context_line":"For example patches that need to land earlier in the release cycle so as to"},{"line_number":29,"context_line":"get additional test time or because later development activities are dependent"},{"line_number":30,"context_line":"upon that functionality merging."}],"source_content_type":"text/x-rst","patch_set":1,"id":"df7087c5_23785f28","line":27,"range":{"start_line":27,"start_character":23,"end_line":27,"end_character":32},"updated":"2018-03-12 21:33:23.000000000","message":"beneficial","commit_id":"614bc65d6ecbb7f248ba6a5e93a1c68b992d131e"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"1acaba3c1c6a7afc4094184a716c2b9d449e97fc","unresolved":false,"context_lines":[{"line_number":24,"context_line":"In an effort to guide team review priorities the Cinder team has"},{"line_number":25,"context_line":"adopted the process of adding comments to reviews to target a"},{"line_number":26,"context_line":"milestone for a particular patch.  This process is not required"},{"line_number":27,"context_line":"for all patches but is benefical for patches that may be time sensitive."},{"line_number":28,"context_line":"For example patches that need to land earlier in the release cycle so as to"},{"line_number":29,"context_line":"get additional test time or because later development activities are dependent"},{"line_number":30,"context_line":"upon that functionality merging."}],"source_content_type":"text/x-rst","patch_set":1,"id":"df7087c5_833a8b31","line":27,"range":{"start_line":27,"start_character":23,"end_line":27,"end_character":32},"in_reply_to":"df7087c5_23785f28","updated":"2018-03-12 21:39:49.000000000","message":"Done","commit_id":"614bc65d6ecbb7f248ba6a5e93a1c68b992d131e"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"a4afa142185d00923d12d94a461b6ef960596f22","unresolved":false,"context_lines":[{"line_number":29,"context_line":"get additional test time or because later development activities are dependent"},{"line_number":30,"context_line":"upon that functionality merging."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"To target a patch to a milestone a reviewer should add a comment using the following"},{"line_number":33,"context_line":"format:"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"  ``target-\u003crelease\u003e-\u003cmilestone\u003e``"}],"source_content_type":"text/x-rst","patch_set":1,"id":"df7087c5_c3b5e3ce","line":32,"updated":"2018-03-12 21:33:23.000000000","message":"Might be good to keep line length under 80 if we ever decide to enable that doc8 check.","commit_id":"614bc65d6ecbb7f248ba6a5e93a1c68b992d131e"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"1acaba3c1c6a7afc4094184a716c2b9d449e97fc","unresolved":false,"context_lines":[{"line_number":29,"context_line":"get additional test time or because later development activities are dependent"},{"line_number":30,"context_line":"upon that functionality merging."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"To target a patch to a milestone a reviewer should add a comment using the following"},{"line_number":33,"context_line":"format:"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"  ``target-\u003crelease\u003e-\u003cmilestone\u003e``"}],"source_content_type":"text/x-rst","patch_set":1,"id":"df7087c5_e362673e","line":32,"in_reply_to":"df7087c5_c3b5e3ce","updated":"2018-03-12 21:39:49.000000000","message":"Not sure what you mean here.  I think all of my lines are under 80 chars.","commit_id":"614bc65d6ecbb7f248ba6a5e93a1c68b992d131e"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"2c91916bbc73f9d1a1c9d6d6525da8133654223d","unresolved":false,"context_lines":[{"line_number":46,"context_line":"guide in review priorities."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Targeting patches should be done by Cinder Core Review Team members."},{"line_number":49,"context_line":"It may also be done by the patch developers in the case there is"},{"line_number":50,"context_line":"reason for prioritizing the patch."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Reviewing Vendor Patches"},{"line_number":53,"context_line":"------------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"df7087c5_7fd310d6","line":50,"range":{"start_line":49,"start_character":0,"end_line":50,"end_character":34},"updated":"2018-03-14 16:26:46.000000000","message":"Should non core reviewers bring this up in a cinder meeting to explain the reasoning and a Core reviewer adding it or something?  Because it seems like it\u0027s too open to everyone\u0027s own discretion.","commit_id":"552fdf21a9f6241e377706d2b31ca0ad3c4acfb1"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"40b2384aa2ca8e0def662ba8eb8842af92daa589","unresolved":false,"context_lines":[{"line_number":46,"context_line":"guide in review priorities."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Targeting patches should be done by Cinder Core Review Team members."},{"line_number":49,"context_line":"It may also be done by the patch developers in the case there is"},{"line_number":50,"context_line":"reason for prioritizing the patch."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Reviewing Vendor Patches"},{"line_number":53,"context_line":"------------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"df7087c5_70f57fec","line":50,"range":{"start_line":49,"start_character":0,"end_line":50,"end_character":34},"in_reply_to":"df7087c5_7fd310d6","updated":"2018-03-14 17:41:52.000000000","message":"That is a good point.  I can reword this accordingly.","commit_id":"552fdf21a9f6241e377706d2b31ca0ad3c4acfb1"},{"author":{"_account_id":24952,"name":"Vivek Soni","email":"viveksoni31390@gmail.com","username":"sonivi"},"change_message_id":"11b3e28ecb561e80c0b6736cafcc90ed52498502","unresolved":false,"context_lines":[{"line_number":52,"context_line":"Reviewing Vendor Patches"},{"line_number":53,"context_line":"------------------------"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"It is important to consider, when reviewing patches to a vendor\u0027s Cinder"},{"line_number":56,"context_line":"driver, whether the patch passes the vendor\u0027s CI process.  CI reports"},{"line_number":57,"context_line":"are the only tool we have to ensure that a patch works with the Vendor\u0027s"},{"line_number":58,"context_line":"driver.  A patch to a vendor\u0027s driver that does not pass that"},{"line_number":59,"context_line":"vendor\u0027s CI should not be merged.  This also means that a patch should"},{"line_number":60,"context_line":"not be merged before the Vendor\u0027s CI has run against the patch."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":".. note::"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"df7087c5_7d5eef44","line":60,"range":{"start_line":55,"start_character":0,"end_line":60,"end_character":63},"updated":"2018-03-13 03:39:51.000000000","message":"some vendor\u0027s CI is not triggered on their back port patches","commit_id":"552fdf21a9f6241e377706d2b31ca0ad3c4acfb1"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"40b2384aa2ca8e0def662ba8eb8842af92daa589","unresolved":false,"context_lines":[{"line_number":52,"context_line":"Reviewing Vendor Patches"},{"line_number":53,"context_line":"------------------------"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"It is important to consider, when reviewing patches to a vendor\u0027s Cinder"},{"line_number":56,"context_line":"driver, whether the patch passes the vendor\u0027s CI process.  CI reports"},{"line_number":57,"context_line":"are the only tool we have to ensure that a patch works with the Vendor\u0027s"},{"line_number":58,"context_line":"driver.  A patch to a vendor\u0027s driver that does not pass that"},{"line_number":59,"context_line":"vendor\u0027s CI should not be merged.  This also means that a patch should"},{"line_number":60,"context_line":"not be merged before the Vendor\u0027s CI has run against the patch."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":".. note::"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"df7087c5_f08bcf64","line":60,"range":{"start_line":55,"start_character":0,"end_line":60,"end_character":63},"in_reply_to":"df7087c5_7d5eef44","updated":"2018-03-14 17:41:52.000000000","message":"Good point.  I should note that this is just for patches to master.","commit_id":"552fdf21a9f6241e377706d2b31ca0ad3c4acfb1"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"d9653c73507877b441694cc15a952345727c4cef","unresolved":false,"context_lines":[{"line_number":48,"context_line":"Targeting patches should be done by Cinder Core Review Team members."},{"line_number":49,"context_line":"If a patch developer feels that a patch should be targeted to a"},{"line_number":50,"context_line":"milestone the developer should bring the request up to the Cinder"},{"line_number":51,"context_line":"team in a weekly meeting or on the #openstack-cinder IRC channel"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"Reviewing Vendor Patches"},{"line_number":54,"context_line":"------------------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"df7087c5_94b0d9df","line":51,"updated":"2018-03-19 19:14:50.000000000","message":"nit: Missing end period.","commit_id":"4e4bb3a0e2decf784c131998b17f9c5c0fcf86d6"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"fb8ceeb6cc0e5681f7944943a18909977538e092","unresolved":false,"context_lines":[{"line_number":48,"context_line":"Targeting patches should be done by Cinder Core Review Team members."},{"line_number":49,"context_line":"If a patch developer feels that a patch should be targeted to a"},{"line_number":50,"context_line":"milestone the developer should bring the request up to the Cinder"},{"line_number":51,"context_line":"team in a weekly meeting or on the #openstack-cinder IRC channel"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"Reviewing Vendor Patches"},{"line_number":54,"context_line":"------------------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"bf659307_bbbbb30c","line":51,"in_reply_to":"df7087c5_94b0d9df","updated":"2018-03-23 16:52:42.000000000","message":"Done","commit_id":"4e4bb3a0e2decf784c131998b17f9c5c0fcf86d6"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"3e95458d2adeed6b1a0c73f888c655c074d4fc12","unresolved":false,"context_lines":[{"line_number":48,"context_line":"Targeting patches should be done by Cinder Core Review Team members."},{"line_number":49,"context_line":"If a patch developer feels that a patch should be targeted to a"},{"line_number":50,"context_line":"milestone the developer should bring the request up to the Cinder"},{"line_number":51,"context_line":"team in a weekly meeting or on the #openstack-cinder IRC channel"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"Reviewing Vendor Patches"},{"line_number":54,"context_line":"------------------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"df7087c5_d4e9f6e2","line":51,"in_reply_to":"df7087c5_94b0d9df","updated":"2018-03-23 14:13:47.000000000","message":"May be useful to say Freenode IRC channel.","commit_id":"4e4bb3a0e2decf784c131998b17f9c5c0fcf86d6"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"fb8ceeb6cc0e5681f7944943a18909977538e092","unresolved":false,"context_lines":[{"line_number":48,"context_line":"Targeting patches should be done by Cinder Core Review Team members."},{"line_number":49,"context_line":"If a patch developer feels that a patch should be targeted to a"},{"line_number":50,"context_line":"milestone the developer should bring the request up to the Cinder"},{"line_number":51,"context_line":"team in a weekly meeting or on the #openstack-cinder IRC channel"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"Reviewing Vendor Patches"},{"line_number":54,"context_line":"------------------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"bf659307_5b3617b7","line":51,"in_reply_to":"df7087c5_d4e9f6e2","updated":"2018-03-23 16:52:42.000000000","message":"Done","commit_id":"4e4bb3a0e2decf784c131998b17f9c5c0fcf86d6"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"d9653c73507877b441694cc15a952345727c4cef","unresolved":false,"context_lines":[{"line_number":58,"context_line":"are the only tool we have to ensure that a patch works with the Vendor\u0027s"},{"line_number":59,"context_line":"driver.  A patch to a vendor\u0027s driver that does not pass that"},{"line_number":60,"context_line":"vendor\u0027s CI should not be merged.  This also means that a patch should"},{"line_number":61,"context_line":"not be merged before the Vendor\u0027s CI has run against the patch."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":".. note::"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"df7087c5_14f2899b","line":61,"updated":"2018-03-19 19:14:50.000000000","message":"?: Given the limit coverage of our CI, should we mention something about requiring the patch to come from the vendor itself or having a +1 from a vendor employee?","commit_id":"4e4bb3a0e2decf784c131998b17f9c5c0fcf86d6"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"3e95458d2adeed6b1a0c73f888c655c074d4fc12","unresolved":false,"context_lines":[{"line_number":58,"context_line":"are the only tool we have to ensure that a patch works with the Vendor\u0027s"},{"line_number":59,"context_line":"driver.  A patch to a vendor\u0027s driver that does not pass that"},{"line_number":60,"context_line":"vendor\u0027s CI should not be merged.  This also means that a patch should"},{"line_number":61,"context_line":"not be merged before the Vendor\u0027s CI has run against the patch."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":".. note::"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"df7087c5_d4c25653","line":61,"in_reply_to":"df7087c5_14ac4eeb","updated":"2018-03-23 14:13:47.000000000","message":"Also may be worth noting that patches changing only unit tests are not validated in any way by vendor CIs.  I see this come up regularly enough that I think it isn\u0027t immediately obvious to people.","commit_id":"4e4bb3a0e2decf784c131998b17f9c5c0fcf86d6"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"fb8ceeb6cc0e5681f7944943a18909977538e092","unresolved":false,"context_lines":[{"line_number":58,"context_line":"are the only tool we have to ensure that a patch works with the Vendor\u0027s"},{"line_number":59,"context_line":"driver.  A patch to a vendor\u0027s driver that does not pass that"},{"line_number":60,"context_line":"vendor\u0027s CI should not be merged.  This also means that a patch should"},{"line_number":61,"context_line":"not be merged before the Vendor\u0027s CI has run against the patch."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":".. note::"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"bf659307_5b05b779","line":61,"in_reply_to":"df7087c5_14f2899b","updated":"2018-03-23 16:52:42.000000000","message":"Done","commit_id":"4e4bb3a0e2decf784c131998b17f9c5c0fcf86d6"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"262f179f858db54f714f754a94d4acc56741ed65","unresolved":false,"context_lines":[{"line_number":58,"context_line":"are the only tool we have to ensure that a patch works with the Vendor\u0027s"},{"line_number":59,"context_line":"driver.  A patch to a vendor\u0027s driver that does not pass that"},{"line_number":60,"context_line":"vendor\u0027s CI should not be merged.  This also means that a patch should"},{"line_number":61,"context_line":"not be merged before the Vendor\u0027s CI has run against the patch."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":".. note::"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"df7087c5_14ac4eeb","line":61,"in_reply_to":"df7087c5_14f2899b","updated":"2018-03-23 13:59:48.000000000","message":"I think this would be a good addition.","commit_id":"4e4bb3a0e2decf784c131998b17f9c5c0fcf86d6"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"3e95458d2adeed6b1a0c73f888c655c074d4fc12","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":".. note::"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    Patches which have passed 3rd party CI and have merged in master"},{"line_number":66,"context_line":"    are exempt from this requirement upon backport to stable and/or"},{"line_number":67,"context_line":"    driverfixes branches as vendors are not required to run CI on those"},{"line_number":68,"context_line":"    branches."}],"source_content_type":"text/x-rst","patch_set":4,"id":"df7087c5_f4275a11","line":65,"range":{"start_line":65,"start_character":31,"end_line":65,"end_character":42},"updated":"2018-03-23 14:13:47.000000000","message":"This is the first time in this doc it\u0027s called 3rd party CI instead of vendor CI, which makes it sound like a different thing.\n\nObvious to us, confusing to a newcomer","commit_id":"4e4bb3a0e2decf784c131998b17f9c5c0fcf86d6"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"fb8ceeb6cc0e5681f7944943a18909977538e092","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":".. note::"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    Patches which have passed 3rd party CI and have merged in master"},{"line_number":66,"context_line":"    are exempt from this requirement upon backport to stable and/or"},{"line_number":67,"context_line":"    driverfixes branches as vendors are not required to run CI on those"},{"line_number":68,"context_line":"    branches."}],"source_content_type":"text/x-rst","patch_set":4,"id":"bf659307_3b1243b3","line":65,"range":{"start_line":65,"start_character":31,"end_line":65,"end_character":42},"in_reply_to":"df7087c5_f4275a11","updated":"2018-03-23 16:52:42.000000000","message":"Done","commit_id":"4e4bb3a0e2decf784c131998b17f9c5c0fcf86d6"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"d9653c73507877b441694cc15a952345727c4cef","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    Patches which have passed 3rd party CI and have merged in master"},{"line_number":66,"context_line":"    are exempt from this requirement upon backport to stable and/or"},{"line_number":67,"context_line":"    driverfixes branches as vendors are not required to run CI on those"},{"line_number":68,"context_line":"    branches."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":".. note::"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"df7087c5_f4091595","line":68,"updated":"2018-03-19 19:14:50.000000000","message":"nit: But if the vendor has a CI on stable branches it should not be exempt and we should watch for it, unless an employee from the vendor says that they are having difficulties on the stable branches CI but they have verified the correctness of the patch.","commit_id":"4e4bb3a0e2decf784c131998b17f9c5c0fcf86d6"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"262f179f858db54f714f754a94d4acc56741ed65","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    Patches which have passed 3rd party CI and have merged in master"},{"line_number":66,"context_line":"    are exempt from this requirement upon backport to stable and/or"},{"line_number":67,"context_line":"    driverfixes branches as vendors are not required to run CI on those"},{"line_number":68,"context_line":"    branches."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":".. note::"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"df7087c5_b4b48237","line":68,"in_reply_to":"df7087c5_f4091595","updated":"2018-03-23 13:59:48.000000000","message":"+1","commit_id":"4e4bb3a0e2decf784c131998b17f9c5c0fcf86d6"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"fb8ceeb6cc0e5681f7944943a18909977538e092","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    Patches which have passed 3rd party CI and have merged in master"},{"line_number":66,"context_line":"    are exempt from this requirement upon backport to stable and/or"},{"line_number":67,"context_line":"    driverfixes branches as vendors are not required to run CI on those"},{"line_number":68,"context_line":"    branches."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":".. note::"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"bf659307_1b82dfc9","line":68,"in_reply_to":"df7087c5_f4091595","updated":"2018-03-23 16:52:42.000000000","message":"Done","commit_id":"4e4bb3a0e2decf784c131998b17f9c5c0fcf86d6"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"3e95458d2adeed6b1a0c73f888c655c074d4fc12","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":".. note::"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    Down voting a patch to hold it on failed CI runs is an acceptable"},{"line_number":73,"context_line":"    practice."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":".. _Review guidelines: https://docs.openstack.org/doc-contrib-guide/docs-review-guidelines.html"}],"source_content_type":"text/x-rst","patch_set":4,"id":"df7087c5_14c9ae57","line":72,"range":{"start_line":72,"start_character":4,"end_line":72,"end_character":15},"updated":"2018-03-23 14:13:47.000000000","message":"Even calling this \"down voting\" may send the wrong message.\n\n-1s in this case (and others) are more about \"let\u0027s work on this more\" and not \"I don\u0027t like this in general\" (which is IMO the connotation of calling it down voting).","commit_id":"4e4bb3a0e2decf784c131998b17f9c5c0fcf86d6"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"262f179f858db54f714f754a94d4acc56741ed65","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":".. note::"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    Down voting a patch to hold it on failed CI runs is an acceptable"},{"line_number":73,"context_line":"    practice."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":".. _Review guidelines: https://docs.openstack.org/doc-contrib-guide/docs-review-guidelines.html"}],"source_content_type":"text/x-rst","patch_set":4,"id":"df7087c5_f4975a8f","line":72,"updated":"2018-03-23 13:59:48.000000000","message":"I really don\u0027t like this bit, but I suppose it\u0027s the best way to make sure later reviewers notice. But not a fan of this at all.","commit_id":"4e4bb3a0e2decf784c131998b17f9c5c0fcf86d6"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"fb8ceeb6cc0e5681f7944943a18909977538e092","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":".. note::"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    Down voting a patch to hold it on failed CI runs is an acceptable"},{"line_number":73,"context_line":"    practice."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":".. _Review guidelines: https://docs.openstack.org/doc-contrib-guide/docs-review-guidelines.html"}],"source_content_type":"text/x-rst","patch_set":4,"id":"bf659307_3b600333","line":72,"range":{"start_line":72,"start_character":4,"end_line":72,"end_character":15},"in_reply_to":"df7087c5_14c9ae57","updated":"2018-03-23 16:52:42.000000000","message":"Removing.","commit_id":"4e4bb3a0e2decf784c131998b17f9c5c0fcf86d6"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"fb8ceeb6cc0e5681f7944943a18909977538e092","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":".. note::"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    Down voting a patch to hold it on failed CI runs is an acceptable"},{"line_number":73,"context_line":"    practice."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":".. _Review guidelines: https://docs.openstack.org/doc-contrib-guide/docs-review-guidelines.html"}],"source_content_type":"text/x-rst","patch_set":4,"id":"bf659307_bb72d310","line":72,"in_reply_to":"df7087c5_f4975a8f","updated":"2018-03-23 16:52:42.000000000","message":"Ok.  I can remove this.","commit_id":"4e4bb3a0e2decf784c131998b17f9c5c0fcf86d6"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"3e95458d2adeed6b1a0c73f888c655c074d4fc12","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    practice."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":".. _Review guidelines: https://docs.openstack.org/doc-contrib-guide/docs-review-guidelines.html"},{"line_number":76,"context_line":".. _Gerrit: https://bugs.chromium.org/p/gerrit/"},{"line_number":77,"context_line":".. _Development Workflow: https://docs.openstack.org/infra/manual/developers.html#development-workflow"},{"line_number":78,"context_line":".. _Gerrit Workflow Quick Reference: https://docs.openstack.org/infra/manual/developers.html#development-workflow"}],"source_content_type":"text/x-rst","patch_set":4,"id":"df7087c5_d44816b4","line":76,"range":{"start_line":76,"start_character":12,"end_line":76,"end_character":47},"updated":"2018-03-23 14:13:47.000000000","message":"Linking to the Gerrit bug tracker here is kind of weird.  This just goes to a list of bugs.","commit_id":"4e4bb3a0e2decf784c131998b17f9c5c0fcf86d6"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"53001a97853ac67e9e3a2a05cf276af205ec6645","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    practice."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":".. _Review guidelines: https://docs.openstack.org/doc-contrib-guide/docs-review-guidelines.html"},{"line_number":76,"context_line":".. _Gerrit: https://bugs.chromium.org/p/gerrit/"},{"line_number":77,"context_line":".. _Development Workflow: https://docs.openstack.org/infra/manual/developers.html#development-workflow"},{"line_number":78,"context_line":".. _Gerrit Workflow Quick Reference: https://docs.openstack.org/infra/manual/developers.html#development-workflow"}],"source_content_type":"text/x-rst","patch_set":4,"id":"df7087c5_741a6a7d","line":76,"range":{"start_line":76,"start_character":12,"end_line":76,"end_character":47},"in_reply_to":"df7087c5_d44816b4","updated":"2018-03-23 14:17:48.000000000","message":"I\u0027ve never noticed this before, but agree. Would be good to get this updated since we\u0027re updating the rest of the doc.","commit_id":"4e4bb3a0e2decf784c131998b17f9c5c0fcf86d6"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"fb8ceeb6cc0e5681f7944943a18909977538e092","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    practice."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":".. _Review guidelines: https://docs.openstack.org/doc-contrib-guide/docs-review-guidelines.html"},{"line_number":76,"context_line":".. _Gerrit: https://bugs.chromium.org/p/gerrit/"},{"line_number":77,"context_line":".. _Development Workflow: https://docs.openstack.org/infra/manual/developers.html#development-workflow"},{"line_number":78,"context_line":".. _Gerrit Workflow Quick Reference: https://docs.openstack.org/infra/manual/developers.html#development-workflow"}],"source_content_type":"text/x-rst","patch_set":4,"id":"bf659307_7bc2fbeb","line":76,"range":{"start_line":76,"start_character":12,"end_line":76,"end_character":47},"in_reply_to":"df7087c5_d44816b4","updated":"2018-03-23 16:52:42.000000000","message":"That is weird.  Hadn\u0027t noticed that.  I have updated this to now point to the review dashboard for Cinder.  Think that makes more sense as what we are really talking about here is review.openstack.org","commit_id":"4e4bb3a0e2decf784c131998b17f9c5c0fcf86d6"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"09d52c4f550dc324315e6a67004a5c604ae2fe44","unresolved":false,"context_lines":[{"line_number":87,"context_line":"   does not include a unit test execution."},{"line_number":88,"context_line":""},{"line_number":89,"context_line":".. _Review guidelines: https://docs.openstack.org/doc-contrib-guide/docs-review-guidelines.html"},{"line_number":90,"context_line":".. _Gerrit: https://review.openstack.org/#/dashboard/?foreach\u003dproject%3A%5Eopenstack%2F.%2Acinder.%2A+status%3Aopen+NOT+owner%3Aself+NOT+label%3AWorkflow%3C%3D%252D1+label%3AVerified%3E%3D1+NOT+label%3ACode%252DReview%3C%3D%252D1%252cself+NOT+label%3ACode%252DReview%3E%3D1%252cself\u0026title\u003dCinder+Review+Inbox\u0026Cinder+Specs\u003dproject%3Aopenstack%2Fcinder%252Dspecs\u0026Bug+Fixes\u003dtopic%3A%5Ebug%2F.%2A\u0026Needs+Feedback+%28Changes+older+than+5+days+that+have+not+been+reviewed+by+anyone%29\u003dNOT+label%3ACode%252DReview%3C%3D2+age%3A5d\u0026You+are+a+reviewer%252c+but+haven%27t+voted+in+the+current+revision\u003dreviewer%3Aself\u0026Needs+final+%2B2\u003dlabel%3ACode%252DReview%3E%3D2+limit%3A50\u0026New+Contributors\u003dreviewer%3A10068\u0026Passed+Jenkins%252c+No+Negative+Feedback\u003dNOT+label%3ACode%252DReview%3E%3D2+NOT+label%3ACode%252DReview%3C%3D%252D1+limit%3A50\u0026Wayward+Changes+%28Changes+with+no+code+review+in+the+last+2days%29\u003dNOT+label%3ACode%252DReview%3C%3D2+age%3A2d"},{"line_number":91,"context_line":".. _Development Workflow: https://docs.openstack.org/infra/manual/developers.html#development-workflow"},{"line_number":92,"context_line":".. _Gerrit Workflow Quick Reference: https://docs.openstack.org/infra/manual/developers.html#development-workflow"}],"source_content_type":"text/x-rst","patch_set":5,"id":"bf659307_c769e88b","line":90,"updated":"2018-03-23 18:56:54.000000000","message":"I like this idea, but the problem I see is if you are not logged in, the dashboards give a somewhat cryptic error message.\n\nWhat if we just did something like:\n\nhttps://review.openstack.org/#/q/project:openstack/cinder+status:open","commit_id":"dce8bc5b476d2a9e9e413d037726f14cbacee927"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"50816479bba455e13314d3b54941fe0159d2598e","unresolved":false,"context_lines":[{"line_number":87,"context_line":"   does not include a unit test execution."},{"line_number":88,"context_line":""},{"line_number":89,"context_line":".. _Review guidelines: https://docs.openstack.org/doc-contrib-guide/docs-review-guidelines.html"},{"line_number":90,"context_line":".. _Gerrit: https://review.openstack.org/#/dashboard/?foreach\u003dproject%3A%5Eopenstack%2F.%2Acinder.%2A+status%3Aopen+NOT+owner%3Aself+NOT+label%3AWorkflow%3C%3D%252D1+label%3AVerified%3E%3D1+NOT+label%3ACode%252DReview%3C%3D%252D1%252cself+NOT+label%3ACode%252DReview%3E%3D1%252cself\u0026title\u003dCinder+Review+Inbox\u0026Cinder+Specs\u003dproject%3Aopenstack%2Fcinder%252Dspecs\u0026Bug+Fixes\u003dtopic%3A%5Ebug%2F.%2A\u0026Needs+Feedback+%28Changes+older+than+5+days+that+have+not+been+reviewed+by+anyone%29\u003dNOT+label%3ACode%252DReview%3C%3D2+age%3A5d\u0026You+are+a+reviewer%252c+but+haven%27t+voted+in+the+current+revision\u003dreviewer%3Aself\u0026Needs+final+%2B2\u003dlabel%3ACode%252DReview%3E%3D2+limit%3A50\u0026New+Contributors\u003dreviewer%3A10068\u0026Passed+Jenkins%252c+No+Negative+Feedback\u003dNOT+label%3ACode%252DReview%3E%3D2+NOT+label%3ACode%252DReview%3C%3D%252D1+limit%3A50\u0026Wayward+Changes+%28Changes+with+no+code+review+in+the+last+2days%29\u003dNOT+label%3ACode%252DReview%3C%3D2+age%3A2d"},{"line_number":91,"context_line":".. _Development Workflow: https://docs.openstack.org/infra/manual/developers.html#development-workflow"},{"line_number":92,"context_line":".. _Gerrit Workflow Quick Reference: https://docs.openstack.org/infra/manual/developers.html#development-workflow"}],"source_content_type":"text/x-rst","patch_set":5,"id":"bf659307_06357846","line":90,"in_reply_to":"bf659307_c769e88b","updated":"2018-03-26 14:28:12.000000000","message":"Yeah, this makes sense.  I can do that.  Thanks for the recommendation.","commit_id":"dce8bc5b476d2a9e9e413d037726f14cbacee927"}]}