)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"d94305fcb4b97677baade1e7f267ff438c85697a","unresolved":false,"context_lines":[{"line_number":10,"context_line":"cephx. And the function _ceph_args() in cinder/backup/drivers/ceph.py"},{"line_number":11,"context_line":"needs to be fixed."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Some fixes below are done:"},{"line_number":14,"context_line":"[1] allow the parameter `user` to be None when ceph not using cephx"},{"line_number":15,"context_line":"[2] remove function _validate_string_args() which is only used in"},{"line_number":16,"context_line":"_ceph_args()"},{"line_number":17,"context_line":"[3] fix docstring of _ceph_args()"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Closes-bug: #1755836"},{"line_number":20,"context_line":"Change-Id: Ie93391b4c394089cbb0fb8002d104034a5ef2123"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"df7087c5_3c7cc61d","line":17,"range":{"start_line":13,"start_character":0,"end_line":17,"end_character":33},"updated":"2018-03-14 16:04:13.000000000","message":"nit: No need to specify what you are doing in the patch.","commit_id":"37a57d583c7768190d8aed34589b64f3ad188da0"},{"author":{"_account_id":23081,"name":"Jeremy Zhang","email":"zhangjun_inspur@163.com","username":"jeremy.zhang"},"change_message_id":"b5d996a449250dff427699291bbb75c2384a1dc3","unresolved":false,"context_lines":[{"line_number":10,"context_line":"cephx. And the function _ceph_args() in cinder/backup/drivers/ceph.py"},{"line_number":11,"context_line":"needs to be fixed."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Some fixes below are done:"},{"line_number":14,"context_line":"[1] allow the parameter `user` to be None when ceph not using cephx"},{"line_number":15,"context_line":"[2] remove function _validate_string_args() which is only used in"},{"line_number":16,"context_line":"_ceph_args()"},{"line_number":17,"context_line":"[3] fix docstring of _ceph_args()"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Closes-bug: #1755836"},{"line_number":20,"context_line":"Change-Id: Ie93391b4c394089cbb0fb8002d104034a5ef2123"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"df7087c5_5ffdec6b","line":17,"range":{"start_line":13,"start_character":0,"end_line":17,"end_character":33},"in_reply_to":"df7087c5_3c7cc61d","updated":"2018-03-14 16:24:17.000000000","message":"Done, thanks","commit_id":"37a57d583c7768190d8aed34589b64f3ad188da0"}],"cinder/backup/drivers/ceph.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"b972417fdb616720ffd71458bb44c54afca47dcf","unresolved":false,"context_lines":[{"line_number":201,"context_line":"        /etc/ceph/ceph.conf"},{"line_number":202,"context_line":"        \"\"\""},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"        # Make sure user arg is valid since rbd command may not fail if"},{"line_number":205,"context_line":"        # invalid/no user provided, resulting in unexpected behaviour."},{"line_number":206,"context_line":"        if not self._validate_string_args(user):"},{"line_number":207,"context_line":"            raise exception.BackupInvalidCephArgs(_(\"invalid user \u0027%s\u0027\") %"},{"line_number":208,"context_line":"                                                  user)"}],"source_content_type":"text/x-python","patch_set":2,"id":"df7087c5_18a5e5b5","side":"PARENT","line":205,"range":{"start_line":204,"start_character":0,"end_line":205,"end_character":70},"updated":"2018-03-19 14:25:58.000000000","message":"What about this issue?","commit_id":"afecba3b951ccc9916bbc328d372a2386cabe14d"},{"author":{"_account_id":23081,"name":"Jeremy Zhang","email":"zhangjun_inspur@163.com","username":"jeremy.zhang"},"change_message_id":"952e596000f2c03f4cb0a7b4305a68377bd42330","unresolved":false,"context_lines":[{"line_number":201,"context_line":"        /etc/ceph/ceph.conf"},{"line_number":202,"context_line":"        \"\"\""},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"        # Make sure user arg is valid since rbd command may not fail if"},{"line_number":205,"context_line":"        # invalid/no user provided, resulting in unexpected behaviour."},{"line_number":206,"context_line":"        if not self._validate_string_args(user):"},{"line_number":207,"context_line":"            raise exception.BackupInvalidCephArgs(_(\"invalid user \u0027%s\u0027\") %"},{"line_number":208,"context_line":"                                                  user)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf659307_4898bd73","side":"PARENT","line":205,"range":{"start_line":204,"start_character":0,"end_line":205,"end_character":70},"in_reply_to":"bf659307_ba976648","updated":"2018-04-03 01:24:35.000000000","message":"Thanks，Gorka，The problem is that the bug is not well described or specified. If that bug does exist, I think the function _ceph_args() in cinder/volume/drivers/rbd.py also needs to be fixed","commit_id":"afecba3b951ccc9916bbc328d372a2386cabe14d"},{"author":{"_account_id":23081,"name":"Jeremy Zhang","email":"zhangjun_inspur@163.com","username":"jeremy.zhang"},"change_message_id":"7b58c62be65a4d8ca0a08b18e80f72004c41adb0","unresolved":false,"context_lines":[{"line_number":201,"context_line":"        /etc/ceph/ceph.conf"},{"line_number":202,"context_line":"        \"\"\""},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"        # Make sure user arg is valid since rbd command may not fail if"},{"line_number":205,"context_line":"        # invalid/no user provided, resulting in unexpected behaviour."},{"line_number":206,"context_line":"        if not self._validate_string_args(user):"},{"line_number":207,"context_line":"            raise exception.BackupInvalidCephArgs(_(\"invalid user \u0027%s\u0027\") %"},{"line_number":208,"context_line":"                                                  user)"}],"source_content_type":"text/x-python","patch_set":2,"id":"df7087c5_276c2635","side":"PARENT","line":205,"range":{"start_line":204,"start_character":0,"end_line":205,"end_character":70},"in_reply_to":"df7087c5_18a5e5b5","updated":"2018-03-20 14:41:25.000000000","message":"When cephx is turned off, no user can be provided.\nWhen cephx is turned on, rbd command using invalid user will fail in authentication, we can just let ceph cluster throw the Exception.\n\nHere the `unexpeted behaviour` is not so specific.","commit_id":"afecba3b951ccc9916bbc328d372a2386cabe14d"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"a811da091b013f3d816cf0e4205f5485786b0adf","unresolved":false,"context_lines":[{"line_number":201,"context_line":"        /etc/ceph/ceph.conf"},{"line_number":202,"context_line":"        \"\"\""},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"        # Make sure user arg is valid since rbd command may not fail if"},{"line_number":205,"context_line":"        # invalid/no user provided, resulting in unexpected behaviour."},{"line_number":206,"context_line":"        if not self._validate_string_args(user):"},{"line_number":207,"context_line":"            raise exception.BackupInvalidCephArgs(_(\"invalid user \u0027%s\u0027\") %"},{"line_number":208,"context_line":"                                                  user)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf659307_ba976648","side":"PARENT","line":205,"range":{"start_line":204,"start_character":0,"end_line":205,"end_character":70},"in_reply_to":"df7087c5_276c2635","updated":"2018-04-02 14:52:07.000000000","message":"I agree with Eric, the submitter of this comment clearly states that not having a user can cause a command to silently fail, so I\u0027m not too keen in fixing insecure Ceph deployments just to create a bug for the big majority of properly deployed Ceph clusters.","commit_id":"afecba3b951ccc9916bbc328d372a2386cabe14d"}]}