)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"63f946b288ebe8c7ee1d6f1eecc0f0b06f219526","unresolved":false,"context_lines":[{"line_number":12,"context_line":"If multiple servers are mapped to a volume the driver was only returning"},{"line_number":13,"context_line":"the first server for a given portal."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: If65780000fa8f59f663b00b88584cf289effa590"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"df7087c5_7e7bdbf3","line":15,"updated":"2018-03-16 09:50:27.000000000","message":"-1: Missing launchpad bug about how this breaks Nova live migrations.","commit_id":"3306bd181f76ac1d47a2181f8987cb83873defbf"},{"author":{"_account_id":12112,"name":"Tom Swanson","email":"tom_swanson@dell.com","username":"tomswanson"},"change_message_id":"cf6a281b31b4daf75400a786f0ca898eafcba737","unresolved":false,"context_lines":[{"line_number":12,"context_line":"If multiple servers are mapped to a volume the driver was only returning"},{"line_number":13,"context_line":"the first server for a given portal."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: If65780000fa8f59f663b00b88584cf289effa590"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"df7087c5_c9b6bd8b","line":15,"in_reply_to":"df7087c5_7e7bdbf3","updated":"2018-03-19 18:15:56.000000000","message":"Done","commit_id":"3306bd181f76ac1d47a2181f8987cb83873defbf"}],"cinder/tests/unit/volume/drivers/dell_emc/sc/test_scapi.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"63f946b288ebe8c7ee1d6f1eecc0f0b06f219526","unresolved":false,"context_lines":[{"line_number":3679,"context_line":"            mock_find_domains, mock_find_ctrl_port,"},{"line_number":3680,"context_line":"            mock_find_active_controller, mock_close_connection,"},{"line_number":3681,"context_line":"            mock_open_connection, mock_init):"},{"line_number":3682,"context_line":"        mappings \u003d [self.MAPPINGS[0].copy()]"},{"line_number":3683,"context_line":"        mappings.append({\u0027instanceId\u0027: \u002764702.970.64702\u0027,"},{"line_number":3684,"context_line":"                         \u0027server\u0027: {\u0027instanceId\u0027: \u002764702.47\u0027},"},{"line_number":3685,"context_line":"                         \u0027volume\u0027: {\u0027instanceId\u0027: \u002764702.92\u0027}})"},{"line_number":3686,"context_line":"        scserver \u003d {\u0027instanceId\u0027: \u002764702.30\u0027}"},{"line_number":3687,"context_line":"        res \u003d self.scapi.find_iscsi_properties(self.VOLUME, scserver)"},{"line_number":3688,"context_line":"        self.assertTrue(mock_is_virtualport_mode.called)"}],"source_content_type":"text/x-python","patch_set":3,"id":"df7087c5_9e190fd8","line":3685,"range":{"start_line":3682,"start_character":0,"end_line":3685,"end_character":63},"updated":"2018-03-16 09:50:27.000000000","message":"-1: I could be wrong, but I believe you have to reverse the order for this test to be meaningful, otherwise the driver could be returning the first match like it was doing before this patch and we wouldn\u0027t know.\n\nIf we reverse the order we would be forcing the driver to ignore the first entry and return the second one, which is the bug this patch is fixing.","commit_id":"3306bd181f76ac1d47a2181f8987cb83873defbf"},{"author":{"_account_id":12112,"name":"Tom Swanson","email":"tom_swanson@dell.com","username":"tomswanson"},"change_message_id":"cf6a281b31b4daf75400a786f0ca898eafcba737","unresolved":false,"context_lines":[{"line_number":3679,"context_line":"            mock_find_domains, mock_find_ctrl_port,"},{"line_number":3680,"context_line":"            mock_find_active_controller, mock_close_connection,"},{"line_number":3681,"context_line":"            mock_open_connection, mock_init):"},{"line_number":3682,"context_line":"        mappings \u003d [self.MAPPINGS[0].copy()]"},{"line_number":3683,"context_line":"        mappings.append({\u0027instanceId\u0027: \u002764702.970.64702\u0027,"},{"line_number":3684,"context_line":"                         \u0027server\u0027: {\u0027instanceId\u0027: \u002764702.47\u0027},"},{"line_number":3685,"context_line":"                         \u0027volume\u0027: {\u0027instanceId\u0027: \u002764702.92\u0027}})"},{"line_number":3686,"context_line":"        scserver \u003d {\u0027instanceId\u0027: \u002764702.30\u0027}"},{"line_number":3687,"context_line":"        res \u003d self.scapi.find_iscsi_properties(self.VOLUME, scserver)"},{"line_number":3688,"context_line":"        self.assertTrue(mock_is_virtualport_mode.called)"}],"source_content_type":"text/x-python","patch_set":3,"id":"df7087c5_897525cf","line":3685,"range":{"start_line":3682,"start_character":0,"end_line":3685,"end_character":63},"in_reply_to":"df7087c5_9e190fd8","updated":"2018-03-19 18:15:56.000000000","message":"Done","commit_id":"3306bd181f76ac1d47a2181f8987cb83873defbf"}],"cinder/volume/drivers/dell_emc/sc/storagecenter_api.py":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"d153c54ea24b74073a8f2af8d9f394507f92d331","unresolved":false,"context_lines":[{"line_number":1818,"context_line":"                            and iqns[idx] \u003d\u003d iqn"},{"line_number":1819,"context_line":"                            and luns[idx] \u003d\u003d lun):"},{"line_number":1820,"context_line":"                        LOG.debug(\u0027Skipping duplicate portal %(ptrl)s and\u0027"},{"line_number":1821,"context_line":"                                  \u0027iqn %(iqn)s and lun %(lun)s.\u0027,"},{"line_number":1822,"context_line":"                                  {\u0027ptrl\u0027: portal, \u0027iqn\u0027: iqn, \u0027lun\u0027: lun})"},{"line_number":1823,"context_line":"                        return"},{"line_number":1824,"context_line":"                # It isn\u0027t in the list so process it."}],"source_content_type":"text/x-python","patch_set":2,"id":"df7087c5_594ded3b","line":1821,"range":{"start_line":1821,"start_character":34,"end_line":1821,"end_character":38},"updated":"2018-03-15 13:13:47.000000000","message":"missing space here.","commit_id":"7467a7425c0e2ac3d09bd6f04963a3ecf351e66d"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"63f946b288ebe8c7ee1d6f1eecc0f0b06f219526","unresolved":false,"context_lines":[{"line_number":1861,"context_line":"                    # Don\u0027t return information for other servers. But"},{"line_number":1862,"context_line":"                    # do log it."},{"line_number":1863,"context_line":"                    if self._get_id(msrv) !\u003d self._get_id(scserver):"},{"line_number":1864,"context_line":"                        LOG.info(\u0027find_iscsi_properties: Multiple servers\u0027"},{"line_number":1865,"context_line":"                                 \u0027 attached to volume.\u0027)"},{"line_number":1866,"context_line":"                        continue"},{"line_number":1867,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"df7087c5_1e7bbf27","line":1864,"updated":"2018-03-16 09:50:27.000000000","message":"nit: Shouldn\u0027t this be at debug level like the on in L1820?","commit_id":"3306bd181f76ac1d47a2181f8987cb83873defbf"},{"author":{"_account_id":12112,"name":"Tom Swanson","email":"tom_swanson@dell.com","username":"tomswanson"},"change_message_id":"cf6a281b31b4daf75400a786f0ca898eafcba737","unresolved":false,"context_lines":[{"line_number":1861,"context_line":"                    # Don\u0027t return information for other servers. But"},{"line_number":1862,"context_line":"                    # do log it."},{"line_number":1863,"context_line":"                    if self._get_id(msrv) !\u003d self._get_id(scserver):"},{"line_number":1864,"context_line":"                        LOG.info(\u0027find_iscsi_properties: Multiple servers\u0027"},{"line_number":1865,"context_line":"                                 \u0027 attached to volume.\u0027)"},{"line_number":1866,"context_line":"                        continue"},{"line_number":1867,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"df7087c5_e93e21d9","line":1864,"in_reply_to":"df7087c5_1e7bbf27","updated":"2018-03-19 18:15:56.000000000","message":"Done","commit_id":"3306bd181f76ac1d47a2181f8987cb83873defbf"}]}