)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"ecce19eba1b42f6e15f1b8c29d7b88d205ee2489","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix parameter location error and assignment error in image_utils"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"1. It is not a good idea to add a new parameter in the middle! It"},{"line_number":10,"context_line":"   makes mistakes for other volume drivers who use it! Please note"},{"line_number":11,"context_line":"   that!"},{"line_number":12,"context_line":"2. Assignment error should be a negligence."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"df7087c5_eea0b5f6","line":9,"updated":"2018-03-15 12:38:16.000000000","message":"You should refer to the change that moved this.\n\nThe last change to these was several months ago, and driver CI has been passing. Furthermore, these are kwargs and should not matter what location they are in the list. You don\u0027t point out the actual code that breaks because of this, but that code should be updated so the order of the kwargs does not matter.","commit_id":"cca0a16d7fd1903a1adc6225a42c96c907a9d099"},{"author":{"_account_id":25837,"name":"yenai","email":"yenai_yewu@cmss.chinamobile.com","username":"yenai2008"},"change_message_id":"7b3789e2be143d9e660c08e142df580ce7be7cd5","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix parameter location error and assignment error in image_utils"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"1. It is not a good idea to add a new parameter in the middle! It"},{"line_number":10,"context_line":"   makes mistakes for other volume drivers who use it! Please note"},{"line_number":11,"context_line":"   that!"},{"line_number":12,"context_line":"2. Assignment error should be a negligence."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"df7087c5_0a705e07","line":9,"in_reply_to":"df7087c5_eea0b5f6","updated":"2018-03-16 06:56:15.000000000","message":"Done\nRef: https://review.openstack.org/#/c/514658/\nI have searched all the codes in cinder, the new patch will fix this problem.","commit_id":"cca0a16d7fd1903a1adc6225a42c96c907a9d099"}],"cinder/image/image_utils.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"2a11681bf45d06f84ccf2b9dc4173785b3e5da7a","unresolved":false,"context_lines":[{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    if out_format \u003d\u003d \u0027vhd\u0027:"},{"line_number":147,"context_line":"        # qemu-img still uses the legacy vpc name"},{"line_number":148,"context_line":"        out_format \u003d \u0027vpc\u0027"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    cmd \u003d [\u0027qemu-img\u0027, \u0027convert\u0027, \u0027-O\u0027, out_format]"},{"line_number":151,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"df7087c5_e45ac828","line":148,"updated":"2018-03-19 16:14:16.000000000","message":"I think this is a separate bug from the issues below.  Please make these changes in separate patches so that we can more reasonably handle backporting of fixes.\n\nThanks","commit_id":"9935d5c30d7529a164e954cfe4aaddbe64084cb5"},{"author":{"_account_id":25837,"name":"yenai","email":"yenai_yewu@cmss.chinamobile.com","username":"yenai2008"},"change_message_id":"18b45ba918fe24aebcd6d70785b852b6efeac295","unresolved":false,"context_lines":[{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    if out_format \u003d\u003d \u0027vhd\u0027:"},{"line_number":147,"context_line":"        # qemu-img still uses the legacy vpc name"},{"line_number":148,"context_line":"        out_format \u003d \u0027vpc\u0027"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    cmd \u003d [\u0027qemu-img\u0027, \u0027convert\u0027, \u0027-O\u0027, out_format]"},{"line_number":151,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"df7087c5_a91d7bbe","line":148,"in_reply_to":"df7087c5_e45ac828","updated":"2018-03-20 02:37:57.000000000","message":"Done\nThe new patch is https://review.openstack.org/#/c/554394/.","commit_id":"9935d5c30d7529a164e954cfe4aaddbe64084cb5"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"2a11681bf45d06f84ccf2b9dc4173785b3e5da7a","unresolved":false,"context_lines":[{"line_number":410,"context_line":"                 user_id\u003dNone, project_id\u003dNone, run_as_root\u003dTrue,"},{"line_number":411,"context_line":"                 volume_subformat\u003dNone):"},{"line_number":412,"context_line":"    fetch_to_volume_format(context, image_service, image_id, dest, \u0027vpc\u0027,"},{"line_number":413,"context_line":"                           blocksize, volume_subformat, user_id, project_id,"},{"line_number":414,"context_line":"                           run_as_root\u003drun_as_root)"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"def fetch_to_raw(context, image_service,"}],"source_content_type":"text/x-python","patch_set":5,"id":"df7087c5_843aecca","line":414,"range":{"start_line":413,"start_character":38,"end_line":414,"end_character":50},"updated":"2018-03-19 16:14:16.000000000","message":"These should all be passed as kwargs to help prevent this kind of issue.","commit_id":"9935d5c30d7529a164e954cfe4aaddbe64084cb5"},{"author":{"_account_id":25837,"name":"yenai","email":"yenai_yewu@cmss.chinamobile.com","username":"yenai2008"},"change_message_id":"18b45ba918fe24aebcd6d70785b852b6efeac295","unresolved":false,"context_lines":[{"line_number":410,"context_line":"                 user_id\u003dNone, project_id\u003dNone, run_as_root\u003dTrue,"},{"line_number":411,"context_line":"                 volume_subformat\u003dNone):"},{"line_number":412,"context_line":"    fetch_to_volume_format(context, image_service, image_id, dest, \u0027vpc\u0027,"},{"line_number":413,"context_line":"                           blocksize, volume_subformat, user_id, project_id,"},{"line_number":414,"context_line":"                           run_as_root\u003drun_as_root)"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"def fetch_to_raw(context, image_service,"}],"source_content_type":"text/x-python","patch_set":5,"id":"df7087c5_098267c9","line":414,"range":{"start_line":413,"start_character":38,"end_line":414,"end_character":50},"in_reply_to":"df7087c5_843aecca","updated":"2018-03-20 02:37:57.000000000","message":"Done","commit_id":"9935d5c30d7529a164e954cfe4aaddbe64084cb5"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"2a11681bf45d06f84ccf2b9dc4173785b3e5da7a","unresolved":false,"context_lines":[{"line_number":418,"context_line":"                 image_id, dest, blocksize,"},{"line_number":419,"context_line":"                 user_id\u003dNone, project_id\u003dNone, size\u003dNone, run_as_root\u003dTrue):"},{"line_number":420,"context_line":"    fetch_to_volume_format(context, image_service, image_id, dest, \u0027raw\u0027,"},{"line_number":421,"context_line":"                           blocksize, None, user_id, project_id, size,"},{"line_number":422,"context_line":"                           run_as_root\u003drun_as_root)"},{"line_number":423,"context_line":""},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"def fetch_to_volume_format(context, image_service,"}],"source_content_type":"text/x-python","patch_set":5,"id":"df7087c5_e425e8ac","line":422,"range":{"start_line":421,"start_character":38,"end_line":422,"end_character":51},"updated":"2018-03-19 16:14:16.000000000","message":"These should all be passed as kwargs to help prevent this kind of issue.","commit_id":"9935d5c30d7529a164e954cfe4aaddbe64084cb5"},{"author":{"_account_id":25837,"name":"yenai","email":"yenai_yewu@cmss.chinamobile.com","username":"yenai2008"},"change_message_id":"18b45ba918fe24aebcd6d70785b852b6efeac295","unresolved":false,"context_lines":[{"line_number":418,"context_line":"                 image_id, dest, blocksize,"},{"line_number":419,"context_line":"                 user_id\u003dNone, project_id\u003dNone, size\u003dNone, run_as_root\u003dTrue):"},{"line_number":420,"context_line":"    fetch_to_volume_format(context, image_service, image_id, dest, \u0027raw\u0027,"},{"line_number":421,"context_line":"                           blocksize, None, user_id, project_id, size,"},{"line_number":422,"context_line":"                           run_as_root\u003drun_as_root)"},{"line_number":423,"context_line":""},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"def fetch_to_volume_format(context, image_service,"}],"source_content_type":"text/x-python","patch_set":5,"id":"df7087c5_c96b0f1d","line":422,"range":{"start_line":421,"start_character":38,"end_line":422,"end_character":51},"in_reply_to":"df7087c5_e425e8ac","updated":"2018-03-20 02:37:57.000000000","message":"Done","commit_id":"9935d5c30d7529a164e954cfe4aaddbe64084cb5"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"2f3f25a469a90e642ac60c3326be25bae04a45e1","unresolved":false,"context_lines":[{"line_number":407,"context_line":""},{"line_number":408,"context_line":"def fetch_to_vhd(context, image_service,"},{"line_number":409,"context_line":"                 image_id, dest, blocksize,"},{"line_number":410,"context_line":"                 user_id\u003dNone, project_id\u003dNone, run_as_root\u003dTrue,"},{"line_number":411,"context_line":"                 volume_subformat\u003dNone):"},{"line_number":412,"context_line":"    fetch_to_volume_format(context, image_service, image_id, dest, \u0027vpc\u0027,"},{"line_number":413,"context_line":"                           blocksize, volume_subformat\u003dvolume_subformat,"}],"source_content_type":"text/x-python","patch_set":6,"id":"df7087c5_e00d9835","line":410,"updated":"2018-03-21 13:06:33.000000000","message":"It\u0027s not a strict convention, but most of our code has \"run_as_root\" as the last argument on calls like this -- it would be good to keep it this way.","commit_id":"362dbd550176bba1c4d594132608aecc82e513b1"},{"author":{"_account_id":25837,"name":"yenai","email":"yenai_yewu@cmss.chinamobile.com","username":"yenai2008"},"change_message_id":"44512d22baa230d61a94cfa6f1c96991b27f5012","unresolved":false,"context_lines":[{"line_number":407,"context_line":""},{"line_number":408,"context_line":"def fetch_to_vhd(context, image_service,"},{"line_number":409,"context_line":"                 image_id, dest, blocksize,"},{"line_number":410,"context_line":"                 user_id\u003dNone, project_id\u003dNone, run_as_root\u003dTrue,"},{"line_number":411,"context_line":"                 volume_subformat\u003dNone):"},{"line_number":412,"context_line":"    fetch_to_volume_format(context, image_service, image_id, dest, \u0027vpc\u0027,"},{"line_number":413,"context_line":"                           blocksize, volume_subformat\u003dvolume_subformat,"}],"source_content_type":"text/x-python","patch_set":6,"id":"df7087c5_34bf44d1","line":410,"in_reply_to":"df7087c5_e00d9835","updated":"2018-03-22 01:10:22.000000000","message":"Done","commit_id":"362dbd550176bba1c4d594132608aecc82e513b1"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"5c8b2c2b5adf32f1c59555cc5af92bf577df2b69","unresolved":false,"context_lines":[{"line_number":409,"context_line":"                 image_id, dest, blocksize, volume_subformat\u003dNone,"},{"line_number":410,"context_line":"                 user_id\u003dNone, project_id\u003dNone, run_as_root\u003dTrue):"},{"line_number":411,"context_line":"    fetch_to_volume_format(context, image_service, image_id, dest, \u0027vpc\u0027,"},{"line_number":412,"context_line":"                           blocksize, volume_subformat\u003dvolume_subformat,"},{"line_number":413,"context_line":"                           user_id\u003duser_id, project_id\u003dproject_id,"},{"line_number":414,"context_line":"                           run_as_root\u003drun_as_root)"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"def fetch_to_raw(context, image_service,"}],"source_content_type":"text/x-python","patch_set":7,"id":"df7087c5_0062f63e","line":414,"range":{"start_line":412,"start_character":26,"end_line":414,"end_character":51},"updated":"2018-03-22 06:21:40.000000000","message":"Oh, so this method was not using kwargs, yet the volume_subformat argument was introduced in between, breaking those calls.","commit_id":"7411eb5aae9952c730ce733dca3595f8286de40c"},{"author":{"_account_id":25837,"name":"yenai","email":"yenai_yewu@cmss.chinamobile.com","username":"yenai2008"},"change_message_id":"f9c575fe2142f841415845e1db742935f13beb2b","unresolved":false,"context_lines":[{"line_number":409,"context_line":"                 image_id, dest, blocksize, volume_subformat\u003dNone,"},{"line_number":410,"context_line":"                 user_id\u003dNone, project_id\u003dNone, run_as_root\u003dTrue):"},{"line_number":411,"context_line":"    fetch_to_volume_format(context, image_service, image_id, dest, \u0027vpc\u0027,"},{"line_number":412,"context_line":"                           blocksize, volume_subformat\u003dvolume_subformat,"},{"line_number":413,"context_line":"                           user_id\u003duser_id, project_id\u003dproject_id,"},{"line_number":414,"context_line":"                           run_as_root\u003drun_as_root)"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"def fetch_to_raw(context, image_service,"}],"source_content_type":"text/x-python","patch_set":7,"id":"df7087c5_94c64b49","line":414,"range":{"start_line":412,"start_character":26,"end_line":414,"end_character":51},"in_reply_to":"df7087c5_0062f63e","updated":"2018-03-22 07:09:03.000000000","message":"Yes. So use kwargs is necessary.","commit_id":"7411eb5aae9952c730ce733dca3595f8286de40c"}]}