)]}'
{"cinder/db/sqlalchemy/api.py":[{"author":{"_account_id":5733,"name":"Kieran Spear","email":"kispear@gmail.com","username":"kspear"},"change_message_id":"ddf3499cf942c334e2aaa4bbb10d82b959523d2b","unresolved":false,"context_lines":[{"line_number":2290,"context_line":""},{"line_number":2291,"context_line":""},{"line_number":2292,"context_line":"@require_context"},{"line_number":2293,"context_line":"def _volumes_glance_metadata_get(context, session\u003dNone):"},{"line_number":2294,"context_line":"    rows \u003d model_query(context, models.VolumeGlanceMetadata, session\u003dsession).\\"},{"line_number":2295,"context_line":"        filter_by(deleted\u003dFalse).\\"},{"line_number":2296,"context_line":"        all()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FaGo%3D","line":2293,"updated":"2013-11-07 02:47:52.000000000","message":"Following the convention in this file (and in Nova) these functions should be named\n\n    volume_glance_metadata_get_all","commit_id":"c5091c2446fce0777169daaf5fe522f102d38877"},{"author":{"_account_id":7996,"name":"Luis A. Garcia","email":"luis@linux.vnet.ibm.com","username":"luisg"},"change_message_id":"88ee7b271af01427fd18fe1457160a853878cb28","unresolved":false,"context_lines":[{"line_number":2290,"context_line":""},{"line_number":2291,"context_line":""},{"line_number":2292,"context_line":"@require_context"},{"line_number":2293,"context_line":"def _volumes_glance_metadata_get(context, session\u003dNone):"},{"line_number":2294,"context_line":"    rows \u003d model_query(context, models.VolumeGlanceMetadata, session\u003dsession).\\"},{"line_number":2295,"context_line":"        filter_by(deleted\u003dFalse).\\"},{"line_number":2296,"context_line":"        all()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FYd4%3D","line":2293,"in_reply_to":"AAAATn%2F%2FaGo%3D","updated":"2013-11-07 17:32:54.000000000","message":"Done","commit_id":"c5091c2446fce0777169daaf5fe522f102d38877"},{"author":{"_account_id":5733,"name":"Kieran Spear","email":"kispear@gmail.com","username":"kspear"},"change_message_id":"ddf3499cf942c334e2aaa4bbb10d82b959523d2b","unresolved":false,"context_lines":[{"line_number":2291,"context_line":""},{"line_number":2292,"context_line":"@require_context"},{"line_number":2293,"context_line":"def _volumes_glance_metadata_get(context, session\u003dNone):"},{"line_number":2294,"context_line":"    rows \u003d model_query(context, models.VolumeGlanceMetadata, session\u003dsession).\\"},{"line_number":2295,"context_line":"        filter_by(deleted\u003dFalse).\\"},{"line_number":2296,"context_line":"        all()"},{"line_number":2297,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FaGg%3D","line":2294,"updated":"2013-11-07 02:47:52.000000000","message":"If you move the .all() from this function to the one below, you will be able to call this function from _volume_glance_metadata_get and avoid repeating yourself.","commit_id":"c5091c2446fce0777169daaf5fe522f102d38877"},{"author":{"_account_id":5733,"name":"Kieran Spear","email":"kispear@gmail.com","username":"kspear"},"change_message_id":"fa48ed93f89f5bb509b809c28216d60be3c49a24","unresolved":false,"context_lines":[{"line_number":2291,"context_line":""},{"line_number":2292,"context_line":"@require_context"},{"line_number":2293,"context_line":"def _volumes_glance_metadata_get(context, session\u003dNone):"},{"line_number":2294,"context_line":"    rows \u003d model_query(context, models.VolumeGlanceMetadata, session\u003dsession).\\"},{"line_number":2295,"context_line":"        filter_by(deleted\u003dFalse).\\"},{"line_number":2296,"context_line":"        all()"},{"line_number":2297,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FX10%3D","line":2294,"in_reply_to":"AAAATn%2F%2FYbg%3D","updated":"2013-11-08 02:24:36.000000000","message":"Makes sense. Usually you\u0027d add a \u0027_query\u0027 suffix to make it clear that it returned a query (_volume_get_query is an example of this). But I don\u0027t have strong feelings either way. I don\u0027t see any need for the private function to exist at all though if the public function is just forwarding the call.","commit_id":"c5091c2446fce0777169daaf5fe522f102d38877"},{"author":{"_account_id":7996,"name":"Luis A. Garcia","email":"luis@linux.vnet.ibm.com","username":"luisg"},"change_message_id":"88ee7b271af01427fd18fe1457160a853878cb28","unresolved":false,"context_lines":[{"line_number":2291,"context_line":""},{"line_number":2292,"context_line":"@require_context"},{"line_number":2293,"context_line":"def _volumes_glance_metadata_get(context, session\u003dNone):"},{"line_number":2294,"context_line":"    rows \u003d model_query(context, models.VolumeGlanceMetadata, session\u003dsession).\\"},{"line_number":2295,"context_line":"        filter_by(deleted\u003dFalse).\\"},{"line_number":2296,"context_line":"        all()"},{"line_number":2297,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FYbg%3D","line":2294,"in_reply_to":"AAAATn%2F%2FaGg%3D","updated":"2013-11-07 17:32:54.000000000","message":"I like how for these methods you have the private method doing the querying, instead of preparing the querying and having the public one execute it, which would be the case for volume_glance_metadata_all() if I implemented this suggested change. \n\nI would prefer to leave it like this and have each private method return results instead of 1 return a query and 1 return results. Feels more symmetric this way. Unless you feel very strongly against it.\n\nI could create a third method that extracts out the common filter in the query (deleted\u003dfalse), then these two would execute it, but it feels like overkill.","commit_id":"c5091c2446fce0777169daaf5fe522f102d38877"}]}