)]}'
{"cinder/api/contrib/volume_image_metadata.py":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"548535c033af206677f195b4c4cedd9da13c694e","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        try:"},{"line_number":35,"context_line":"            all_metadata \u003d self.volume_api.get_volumes_image_metadata(context)"},{"line_number":36,"context_line":"        except Exception:"},{"line_number":37,"context_line":"            all_metadata \u003d {}"},{"line_number":38,"context_line":"        return all_metadata"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def _add_image_metadata(self, context, resp_volume, image_meta\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FamA%3D","line":37,"updated":"2013-11-06 19:36:41.000000000","message":"In the case that you eat an exception, I assume that it is coming up for the database.  Seems like you should at least do a LOG.info message or something like that to indicate that this situation has been encountered and handled.","commit_id":"fe1a7df107d63abb3fd0a8cf7fed9a8b7926f840"},{"author":{"_account_id":7996,"name":"Luis A. Garcia","email":"luis@linux.vnet.ibm.com","username":"luisg"},"change_message_id":"0c9f6094b34bd86224b3e8703ab83db47a46505b","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        try:"},{"line_number":35,"context_line":"            all_metadata \u003d self.volume_api.get_volumes_image_metadata(context)"},{"line_number":36,"context_line":"        except Exception:"},{"line_number":37,"context_line":"            all_metadata \u003d {}"},{"line_number":38,"context_line":"        return all_metadata"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def _add_image_metadata(self, context, resp_volume, image_meta\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FaSE%3D","line":37,"in_reply_to":"AAAATn%2F%2FamA%3D","updated":"2013-11-06 23:43:14.000000000","message":"Done","commit_id":"fe1a7df107d63abb3fd0a8cf7fed9a8b7926f840"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"548535c033af206677f195b4c4cedd9da13c694e","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        :param resp_volume: the response volume"},{"line_number":45,"context_line":"        :param image_meta: the image metadata to append, if None is provided it"},{"line_number":46,"context_line":"                           will be retrieved from the database. An empty dict"},{"line_number":47,"context_line":"                           means there is no metadata and it won\u0027t be retrieved"},{"line_number":48,"context_line":"        \"\"\""},{"line_number":49,"context_line":"        if image_meta is None:"},{"line_number":50,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2Famg%3D","line":47,"updated":"2013-11-06 19:36:41.000000000","message":"This should start with a capital and end with a period since they are sentences.","commit_id":"fe1a7df107d63abb3fd0a8cf7fed9a8b7926f840"},{"author":{"_account_id":7996,"name":"Luis A. Garcia","email":"luis@linux.vnet.ibm.com","username":"luisg"},"change_message_id":"0c9f6094b34bd86224b3e8703ab83db47a46505b","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        :param resp_volume: the response volume"},{"line_number":45,"context_line":"        :param image_meta: the image metadata to append, if None is provided it"},{"line_number":46,"context_line":"                           will be retrieved from the database. An empty dict"},{"line_number":47,"context_line":"                           means there is no metadata and it won\u0027t be retrieved"},{"line_number":48,"context_line":"        \"\"\""},{"line_number":49,"context_line":"        if image_meta is None:"},{"line_number":50,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FaSo%3D","line":47,"in_reply_to":"AAAATn%2F%2Famg%3D","updated":"2013-11-06 23:43:14.000000000","message":"Done","commit_id":"fe1a7df107d63abb3fd0a8cf7fed9a8b7926f840"},{"author":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"change_message_id":"3ac7a6bc31f7ee7a0672f9d634419f18ea6795b1","unresolved":false,"context_lines":[{"line_number":59,"context_line":"                    context, resp_volume)"},{"line_number":60,"context_line":"            except Exception:"},{"line_number":61,"context_line":"                return"},{"line_number":62,"context_line":"        if image_meta:"},{"line_number":63,"context_line":"            resp_volume[\u0027volume_image_metadata\u0027] \u003d dict("},{"line_number":64,"context_line":"                image_meta.iteritems())"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2FVAU%3D","line":62,"updated":"2013-11-10 14:26:46.000000000","message":"else?","commit_id":"8dbdc40790452cdbf39fab55c51fc9cc3839113f"},{"author":{"_account_id":7996,"name":"Luis A. Garcia","email":"luis@linux.vnet.ibm.com","username":"luisg"},"change_message_id":"b4a0d4acb18214953d8e65ab9c282157a8410bd9","unresolved":false,"context_lines":[{"line_number":59,"context_line":"                    context, resp_volume)"},{"line_number":60,"context_line":"            except Exception:"},{"line_number":61,"context_line":"                return"},{"line_number":62,"context_line":"        if image_meta:"},{"line_number":63,"context_line":"            resp_volume[\u0027volume_image_metadata\u0027] \u003d dict("},{"line_number":64,"context_line":"                image_meta.iteritems())"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2FSQM%3D","line":62,"in_reply_to":"AAAATn%2F%2FVAU%3D","updated":"2013-11-11 17:38:26.000000000","message":"Hi Avishay, \nThanks for the comment. If there is no metadata (the else case) the field \u0027volume_image_metadata\u0027 field is not added to the volume representation, so there is nothing to do on else.. Just like in the original implementation on the left. Did you have anything in particular you wanted to do in the else clause?\nThank you,","commit_id":"8dbdc40790452cdbf39fab55c51fc9cc3839113f"}]}