)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"dc5677b135be076c382fc809668ec240a9fef570","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     jeremy.zhang \u003czhangjun_inspur@163.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-04-13 19:47:39 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"RBD: fix manage and unmanage snapshot"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The managed RBD snapshot needs to be protected, just as the same with"},{"line_number":10,"context_line":"procedure of creating a new Cinder RBD snapshot, to prevent the snapshot"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bf659307_4ca9aa21","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":37},"updated":"2018-04-13 14:37:43.000000000","message":"This is really not a good title, given that the feature does work.","commit_id":"e5f488203d3af8389815af80e0e6780ea4cc199a"}],"cinder/volume/drivers/rbd.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"2deb43594e4cc47d6cdb33190484bb270da975cd","unresolved":false,"context_lines":[{"line_number":1736,"context_line":""},{"line_number":1737,"context_line":"    def unmanage_snapshot(self, snapshot):"},{"line_number":1738,"context_line":"        \"\"\"Removes the specified snapshot from Cinder management.\"\"\""},{"line_number":1739,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":2,"id":"df7087c5_6008bf2c","line":1739,"updated":"2018-03-20 19:16:45.000000000","message":"Don\u0027t we need to unprotect it in unmanage_snapshot, too?","commit_id":"61ef8addf8fd3edd6dc4fecb33d2a043e1106d6e"},{"author":{"_account_id":23081,"name":"Jeremy Zhang","email":"zhangjun_inspur@163.com","username":"jeremy.zhang"},"change_message_id":"395a5873e6def57828ea56975b27bb7cc167acf4","unresolved":false,"context_lines":[{"line_number":1736,"context_line":""},{"line_number":1737,"context_line":"    def unmanage_snapshot(self, snapshot):"},{"line_number":1738,"context_line":"        \"\"\"Removes the specified snapshot from Cinder management.\"\"\""},{"line_number":1739,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":2,"id":"df7087c5_f1500c61","line":1739,"in_reply_to":"df7087c5_6008bf2c","updated":"2018-03-21 15:10:51.000000000","message":"1. When unmanage snapshot which has no children, it maybe not necessary to unprotect the snapshot.\n2. When unmanage the snapshot that has children (volumes created on the snapshot), it cannot unprotect the snapshot.","commit_id":"61ef8addf8fd3edd6dc4fecb33d2a043e1106d6e"}]}