)]}'
{"cinder/keymgr/migration.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"8893a12d89de1f69655f4ff89c57a931ff98e6a5","unresolved":false,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        for backup in backups:"},{"line_number":117,"context_line":"            try:"},{"line_number":118,"context_line":"                self._migrate_backup_key(backup)"},{"line_number":119,"context_line":"            except Exception as e:"},{"line_number":120,"context_line":"                LOG.error(\"Error migrating encryption key: %s\", e)"},{"line_number":121,"context_line":"                errors +\u003d 1"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf659307_badd26e1","line":118,"range":{"start_line":118,"start_character":21,"end_line":118,"end_character":40},"updated":"2018-04-02 15:06:58.000000000","message":"Since this is the same operation with two different lists, I wonder if we can just make this a generic call. Then we could do something like:\n\nfor migration in zip(volumes, backups):\n    try:\n        self._migration_key(migration)\n    ....\n\n\nThe code is identical other than the name, so I would rather not have the duplication.","commit_id":"b32bad0546e3a8398a35104fb4b525cfcbd373e5"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"ebc9cd4af5fa7102677c28db669aa940acdf1299","unresolved":false,"context_lines":[{"line_number":162,"context_line":"            snapshot.save()"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    def _update_backup_encryption_key_id(self, backup):"},{"line_number":165,"context_line":"        LOG.info(\"Migrating backup %s encryption key to Barbican\", backup.id)"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"        backup.encryption_key_id \u003d self._get_barbican_key_id(backup.user_id)"},{"line_number":168,"context_line":"        backup.save()"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf659307_2fe9c1e4","line":165,"range":{"start_line":165,"start_character":28,"end_line":165,"end_character":34},"updated":"2018-04-03 14:33:20.000000000","message":"I\u0027m still not seeing a difference in these calls other than this log text. I think it would be easy to update this to get the object type from the passed in variable.","commit_id":"fcc4a448bb24344e978d3227ca6366a433834054"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"7946ddc882ebb743bd3925b623c3194df7268a5e","unresolved":false,"context_lines":[{"line_number":162,"context_line":"            snapshot.save()"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    def _update_backup_encryption_key_id(self, backup):"},{"line_number":165,"context_line":"        LOG.info(\"Migrating backup %s encryption key to Barbican\", backup.id)"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"        backup.encryption_key_id \u003d self._get_barbican_key_id(backup.user_id)"},{"line_number":168,"context_line":"        backup.save()"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf659307_80e53ade","line":165,"range":{"start_line":165,"start_character":28,"end_line":165,"end_character":34},"in_reply_to":"bf659307_2fe9c1e4","updated":"2018-04-03 16:20:43.000000000","message":"Yes, and thank you for pressing the point. I stepped back and realized there\u0027s a lot that I can consolidate. I\u0027ll rebase first.","commit_id":"fcc4a448bb24344e978d3227ca6366a433834054"}]}