)]}'
{"cinder/volume/drivers/dell_emc/scaleio/driver.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"a8da52cb0648323d2486723f9cbe9496d659d16b","unresolved":false,"context_lines":[{"line_number":105,"context_line":"    cfg.BoolOpt(\u0027sio_allow_non_padded_thick_volumes\u0027,"},{"line_number":106,"context_line":"                default\u003dFalse,"},{"line_number":107,"context_line":"                help\u003d\u0027Allow thick volumes to be created in Storage Pools \u0027"},{"line_number":108,"context_line":"                     \u0027when zero padding is disabled.\u0027),"},{"line_number":109,"context_line":"]"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"CONF.register_opts(scaleio_opts, group\u003dconfiguration.SHARED_CONF_GROUP)"}],"source_content_type":"text/x-python","patch_set":2,"id":"df7087c5_346cf2ce","line":108,"updated":"2018-03-23 13:58:38.000000000","message":"This should include a note advising that if you have more than one tenant, this should not be used.","commit_id":"4095bfedf67bec7c7def390b4dd1717a1ea3b0a9"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"af52f5fe4269a530f69e3973865a132f973fe37f","unresolved":false,"context_lines":[{"line_number":106,"context_line":"                default\u003dFalse,"},{"line_number":107,"context_line":"                help\u003d\u0027Allow thick volumes to be created in Storage Pools \u0027"},{"line_number":108,"context_line":"                     \u0027when zero padding is disabled. This option should \u0027"},{"line_number":109,"context_line":"                     \u0027not be used if multiple tenants will utilize thick \u0027"},{"line_number":110,"context_line":"                     \u0027volumes from a shared Storage Pool.\u0027),"},{"line_number":111,"context_line":"]"},{"line_number":112,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"df7087c5_117a1b76","line":109,"range":{"start_line":109,"start_character":29,"end_line":109,"end_character":33},"updated":"2018-03-23 15:46:46.000000000","message":"s/used/enabled/","commit_id":"b7e7a82dde5c5cab64b2ae129c63a7ac671eee99"},{"author":{"_account_id":10439,"name":"Xi Yang","email":"yang.xi@99cloud.net","username":"phenom"},"change_message_id":"1b53726eb411b9bf7a069658a6cfaf8a88108809","unresolved":false,"context_lines":[{"line_number":487,"context_line":"                  {\u0027id\u0027: id, \u0027name\u0027: encoded_name})"},{"line_number":488,"context_line":"        return encoded_name"},{"line_number":489,"context_line":""},{"line_number":490,"context_line":"    def _is_volume_creation_safe(self, pd, sp, type):"},{"line_number":491,"context_line":"        \"\"\"Checks if volume creation is safe or not"},{"line_number":492,"context_line":""},{"line_number":493,"context_line":"           using thick volumes with zero padding disabled can lead"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf659307_b6d2cb33","line":490,"updated":"2018-03-26 01:56:48.000000000","message":"I think it is better to use full name of the parameters, like \"protection_domain_name\". And we should avoid using built-in \u0027type\u0027 here..","commit_id":"01ac5c7ebcb2dc5de13a2f938461b29e17895be3"}]}