)]}'
{"cinder/tests/unit/volume/drivers/dell_emc/vmax/test_vmax.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"aeca329943184ceb9f47ec4e5d54f27987ac004f","unresolved":false,"context_lines":[{"line_number":3554,"context_line":"        mock_rm.assert_called_once_with("},{"line_number":3555,"context_line":"            array, volume, device_id, volume_name,"},{"line_number":3556,"context_line":"            extra_specs, True, self.data.connector, async_grp\u003dNone)"},{"line_number":3557,"context_line":"        # Multiattach case"},{"line_number":3558,"context_line":"        mock_rm.reset_mock()"},{"line_number":3559,"context_line":"        self.common._remove_members("},{"line_number":3560,"context_line":"            array, volume, device_id, extra_specs, self.data.connector, True)"}],"source_content_type":"text/x-python","patch_set":6,"id":"bf659307_c0b9f2cb","line":3557,"updated":"2018-04-13 22:00:13.000000000","message":"it would be good to move this case into the separate test","commit_id":"71fd8f541018de5762f4dbb6d637e676739189d3"},{"author":{"_account_id":23414,"name":"Ciara Stacke","email":"ciara.stacke@emc.com","username":"cstacke"},"change_message_id":"fe2b26fe5671e98c53aed9e4c4a90fb9cef99876","unresolved":false,"context_lines":[{"line_number":3554,"context_line":"        mock_rm.assert_called_once_with("},{"line_number":3555,"context_line":"            array, volume, device_id, volume_name,"},{"line_number":3556,"context_line":"            extra_specs, True, self.data.connector, async_grp\u003dNone)"},{"line_number":3557,"context_line":"        # Multiattach case"},{"line_number":3558,"context_line":"        mock_rm.reset_mock()"},{"line_number":3559,"context_line":"        self.common._remove_members("},{"line_number":3560,"context_line":"            array, volume, device_id, extra_specs, self.data.connector, True)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f6a8fd7_c37f99a9","line":3557,"in_reply_to":"bf659307_c0b9f2cb","updated":"2018-04-16 06:54:42.000000000","message":"Sure, can do, thanks Ivan.","commit_id":"71fd8f541018de5762f4dbb6d637e676739189d3"}],"cinder/volume/drivers/dell_emc/vmax/common.py":[{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"e08b7ba51282b05796110c4fef3382c4b8853c92","unresolved":false,"context_lines":[{"line_number":651,"context_line":"        :param volume: the volume object"},{"line_number":652,"context_line":"        :param connector: the connector dict"},{"line_number":653,"context_line":"        :param is_multiattach: flag to indicate if this a multiattach case"},{"line_number":654,"context_line":"        :param rep_extra_specs: replication extra specifications"},{"line_number":655,"context_line":"        :return: hostlunid, remote_port_group"},{"line_number":656,"context_line":"        \"\"\""},{"line_number":657,"context_line":"        remote_mv_dict \u003d self._populate_masking_dict("}],"source_content_type":"text/x-python","patch_set":3,"id":"bf659307_e9a1d347","line":654,"updated":"2018-03-29 13:56:37.000000000","message":"missing :param extra_specs","commit_id":"8b14fa89467a52fc1c555550612cc46c4e321344"},{"author":{"_account_id":23414,"name":"Ciara Stacke","email":"ciara.stacke@emc.com","username":"cstacke"},"change_message_id":"1c2fa18a199847fcccc0062c5027c25eddc3e9d4","unresolved":false,"context_lines":[{"line_number":651,"context_line":"        :param volume: the volume object"},{"line_number":652,"context_line":"        :param connector: the connector dict"},{"line_number":653,"context_line":"        :param is_multiattach: flag to indicate if this a multiattach case"},{"line_number":654,"context_line":"        :param rep_extra_specs: replication extra specifications"},{"line_number":655,"context_line":"        :return: hostlunid, remote_port_group"},{"line_number":656,"context_line":"        \"\"\""},{"line_number":657,"context_line":"        remote_mv_dict \u003d self._populate_masking_dict("}],"source_content_type":"text/x-python","patch_set":3,"id":"bf659307_2f8b4b6e","line":654,"in_reply_to":"bf659307_e9a1d347","updated":"2018-03-29 14:20:18.000000000","message":"Thanks, I\u0027ll fix this","commit_id":"8b14fa89467a52fc1c555550612cc46c4e321344"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"e08b7ba51282b05796110c4fef3382c4b8853c92","unresolved":false,"context_lines":[{"line_number":698,"context_line":"        if \u0027hostlunid\u0027 not in device_info_dict:"},{"line_number":699,"context_line":"            # Did not successfully attach to host, so a rollback is required."},{"line_number":700,"context_line":"            error_message \u003d (_(\"Error Attaching volume %(vol)s. Cannot \""},{"line_number":701,"context_line":"                               \"retrieve hostlunid. \") % {\u0027vol\u0027: volume_name})"},{"line_number":702,"context_line":"            LOG.error(error_message)"},{"line_number":703,"context_line":"            self.masking.check_if_rollback_action_for_masking_required("},{"line_number":704,"context_line":"                masking_view_dict[utils.ARRAY], volume,"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf659307_296a6bed","line":701,"range":{"start_line":701,"start_character":51,"end_line":701,"end_character":52},"updated":"2018-03-29 13:56:37.000000000","message":"nit - space unnecessary","commit_id":"8b14fa89467a52fc1c555550612cc46c4e321344"},{"author":{"_account_id":23414,"name":"Ciara Stacke","email":"ciara.stacke@emc.com","username":"cstacke"},"change_message_id":"1c2fa18a199847fcccc0062c5027c25eddc3e9d4","unresolved":false,"context_lines":[{"line_number":698,"context_line":"        if \u0027hostlunid\u0027 not in device_info_dict:"},{"line_number":699,"context_line":"            # Did not successfully attach to host, so a rollback is required."},{"line_number":700,"context_line":"            error_message \u003d (_(\"Error Attaching volume %(vol)s. Cannot \""},{"line_number":701,"context_line":"                               \"retrieve hostlunid. \") % {\u0027vol\u0027: volume_name})"},{"line_number":702,"context_line":"            LOG.error(error_message)"},{"line_number":703,"context_line":"            self.masking.check_if_rollback_action_for_masking_required("},{"line_number":704,"context_line":"                masking_view_dict[utils.ARRAY], volume,"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf659307_af967b92","line":701,"range":{"start_line":701,"start_character":51,"end_line":701,"end_character":52},"in_reply_to":"bf659307_296a6bed","updated":"2018-03-29 14:20:18.000000000","message":"Sure, I\u0027ll remove this.","commit_id":"8b14fa89467a52fc1c555550612cc46c4e321344"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"e08b7ba51282b05796110c4fef3382c4b8853c92","unresolved":false,"context_lines":[{"line_number":1026,"context_line":"        host_name \u003d self.utils.get_host_short_name(host) if host else None"},{"line_number":1027,"context_line":"        if device_id:"},{"line_number":1028,"context_line":"            array \u003d extra_specs[utils.ARRAY]"},{"line_number":1029,"context_line":"            # return only masking views for this host"},{"line_number":1030,"context_line":"            host_maskingviews, all_masking_view_list \u003d ("},{"line_number":1031,"context_line":"                self._get_masking_views_from_volume("},{"line_number":1032,"context_line":"                    array, device_id, host_name))"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf659307_a9751bcd","line":1029,"range":{"start_line":1029,"start_character":14,"end_line":1029,"end_character":15},"updated":"2018-03-29 13:56:37.000000000","message":"nit - r/R","commit_id":"8b14fa89467a52fc1c555550612cc46c4e321344"},{"author":{"_account_id":23414,"name":"Ciara Stacke","email":"ciara.stacke@emc.com","username":"cstacke"},"change_message_id":"1c2fa18a199847fcccc0062c5027c25eddc3e9d4","unresolved":false,"context_lines":[{"line_number":1026,"context_line":"        host_name \u003d self.utils.get_host_short_name(host) if host else None"},{"line_number":1027,"context_line":"        if device_id:"},{"line_number":1028,"context_line":"            array \u003d extra_specs[utils.ARRAY]"},{"line_number":1029,"context_line":"            # return only masking views for this host"},{"line_number":1030,"context_line":"            host_maskingviews, all_masking_view_list \u003d ("},{"line_number":1031,"context_line":"                self._get_masking_views_from_volume("},{"line_number":1032,"context_line":"                    array, device_id, host_name))"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf659307_0febe712","line":1029,"range":{"start_line":1029,"start_character":14,"end_line":1029,"end_character":15},"in_reply_to":"bf659307_a9751bcd","updated":"2018-03-29 14:20:18.000000000","message":"Sure, I can change this","commit_id":"8b14fa89467a52fc1c555550612cc46c4e321344"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"e08b7ba51282b05796110c4fef3382c4b8853c92","unresolved":false,"context_lines":[{"line_number":1082,"context_line":"        \"\"\""},{"line_number":1083,"context_line":"        is_metro \u003d False"},{"line_number":1084,"context_line":"        extra_specs \u003d self._initial_setup(volume)"},{"line_number":1085,"context_line":"        mv_list, _ \u003d self._get_masking_views_from_volume(array, device_id,"},{"line_number":1086,"context_line":"                                                         host)"},{"line_number":1087,"context_line":"        if self.utils.is_metro_device(self.rep_config, extra_specs):"},{"line_number":1088,"context_line":"            is_metro \u003d True"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf659307_b4f7aed3","line":1085,"range":{"start_line":1085,"start_character":17,"end_line":1085,"end_character":18},"updated":"2018-03-29 13:56:37.000000000","message":"as __ is being used elsewhere please change _/__","commit_id":"8b14fa89467a52fc1c555550612cc46c4e321344"},{"author":{"_account_id":23414,"name":"Ciara Stacke","email":"ciara.stacke@emc.com","username":"cstacke"},"change_message_id":"1c2fa18a199847fcccc0062c5027c25eddc3e9d4","unresolved":false,"context_lines":[{"line_number":1082,"context_line":"        \"\"\""},{"line_number":1083,"context_line":"        is_metro \u003d False"},{"line_number":1084,"context_line":"        extra_specs \u003d self._initial_setup(volume)"},{"line_number":1085,"context_line":"        mv_list, _ \u003d self._get_masking_views_from_volume(array, device_id,"},{"line_number":1086,"context_line":"                                                         host)"},{"line_number":1087,"context_line":"        if self.utils.is_metro_device(self.rep_config, extra_specs):"},{"line_number":1088,"context_line":"            is_metro \u003d True"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf659307_8fde176b","line":1085,"range":{"start_line":1085,"start_character":17,"end_line":1085,"end_character":18},"in_reply_to":"bf659307_b4f7aed3","updated":"2018-03-29 14:20:18.000000000","message":"No problem, I\u0027ll change this","commit_id":"8b14fa89467a52fc1c555550612cc46c4e321344"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"e08b7ba51282b05796110c4fef3382c4b8853c92","unresolved":false,"context_lines":[{"line_number":1655,"context_line":"        \"\"\""},{"line_number":1656,"context_line":"        target_wwns \u003d []"},{"line_number":1657,"context_line":"        array \u003d extra_specs[utils.ARRAY]"},{"line_number":1658,"context_line":"        masking_view_list, _ \u003d self._get_masking_views_from_volume("},{"line_number":1659,"context_line":"            array, device_id, short_host_name)"},{"line_number":1660,"context_line":"        if masking_view_list:"},{"line_number":1661,"context_line":"            portgroup \u003d self.get_port_group_from_masking_view("}],"source_content_type":"text/x-python","patch_set":3,"id":"bf659307_b4200e4a","line":1658,"range":{"start_line":1658,"start_character":27,"end_line":1658,"end_character":28},"updated":"2018-03-29 13:56:37.000000000","message":"as above","commit_id":"8b14fa89467a52fc1c555550612cc46c4e321344"},{"author":{"_account_id":23414,"name":"Ciara Stacke","email":"ciara.stacke@emc.com","username":"cstacke"},"change_message_id":"1c2fa18a199847fcccc0062c5027c25eddc3e9d4","unresolved":false,"context_lines":[{"line_number":1655,"context_line":"        \"\"\""},{"line_number":1656,"context_line":"        target_wwns \u003d []"},{"line_number":1657,"context_line":"        array \u003d extra_specs[utils.ARRAY]"},{"line_number":1658,"context_line":"        masking_view_list, _ \u003d self._get_masking_views_from_volume("},{"line_number":1659,"context_line":"            array, device_id, short_host_name)"},{"line_number":1660,"context_line":"        if masking_view_list:"},{"line_number":1661,"context_line":"            portgroup \u003d self.get_port_group_from_masking_view("}],"source_content_type":"text/x-python","patch_set":3,"id":"bf659307_4fe47f3c","line":1658,"range":{"start_line":1658,"start_character":27,"end_line":1658,"end_character":28},"in_reply_to":"bf659307_b4200e4a","updated":"2018-03-29 14:20:18.000000000","message":"Sure","commit_id":"8b14fa89467a52fc1c555550612cc46c4e321344"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"e08b7ba51282b05796110c4fef3382c4b8853c92","unresolved":false,"context_lines":[{"line_number":2219,"context_line":"            LOG.debug("},{"line_number":2220,"context_line":"                \"Retype Volume %(name)s from source host %(sourceHost)s \""},{"line_number":2221,"context_line":"                \"to target host %(targetHost)s. Compression change is %(cc)r. \""},{"line_number":2222,"context_line":"                \"Replication change is %(rc)s\","},{"line_number":2223,"context_line":"                {\u0027name\u0027: volume_name, \u0027sourceHost\u0027: volume.host,"},{"line_number":2224,"context_line":"                 \u0027targetHost\u0027: host[\u0027host\u0027],"},{"line_number":2225,"context_line":"                 \u0027cc\u0027: do_change_compression, \u0027rc\u0027: do_change_replication})"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf659307_49055f13","line":2222,"updated":"2018-03-29 13:56:37.000000000","message":"full stop.","commit_id":"8b14fa89467a52fc1c555550612cc46c4e321344"},{"author":{"_account_id":23414,"name":"Ciara Stacke","email":"ciara.stacke@emc.com","username":"cstacke"},"change_message_id":"1c2fa18a199847fcccc0062c5027c25eddc3e9d4","unresolved":false,"context_lines":[{"line_number":2219,"context_line":"            LOG.debug("},{"line_number":2220,"context_line":"                \"Retype Volume %(name)s from source host %(sourceHost)s \""},{"line_number":2221,"context_line":"                \"to target host %(targetHost)s. Compression change is %(cc)r. \""},{"line_number":2222,"context_line":"                \"Replication change is %(rc)s\","},{"line_number":2223,"context_line":"                {\u0027name\u0027: volume_name, \u0027sourceHost\u0027: volume.host,"},{"line_number":2224,"context_line":"                 \u0027targetHost\u0027: host[\u0027host\u0027],"},{"line_number":2225,"context_line":"                 \u0027cc\u0027: do_change_compression, \u0027rc\u0027: do_change_replication})"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf659307_6fe1432a","line":2222,"in_reply_to":"bf659307_49055f13","updated":"2018-03-29 14:20:18.000000000","message":"Sure I can change this","commit_id":"8b14fa89467a52fc1c555550612cc46c4e321344"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"9f7ff574a74b02f65511f002e8439238d56300c6","unresolved":false,"context_lines":[{"line_number":485,"context_line":"        if connector is not None:"},{"line_number":486,"context_line":"            host \u003d connector[\u0027host\u0027]"},{"line_number":487,"context_line":"            attachment_list \u003d volume.volume_attachment"},{"line_number":488,"context_line":"            LOG.debug(\"Volume attachment list: %(atl)s.\""},{"line_number":489,"context_line":"                      \"Attachment type: %(at)s\","},{"line_number":490,"context_line":"                      {\u0027atl\u0027: attachment_list, \u0027at\u0027: type(attachment_list)})"},{"line_number":491,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f7c97a3_e39cac5e","line":488,"range":{"start_line":488,"start_character":55,"end_line":488,"end_character":56},"updated":"2018-05-09 17:24:10.000000000","message":"Missing space on the end.","commit_id":"f901090603f1d8b68d1e603697917e87b403196e"},{"author":{"_account_id":23414,"name":"Ciara Stacke","email":"ciara.stacke@emc.com","username":"cstacke"},"change_message_id":"36ca980f2242a6d7419a262e72fd0ff5c589841f","unresolved":false,"context_lines":[{"line_number":485,"context_line":"        if connector is not None:"},{"line_number":486,"context_line":"            host \u003d connector[\u0027host\u0027]"},{"line_number":487,"context_line":"            attachment_list \u003d volume.volume_attachment"},{"line_number":488,"context_line":"            LOG.debug(\"Volume attachment list: %(atl)s.\""},{"line_number":489,"context_line":"                      \"Attachment type: %(at)s\","},{"line_number":490,"context_line":"                      {\u0027atl\u0027: attachment_list, \u0027at\u0027: type(attachment_list)})"},{"line_number":491,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f7c97a3_02ed6f24","line":488,"range":{"start_line":488,"start_character":55,"end_line":488,"end_character":56},"in_reply_to":"5f7c97a3_e39cac5e","updated":"2018-05-18 09:24:18.000000000","message":"Thanks Sean, I\u0027ll change this.","commit_id":"f901090603f1d8b68d1e603697917e87b403196e"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"485a69d142ac0e92909c4d329b47e4ad635682ae","unresolved":false,"context_lines":[{"line_number":583,"context_line":"        masking_view_dict \u003d self._populate_masking_dict("},{"line_number":584,"context_line":"            volume, connector, extra_specs)"},{"line_number":585,"context_line":"        masking_view_dict[utils.IS_MULTIATTACH] \u003d ("},{"line_number":586,"context_line":"            True if is_multiattach else False)"},{"line_number":587,"context_line":""},{"line_number":588,"context_line":"        if (\u0027hostlunid\u0027 in device_info_dict and"},{"line_number":589,"context_line":"                device_info_dict[\u0027hostlunid\u0027] is not None):"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f7c97a3_0201fdaf","line":586,"updated":"2018-05-17 18:34:26.000000000","message":"You can just set \"\u003d is_multiattach\" here.","commit_id":"f901090603f1d8b68d1e603697917e87b403196e"},{"author":{"_account_id":23414,"name":"Ciara Stacke","email":"ciara.stacke@emc.com","username":"cstacke"},"change_message_id":"897c2556c82343ed2ec07236540cf8c5a3be884e","unresolved":false,"context_lines":[{"line_number":583,"context_line":"        masking_view_dict \u003d self._populate_masking_dict("},{"line_number":584,"context_line":"            volume, connector, extra_specs)"},{"line_number":585,"context_line":"        masking_view_dict[utils.IS_MULTIATTACH] \u003d ("},{"line_number":586,"context_line":"            True if is_multiattach else False)"},{"line_number":587,"context_line":""},{"line_number":588,"context_line":"        if (\u0027hostlunid\u0027 in device_info_dict and"},{"line_number":589,"context_line":"                device_info_dict[\u0027hostlunid\u0027] is not None):"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f7c97a3_c273f7b0","line":586,"in_reply_to":"5f7c97a3_0201fdaf","updated":"2018-05-18 09:19:42.000000000","message":"Thanks Eric, I\u0027ll update this.","commit_id":"f901090603f1d8b68d1e603697917e87b403196e"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"3d3de66214031bed3fdcd867888b5b336595236c","unresolved":false,"context_lines":[{"line_number":699,"context_line":"        if \u0027hostlunid\u0027 not in device_info_dict:"},{"line_number":700,"context_line":"            # Did not successfully attach to host, so a rollback is required."},{"line_number":701,"context_line":"            error_message \u003d (_(\"Error Attaching volume %(vol)s. Cannot \""},{"line_number":702,"context_line":"                               \"retrieve hostlunid.\") % {\u0027vol\u0027: volume_name})"},{"line_number":703,"context_line":"            LOG.error(error_message)"},{"line_number":704,"context_line":"            self.masking.check_if_rollback_action_for_masking_required("},{"line_number":705,"context_line":"                masking_view_dict[utils.ARRAY], volume,"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f7c97a3_a40b077b","line":702,"updated":"2018-05-10 14:19:30.000000000","message":"Is it backend volume name? If now, we should use volume ID instead of it.","commit_id":"f901090603f1d8b68d1e603697917e87b403196e"},{"author":{"_account_id":23414,"name":"Ciara Stacke","email":"ciara.stacke@emc.com","username":"cstacke"},"change_message_id":"ead293e38f5ea3da8019309e323855d5a56de8a1","unresolved":false,"context_lines":[{"line_number":699,"context_line":"        if \u0027hostlunid\u0027 not in device_info_dict:"},{"line_number":700,"context_line":"            # Did not successfully attach to host, so a rollback is required."},{"line_number":701,"context_line":"            error_message \u003d (_(\"Error Attaching volume %(vol)s. Cannot \""},{"line_number":702,"context_line":"                               \"retrieve hostlunid.\") % {\u0027vol\u0027: volume_name})"},{"line_number":703,"context_line":"            LOG.error(error_message)"},{"line_number":704,"context_line":"            self.masking.check_if_rollback_action_for_masking_required("},{"line_number":705,"context_line":"                masking_view_dict[utils.ARRAY], volume,"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f7c97a3_c2c953ac","line":702,"in_reply_to":"5f7c97a3_a40b077b","updated":"2018-05-10 15:09:57.000000000","message":"No it isn\u0027t backend volume name, it is the cinder volume name (so {prefix}-UUID, e.g. \u0027volume-\u003cuuid\u003e\u0027)","commit_id":"f901090603f1d8b68d1e603697917e87b403196e"},{"author":{"_account_id":23414,"name":"Ciara Stacke","email":"ciara.stacke@emc.com","username":"cstacke"},"change_message_id":"36ca980f2242a6d7419a262e72fd0ff5c589841f","unresolved":false,"context_lines":[{"line_number":699,"context_line":"        if \u0027hostlunid\u0027 not in device_info_dict:"},{"line_number":700,"context_line":"            # Did not successfully attach to host, so a rollback is required."},{"line_number":701,"context_line":"            error_message \u003d (_(\"Error Attaching volume %(vol)s. Cannot \""},{"line_number":702,"context_line":"                               \"retrieve hostlunid.\") % {\u0027vol\u0027: volume_name})"},{"line_number":703,"context_line":"            LOG.error(error_message)"},{"line_number":704,"context_line":"            self.masking.check_if_rollback_action_for_masking_required("},{"line_number":705,"context_line":"                masking_view_dict[utils.ARRAY], volume,"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f7c97a3_428da779","line":702,"in_reply_to":"5f7c97a3_c2c953ac","updated":"2018-05-18 09:24:18.000000000","message":"I\u0027ll change this to \u0027volume.id\u0027","commit_id":"f901090603f1d8b68d1e603697917e87b403196e"}],"cinder/volume/drivers/dell_emc/vmax/masking.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"9ea9a9df7cbf227260f9bbf603aea8771571251e","unresolved":false,"context_lines":[{"line_number":1035,"context_line":"            elif connector is not None:"},{"line_number":1036,"context_line":"                short_host_name \u003d self.utils.get_host_short_name("},{"line_number":1037,"context_line":"                    connector[\u0027host\u0027])"},{"line_number":1038,"context_line":"                move \u003d True if reset is True else False"},{"line_number":1039,"context_line":"            if short_host_name:"},{"line_number":1040,"context_line":"                for sg_name in storagegroup_names:"},{"line_number":1041,"context_line":"                    if short_host_name in sg_name:"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf659307_5d5e9912","line":1038,"range":{"start_line":1038,"start_character":23,"end_line":1038,"end_character":55},"updated":"2018-04-10 14:51:09.000000000","message":"Shouldn\u0027t this be:\n\nmove \u003d reset","commit_id":"9aa8c909552f4a6fbe78430bed90d726fbea182e"},{"author":{"_account_id":23414,"name":"Ciara Stacke","email":"ciara.stacke@emc.com","username":"cstacke"},"change_message_id":"db7e72669028d0992a0641708c54f5a401286069","unresolved":false,"context_lines":[{"line_number":1035,"context_line":"            elif connector is not None:"},{"line_number":1036,"context_line":"                short_host_name \u003d self.utils.get_host_short_name("},{"line_number":1037,"context_line":"                    connector[\u0027host\u0027])"},{"line_number":1038,"context_line":"                move \u003d True if reset is True else False"},{"line_number":1039,"context_line":"            if short_host_name:"},{"line_number":1040,"context_line":"                for sg_name in storagegroup_names:"},{"line_number":1041,"context_line":"                    if short_host_name in sg_name:"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf659307_7dcb5d52","line":1038,"range":{"start_line":1038,"start_character":23,"end_line":1038,"end_character":55},"in_reply_to":"bf659307_5d5e9912","updated":"2018-04-10 15:01:06.000000000","message":"Yes that would make much more sense! Thanks Sean.","commit_id":"9aa8c909552f4a6fbe78430bed90d726fbea182e"}]}