)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"8b207114812e0ce9367c6ee826cfec0dc2d9c8d2","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Instead of manually managing periodic tasks, use"},{"line_number":10,"context_line":"oslo.service\u0027s threadgroup to make it easier to"},{"line_number":11,"context_line":"stop them."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"[1]: https://docs.openstack.org/oslo.service/latest/reference/threadgroup.html"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bf659307_5b629eaf","line":11,"updated":"2018-04-04 10:11:28.000000000","message":"?: Is this somehow related to LP bug 1759988?","commit_id":"9ab4f87078e0927a79bced17f16816c4418af4d7"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"b175cf3441de69855143ae947275a222b4bb2b20","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Instead of manually managing periodic tasks, use"},{"line_number":10,"context_line":"oslo.service\u0027s threadgroup to make it easier to"},{"line_number":11,"context_line":"stop them."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"[1]: https://docs.openstack.org/oslo.service/latest/reference/threadgroup.html"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bf659307_32cbf6a5","line":11,"updated":"2018-04-09 11:13:14.000000000","message":"?: Is this somehow related to LP bug 1759988?","commit_id":"02bc11f00049bafc259b1fdacf25098690a4814a"}],"cinder/service.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"8b207114812e0ce9367c6ee826cfec0dc2d9c8d2","unresolved":false,"context_lines":[{"line_number":397,"context_line":"        # Try to shut the connection down, but if we get any sort of"},{"line_number":398,"context_line":"        # errors, go ahead and ignore them.. as we\u0027re shutting down anyway"},{"line_number":399,"context_line":"        try:"},{"line_number":400,"context_line":"            if self.rpcserver:"},{"line_number":401,"context_line":"                self.rpcserver.stop()"},{"line_number":402,"context_line":"                self.rpcserver.wait()"},{"line_number":403,"context_line":"            if self.backend_rpcserver:"},{"line_number":404,"context_line":"                self.backend_rpcserver.stop()"},{"line_number":405,"context_line":"                self.backend_rpcserver.wait()"},{"line_number":406,"context_line":"            if self.cluster_rpcserver:"},{"line_number":407,"context_line":"                self.cluster_rpcserver.stop()"},{"line_number":408,"context_line":"                self.cluster_rpcserver.wait()"},{"line_number":409,"context_line":"        except Exception:"},{"line_number":410,"context_line":"            pass"},{"line_number":411,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_1bcae69f","line":408,"range":{"start_line":400,"start_character":0,"end_line":408,"end_character":45},"updated":"2018-04-04 10:11:28.000000000","message":"-1: We should stop all RPC servers first and then wait for them all, otherwise it will not only take longer but you will also keep receiving RPC requests while waiting for the other RPC serves to stop.","commit_id":"9ab4f87078e0927a79bced17f16816c4418af4d7"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"b175cf3441de69855143ae947275a222b4bb2b20","unresolved":false,"context_lines":[{"line_number":403,"context_line":"                self.backend_rpcserver.stop()"},{"line_number":404,"context_line":"            if self.cluster_rpcserver:"},{"line_number":405,"context_line":"                self.cluster_rpcserver.stop()"},{"line_number":406,"context_line":"            if self.rpcserver:"},{"line_number":407,"context_line":"                self.rpcserver.wait()"},{"line_number":408,"context_line":"            if self.backend_rpcserver:"},{"line_number":409,"context_line":"                self.backend_rpcserver.wait()"},{"line_number":410,"context_line":"            if self.cluster_rpcserver:"},{"line_number":411,"context_line":"                self.cluster_rpcserver.wait()"},{"line_number":412,"context_line":"        except Exception:"},{"line_number":413,"context_line":"            pass"},{"line_number":414,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bf659307_32f21608","line":411,"range":{"start_line":406,"start_character":0,"end_line":411,"end_character":45},"updated":"2018-04-09 11:13:14.000000000","message":"-1: We should not wait in the stop method, we should do it in the wait method as we were doing before.  As that\u0027s what\u0027s oslo.service is expecting us to do.","commit_id":"02bc11f00049bafc259b1fdacf25098690a4814a"}]}