)]}'
{"cinder/api/contrib/quotas.py":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"5c409d6deaacb1c2cc06f430be490c2a48934cb7","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        project_id \u003d id"},{"line_number":99,"context_line":"        if not self.is_valid_body(body, \u0027quota_set\u0027):"},{"line_number":100,"context_line":"            msg \u003d (_(\"Missing required element \u0027%s\u0027 in request body\") %"},{"line_number":101,"context_line":"                   \u0027quota_set\u0027)"},{"line_number":102,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        for key in body[\u0027quota_set\u0027].keys():"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2FSkk%3D","line":101,"updated":"2013-11-11 15:52:25.000000000","message":"Since quota_set is the only element that could come out of this message I would recommend just putting it into the message instead of as a parameter.  Also recommend ending with a \u0027.\u0027 as this is a sentence.","commit_id":"bd39321c727c54c3fa13586fa9c69f4be7a8acf1"},{"author":{"_account_id":5538,"name":"Rushi Agrawal","email":"rushi.openstack@gmail.com","username":"rushiagr"},"change_message_id":"443d943b8b730b1e981489b3179c43b505241fe8","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        context \u003d req.environ[\u0027cinder.context\u0027]"},{"line_number":97,"context_line":"        authorize_update(context)"},{"line_number":98,"context_line":"        project_id \u003d id"},{"line_number":99,"context_line":"        if not self.is_valid_body(body, \u0027quota_set\u0027):"},{"line_number":100,"context_line":"            msg \u003d (_(\"Missing required element quota_set in request body\"))"},{"line_number":101,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":102,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2FPXI%3D","line":99,"updated":"2013-11-12 12:35:19.000000000","message":"isnt this a better and clearer choice:\n\n if \u0027quota_set\u0027 not in body.keys()\n\nI might be wrong though. Also, doesn\u0027t warrant inheriting the class from wsgi.controller.","commit_id":"3be9106a0e7ab509b8b914611f6c8e92fc7f7d49"},{"author":{"_account_id":8874,"name":"ling-yun","email":"YunlingZeng@hotmail.com","username":"ling-yun"},"change_message_id":"ed551f15cb0a38476d861559669145d8399559fd","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        context \u003d req.environ[\u0027cinder.context\u0027]"},{"line_number":97,"context_line":"        authorize_update(context)"},{"line_number":98,"context_line":"        project_id \u003d id"},{"line_number":99,"context_line":"        if not self.is_valid_body(body, \u0027quota_set\u0027):"},{"line_number":100,"context_line":"            msg \u003d (_(\"Missing required element quota_set in request body\"))"},{"line_number":101,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":102,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2FMxg%3D","line":99,"in_reply_to":"AAAATn%2F%2FPXI%3D","updated":"2013-11-13 01:52:12.000000000","message":"Almost all cinder api controller inherit from wsgi.controller, but quota api controller directly inherit from object, so I think it needed to inherit from wsgi controller.","commit_id":"3be9106a0e7ab509b8b914611f6c8e92fc7f7d49"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"096864c09253b07754b8beb8102ae3f7c450ecdb","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        authorize_update(context)"},{"line_number":98,"context_line":"        project_id \u003d id"},{"line_number":99,"context_line":"        if not self.is_valid_body(body, \u0027quota_set\u0027):"},{"line_number":100,"context_line":"            msg \u003d (_(\"Missing required element quota_set in request body\"))"},{"line_number":101,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        for key in body[\u0027quota_set\u0027].keys():"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2FNAQ%3D","line":100,"updated":"2013-11-12 23:46:12.000000000","message":"This still needs to end with a period.  \n\nAlso agree with Rushi\u0027s comment unless is_valid_body needs to be used for some reason.","commit_id":"3be9106a0e7ab509b8b914611f6c8e92fc7f7d49"},{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"e635e2e181565ecfef09130bc3db2b268a0969b0","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        authorize_update(context)"},{"line_number":98,"context_line":"        project_id \u003d id"},{"line_number":99,"context_line":"        if not self.is_valid_body(body, \u0027quota_set\u0027):"},{"line_number":100,"context_line":"            msg \u003d (_(\"Missing required element quota_set in request body\"))"},{"line_number":101,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        for key in body[\u0027quota_set\u0027].keys():"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2FMAw%3D","line":100,"in_reply_to":"AAAATn%2F%2FMxc%3D","updated":"2013-11-13 07:16:05.000000000","message":"Please address Jay\u0027s comment about missing period at the end of the message.","commit_id":"3be9106a0e7ab509b8b914611f6c8e92fc7f7d49"},{"author":{"_account_id":8874,"name":"ling-yun","email":"YunlingZeng@hotmail.com","username":"ling-yun"},"change_message_id":"ed551f15cb0a38476d861559669145d8399559fd","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        authorize_update(context)"},{"line_number":98,"context_line":"        project_id \u003d id"},{"line_number":99,"context_line":"        if not self.is_valid_body(body, \u0027quota_set\u0027):"},{"line_number":100,"context_line":"            msg \u003d (_(\"Missing required element quota_set in request body\"))"},{"line_number":101,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        for key in body[\u0027quota_set\u0027].keys():"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2FMxc%3D","line":100,"in_reply_to":"AAAATn%2F%2FNAQ%3D","updated":"2013-11-13 01:52:12.000000000","message":"Almost all cinder api controller inherit from wsgi.controller, but quota api controller directly inherit from object, so I think it needed to inherit from wsgi controller.","commit_id":"3be9106a0e7ab509b8b914611f6c8e92fc7f7d49"}]}