)]}'
{"id":"openstack%2Fcinder~56083","triplet_id":"openstack%2Fcinder~stable%2Fgrizzly~Ie6764209018152565295291efc6fbba553698ae6","project":"openstack/cinder","branch":"stable/grizzly","topic":"bug/1240299","hashtags":[],"change_id":"Ie6764209018152565295291efc6fbba553698ae6","subject":"Don\u0027t zero out thin provisioned LV\u0027s on delete","status":"MERGED","created":"2013-11-12 19:40:59.000000000","updated":"2013-11-13 02:47:20.000000000","submitted":"2013-11-13 02:47:20.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"020b0a7ceda83d2d724720224f528bfda6834844","_number":56083,"virtual_id_number":56083,"owner":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},{"value":0,"_account_id":1955,"name":"Alan Pevec","email":"alan.pevec@redhat.com","username":"apevec"},{"value":0,"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"value":2,"date":"2013-11-13 02:47:20.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"all":[{"value":2,"date":"2013-11-12 23:03:13.000000000","_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},{"value":2,"date":"2013-11-12 21:21:38.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1955,"name":"Alan Pevec","email":"alan.pevec@redhat.com","username":"apevec"},{"value":2,"date":"2013-11-13 02:10:55.000000000","_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"all":[{"value":0,"date":"2013-11-12 23:03:13.000000000","_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},{"value":0,"date":"2013-11-12 21:21:38.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":1955,"name":"Alan Pevec","email":"alan.pevec@redhat.com","username":"apevec"},{"value":1,"date":"2013-11-13 02:10:55.000000000","_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},{"value":0,"_account_id":1955,"name":"Alan Pevec","email":"alan.pevec@redhat.com","username":"apevec"},{"value":0,"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},{"_account_id":1955,"name":"Alan Pevec","email":"alan.pevec@redhat.com","username":"apevec"},{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-11-12 21:21:38.000000000","updated_by":{"_account_id":1955,"name":"Alan Pevec","email":"alan.pevec@redhat.com","username":"apevec"},"reviewer":{"_account_id":1955,"name":"Alan Pevec","email":"alan.pevec@redhat.com","username":"apevec"},"state":"REVIEWER"},{"updated":"2013-11-12 23:03:13.000000000","updated_by":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"reviewer":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"state":"REVIEWER"},{"updated":"2013-11-13 02:10:55.000000000","updated_by":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"reviewer":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"state":"REVIEWER"},{"updated":"2013-11-13 02:47:20.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"98b0f3f682c8cb9247b9085febacf277150ebe27","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-11-12 20:17:43.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- gate-cinder-pep8 http://logs.openstack.org/83/56083/1/check/gate-cinder-pep8/b7ed9f8 : SUCCESS in 2m 00s\n- gate-cinder-docs http://docs-draft.openstack.org/83/56083/1/check/gate-cinder-docs/c7b92c3/doc/build/html/ : SUCCESS in 5m 11s\n- gate-cinder-python26 http://logs.openstack.org/83/56083/1/check/gate-cinder-python26/162f10f : SUCCESS in 3m 16s\n- gate-cinder-python27 http://logs.openstack.org/83/56083/1/check/gate-cinder-python27/3c3caec : SUCCESS in 2m 32s\n- check-tempest-devstack-vm-full http://logs.openstack.org/83/56083/1/check/check-tempest-devstack-vm-full/fbef8ea : SUCCESS in 34m 06s\n- check-tempest-devstack-vm-postgres-full http://logs.openstack.org/83/56083/1/check/check-tempest-devstack-vm-postgres-full/a3ac481 : SUCCESS in 36m 38s\n- check-tempest-devstack-vm-neutron http://logs.openstack.org/83/56083/1/check/check-tempest-devstack-vm-neutron/9089f57 : SUCCESS in 16m 06s\n","accounts_in_message":[],"_revision_number":1},{"id":"d990da065853c076b7e3e87fa75ba0a8c5f1a42b","author":{"_account_id":1955,"name":"Alan Pevec","email":"alan.pevec@redhat.com","username":"apevec"},"date":"2013-11-12 21:21:38.000000000","message":"Patch Set 1: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"b98a2dfa8d05ae6c98ff5d1c2a7f371a997b2875","author":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"date":"2013-11-12 23:03:13.000000000","message":"Patch Set 1: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"f72601c93bb79357f187e9b4aec138175b47d901","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-11-13 02:10:55.000000000","message":"Patch Set 1: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"94afa3a605ef2ec036e654b9f60a1cf78d6e8a39","author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"date":"2013-11-13 02:10:55.000000000","message":"Patch Set 1: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":1},{"id":"a43c7db057752071be3f1ad9e824601395e91f1a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-11-13 02:47:20.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1},{"id":"23e73fd7ee0c2536ea1454d4fc46badcb164260c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-11-13 02:47:20.000000000","message":"Patch Set 1: Verified\n\nBuild succeeded.\n\n- gate-cinder-docs http://docs-draft.openstack.org/83/56083/1/gate/gate-cinder-docs/122e45b/doc/build/html/ : SUCCESS in 4m 55s\n- gate-cinder-pep8 http://logs.openstack.org/83/56083/1/gate/gate-cinder-pep8/7c8d87f : SUCCESS in 2m 06s\n- gate-cinder-python26 http://logs.openstack.org/83/56083/1/gate/gate-cinder-python26/15ca505 : SUCCESS in 4m 05s\n- gate-cinder-python27 http://logs.openstack.org/83/56083/1/gate/gate-cinder-python27/2b21e98 : SUCCESS in 2m 28s\n- gate-tempest-devstack-vm-full http://logs.openstack.org/83/56083/1/gate/gate-tempest-devstack-vm-full/a3b9fa0 : SUCCESS in 36m 18s\n- gate-tempest-devstack-vm-postgres-full http://logs.openstack.org/83/56083/1/gate/gate-tempest-devstack-vm-postgres-full/240dd25 : SUCCESS in 31m 11s\n- gate-tempest-devstack-vm-neutron http://logs.openstack.org/83/56083/1/gate/gate-tempest-devstack-vm-neutron/d140706 : SUCCESS in 15m 00s\n","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"c9c9eaac573b65df671aab5c0f9ab4411557b926","revisions":{"c9c9eaac573b65df671aab5c0f9ab4411557b926":{"kind":"REWORK","_number":1,"created":"2013-11-12 19:40:59.000000000","uploader":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"ref":"refs/changes/83/56083/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cinder","ref":"refs/changes/83/56083/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cinder refs/changes/83/56083/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cinder refs/changes/83/56083/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cinder refs/changes/83/56083/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cinder refs/changes/83/56083/1"}}},"commit":{"parents":[{"commit":"64878632a0602879a59e4166232ef389cd6d0a60","subject":"Clear correct device when deleting a ThinLVM snap","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder/commit/64878632a0602879a59e4166232ef389cd6d0a60"}]}],"author":{"name":"Eric Harney","email":"eharney@redhat.com","date":"2013-11-12 19:34:44.000000000","tz":-300},"committer":{"name":"Eric Harney","email":"eharney@redhat.com","date":"2013-11-12 19:34:44.000000000","tz":-300},"subject":"Don\u0027t zero out thin provisioned LV\u0027s on delete","message":"Don\u0027t zero out thin provisioned LV\u0027s on delete\n\nThin provisioned LV\u0027s don\u0027t need secure delete to protect\nfrom data leakage.  Also, zeroing these out kinda defeats\nthe purpose of using thing provisioning.\n\nThis patch add a check for the lvm type and if it\u0027s thin simply\nreturns from the lvm.clear_volume() method.\n\nConflicts:\n\tcinder/tests/test_volume.py\n\tcinder/volume/drivers/lvm.py\n\nChange-Id: Ie6764209018152565295291efc6fbba553698ae6\nCloses-Bug: #1240299\n(cherry picked from commit de4392314f9b0def8fab65679ec5668aec98fbee)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder/commit/c9c9eaac573b65df671aab5c0f9ab4411557b926"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder/commit/c9c9eaac573b65df671aab5c0f9ab4411557b926"}]},"branch":"refs/heads/stable/grizzly"}},"requirements":[],"submit_records":[],"submit_requirements":[]}