)]}'
{"cinder/api/middleware/auth.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"e8258dad83a6fc05ad08b541918b27b630d1cc23","unresolved":false,"context_lines":[{"line_number":111,"context_line":"            return webob.exc.HTTPUnauthorized()"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        if req.environ.get(\u0027X_PROJECT_DOMAIN_ID\u0027):"},{"line_number":114,"context_line":"            ctx.project_domain \u003d req.environ.get(\u0027X_PROJECT_DOMAIN_ID\u0027)"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        if req.environ.get(\u0027X_PROJECT_DOMAIN_NAME\u0027):"},{"line_number":117,"context_line":"            ctx.project_domain_name \u003d req.environ.get(\u0027X_PROJECT_DOMAIN_NAME\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f6a8fd7_1bf0f2fc","line":114,"range":{"start_line":114,"start_character":45,"end_line":114,"end_character":48},"updated":"2018-04-23 10:02:53.000000000","message":"nit: No need to use get since we already know it\u0027s there:\n\n ctx.project_domain \u003d req.environ[\u0027X_PROJECT_DOMAIN_ID\u0027]","commit_id":"d68e3f0b347af51e4d78f97acc9c2f8615c5656d"}],"cinder/context.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"e8258dad83a6fc05ad08b541918b27b630d1cc23","unresolved":false,"context_lines":[{"line_number":183,"context_line":"                   user_domain_id\u003dvalues.get(\u0027user_domain\u0027),"},{"line_number":184,"context_line":"                   project_domain_id\u003dvalues.get(\u0027project_domain\u0027),"},{"line_number":185,"context_line":"                   user_domain\u003dvalues.get(\u0027user_domain\u0027),"},{"line_number":186,"context_line":"                   project_domain\u003dvalues.get(\u0027project_domain\u0027),)"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    def authorize(self, action, target\u003dNone, target_obj\u003dNone, fatal\u003dTrue):"},{"line_number":189,"context_line":"        \"\"\"Verifies that the given action is valid on the target in this context."}],"source_content_type":"text/x-python","patch_set":2,"id":"9f6a8fd7_db6d9a32","line":186,"range":{"start_line":186,"start_character":61,"end_line":186,"end_character":64},"updated":"2018-04-23 10:02:53.000000000","message":"nit: This comma serves no purpose since the closing parenthesis is on the same line.","commit_id":"d68e3f0b347af51e4d78f97acc9c2f8615c5656d"}],"cinder/tests/unit/api/middleware/test_auth.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"e8258dad83a6fc05ad08b541918b27b630d1cc23","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        self.request.get_response(self.middleware)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        self.assertEqual(\u0027domain1\u0027, self.context.project_domain)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def test_request_project_domain_name(self):"},{"line_number":88,"context_line":"        self.request.headers[\u0027X_USER_ID\u0027] \u003d \u0027testuserid\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f6a8fd7_5bf18a6a","line":85,"updated":"2018-04-23 10:02:53.000000000","message":"nit: We could also check that we have the same value in self.context.project_domain_id","commit_id":"d68e3f0b347af51e4d78f97acc9c2f8615c5656d"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"e8258dad83a6fc05ad08b541918b27b630d1cc23","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        self.request.get_response(self.middleware)"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        self.assertEqual(\u0027domain2\u0027, self.context.user_domain)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    def test_request_user_domain_name(self):"},{"line_number":104,"context_line":"        self.request.headers[\u0027X_USER_ID\u0027] \u003d \u0027testuserid\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f6a8fd7_bb8c66d7","line":101,"updated":"2018-04-23 10:02:53.000000000","message":"nit: We could also check that self.context.user_domain_id has the same value","commit_id":"d68e3f0b347af51e4d78f97acc9c2f8615c5656d"}]}