)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"9880ebdd8eccf8e542f5aec05be8e845ba53f943","unresolved":false,"context_lines":[{"line_number":10,"context_line":"statement to the wrong place. We need to open image in Ceph inside"},{"line_number":11,"context_line":"try-except block."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch also fixes raise condition between volume deletion and"},{"line_number":14,"context_line":"_get_usage_info calls."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I7d3d006b023ca4b7963c4c684e4c036399d1295c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f6a8fd7_784d86c2","line":13,"range":{"start_line":13,"start_character":22,"end_line":13,"end_character":27},"updated":"2018-04-20 21:21:11.000000000","message":"race","commit_id":"4f188c2961df9c2a2a12e09c8f386c82ce8c17cf"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"9880ebdd8eccf8e542f5aec05be8e845ba53f943","unresolved":false,"context_lines":[{"line_number":11,"context_line":"try-except block."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch also fixes raise condition between volume deletion and"},{"line_number":14,"context_line":"_get_usage_info calls."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I7d3d006b023ca4b7963c4c684e4c036399d1295c"},{"line_number":17,"context_line":"Co-Authored-By: Melanie Witt \u003cmelwittt@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f6a8fd7_b8dc7ee4","line":14,"updated":"2018-04-20 21:21:11.000000000","message":"I\u0027ve opened a bug [0] for this.\n\n[0] https://bugs.launchpad.net/cinder/+bug/1765845","commit_id":"4f188c2961df9c2a2a12e09c8f386c82ce8c17cf"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"30104aa93ed2ca7e14b9d1a9e9c354d5bc1975ac","unresolved":false,"context_lines":[{"line_number":14,"context_line":"_get_usage_info calls."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closed-Bug: #1765845"},{"line_number":17,"context_line":"Depends-On: https://review.openstack.org/563238"},{"line_number":18,"context_line":"Change-Id: I7d3d006b023ca4b7963c4c684e4c036399d1295c"},{"line_number":19,"context_line":"Co-Authored-By: Melanie Witt \u003cmelwittt@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9f6a8fd7_2d347292","line":17,"updated":"2018-04-24 20:56:26.000000000","message":"Ah, this changed to a different fix:\n\nhttps://review.openstack.org/563870\n\n(which has already merged), so we need to remove this line.","commit_id":"6cbd667eaba65b82e6f4362db597ee8fc4f13eb3"}],"cinder/tests/unit/volume/drivers/test_rbd.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"9b1868003823a913834bf552bf70e4ffbc6987da","unresolved":false,"context_lines":[{"line_number":1994,"context_line":"            mock.call(self.driver, v, read_only\u003dTrue,"},{"line_number":1995,"context_line":"                      client\u003dclient.cluster, ioctx\u003dclient.ioctx)"},{"line_number":1996,"context_line":"            for v in volumes]"},{"line_number":1997,"context_line":"        self.assertEqual(volproxy_mock.mock_calls, expected_volproxy_calls)"},{"line_number":1998,"context_line":""},{"line_number":1999,"context_line":"        self.assertEqual(3.00, total_provision)"},{"line_number":2000,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9f6a8fd7_47f74c5a","line":1997,"updated":"2018-04-24 15:26:26.000000000","message":"FYI, this should be ordered assertEqual(expected, actual) for the failure message (it will label the first thing as expected and the second thing as actual).","commit_id":"60fdc68a2acd55ab69724a8cc20c57ad6540ca01"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"946d3d2577da424c4f864c32113da5caa080a85b","unresolved":false,"context_lines":[{"line_number":1994,"context_line":"            mock.call(self.driver, v, read_only\u003dTrue,"},{"line_number":1995,"context_line":"                      client\u003dclient.cluster, ioctx\u003dclient.ioctx)"},{"line_number":1996,"context_line":"            for v in volumes]"},{"line_number":1997,"context_line":"        self.assertEqual(volproxy_mock.mock_calls, expected_volproxy_calls)"},{"line_number":1998,"context_line":""},{"line_number":1999,"context_line":"        self.assertEqual(3.00, total_provision)"},{"line_number":2000,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9f6a8fd7_6a2a55db","line":1997,"in_reply_to":"9f6a8fd7_47f74c5a","updated":"2018-04-24 15:59:20.000000000","message":"+1","commit_id":"60fdc68a2acd55ab69724a8cc20c57ad6540ca01"}],"cinder/volume/drivers/rbd.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"b0d8454afe7447b4c79c18509fdf0f93bc503635","unresolved":false,"context_lines":[{"line_number":144,"context_line":"            self.volume \u003d driver.rbd.Image(rados_ioctx,"},{"line_number":145,"context_line":"                                           utils.convert_str(name),"},{"line_number":146,"context_line":"                                           snapshot\u003dsnapshot,"},{"line_number":147,"context_line":"                                           read_only\u003dread_only)"},{"line_number":148,"context_line":"            self.volume \u003d tpool.Proxy(self.volume)"},{"line_number":149,"context_line":"        except driver.rbd.Error:"},{"line_number":150,"context_line":"            LOG.exception(\"error opening rbd image %s\", name)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f6a8fd7_43e5f736","line":147,"updated":"2018-04-24 22:44:36.000000000","message":"Hm, looks like we\u0027re getting ImageNotFound raised during this call as well in the failed ceph job run:\n\nhttp://logs.openstack.org/13/563313/7/check/legacy-tempest-dsvm-full-devstack-plugin-ceph/26b25e6/logs/screen-c-vol.txt.gz?level\u003dTRACE#_Apr_24_21_54_00_054078","commit_id":"3cc8cbdee7c98e1fcf41bb27d81e34fef3a2d032"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"833e9782bf65f1c2db296fa098a5ddf0a6bfe5d0","unresolved":false,"context_lines":[{"line_number":144,"context_line":"            self.volume \u003d driver.rbd.Image(rados_ioctx,"},{"line_number":145,"context_line":"                                           utils.convert_str(name),"},{"line_number":146,"context_line":"                                           snapshot\u003dsnapshot,"},{"line_number":147,"context_line":"                                           read_only\u003dread_only)"},{"line_number":148,"context_line":"            self.volume \u003d tpool.Proxy(self.volume)"},{"line_number":149,"context_line":"        except driver.rbd.Error:"},{"line_number":150,"context_line":"            LOG.exception(\"error opening rbd image %s\", name)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f6a8fd7_467c0e71","line":147,"in_reply_to":"9f6a8fd7_43e5f736","updated":"2018-04-25 20:41:57.000000000","message":"Nevermind, that\u0027s just the bug this patch is fixing but the code on L150 is logging a traceback (which it probably shouldn\u0027t if this can happen as a race between delete and _get_usage_info during tests).\n\nThe job run I linked actually failed because of this instead, different problem:\n\n\"Failed to delete volume b4c8c903-2ac7-4581-a796-d326cfa798ec within the required time (196 s).\"\n\n\"Details: {u\u0027message\u0027: u\u0027Invalid volume: Volume status must be available or error or error_restoring or error_extending or error_managing and must not be migrating, attached, belong to a group, have snapshots or be disassociated from snapshots after volume transfer.\u0027, u\u0027code\u0027: 400}\"\n\nhttp://logs.openstack.org/13/563313/7/check/legacy-tempest-dsvm-full-devstack-plugin-ceph/26b25e6/logs/screen-c-api.txt.gz#_Apr_24_21_53_17_899186","commit_id":"3cc8cbdee7c98e1fcf41bb27d81e34fef3a2d032"}]}