)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"7cb98e8194029703bc92628573d73207dd7a6f78","unresolved":false,"context_lines":[{"line_number":7,"context_line":"DRBD: Make calculation use more bits"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In Python2.x, \"int\" is 32bit only, and so this overflows for 2TiB"},{"line_number":10,"context_line":"volumes. Don\u0027t know what to do about Python3, where \"int\" is no"},{"line_number":11,"context_line":"longer available, though..."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This is a resubmission of 395132"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9f6a8fd7_70871263","line":10,"range":{"start_line":10,"start_character":9,"end_line":10,"end_character":30},"updated":"2018-05-02 10:23:18.000000000","message":"int\u0027s in Python 3 are changed to basically be what is a long in Python 2.","commit_id":"7da58311e8c7544118d0f5e8b8399400d836b709"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"7cb98e8194029703bc92628573d73207dd7a6f78","unresolved":false,"context_lines":[{"line_number":10,"context_line":"volumes. Don\u0027t know what to do about Python3, where \"int\" is no"},{"line_number":11,"context_line":"longer available, though..."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This is a resubmission of 395132"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I3e4814ee066df5726b0a2b599961511c2516135b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9f6a8fd7_30819a4b","line":13,"updated":"2018-05-02 10:23:18.000000000","message":"Why wasn\u0027t this one just updated?","commit_id":"7da58311e8c7544118d0f5e8b8399400d836b709"},{"author":{"_account_id":25972,"name":"Hayley Swimelar","email":"hayley.swimelar@linbit.com","username":"hayswim"},"change_message_id":"79243c1459fac8be3577669fb9a5764e197678d3","unresolved":false,"context_lines":[{"line_number":10,"context_line":"volumes. Don\u0027t know what to do about Python3, where \"int\" is no"},{"line_number":11,"context_line":"longer available, though..."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This is a resubmission of 395132"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I3e4814ee066df5726b0a2b599961511c2516135b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9f6a8fd7_ed1023ab","line":13,"in_reply_to":"9f6a8fd7_30819a4b","updated":"2018-05-02 16:26:22.000000000","message":"Last time that I tried to do it I couldn\u0027t un-abandon it because I wasn\u0027t the owner.","commit_id":"7da58311e8c7544118d0f5e8b8399400d836b709"}],"cinder/volume/drivers/drbdmanagedrv.py":[{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"bc0cfe16d9c624368974c8157f6e2e65304e2ab9","unresolved":false,"context_lines":[{"line_number":285,"context_line":"            return long(x)"},{"line_number":286,"context_line":"        except OverflowError:"},{"line_number":287,"context_line":"            msg \u003d _(\u0027Volume Size is too large: %s\u0027) % x"},{"line_number":288,"context_line":"            LOG.exception(msg)"},{"line_number":289,"context_line":"            raise exception.VolumeBackendAPIException(data\u003dmsg)"},{"line_number":290,"context_line":"        except TypeError:"},{"line_number":291,"context_line":"            msg \u003d _(\u0027Volume Size must be a number: %s\u0027) % x"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f6a8fd7_18adefe9","line":288,"range":{"start_line":288,"start_character":16,"end_line":288,"end_character":25},"updated":"2018-04-27 05:18:38.000000000","message":"As exception will be raised the msg is there in L289. I think there is not need TO show msg in LOG also. Thanks.","commit_id":"0c90a7c5a367556a8de26fb0f5be1c9012737303"},{"author":{"_account_id":25972,"name":"Hayley Swimelar","email":"hayley.swimelar@linbit.com","username":"hayswim"},"change_message_id":"1f40e2a576b6b0578cdd536546436b04705a29ea","unresolved":false,"context_lines":[{"line_number":285,"context_line":"            return long(x)"},{"line_number":286,"context_line":"        except OverflowError:"},{"line_number":287,"context_line":"            msg \u003d _(\u0027Volume Size is too large: %s\u0027) % x"},{"line_number":288,"context_line":"            LOG.exception(msg)"},{"line_number":289,"context_line":"            raise exception.VolumeBackendAPIException(data\u003dmsg)"},{"line_number":290,"context_line":"        except TypeError:"},{"line_number":291,"context_line":"            msg \u003d _(\u0027Volume Size must be a number: %s\u0027) % x"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f6a8fd7_07fee204","line":288,"range":{"start_line":288,"start_character":16,"end_line":288,"end_character":25},"in_reply_to":"9f6a8fd7_18adefe9","updated":"2018-04-27 17:15:14.000000000","message":"Done","commit_id":"0c90a7c5a367556a8de26fb0f5be1c9012737303"},{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"bc0cfe16d9c624368974c8157f6e2e65304e2ab9","unresolved":false,"context_lines":[{"line_number":289,"context_line":"            raise exception.VolumeBackendAPIException(data\u003dmsg)"},{"line_number":290,"context_line":"        except TypeError:"},{"line_number":291,"context_line":"            msg \u003d _(\u0027Volume Size must be a number: %s\u0027) % x"},{"line_number":292,"context_line":"            LOG.exception(msg)"},{"line_number":293,"context_line":"            raise exception.VolumeBackendAPIException(data\u003dmsg)"},{"line_number":294,"context_line":"        except ValueError:"},{"line_number":295,"context_line":"            msg \u003d _(\u0027Volume Size is invalid: %s\u0027) % x"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f6a8fd7_d8b6973f","line":292,"range":{"start_line":292,"start_character":16,"end_line":292,"end_character":25},"updated":"2018-04-27 05:18:38.000000000","message":"Same as above.","commit_id":"0c90a7c5a367556a8de26fb0f5be1c9012737303"},{"author":{"_account_id":25972,"name":"Hayley Swimelar","email":"hayley.swimelar@linbit.com","username":"hayswim"},"change_message_id":"1f40e2a576b6b0578cdd536546436b04705a29ea","unresolved":false,"context_lines":[{"line_number":289,"context_line":"            raise exception.VolumeBackendAPIException(data\u003dmsg)"},{"line_number":290,"context_line":"        except TypeError:"},{"line_number":291,"context_line":"            msg \u003d _(\u0027Volume Size must be a number: %s\u0027) % x"},{"line_number":292,"context_line":"            LOG.exception(msg)"},{"line_number":293,"context_line":"            raise exception.VolumeBackendAPIException(data\u003dmsg)"},{"line_number":294,"context_line":"        except ValueError:"},{"line_number":295,"context_line":"            msg \u003d _(\u0027Volume Size is invalid: %s\u0027) % x"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f6a8fd7_2703e60f","line":292,"range":{"start_line":292,"start_character":16,"end_line":292,"end_character":25},"in_reply_to":"9f6a8fd7_d8b6973f","updated":"2018-04-27 17:15:14.000000000","message":"Done","commit_id":"0c90a7c5a367556a8de26fb0f5be1c9012737303"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"7cb98e8194029703bc92628573d73207dd7a6f78","unresolved":false,"context_lines":[{"line_number":296,"context_line":"    # DRBDmanage works in kiB units; Cinder uses GiB."},{"line_number":297,"context_line":"    def _vol_size_to_dm(self, size):"},{"line_number":298,"context_line":"        try:"},{"line_number":299,"context_line":"            return self._python_long(size * units.Gi / units.Ki)"},{"line_number":300,"context_line":"        except OverflowError:"},{"line_number":301,"context_line":"            msg \u003d _(\u0027Volume Size in KiB is too large: %s\u0027) % str(size)"},{"line_number":302,"context_line":"            raise exception.VolumeDriverException(data\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f6a8fd7_30f67afb","line":299,"updated":"2018-05-02 10:23:18.000000000","message":"Not sure why any of this is needed, including the existing code that does the int() call. Just return (size * units.Gi / units.Ki).","commit_id":"7da58311e8c7544118d0f5e8b8399400d836b709"},{"author":{"_account_id":25972,"name":"Hayley Swimelar","email":"hayley.swimelar@linbit.com","username":"hayswim"},"change_message_id":"79243c1459fac8be3577669fb9a5764e197678d3","unresolved":false,"context_lines":[{"line_number":296,"context_line":"    # DRBDmanage works in kiB units; Cinder uses GiB."},{"line_number":297,"context_line":"    def _vol_size_to_dm(self, size):"},{"line_number":298,"context_line":"        try:"},{"line_number":299,"context_line":"            return self._python_long(size * units.Gi / units.Ki)"},{"line_number":300,"context_line":"        except OverflowError:"},{"line_number":301,"context_line":"            msg \u003d _(\u0027Volume Size in KiB is too large: %s\u0027) % str(size)"},{"line_number":302,"context_line":"            raise exception.VolumeDriverException(data\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f6a8fd7_ed8583d0","line":299,"in_reply_to":"9f6a8fd7_30f67afb","updated":"2018-05-02 16:26:22.000000000","message":"Done","commit_id":"7da58311e8c7544118d0f5e8b8399400d836b709"}]}
