)]}'
{"cinder/tests/unit/volume/drivers/test_qnap.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"bf626316b9faf5b47331dfe1c64aaab2fcc2147b","unresolved":false,"context_lines":[{"line_number":2392,"context_line":"        self.driver.do_setup(\u0027context\u0027)"},{"line_number":2393,"context_line":"        self.driver._detach_volume(\u0027context\u0027,"},{"line_number":2394,"context_line":"                                   \u0027attach_info\u0027, \u0027volume\u0027,"},{"line_number":2395,"context_line":"                                   \u0027property\u0027)"},{"line_number":2396,"context_line":"        mock_detach_volume.assert_called_once_with("},{"line_number":2397,"context_line":"            \u0027context\u0027, \u0027attach_info\u0027, \u0027volume\u0027, \u0027property\u0027,"},{"line_number":2398,"context_line":"            force\u003dFalse, ignore_errors\u003dFalse, remote\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f6a8fd7_1eb0778b","line":2395,"updated":"2018-04-27 08:22:53.000000000","message":"We need to test the signature change (now accepts ignore_errors), so we should pass all optional parameters and confirm they are passed along.","commit_id":"9e86d335e73c29bba75624eaedb1d55886f93027"},{"author":{"_account_id":26134,"name":"Chris Yang","email":"chrisyang@qnap.com","username":"chrisyang"},"change_message_id":"a6e5c56621102cc4fa384521e751c4dfc28467d0","unresolved":false,"context_lines":[{"line_number":2392,"context_line":"        self.driver.do_setup(\u0027context\u0027)"},{"line_number":2393,"context_line":"        self.driver._detach_volume(\u0027context\u0027,"},{"line_number":2394,"context_line":"                                   \u0027attach_info\u0027, \u0027volume\u0027,"},{"line_number":2395,"context_line":"                                   \u0027property\u0027)"},{"line_number":2396,"context_line":"        mock_detach_volume.assert_called_once_with("},{"line_number":2397,"context_line":"            \u0027context\u0027, \u0027attach_info\u0027, \u0027volume\u0027, \u0027property\u0027,"},{"line_number":2398,"context_line":"            force\u003dFalse, ignore_errors\u003dFalse, remote\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f6a8fd7_3e95f1e4","line":2395,"in_reply_to":"9f6a8fd7_1eb0778b","updated":"2018-05-02 03:15:54.000000000","message":"Done","commit_id":"9e86d335e73c29bba75624eaedb1d55886f93027"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"5499216002bd42842d46f10e0647d2556843be68","unresolved":false,"context_lines":[{"line_number":2378,"context_line":"            \u0027ignore_errors\u0027: False,"},{"line_number":2379,"context_line":"            \u0027remote\u0027: False"},{"line_number":2380,"context_line":"        }"},{"line_number":2381,"context_line":"    }, {"},{"line_number":2382,"context_line":"        \u0027fake_spec\u0027: {"},{"line_number":2383,"context_line":"            \u0027force\u0027: False,"},{"line_number":2384,"context_line":"            \u0027ignore_errors\u0027: False,"},{"line_number":2385,"context_line":"            \u0027remote\u0027: False"},{"line_number":2386,"context_line":"        },"},{"line_number":2387,"context_line":"        \u0027expect_spec\u0027: {"},{"line_number":2388,"context_line":"            \u0027force\u0027: False,"},{"line_number":2389,"context_line":"            \u0027ignore_errors\u0027: False,"},{"line_number":2390,"context_line":"            \u0027remote\u0027: False"},{"line_number":2391,"context_line":"        }"},{"line_number":2392,"context_line":"    }, {"},{"line_number":2393,"context_line":"        \u0027fake_spec\u0027: {"},{"line_number":2394,"context_line":"            \u0027force\u0027: True,"},{"line_number":2395,"context_line":"            \u0027ignore_errors\u0027: True,"},{"line_number":2396,"context_line":"            \u0027remote\u0027: True"},{"line_number":2397,"context_line":"        },"},{"line_number":2398,"context_line":"        \u0027expect_spec\u0027: {"},{"line_number":2399,"context_line":"            \u0027force\u0027: True,"},{"line_number":2400,"context_line":"            \u0027ignore_errors\u0027: True,"},{"line_number":2401,"context_line":"            \u0027remote\u0027: True"},{"line_number":2402,"context_line":"        }"},{"line_number":2403,"context_line":"    }, {"},{"line_number":2404,"context_line":"        \u0027fake_spec\u0027: {"},{"line_number":2405,"context_line":"            \u0027force\u0027: True,"},{"line_number":2406,"context_line":"            \u0027ignore_errors\u0027: False,"},{"line_number":2407,"context_line":"            \u0027remote\u0027: True"},{"line_number":2408,"context_line":"        },"},{"line_number":2409,"context_line":"        \u0027expect_spec\u0027: {"},{"line_number":2410,"context_line":"            \u0027force\u0027: True,"},{"line_number":2411,"context_line":"            \u0027ignore_errors\u0027: False,"},{"line_number":2412,"context_line":"            \u0027remote\u0027: True"},{"line_number":2413,"context_line":"        }"},{"line_number":2414,"context_line":"    }, {"},{"line_number":2415,"context_line":"        \u0027fake_spec\u0027: {"},{"line_number":2416,"context_line":"            \u0027force\u0027: False,"},{"line_number":2417,"context_line":"            \u0027ignore_errors\u0027: True,"},{"line_number":2418,"context_line":"            \u0027remote\u0027: False"},{"line_number":2419,"context_line":"        },"},{"line_number":2420,"context_line":"        \u0027expect_spec\u0027: {"},{"line_number":2421,"context_line":"            \u0027force\u0027: False,"},{"line_number":2422,"context_line":"            \u0027ignore_errors\u0027: True,"},{"line_number":2423,"context_line":"            \u0027remote\u0027: False"},{"line_number":2424,"context_line":"        }"},{"line_number":2425,"context_line":"    })"},{"line_number":2426,"context_line":"    @unpack"},{"line_number":2427,"context_line":"    @mock.patch.object(driver.BaseVD, \u0027_detach_volume\u0027)"},{"line_number":2428,"context_line":"    @mock.patch(\u0027cinder.volume.drivers.qnap.QnapAPIExecutor\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_b4e5f93a","line":2425,"range":{"start_line":2381,"start_character":0,"end_line":2425,"end_character":5},"updated":"2018-05-03 10:47:48.000000000","message":"nit: Using sentinels all these tests can be done with just one:\n\n{\u0027fake_spec\u0027: {\u0027force\u0027: mock.sentinel.force,\n               \u0027ignore_errors\u0027: mock.sentinel.ignore_errors,\n               \u0027remote\u0027: mock.sentinel.remote},\n \u0027expect_spec\u0027: {\u0027force\u0027: mock.sentinel.force,\n                 \u0027ignore_errors\u0027: mock.sentinel.ignore_errors,\n                 \u0027remote\u0027: mock.sentinel.remote}},","commit_id":"6aa1b2dff80a21aac09d994ba30bb1ccdfcc0741"},{"author":{"_account_id":26134,"name":"Chris Yang","email":"chrisyang@qnap.com","username":"chrisyang"},"change_message_id":"216e047fc34a6a864aeabe6b12e90dbef704e4a7","unresolved":false,"context_lines":[{"line_number":2378,"context_line":"            \u0027ignore_errors\u0027: False,"},{"line_number":2379,"context_line":"            \u0027remote\u0027: False"},{"line_number":2380,"context_line":"        }"},{"line_number":2381,"context_line":"    }, {"},{"line_number":2382,"context_line":"        \u0027fake_spec\u0027: {"},{"line_number":2383,"context_line":"            \u0027force\u0027: False,"},{"line_number":2384,"context_line":"            \u0027ignore_errors\u0027: False,"},{"line_number":2385,"context_line":"            \u0027remote\u0027: False"},{"line_number":2386,"context_line":"        },"},{"line_number":2387,"context_line":"        \u0027expect_spec\u0027: {"},{"line_number":2388,"context_line":"            \u0027force\u0027: False,"},{"line_number":2389,"context_line":"            \u0027ignore_errors\u0027: False,"},{"line_number":2390,"context_line":"            \u0027remote\u0027: False"},{"line_number":2391,"context_line":"        }"},{"line_number":2392,"context_line":"    }, {"},{"line_number":2393,"context_line":"        \u0027fake_spec\u0027: {"},{"line_number":2394,"context_line":"            \u0027force\u0027: True,"},{"line_number":2395,"context_line":"            \u0027ignore_errors\u0027: True,"},{"line_number":2396,"context_line":"            \u0027remote\u0027: True"},{"line_number":2397,"context_line":"        },"},{"line_number":2398,"context_line":"        \u0027expect_spec\u0027: {"},{"line_number":2399,"context_line":"            \u0027force\u0027: True,"},{"line_number":2400,"context_line":"            \u0027ignore_errors\u0027: True,"},{"line_number":2401,"context_line":"            \u0027remote\u0027: True"},{"line_number":2402,"context_line":"        }"},{"line_number":2403,"context_line":"    }, {"},{"line_number":2404,"context_line":"        \u0027fake_spec\u0027: {"},{"line_number":2405,"context_line":"            \u0027force\u0027: True,"},{"line_number":2406,"context_line":"            \u0027ignore_errors\u0027: False,"},{"line_number":2407,"context_line":"            \u0027remote\u0027: True"},{"line_number":2408,"context_line":"        },"},{"line_number":2409,"context_line":"        \u0027expect_spec\u0027: {"},{"line_number":2410,"context_line":"            \u0027force\u0027: True,"},{"line_number":2411,"context_line":"            \u0027ignore_errors\u0027: False,"},{"line_number":2412,"context_line":"            \u0027remote\u0027: True"},{"line_number":2413,"context_line":"        }"},{"line_number":2414,"context_line":"    }, {"},{"line_number":2415,"context_line":"        \u0027fake_spec\u0027: {"},{"line_number":2416,"context_line":"            \u0027force\u0027: False,"},{"line_number":2417,"context_line":"            \u0027ignore_errors\u0027: True,"},{"line_number":2418,"context_line":"            \u0027remote\u0027: False"},{"line_number":2419,"context_line":"        },"},{"line_number":2420,"context_line":"        \u0027expect_spec\u0027: {"},{"line_number":2421,"context_line":"            \u0027force\u0027: False,"},{"line_number":2422,"context_line":"            \u0027ignore_errors\u0027: True,"},{"line_number":2423,"context_line":"            \u0027remote\u0027: False"},{"line_number":2424,"context_line":"        }"},{"line_number":2425,"context_line":"    })"},{"line_number":2426,"context_line":"    @unpack"},{"line_number":2427,"context_line":"    @mock.patch.object(driver.BaseVD, \u0027_detach_volume\u0027)"},{"line_number":2428,"context_line":"    @mock.patch(\u0027cinder.volume.drivers.qnap.QnapAPIExecutor\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_98626316","line":2425,"range":{"start_line":2381,"start_character":0,"end_line":2425,"end_character":5},"in_reply_to":"5f7c97a3_b4e5f93a","updated":"2018-05-04 01:09:27.000000000","message":"Done","commit_id":"6aa1b2dff80a21aac09d994ba30bb1ccdfcc0741"}]}
