)]}'
{"cinder/backup/manager.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"4f3d2700b4920b4645d3a993d7c8591b896f9fd8","unresolved":false,"context_lines":[{"line_number":624,"context_line":"        except exception.BackupRestoreCancel:"},{"line_number":625,"context_line":"            raise"},{"line_number":626,"context_line":"        except Exception:"},{"line_number":627,"context_line":"            LOG.exception(\u0027Restoring backup %(backup_id)s to volume \u0027"},{"line_number":628,"context_line":"                          \u0027%(volume_id)s failed.\u0027, {\u0027backup_id\u0027: backup.id,"},{"line_number":629,"context_line":"                                                    \u0027volume_id\u0027: volume.id})"},{"line_number":630,"context_line":"            raise"},{"line_number":631,"context_line":"        finally:"},{"line_number":632,"context_line":"            self._detach_device(context, attach_info, volume, properties,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_abe8a2e1","line":629,"range":{"start_line":627,"start_character":0,"end_line":629,"end_character":76},"updated":"2018-05-11 09:33:49.000000000","message":"-1: Move this to L577","commit_id":"dc118ef8029730601b2eece515a574c7c44e7b15"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"5ba13d9c0350719ada0371d253928da2db409536","unresolved":false,"context_lines":[{"line_number":624,"context_line":"        except exception.BackupRestoreCancel:"},{"line_number":625,"context_line":"            raise"},{"line_number":626,"context_line":"        except Exception:"},{"line_number":627,"context_line":"            LOG.exception(\u0027Restoring backup %(backup_id)s to volume \u0027"},{"line_number":628,"context_line":"                          \u0027%(volume_id)s failed.\u0027, {\u0027backup_id\u0027: backup.id,"},{"line_number":629,"context_line":"                                                    \u0027volume_id\u0027: volume.id})"},{"line_number":630,"context_line":"            raise"},{"line_number":631,"context_line":"        finally:"},{"line_number":632,"context_line":"            self._detach_device(context, attach_info, volume, properties,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_d98fdcca","line":629,"range":{"start_line":627,"start_character":0,"end_line":629,"end_character":76},"in_reply_to":"5f7c97a3_2bad649a","updated":"2018-05-14 08:23:57.000000000","message":"Yes, you are right, detaching errors would mask errors on the restore process.","commit_id":"dc118ef8029730601b2eece515a574c7c44e7b15"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"37baed70e7e8ae93e15b9df47b039890af89bc01","unresolved":false,"context_lines":[{"line_number":624,"context_line":"        except exception.BackupRestoreCancel:"},{"line_number":625,"context_line":"            raise"},{"line_number":626,"context_line":"        except Exception:"},{"line_number":627,"context_line":"            LOG.exception(\u0027Restoring backup %(backup_id)s to volume \u0027"},{"line_number":628,"context_line":"                          \u0027%(volume_id)s failed.\u0027, {\u0027backup_id\u0027: backup.id,"},{"line_number":629,"context_line":"                                                    \u0027volume_id\u0027: volume.id})"},{"line_number":630,"context_line":"            raise"},{"line_number":631,"context_line":"        finally:"},{"line_number":632,"context_line":"            self._detach_device(context, attach_info, volume, properties,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_2bad649a","line":629,"range":{"start_line":627,"start_character":0,"end_line":629,"end_character":76},"in_reply_to":"5f7c97a3_abe8a2e1","updated":"2018-05-11 22:44:00.000000000","message":"I don\u0027t see how that helps. If we move this to line 577 and line 632 raises an exception, the exception raised by backup_service.restore() call will not be logged anywhere, right?","commit_id":"dc118ef8029730601b2eece515a574c7c44e7b15"}]}