)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"308b74702850286876996c26d164df82195ff72a","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix hostname validation regex."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"With the addition of the fields validation on the API, cinder now"},{"line_number":10,"context_line":"oes not allow \u0027:\u0027 and \u0027/\u0027 characters on the hostname field. Some"},{"line_number":11,"context_line":"drivers use there characters for the hostname of the volumes, mainly"},{"line_number":12,"context_line":"for the NFS implementation. This patch fixes that by adding these"},{"line_number":13,"context_line":"characters to the validation regex."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5f7c97a3_a4723ae2","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":3},"updated":"2018-05-09 19:50:26.000000000","message":"s/oes/does","commit_id":"76edef6150b251a45e2e117d414648136d244e96"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"308b74702850286876996c26d164df82195ff72a","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"With the addition of the fields validation on the API, cinder now"},{"line_number":10,"context_line":"oes not allow \u0027:\u0027 and \u0027/\u0027 characters on the hostname field. Some"},{"line_number":11,"context_line":"drivers use there characters for the hostname of the volumes, mainly"},{"line_number":12,"context_line":"for the NFS implementation. This patch fixes that by adding these"},{"line_number":13,"context_line":"characters to the validation regex."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5f7c97a3_647c22b5","line":11,"range":{"start_line":11,"start_character":12,"end_line":11,"end_character":17},"updated":"2018-05-09 19:50:26.000000000","message":"s/there/these","commit_id":"76edef6150b251a45e2e117d414648136d244e96"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"6bba9b6729b56f1b6a171396babc84f655721780","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix hostname validation regex."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"With the addition of the fields validation on the API, cinder now"},{"line_number":10,"context_line":"oes not allow \u0027:\u0027 and \u0027/\u0027 characters on the hostname field. Some"},{"line_number":11,"context_line":"drivers use there characters for the hostname of the volumes, mainly"},{"line_number":12,"context_line":"for the NFS implementation. This patch fixes that by adding these"},{"line_number":13,"context_line":"characters to the validation regex."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"5f7c97a3_96de3c6b","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":4},"updated":"2018-05-10 18:55:02.000000000","message":"does","commit_id":"26d65ca75f709405bdf6cb8daa11745e13d1fbc1"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"6bba9b6729b56f1b6a171396babc84f655721780","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"With the addition of the fields validation on the API, cinder now"},{"line_number":10,"context_line":"oes not allow \u0027:\u0027 and \u0027/\u0027 characters on the hostname field. Some"},{"line_number":11,"context_line":"drivers use there characters for the hostname of the volumes, mainly"},{"line_number":12,"context_line":"for the NFS implementation. This patch fixes that by adding these"},{"line_number":13,"context_line":"characters to the validation regex."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"5f7c97a3_b6db387a","line":11,"range":{"start_line":11,"start_character":12,"end_line":11,"end_character":17},"updated":"2018-05-10 18:55:02.000000000","message":"these","commit_id":"26d65ca75f709405bdf6cb8daa11745e13d1fbc1"}],"cinder/api/validation/parameter_types.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"7716c5fd78c4441e743070489048513bbf6e3409","unresolved":false,"context_lines":[{"line_number":218,"context_line":"    # means a hostname. The hostname grammar in RFC952 does"},{"line_number":219,"context_line":"    # not allow for underscores in hostnames. However, this"},{"line_number":220,"context_line":"    # schema allows them, because it sometimes occurs in"},{"line_number":221,"context_line":"    # real systems."},{"line_number":222,"context_line":"    \u0027pattern\u0027: \u0027^[a-zA-Z0-9-._#@:/]*$\u0027"},{"line_number":223,"context_line":"}"},{"line_number":224,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5f7c97a3_b3da6b48","line":221,"updated":"2018-05-10 17:15:42.000000000","message":"This comment is now misleading because this field is used to validate strings that aren\u0027t strictly hostnames.  That should be indicated here somehow.","commit_id":"44512319d0543e3865e26ca0c2e6622e7bfb21a9"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"c278c2b7d79bec942f3cb9a4e3ada605cb939492","unresolved":false,"context_lines":[{"line_number":218,"context_line":"    # means a hostname. The hostname grammar in RFC952 does"},{"line_number":219,"context_line":"    # not allow for underscores in hostnames. However, this"},{"line_number":220,"context_line":"    # schema allows them, because it sometimes occurs in"},{"line_number":221,"context_line":"    # real systems."},{"line_number":222,"context_line":"    \u0027pattern\u0027: \u0027^[a-zA-Z0-9-._#@:/]*$\u0027"},{"line_number":223,"context_line":"}"},{"line_number":224,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5f7c97a3_33909bed","line":221,"in_reply_to":"5f7c97a3_93f88f7b","updated":"2018-05-10 17:39:56.000000000","message":"Well hostnames don\u0027t contain colons and slashes.  The comment should just be extended to explain that what\u0027s being validated is not strictly a hostname.","commit_id":"44512319d0543e3865e26ca0c2e6622e7bfb21a9"},{"author":{"_account_id":25186,"name":"Luiz Benedito Aidar Gavioli","email":"luizbag@gmail.com","username":"luizbag"},"change_message_id":"c427c921adde34a8975219eadd8c70f96435eafe","unresolved":false,"context_lines":[{"line_number":218,"context_line":"    # means a hostname. The hostname grammar in RFC952 does"},{"line_number":219,"context_line":"    # not allow for underscores in hostnames. However, this"},{"line_number":220,"context_line":"    # schema allows them, because it sometimes occurs in"},{"line_number":221,"context_line":"    # real systems."},{"line_number":222,"context_line":"    \u0027pattern\u0027: \u0027^[a-zA-Z0-9-._#@:/]*$\u0027"},{"line_number":223,"context_line":"}"},{"line_number":224,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5f7c97a3_93f88f7b","line":221,"in_reply_to":"5f7c97a3_b3da6b48","updated":"2018-05-10 17:27:15.000000000","message":"Would it be enough to add colons and forward slashes after underscores in the comment?","commit_id":"44512319d0543e3865e26ca0c2e6622e7bfb21a9"}],"cinder/tests/unit/volume/test_manage_volume.py":[{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"0d53092cf6db8b268eb76045745336a6c529fa46","unresolved":false,"context_lines":[{"line_number":298,"context_line":"        mock_update_volume_stats \u003d self.mock_object("},{"line_number":299,"context_line":"            self.manager, \u0027_update_stats_for_managed\u0027)"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"        result \u003d self.manager.manage_existing(self.context, volume_object)"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"        self.assertEqual(fake.VOLUME_ID, result)"},{"line_number":304,"context_line":"        mock_run_flow_engine.assert_called_once_with(self.context,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_94189975","line":301,"range":{"start_line":301,"start_character":0,"end_line":301,"end_character":74},"updated":"2018-05-09 13:38:17.000000000","message":"At this point, the validation was already done. This test should be done on the API to guarantee that the parameters are being checked with the regex.","commit_id":"a96559a353dd8cb21da68ce26403c46daeda40b2"},{"author":{"_account_id":25186,"name":"Luiz Benedito Aidar Gavioli","email":"luizbag@gmail.com","username":"luizbag"},"change_message_id":"660741d065512c27ef1a9aeb65c82665f0b01437","unresolved":false,"context_lines":[{"line_number":298,"context_line":"        mock_update_volume_stats \u003d self.mock_object("},{"line_number":299,"context_line":"            self.manager, \u0027_update_stats_for_managed\u0027)"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"        result \u003d self.manager.manage_existing(self.context, volume_object)"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"        self.assertEqual(fake.VOLUME_ID, result)"},{"line_number":304,"context_line":"        mock_run_flow_engine.assert_called_once_with(self.context,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_69fe3baf","line":301,"range":{"start_line":301,"start_character":0,"end_line":301,"end_character":74},"in_reply_to":"5f7c97a3_94189975","updated":"2018-05-09 18:45:45.000000000","message":"Done","commit_id":"a96559a353dd8cb21da68ce26403c46daeda40b2"}]}