)]}'
{"cinder/volume/drivers/dell_emc/sc/storagecenter_api.py":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"f071dab01233c508c016286b8cc037aaeb8acc35","unresolved":false,"context_lines":[{"line_number":358,"context_line":"        connection.sfname \u003d self.config.dell_sc_server_folder"},{"line_number":359,"context_line":"        connection.excluded_domain_ips \u003d self.config.excluded_domain_ips"},{"line_number":360,"context_line":"        if self.config.excluded_domain_ip:"},{"line_number":361,"context_line":"            connection.excluded_domain_ips +\u003d self.config.excluded_domain_ip"},{"line_number":362,"context_line":"        # Our primary SSN doesn\u0027t change"},{"line_number":363,"context_line":"        connection.primaryssn \u003d self.primaryssn"},{"line_number":364,"context_line":"        if self.storage_protocol \u003d\u003d \u0027FC\u0027:"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_8b247d61","line":361,"updated":"2018-06-13 16:56:46.000000000","message":"do we care about duplicates, perhaps even duplicate entries in config.excluded_domain_ips?\n\nIf so, then adding something like this might be prudent:\n\nconnection.excluded_domain_ips \u003d list(set(connection.excluded_domain_ips))","commit_id":"a9830e4104f0d8c284b48055877c39d388d15177"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"4fe93a9f14ddd4559b5208a988346edc426ecde8","unresolved":false,"context_lines":[{"line_number":358,"context_line":"        connection.sfname \u003d self.config.dell_sc_server_folder"},{"line_number":359,"context_line":"        connection.excluded_domain_ips \u003d self.config.excluded_domain_ips"},{"line_number":360,"context_line":"        if self.config.excluded_domain_ip:"},{"line_number":361,"context_line":"            connection.excluded_domain_ips +\u003d self.config.excluded_domain_ip"},{"line_number":362,"context_line":"        # Our primary SSN doesn\u0027t change"},{"line_number":363,"context_line":"        connection.primaryssn \u003d self.primaryssn"},{"line_number":364,"context_line":"        if self.storage_protocol \u003d\u003d \u0027FC\u0027:"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_b0bbe5c1","line":361,"in_reply_to":"5f7c97a3_8b247d61","updated":"2018-06-13 20:16:10.000000000","message":"Done","commit_id":"a9830e4104f0d8c284b48055877c39d388d15177"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"f4425cf8c500b77021d92644e3de319b358ba057","unresolved":false,"context_lines":[{"line_number":360,"context_line":"        if self.config.excluded_domain_ip:"},{"line_number":361,"context_line":"            connection.excluded_domain_ips +\u003d self.config.excluded_domain_ip"},{"line_number":362,"context_line":"        # Remove duplicates"},{"line_number":363,"context_line":"        connection.excluded_domain_ips \u003d \\"},{"line_number":364,"context_line":"            list(set(connection.excluded_domain_ips))"},{"line_number":365,"context_line":"        # Our primary SSN doesn\u0027t change"},{"line_number":366,"context_line":"        connection.primaryssn \u003d self.primaryssn"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f7c97a3_e3f05e94","line":363,"range":{"start_line":363,"start_character":41,"end_line":363,"end_character":42},"updated":"2018-06-18 19:27:28.000000000","message":"Please don\u0027t use \\ for multiline statements. We\u0027ve made an effort to make sure they are not used outside of the test code.\n\nIt looks like it should work to have the \"set(\" call on this line and then be able to continue on to the next without anything extra needed.","commit_id":"9443e34a9c7e8c93e26e9e3c048a46065f63a9f4"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"845b559171c47e980fa959c05437319a3e189e4a","unresolved":false,"context_lines":[{"line_number":360,"context_line":"        if self.config.excluded_domain_ip:"},{"line_number":361,"context_line":"            connection.excluded_domain_ips +\u003d self.config.excluded_domain_ip"},{"line_number":362,"context_line":"        # Remove duplicates"},{"line_number":363,"context_line":"        connection.excluded_domain_ips \u003d \\"},{"line_number":364,"context_line":"            list(set(connection.excluded_domain_ips))"},{"line_number":365,"context_line":"        # Our primary SSN doesn\u0027t change"},{"line_number":366,"context_line":"        connection.primaryssn \u003d self.primaryssn"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f7c97a3_9edd2615","line":363,"range":{"start_line":363,"start_character":41,"end_line":363,"end_character":42},"in_reply_to":"5f7c97a3_e3f05e94","updated":"2018-06-19 16:38:16.000000000","message":"Done","commit_id":"9443e34a9c7e8c93e26e9e3c048a46065f63a9f4"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"eb2f9af06646dc877530a8467599d2a999ec3b96","unresolved":false,"context_lines":[{"line_number":358,"context_line":"        connection.sfname \u003d self.config.dell_sc_server_folder"},{"line_number":359,"context_line":"        connection.excluded_domain_ips \u003d self.config.excluded_domain_ips"},{"line_number":360,"context_line":"        if self.config.excluded_domain_ip:"},{"line_number":361,"context_line":"            LOG.info(\"Using excluded_domain_ip for\""},{"line_number":362,"context_line":"                     \"excluding domain IPs will be deprecated in the \""},{"line_number":363,"context_line":"                     \"Rocky release of OpenStack. Please use \""},{"line_number":364,"context_line":"                     \"excluded_domain_ips configuration option.\")"}],"source_content_type":"text/x-python","patch_set":10,"id":"3f79a3b5_8d05d912","line":361,"range":{"start_line":361,"start_character":50,"end_line":361,"end_character":51},"updated":"2018-08-22 14:16:46.000000000","message":"missing space at EOL","commit_id":"583ab7be0bf8e50854e059985d5d1e31f3fefcb3"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"634dd2cba26343af9b354c1d0ebee66f5ab9de9f","unresolved":false,"context_lines":[{"line_number":358,"context_line":"        connection.sfname \u003d self.config.dell_sc_server_folder"},{"line_number":359,"context_line":"        connection.excluded_domain_ips \u003d self.config.excluded_domain_ips"},{"line_number":360,"context_line":"        if self.config.excluded_domain_ip:"},{"line_number":361,"context_line":"            LOG.info(\"Using excluded_domain_ip for\""},{"line_number":362,"context_line":"                     \"excluding domain IPs will be deprecated in the \""},{"line_number":363,"context_line":"                     \"Rocky release of OpenStack. Please use \""},{"line_number":364,"context_line":"                     \"excluded_domain_ips configuration option.\")"}],"source_content_type":"text/x-python","patch_set":10,"id":"3f79a3b5_fe1f5169","line":361,"range":{"start_line":361,"start_character":50,"end_line":361,"end_character":51},"in_reply_to":"3f79a3b5_8d05d912","updated":"2018-08-22 15:56:55.000000000","message":"Done","commit_id":"583ab7be0bf8e50854e059985d5d1e31f3fefcb3"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"11629e6d808bd1a4493cfaeedc9c2f5746b24f58","unresolved":false,"context_lines":[{"line_number":359,"context_line":"        connection.excluded_domain_ips \u003d self.config.excluded_domain_ips"},{"line_number":360,"context_line":"        if self.config.excluded_domain_ip:"},{"line_number":361,"context_line":"            LOG.info(\"Using excluded_domain_ip for\""},{"line_number":362,"context_line":"                     \"excluding domain IPs will be deprecated in the \""},{"line_number":363,"context_line":"                     \"Rocky release of OpenStack. Please use \""},{"line_number":364,"context_line":"                     \"excluded_domain_ips configuration option.\")"},{"line_number":365,"context_line":"            connection.excluded_domain_ips +\u003d self.config.excluded_domain_ip"}],"source_content_type":"text/x-python","patch_set":10,"id":"3f79a3b5_0d1ea9ba","line":362,"range":{"start_line":362,"start_character":43,"end_line":362,"end_character":61},"updated":"2018-08-22 14:42:43.000000000","message":"\"will be deprecated\" or \"is deprecated\" now, as of this patch?","commit_id":"583ab7be0bf8e50854e059985d5d1e31f3fefcb3"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"634dd2cba26343af9b354c1d0ebee66f5ab9de9f","unresolved":false,"context_lines":[{"line_number":359,"context_line":"        connection.excluded_domain_ips \u003d self.config.excluded_domain_ips"},{"line_number":360,"context_line":"        if self.config.excluded_domain_ip:"},{"line_number":361,"context_line":"            LOG.info(\"Using excluded_domain_ip for\""},{"line_number":362,"context_line":"                     \"excluding domain IPs will be deprecated in the \""},{"line_number":363,"context_line":"                     \"Rocky release of OpenStack. Please use \""},{"line_number":364,"context_line":"                     \"excluded_domain_ips configuration option.\")"},{"line_number":365,"context_line":"            connection.excluded_domain_ips +\u003d self.config.excluded_domain_ip"}],"source_content_type":"text/x-python","patch_set":10,"id":"3f79a3b5_9e109d5b","line":362,"range":{"start_line":362,"start_character":43,"end_line":362,"end_character":61},"in_reply_to":"3f79a3b5_0d1ea9ba","updated":"2018-08-22 15:56:55.000000000","message":"Done","commit_id":"583ab7be0bf8e50854e059985d5d1e31f3fefcb3"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"11629e6d808bd1a4493cfaeedc9c2f5746b24f58","unresolved":false,"context_lines":[{"line_number":360,"context_line":"        if self.config.excluded_domain_ip:"},{"line_number":361,"context_line":"            LOG.info(\"Using excluded_domain_ip for\""},{"line_number":362,"context_line":"                     \"excluding domain IPs will be deprecated in the \""},{"line_number":363,"context_line":"                     \"Rocky release of OpenStack. Please use \""},{"line_number":364,"context_line":"                     \"excluded_domain_ips configuration option.\")"},{"line_number":365,"context_line":"            connection.excluded_domain_ips +\u003d self.config.excluded_domain_ip"},{"line_number":366,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"3f79a3b5_0df0e990","line":363,"range":{"start_line":363,"start_character":22,"end_line":363,"end_character":27},"updated":"2018-08-22 14:42:43.000000000","message":"Stein","commit_id":"583ab7be0bf8e50854e059985d5d1e31f3fefcb3"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"634dd2cba26343af9b354c1d0ebee66f5ab9de9f","unresolved":false,"context_lines":[{"line_number":360,"context_line":"        if self.config.excluded_domain_ip:"},{"line_number":361,"context_line":"            LOG.info(\"Using excluded_domain_ip for\""},{"line_number":362,"context_line":"                     \"excluding domain IPs will be deprecated in the \""},{"line_number":363,"context_line":"                     \"Rocky release of OpenStack. Please use \""},{"line_number":364,"context_line":"                     \"excluded_domain_ips configuration option.\")"},{"line_number":365,"context_line":"            connection.excluded_domain_ips +\u003d self.config.excluded_domain_ip"},{"line_number":366,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"3f79a3b5_be15594b","line":363,"range":{"start_line":363,"start_character":22,"end_line":363,"end_character":27},"in_reply_to":"3f79a3b5_0df0e990","updated":"2018-08-22 15:56:55.000000000","message":"Done","commit_id":"583ab7be0bf8e50854e059985d5d1e31f3fefcb3"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"abb1e33a79a765495738dc7079476e53acac27b6","unresolved":false,"context_lines":[{"line_number":360,"context_line":"        if self.config.excluded_domain_ip:"},{"line_number":361,"context_line":"            LOG.info(\"Using excluded_domain_ip for \""},{"line_number":362,"context_line":"                     \"excluding domain IPs is deprecated in the \""},{"line_number":363,"context_line":"                     \"Stien release of OpenStack. Please use \""},{"line_number":364,"context_line":"                     \"excluded_domain_ips configuration option.\")"},{"line_number":365,"context_line":"            connection.excluded_domain_ips +\u003d self.config.excluded_domain_ip"},{"line_number":366,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"3f79a3b5_84228bb8","line":363,"updated":"2018-08-22 19:06:34.000000000","message":"typo: Stein (not Stien)\n\ngrammar nit: Add \"the\" so it reads \"Please use the excluded_domain_ips configuration option.","commit_id":"25cd9f2a8ede6ecd28fad087f2b9dd32a3660c53"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"72973146140a1141b865430897a62ae1fe26d38a","unresolved":false,"context_lines":[{"line_number":360,"context_line":"        if self.config.excluded_domain_ip:"},{"line_number":361,"context_line":"            LOG.info(\"Using excluded_domain_ip for \""},{"line_number":362,"context_line":"                     \"excluding domain IPs is deprecated in the \""},{"line_number":363,"context_line":"                     \"Stien release of OpenStack. Please use \""},{"line_number":364,"context_line":"                     \"excluded_domain_ips configuration option.\")"},{"line_number":365,"context_line":"            connection.excluded_domain_ips +\u003d self.config.excluded_domain_ip"},{"line_number":366,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"3f79a3b5_bfa790bc","line":363,"in_reply_to":"3f79a3b5_84228bb8","updated":"2018-08-22 19:18:31.000000000","message":"Done","commit_id":"25cd9f2a8ede6ecd28fad087f2b9dd32a3660c53"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"abb1e33a79a765495738dc7079476e53acac27b6","unresolved":false,"context_lines":[{"line_number":447,"context_line":""},{"line_number":448,"context_line":"    \"\"\""},{"line_number":449,"context_line":""},{"line_number":450,"context_line":"    APIDRIVERVERSION \u003d \u00274.1.0\u0027"},{"line_number":451,"context_line":""},{"line_number":452,"context_line":"    def __init__(self, host, port, user, password, verify,"},{"line_number":453,"context_line":"                 asynctimeout, synctimeout, apiversion):"}],"source_content_type":"text/x-python","patch_set":11,"id":"3f79a3b5_1f2ec491","line":450,"updated":"2018-08-22 19:06:34.000000000","message":"4.1.1, yes?","commit_id":"25cd9f2a8ede6ecd28fad087f2b9dd32a3660c53"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"72973146140a1141b865430897a62ae1fe26d38a","unresolved":false,"context_lines":[{"line_number":447,"context_line":""},{"line_number":448,"context_line":"    \"\"\""},{"line_number":449,"context_line":""},{"line_number":450,"context_line":"    APIDRIVERVERSION \u003d \u00274.1.0\u0027"},{"line_number":451,"context_line":""},{"line_number":452,"context_line":"    def __init__(self, host, port, user, password, verify,"},{"line_number":453,"context_line":"                 asynctimeout, synctimeout, apiversion):"}],"source_content_type":"text/x-python","patch_set":11,"id":"3f79a3b5_7f95783f","line":450,"in_reply_to":"3f79a3b5_1f2ec491","updated":"2018-08-22 19:18:31.000000000","message":"Yes, good catch","commit_id":"25cd9f2a8ede6ecd28fad087f2b9dd32a3660c53"}],"cinder/volume/drivers/dell_emc/sc/storagecenter_common.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"fbe4a29a461729fa08db08322b87104565a8ccd6","unresolved":false,"context_lines":[{"line_number":70,"context_line":"                 help\u003d\u0027Fault Domain IP to be excluded from iSCSI returns.\u0027),"},{"line_number":71,"context_line":"    cfg.ListOpt(\u0027excluded_domain_ips\u0027,"},{"line_number":72,"context_line":"                item_type\u003dtypes.IPAddress(),"},{"line_number":73,"context_line":"                default\u003d[],"},{"line_number":74,"context_line":"                help\u003d\u0027Comma separated Fault Domain IPs to be excluded \u0027"},{"line_number":75,"context_line":"                     \u0027from iSCSI returns.\u0027),"},{"line_number":76,"context_line":"    cfg.StrOpt(\u0027dell_server_os\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_109e1007","line":73,"updated":"2018-05-18 19:34:22.000000000","message":"We are trying to reduce config options. Could we deprecate the MultiOpt option at the same time and just move everyone to using the new ListOpt one?","commit_id":"eb23b0f6eb1e4240c4a06f2a8f294ebc12a1a06d"}],"cinder/volume/drivers/dell_emc/sc/storagecenter_fc.py":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"abb1e33a79a765495738dc7079476e53acac27b6","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    \"\"\""},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    VERSION \u003d \u00274.1.0\u0027"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    CI_WIKI_NAME \u003d \"Dell_EMC_SC_Series_CI\""},{"line_number":73,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"3f79a3b5_df584c32","line":70,"updated":"2018-08-22 19:06:34.000000000","message":"4.1.1?","commit_id":"25cd9f2a8ede6ecd28fad087f2b9dd32a3660c53"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"72973146140a1141b865430897a62ae1fe26d38a","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    \"\"\""},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    VERSION \u003d \u00274.1.0\u0027"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    CI_WIKI_NAME \u003d \"Dell_EMC_SC_Series_CI\""},{"line_number":73,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"3f79a3b5_3f9b8073","line":70,"in_reply_to":"3f79a3b5_df584c32","updated":"2018-08-22 19:18:31.000000000","message":"Done","commit_id":"25cd9f2a8ede6ecd28fad087f2b9dd32a3660c53"}],"cinder/volume/drivers/dell_emc/sc/storagecenter_iscsi.py":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"abb1e33a79a765495738dc7079476e53acac27b6","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    \"\"\""},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    VERSION \u003d \u00274.1.0\u0027"},{"line_number":71,"context_line":"    CI_WIKI_NAME \u003d \"Dell_EMC_SC_Series_CI\""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def __init__(self, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":11,"id":"3f79a3b5_5f443c47","line":70,"updated":"2018-08-22 19:06:34.000000000","message":"4.1.1?","commit_id":"25cd9f2a8ede6ecd28fad087f2b9dd32a3660c53"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"72973146140a1141b865430897a62ae1fe26d38a","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    \"\"\""},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    VERSION \u003d \u00274.1.0\u0027"},{"line_number":71,"context_line":"    CI_WIKI_NAME \u003d \"Dell_EMC_SC_Series_CI\""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def __init__(self, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":11,"id":"3f79a3b5_ffb8a8c8","line":70,"in_reply_to":"3f79a3b5_5f443c47","updated":"2018-08-22 19:18:31.000000000","message":"Done","commit_id":"25cd9f2a8ede6ecd28fad087f2b9dd32a3660c53"}],"doc/source/configuration/block-storage/drivers/dell-storagecenter-driver.rst":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"fbe4a29a461729fa08db08322b87104565a8ccd6","unresolved":false,"context_lines":[{"line_number":380,"context_line":"    [dell]"},{"line_number":381,"context_line":"    excluded_domain_ips\u003d172.20.25.15,172.20.26.15"},{"line_number":382,"context_line":""},{"line_number":383,"context_line":"Note that the lists defined by these wo options will be combined into a single"},{"line_number":384,"context_line":"list."},{"line_number":385,"context_line":""},{"line_number":386,"context_line":"Setting Dell EMC SC REST API timeouts"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5f7c97a3_10b7f088","line":383,"range":{"start_line":383,"start_character":37,"end_line":383,"end_character":39},"updated":"2018-05-18 19:34:22.000000000","message":"two","commit_id":"eb23b0f6eb1e4240c4a06f2a8f294ebc12a1a06d"},{"author":{"_account_id":12112,"name":"Tom Swanson","email":"tom_swanson@dell.com","username":"tomswanson"},"change_message_id":"e71b9da0b703ab5106a97a795c7f6cbe4e2e1bfd","unresolved":false,"context_lines":[{"line_number":380,"context_line":"    [dell]"},{"line_number":381,"context_line":"    excluded_domain_ips\u003d172.20.25.15,172.20.26.15"},{"line_number":382,"context_line":""},{"line_number":383,"context_line":"Note that the lists defined by these wo options will be combined into a single"},{"line_number":384,"context_line":"list."},{"line_number":385,"context_line":""},{"line_number":386,"context_line":"Setting Dell EMC SC REST API timeouts"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5f7c97a3_a50a2e1d","line":383,"range":{"start_line":383,"start_character":37,"end_line":383,"end_character":39},"in_reply_to":"5f7c97a3_10b7f088","updated":"2018-05-24 22:43:05.000000000","message":"\u003e two\n\nI said wo, I meant wo.\n\nFixed.","commit_id":"eb23b0f6eb1e4240c4a06f2a8f294ebc12a1a06d"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"7f333d6aaa0b3200320c8655455f82e737a3c0ed","unresolved":false,"context_lines":[{"line_number":378,"context_line":".. code-block:: ini"},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"    [dell]"},{"line_number":381,"context_line":"    excluded_domain_ips\u003d172.20.25.15,172.20.26.15"},{"line_number":382,"context_line":""},{"line_number":383,"context_line":"Note that the lists defined by these two options will be combined into a single"},{"line_number":384,"context_line":"list."}],"source_content_type":"text/x-rst","patch_set":8,"id":"5f7c97a3_83e62f4a","line":381,"range":{"start_line":381,"start_character":3,"end_line":381,"end_character":49},"updated":"2018-06-19 15:50:08.000000000","message":"does it support space after comma?\nOr is it strict format?","commit_id":"9443e34a9c7e8c93e26e9e3c048a46065f63a9f4"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"845b559171c47e980fa959c05437319a3e189e4a","unresolved":false,"context_lines":[{"line_number":378,"context_line":".. code-block:: ini"},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"    [dell]"},{"line_number":381,"context_line":"    excluded_domain_ips\u003d172.20.25.15,172.20.26.15"},{"line_number":382,"context_line":""},{"line_number":383,"context_line":"Note that the lists defined by these two options will be combined into a single"},{"line_number":384,"context_line":"list."}],"source_content_type":"text/x-rst","patch_set":8,"id":"5f7c97a3_bec26233","line":381,"range":{"start_line":381,"start_character":3,"end_line":381,"end_character":49},"in_reply_to":"5f7c97a3_83e62f4a","updated":"2018-06-19 16:38:16.000000000","message":"Supports both. Its not strict. I will add a space for better readability","commit_id":"9443e34a9c7e8c93e26e9e3c048a46065f63a9f4"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"eb2f9af06646dc877530a8467599d2a999ec3b96","unresolved":false,"context_lines":[{"line_number":383,"context_line":"Note that the lists defined by these two options will be combined into a single"},{"line_number":384,"context_line":"list."},{"line_number":385,"context_line":""},{"line_number":386,"context_line":"The \u0027excluded_domain_ip\u0027 will be deprecated from Rocky, please use"},{"line_number":387,"context_line":"\u0027excluded_domain_ips\u0027 instead."},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"Setting Dell EMC SC REST API timeouts"}],"source_content_type":"text/x-rst","patch_set":10,"id":"3f79a3b5_8d1e395d","line":386,"range":{"start_line":386,"start_character":48,"end_line":386,"end_character":54},"updated":"2018-08-22 14:16:46.000000000","message":"This should now be updated to Stein.","commit_id":"583ab7be0bf8e50854e059985d5d1e31f3fefcb3"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"634dd2cba26343af9b354c1d0ebee66f5ab9de9f","unresolved":false,"context_lines":[{"line_number":383,"context_line":"Note that the lists defined by these two options will be combined into a single"},{"line_number":384,"context_line":"list."},{"line_number":385,"context_line":""},{"line_number":386,"context_line":"The \u0027excluded_domain_ip\u0027 will be deprecated from Rocky, please use"},{"line_number":387,"context_line":"\u0027excluded_domain_ips\u0027 instead."},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"Setting Dell EMC SC REST API timeouts"}],"source_content_type":"text/x-rst","patch_set":10,"id":"3f79a3b5_5e2525c1","line":386,"range":{"start_line":386,"start_character":48,"end_line":386,"end_character":54},"in_reply_to":"3f79a3b5_8d1e395d","updated":"2018-08-22 15:56:55.000000000","message":"Done","commit_id":"583ab7be0bf8e50854e059985d5d1e31f3fefcb3"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"abb1e33a79a765495738dc7079476e53acac27b6","unresolved":false,"context_lines":[{"line_number":371,"context_line":"    excluded_domain_ip\u003d172.20.25.15"},{"line_number":372,"context_line":"    excluded_domain_ip\u003d172.20.26.15"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"Alternately several domains can be excluded on a single line by specifying them"},{"line_number":375,"context_line":"in a comma separated list on the excluded_domain_ips option. The above would"},{"line_number":376,"context_line":"look like this."},{"line_number":377,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"3f79a3b5_9f95f489","line":374,"updated":"2018-08-22 19:06:34.000000000","message":"Given the fact that the original excluded_domain_ip option is deprecated, I think this section should emphasize the new option, and not refer to it \"alternatively.\"\n\nIn other words, this section should start by describing the new option. Then add something about the old option, including that it is deprecated.","commit_id":"25cd9f2a8ede6ecd28fad087f2b9dd32a3660c53"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"72973146140a1141b865430897a62ae1fe26d38a","unresolved":false,"context_lines":[{"line_number":371,"context_line":"    excluded_domain_ip\u003d172.20.25.15"},{"line_number":372,"context_line":"    excluded_domain_ip\u003d172.20.26.15"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"Alternately several domains can be excluded on a single line by specifying them"},{"line_number":375,"context_line":"in a comma separated list on the excluded_domain_ips option. The above would"},{"line_number":376,"context_line":"look like this."},{"line_number":377,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"3f79a3b5_5f42fcac","line":374,"in_reply_to":"3f79a3b5_9f95f489","updated":"2018-08-22 19:18:31.000000000","message":"Done","commit_id":"25cd9f2a8ede6ecd28fad087f2b9dd32a3660c53"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"33e9e33fe1da26d5a3abde37614546ba5a72218e","unresolved":false,"context_lines":[{"line_number":371,"context_line":"    excluded_domain_ip\u003d172.20.25.15"},{"line_number":372,"context_line":"    excluded_domain_ip\u003d172.20.26.15"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"The \u0027excluded_domain_ip\u0027 will be deprecated from Stein, please use the"},{"line_number":375,"context_line":"new option \u0027excluded_domain_ips\u0027 described below instead."},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"Several domains can be excluded on a single line by specifying them"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3f79a3b5_ff1ae87a","line":374,"updated":"2018-08-22 19:31:21.000000000","message":"Sorry, this isn\u0027t quite what I had in mind. The new option is introduced on L374, but that\u0027s after the old (deprecated) option has been described on L365. I don\u0027t think this section (titled on L353) should lead by describing a deprecated option.\n\nI think the paragraph starting on L360 should be updated to refer to the new option, and L377..L384 should also be moved up. Don\u0027t mention the existence of the deprecated option until after the new one has been fully documented.","commit_id":"54131fdc38d30354028bc73be3e9ab572d33dbde"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"4aa497ea3bb7aea8cbc6c3f240b15a83c39105f6","unresolved":false,"context_lines":[{"line_number":371,"context_line":"    excluded_domain_ip\u003d172.20.25.15"},{"line_number":372,"context_line":"    excluded_domain_ip\u003d172.20.26.15"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"The \u0027excluded_domain_ip\u0027 will be deprecated from Stein, please use the"},{"line_number":375,"context_line":"new option \u0027excluded_domain_ips\u0027 described below instead."},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"Several domains can be excluded on a single line by specifying them"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3f79a3b5_fa0516c3","line":374,"in_reply_to":"3f79a3b5_ff1ae87a","updated":"2018-08-22 19:43:24.000000000","message":"Good point. I removed the deprecated option as a whole and updated the doc to mention only the new option","commit_id":"54131fdc38d30354028bc73be3e9ab572d33dbde"}],"releasenotes/notes/Dell-SC-excluded_domain_ips_ListOpt-51bacddee199ce83.yaml":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"f4425cf8c500b77021d92644e3de319b358ba057","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Added an excluded_domain_ips option to the Dell EMC SC driver. This"},{"line_number":4,"context_line":"    is identical to the excluded_domain_ip option only comma separated"},{"line_number":5,"context_line":"    rather than multiple entry. This is concatenated with the"},{"line_number":6,"context_line":"    excluded_domain_ip option."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"5f7c97a3_c3dd2214","line":3,"range":{"start_line":3,"start_character":13,"end_line":3,"end_character":32},"updated":"2018-06-18 19:27:28.000000000","message":"If you need to do an update, please put these config options in `` so they get formatted in the output.","commit_id":"9443e34a9c7e8c93e26e9e3c048a46065f63a9f4"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"845b559171c47e980fa959c05437319a3e189e4a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Added an excluded_domain_ips option to the Dell EMC SC driver. This"},{"line_number":4,"context_line":"    is identical to the excluded_domain_ip option only comma separated"},{"line_number":5,"context_line":"    rather than multiple entry. This is concatenated with the"},{"line_number":6,"context_line":"    excluded_domain_ip option."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"5f7c97a3_7eda8a1d","line":3,"range":{"start_line":3,"start_character":13,"end_line":3,"end_character":32},"in_reply_to":"5f7c97a3_c3dd2214","updated":"2018-06-19 16:38:16.000000000","message":"Done","commit_id":"9443e34a9c7e8c93e26e9e3c048a46065f63a9f4"}]}