)]}'
{"cinder/volume/drivers/ibm/ibm_storage/ds8k_proxy.py":[{"author":{"_account_id":11186,"name":"yixuan zhang","email":"yixuan_z@hotmail.com","username":"yixuanzhang"},"change_message_id":"0c6ab34446d457e6d0198a8de11b69b64cf1a874","unresolved":false,"context_lines":[{"line_number":467,"context_line":"                         % self.configuration.volume_backend_name))"},{"line_number":468,"context_line":"        else:"},{"line_number":469,"context_line":"            storage_pools \u003d self._helper.get_pools()"},{"line_number":470,"context_line":"            self._helper.update_storage_pools(storage_pools)"},{"line_number":471,"context_line":"        stats \u003d {"},{"line_number":472,"context_line":"            \"volume_backend_name\":"},{"line_number":473,"context_line":"                self.configuration.volume_backend_name,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_796fa8fb","line":470,"updated":"2018-05-14 08:25:50.000000000","message":"If storage_pools is None. the self._storage_pools will be updated to None.\nThere will be Error if you use the self._storage_pools directly.","commit_id":"3949d2ad767af5838f266f95176cb23a63b2b051"},{"author":{"_account_id":26422,"name":"Peng Wang","email":"wangpww@cn.ibm.com","username":"wangpeng"},"change_message_id":"9acd625bb89cbf1a8d51f28cbaa435143cca6410","unresolved":false,"context_lines":[{"line_number":467,"context_line":"                         % self.configuration.volume_backend_name))"},{"line_number":468,"context_line":"        else:"},{"line_number":469,"context_line":"            storage_pools \u003d self._helper.get_pools()"},{"line_number":470,"context_line":"            self._helper.update_storage_pools(storage_pools)"},{"line_number":471,"context_line":"        stats \u003d {"},{"line_number":472,"context_line":"            \"volume_backend_name\":"},{"line_number":473,"context_line":"                self.configuration.volume_backend_name,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_7486cf15","line":470,"in_reply_to":"5f7c97a3_796fa8fb","updated":"2018-05-14 12:59:19.000000000","message":"Thanks, it will be addressed in the new patch","commit_id":"3949d2ad767af5838f266f95176cb23a63b2b051"},{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"e59ab8f9760c78d679bfdf3057d12fca0c272321","unresolved":false,"context_lines":[{"line_number":486,"context_line":"            \"free_capacity_gb\": 0,"},{"line_number":487,"context_line":"            \"backend_state\": \u0027up\u0027"},{"line_number":488,"context_line":"        }"},{"line_number":489,"context_line":"        if not len(storage_pools):"},{"line_number":490,"context_line":"            msg \u003d _(\u0027No pools found - make sure san_clustername \u0027"},{"line_number":491,"context_line":"                    \u0027is defined in the config file and that the \u0027"},{"line_number":492,"context_line":"                    \u0027pools exist on the storage.\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_2026d5cf","line":489,"updated":"2018-05-14 05:37:54.000000000","message":"It Should not check for length of storage_pools after L469??\n\nNO cinder exception will be raised now as in the old file L470??\n\nThanks.","commit_id":"3949d2ad767af5838f266f95176cb23a63b2b051"},{"author":{"_account_id":26422,"name":"Peng Wang","email":"wangpww@cn.ibm.com","username":"wangpeng"},"change_message_id":"76bae821d892be298c24e43f228d68959c4c66fe","unresolved":false,"context_lines":[{"line_number":486,"context_line":"            \"free_capacity_gb\": 0,"},{"line_number":487,"context_line":"            \"backend_state\": \u0027up\u0027"},{"line_number":488,"context_line":"        }"},{"line_number":489,"context_line":"        if not len(storage_pools):"},{"line_number":490,"context_line":"            msg \u003d _(\u0027No pools found - make sure san_clustername \u0027"},{"line_number":491,"context_line":"                    \u0027is defined in the config file and that the \u0027"},{"line_number":492,"context_line":"                    \u0027pools exist on the storage.\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_56807bbf","line":489,"in_reply_to":"5f7c97a3_2026d5cf","updated":"2018-05-14 07:23:39.000000000","message":"Before supportting \"report backend status\", if cinder can not get any pool from the storage, an exception need to throw. After supporting this feature, driver just need to report the backend_state is \u0027down\u0027. Then cinder will set the related status in service-list. So the exception was removed.","commit_id":"3949d2ad767af5838f266f95176cb23a63b2b051"}]}