)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"1363f22c6948ee910fcd06a4491dfb209b3cf5fe","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"It looks like rbd.py sometimes gets some bytes, not strings, probably"},{"line_number":10,"context_line":"this happens with the latest version of Ceph, and that\u0027s an issue only"},{"line_number":11,"context_line":"with Python 3. I\u0027m not sure why, but what I know, is that it\u0027s completely"},{"line_number":12,"context_line":"breaking Debian with Python 3 and ceph Luminous release."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Convert byte buffers coming from Ceph to strings."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5f7c97a3_530100af","line":12,"range":{"start_line":11,"start_character":15,"end_line":12,"end_character":56},"updated":"2018-05-18 08:02:06.000000000","message":"nit: I\u0027m not sure this part is really necessary","commit_id":"d156030338ba10980b85704602e5085fffb32124"}],"cinder/tests/unit/volume/drivers/test_rbd.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"1363f22c6948ee910fcd06a4491dfb209b3cf5fe","unresolved":false,"context_lines":[{"line_number":1332,"context_line":"        self.assertEqual((free_capacity, total_capacity), result)"},{"line_number":1333,"context_line":""},{"line_number":1334,"context_line":"    @common_mocks"},{"line_number":1335,"context_line":"    def test_get_pool_bytes(self, free_capacity\u003d1.56, total_capacity\u003d3.0,"},{"line_number":1336,"context_line":"                            dynamic_total\u003dTrue):"},{"line_number":1337,"context_line":"        \"\"\"test for mon_commands returning bytes instead of str\"\"\""},{"line_number":1338,"context_line":"        client \u003d self.mock_client.return_value"},{"line_number":1339,"context_line":"        client.__enter__.return_value \u003d client"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_73b43c36","line":1336,"range":{"start_line":1335,"start_character":34,"end_line":1336,"end_character":48},"updated":"2018-05-18 08:02:06.000000000","message":"nit: I think these should go inside the test and not here.","commit_id":"d156030338ba10980b85704602e5085fffb32124"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"1363f22c6948ee910fcd06a4491dfb209b3cf5fe","unresolved":false,"context_lines":[{"line_number":1347,"context_line":"            (0, b\u0027{\"pool_name\":\"volumes\",\"pool_id\":4,\"quota_max_objects\":0,\u0027"},{"line_number":1348,"context_line":"             b\u0027\"quota_max_bytes\":3221225472}\\n\u0027, \u0027\u0027),"},{"line_number":1349,"context_line":"        ]"},{"line_number":1350,"context_line":"        with mock.patch.object(self.driver.configuration, \u0027safe_get\u0027,"},{"line_number":1351,"context_line":"                               return_value\u003ddynamic_total):"},{"line_number":1352,"context_line":"            result \u003d self.driver._get_pool_stats()"},{"line_number":1353,"context_line":"        client.cluster.mon_command.assert_has_calls(["},{"line_number":1354,"context_line":"            mock.call(\u0027{\"prefix\":\"df\", \"format\":\"json\"}\u0027, \u0027\u0027),"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_93c47894","line":1351,"range":{"start_line":1350,"start_character":0,"end_line":1351,"end_character":59},"updated":"2018-05-18 08:02:06.000000000","message":"-1: If we are doing this to set \"report_dynamic_total_capacity\" we don\u0027t need to, because the default is already True, and if we want to be explicit about it we should be setting the configuration option instead, as it\u0027s more clear:\n\n self.override_config(\u0027report_dynamic_total_capacity\u0027, True)","commit_id":"d156030338ba10980b85704602e5085fffb32124"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"9042a27205da4b2d6aecb1f2d838a5aa56361b17","unresolved":false,"context_lines":[{"line_number":1347,"context_line":"            (0, b\u0027{\"pool_name\":\"volumes\",\"pool_id\":4,\"quota_max_objects\":0,\u0027"},{"line_number":1348,"context_line":"             b\u0027\"quota_max_bytes\":3221225472}\\n\u0027, \u0027\u0027),"},{"line_number":1349,"context_line":"        ]"},{"line_number":1350,"context_line":"        with mock.patch.object(self.driver.configuration, \u0027safe_get\u0027,"},{"line_number":1351,"context_line":"                               return_value\u003ddynamic_total):"},{"line_number":1352,"context_line":"            result \u003d self.driver._get_pool_stats()"},{"line_number":1353,"context_line":"        client.cluster.mon_command.assert_has_calls(["},{"line_number":1354,"context_line":"            mock.call(\u0027{\"prefix\":\"df\", \"format\":\"json\"}\u0027, \u0027\u0027),"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_04376eb2","line":1351,"range":{"start_line":1350,"start_character":0,"end_line":1351,"end_character":59},"in_reply_to":"5f7c97a3_0373ff81","updated":"2018-05-24 08:02:41.000000000","message":"For that test I did the exact same thing. I copied it from another test and nobody complained.  So we keep perpetuating the same mistake.  ;-)\n\nI\u0027ll change my vote to a +1, but I still think this should be changed.","commit_id":"d156030338ba10980b85704602e5085fffb32124"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"654649edc4bbabe28817e5249d416c0273e6c58a","unresolved":false,"context_lines":[{"line_number":1347,"context_line":"            (0, b\u0027{\"pool_name\":\"volumes\",\"pool_id\":4,\"quota_max_objects\":0,\u0027"},{"line_number":1348,"context_line":"             b\u0027\"quota_max_bytes\":3221225472}\\n\u0027, \u0027\u0027),"},{"line_number":1349,"context_line":"        ]"},{"line_number":1350,"context_line":"        with mock.patch.object(self.driver.configuration, \u0027safe_get\u0027,"},{"line_number":1351,"context_line":"                               return_value\u003ddynamic_total):"},{"line_number":1352,"context_line":"            result \u003d self.driver._get_pool_stats()"},{"line_number":1353,"context_line":"        client.cluster.mon_command.assert_has_calls(["},{"line_number":1354,"context_line":"            mock.call(\u0027{\"prefix\":\"df\", \"format\":\"json\"}\u0027, \u0027\u0027),"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_9ea613c0","line":1351,"range":{"start_line":1350,"start_character":0,"end_line":1351,"end_character":59},"in_reply_to":"5f7c97a3_04376eb2","updated":"2018-06-25 21:41:46.000000000","message":"It actually needs to be overridden in test_get_pool because that test uses ddt to pass in different possible values for the dynamic_total.\n\nI don\u0027t think override_config can be used either as it may be possible for two of these ddt\u0027d test cases to be run at the same time and a global override interfering with each other. That appears to be the case in the local test I did.","commit_id":"d156030338ba10980b85704602e5085fffb32124"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"6c358f4c112a1f0580be5e1d977051ec7b91bf21","unresolved":false,"context_lines":[{"line_number":1347,"context_line":"            (0, b\u0027{\"pool_name\":\"volumes\",\"pool_id\":4,\"quota_max_objects\":0,\u0027"},{"line_number":1348,"context_line":"             b\u0027\"quota_max_bytes\":3221225472}\\n\u0027, \u0027\u0027),"},{"line_number":1349,"context_line":"        ]"},{"line_number":1350,"context_line":"        with mock.patch.object(self.driver.configuration, \u0027safe_get\u0027,"},{"line_number":1351,"context_line":"                               return_value\u003ddynamic_total):"},{"line_number":1352,"context_line":"            result \u003d self.driver._get_pool_stats()"},{"line_number":1353,"context_line":"        client.cluster.mon_command.assert_has_calls(["},{"line_number":1354,"context_line":"            mock.call(\u0027{\"prefix\":\"df\", \"format\":\"json\"}\u0027, \u0027\u0027),"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_0373ff81","line":1351,"range":{"start_line":1350,"start_character":0,"end_line":1351,"end_character":59},"in_reply_to":"5f7c97a3_93c47894","updated":"2018-05-22 15:43:53.000000000","message":"This was just copied from the test above (test_get_pool).  Should we remove it there too?","commit_id":"d156030338ba10980b85704602e5085fffb32124"}]}