)]}'
{"cinder/volume/drivers/ibm/storwize_svc/storwize_svc_common.py":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"b3288bb5b0d76fb78cb0df68ba352604452e422d","unresolved":false,"context_lines":[{"line_number":1494,"context_line":"        if opts[\u0027warning\u0027] !\u003d 0:"},{"line_number":1495,"context_line":"            msg \u003d (_(\u0027You cannot specify -warning for thin-provisioned or \u0027"},{"line_number":1496,"context_line":"                     \u0027compressed volume that are in data reduction \u0027"},{"line_number":1497,"context_line":"                     \u0027pools.The configured warning is \u0027"},{"line_number":1498,"context_line":"                     \u0027%s.\u0027) % opts[\u0027warning\u0027])"},{"line_number":1499,"context_line":"            raise exception.VolumeDriverException(message\u003dmsg)"},{"line_number":1500,"context_line":"        if not opts[\u0027easytier\u0027]:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_9d87b513","line":1497,"range":{"start_line":1497,"start_character":27,"end_line":1497,"end_character":29},"updated":"2018-06-04 19:12:17.000000000","message":"missing space after \u0027.\u0027","commit_id":"7a2e4b73a54d88c5348af75c131152a94e6df8c8"},{"author":{"_account_id":11186,"name":"yixuan zhang","email":"yixuan_z@hotmail.com","username":"yixuanzhang"},"change_message_id":"50666e5b1790161732ffabe315e81794adba2969","unresolved":false,"context_lines":[{"line_number":1494,"context_line":"        if opts[\u0027warning\u0027] !\u003d 0:"},{"line_number":1495,"context_line":"            msg \u003d (_(\u0027You cannot specify -warning for thin-provisioned or \u0027"},{"line_number":1496,"context_line":"                     \u0027compressed volume that are in data reduction \u0027"},{"line_number":1497,"context_line":"                     \u0027pools.The configured warning is \u0027"},{"line_number":1498,"context_line":"                     \u0027%s.\u0027) % opts[\u0027warning\u0027])"},{"line_number":1499,"context_line":"            raise exception.VolumeDriverException(message\u003dmsg)"},{"line_number":1500,"context_line":"        if not opts[\u0027easytier\u0027]:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_bea32b00","line":1497,"range":{"start_line":1497,"start_character":27,"end_line":1497,"end_character":29},"in_reply_to":"5f7c97a3_9d87b513","updated":"2018-06-08 02:48:52.000000000","message":"Hi Jay, thanks a lot for your comments, it is addressed in the new patch.","commit_id":"7a2e4b73a54d88c5348af75c131152a94e6df8c8"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"b3288bb5b0d76fb78cb0df68ba352604452e422d","unresolved":false,"context_lines":[{"line_number":1506,"context_line":"        if opts[\u0027grainsize\u0027] !\u003d 256 and opts[\u0027grainsize\u0027] !\u003d 8:"},{"line_number":1507,"context_line":"            msg \u003d (_(\u0027You cannot specify -grainsize for thin-provisioned \u0027"},{"line_number":1508,"context_line":"                     \u0027or compressed volume that are in data reduction \u0027"},{"line_number":1509,"context_line":"                     \u0027pools.This type of volume will be created with a \u0027"},{"line_number":1510,"context_line":"                     \u0027grainsize of 8 KB. The configured grainsize is \u0027"},{"line_number":1511,"context_line":"                     \u0027%s.\u0027) % opts[\u0027grainsize\u0027])"},{"line_number":1512,"context_line":"            raise exception.VolumeDriverException(message\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_1d7ba529","line":1509,"range":{"start_line":1509,"start_character":27,"end_line":1509,"end_character":29},"updated":"2018-06-04 19:12:17.000000000","message":"missing space after \u0027.\u0027","commit_id":"7a2e4b73a54d88c5348af75c131152a94e6df8c8"},{"author":{"_account_id":11186,"name":"yixuan zhang","email":"yixuan_z@hotmail.com","username":"yixuanzhang"},"change_message_id":"50666e5b1790161732ffabe315e81794adba2969","unresolved":false,"context_lines":[{"line_number":1506,"context_line":"        if opts[\u0027grainsize\u0027] !\u003d 256 and opts[\u0027grainsize\u0027] !\u003d 8:"},{"line_number":1507,"context_line":"            msg \u003d (_(\u0027You cannot specify -grainsize for thin-provisioned \u0027"},{"line_number":1508,"context_line":"                     \u0027or compressed volume that are in data reduction \u0027"},{"line_number":1509,"context_line":"                     \u0027pools.This type of volume will be created with a \u0027"},{"line_number":1510,"context_line":"                     \u0027grainsize of 8 KB. The configured grainsize is \u0027"},{"line_number":1511,"context_line":"                     \u0027%s.\u0027) % opts[\u0027grainsize\u0027])"},{"line_number":1512,"context_line":"            raise exception.VolumeDriverException(message\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_3eb71b3d","line":1509,"range":{"start_line":1509,"start_character":27,"end_line":1509,"end_character":29},"in_reply_to":"5f7c97a3_1d7ba529","updated":"2018-06-08 02:48:52.000000000","message":"Done","commit_id":"7a2e4b73a54d88c5348af75c131152a94e6df8c8"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"b3288bb5b0d76fb78cb0df68ba352604452e422d","unresolved":false,"context_lines":[{"line_number":1526,"context_line":"                         \u0027is %s.\u0027) % opts[\u0027rsize\u0027])"},{"line_number":1527,"context_line":"                raise exception.VolumeDriverException(message\u003dmsg)"},{"line_number":1528,"context_line":"        if not opts[\u0027autoexpand\u0027]:"},{"line_number":1529,"context_line":"            msg \u003d (_(\u0027The volume is in data reduction pools, The \u0027"},{"line_number":1530,"context_line":"                     \u0027autoexpand must be enabled. The configured \u0027"},{"line_number":1531,"context_line":"                     \u0027autoexpand is %s.\u0027) % opts[\u0027autoexpand\u0027])"},{"line_number":1532,"context_line":"            raise exception.VolumeDriverException(message\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_fd710946","line":1529,"range":{"start_line":1529,"start_character":54,"end_line":1529,"end_character":60},"updated":"2018-06-04 19:12:17.000000000","message":"replace \u0027,\u0027 with \u0027.\u0027","commit_id":"7a2e4b73a54d88c5348af75c131152a94e6df8c8"},{"author":{"_account_id":11186,"name":"yixuan zhang","email":"yixuan_z@hotmail.com","username":"yixuanzhang"},"change_message_id":"50666e5b1790161732ffabe315e81794adba2969","unresolved":false,"context_lines":[{"line_number":1526,"context_line":"                         \u0027is %s.\u0027) % opts[\u0027rsize\u0027])"},{"line_number":1527,"context_line":"                raise exception.VolumeDriverException(message\u003dmsg)"},{"line_number":1528,"context_line":"        if not opts[\u0027autoexpand\u0027]:"},{"line_number":1529,"context_line":"            msg \u003d (_(\u0027The volume is in data reduction pools, The \u0027"},{"line_number":1530,"context_line":"                     \u0027autoexpand must be enabled. The configured \u0027"},{"line_number":1531,"context_line":"                     \u0027autoexpand is %s.\u0027) % opts[\u0027autoexpand\u0027])"},{"line_number":1532,"context_line":"            raise exception.VolumeDriverException(message\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_5eb2174b","line":1529,"range":{"start_line":1529,"start_character":54,"end_line":1529,"end_character":60},"in_reply_to":"5f7c97a3_fd710946","updated":"2018-06-08 02:48:52.000000000","message":"Done","commit_id":"7a2e4b73a54d88c5348af75c131152a94e6df8c8"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"b3288bb5b0d76fb78cb0df68ba352604452e422d","unresolved":false,"context_lines":[{"line_number":1533,"context_line":"        else:"},{"line_number":1534,"context_line":"            LOG.info(\u0027You cannot specify warning, grainsize, and \u0027"},{"line_number":1535,"context_line":"                     \u0027easytier for thin-provisioned or compressed\u0027"},{"line_number":1536,"context_line":"                     \u0027 volumes that are in data reduction pools.\u0027"},{"line_number":1537,"context_line":"                     \u0027The rsize parameter will be ignored, the \u0027"},{"line_number":1538,"context_line":"                     \u0027autoexpand must be enabled.\u0027)"},{"line_number":1539,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_bd915149","line":1536,"range":{"start_line":1536,"start_character":63,"end_line":1536,"end_character":65},"updated":"2018-06-04 19:12:17.000000000","message":"missing space at EOL","commit_id":"7a2e4b73a54d88c5348af75c131152a94e6df8c8"},{"author":{"_account_id":11186,"name":"yixuan zhang","email":"yixuan_z@hotmail.com","username":"yixuanzhang"},"change_message_id":"50666e5b1790161732ffabe315e81794adba2969","unresolved":false,"context_lines":[{"line_number":1533,"context_line":"        else:"},{"line_number":1534,"context_line":"            LOG.info(\u0027You cannot specify warning, grainsize, and \u0027"},{"line_number":1535,"context_line":"                     \u0027easytier for thin-provisioned or compressed\u0027"},{"line_number":1536,"context_line":"                     \u0027 volumes that are in data reduction pools.\u0027"},{"line_number":1537,"context_line":"                     \u0027The rsize parameter will be ignored, the \u0027"},{"line_number":1538,"context_line":"                     \u0027autoexpand must be enabled.\u0027)"},{"line_number":1539,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_1e86df66","line":1536,"range":{"start_line":1536,"start_character":63,"end_line":1536,"end_character":65},"in_reply_to":"5f7c97a3_bd915149","updated":"2018-06-08 02:48:52.000000000","message":"Done","commit_id":"7a2e4b73a54d88c5348af75c131152a94e6df8c8"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"b3288bb5b0d76fb78cb0df68ba352604452e422d","unresolved":false,"context_lines":[{"line_number":4412,"context_line":"                if (self._helpers.is_data_reduction_pool(src_pool) or"},{"line_number":4413,"context_line":"                        self._helpers.is_data_reduction_pool(mirror_pool)):"},{"line_number":4414,"context_line":"                    msg \u003d _(\u0027Unable to migrate: the thin-provisioned or \u0027"},{"line_number":4415,"context_line":"                            \u0027compressed volume can not be migrated from a date\u0027"},{"line_number":4416,"context_line":"                            \u0027 reduction pool. \u0027)"},{"line_number":4417,"context_line":"                    raise exception.VolumeDriverException(message\u003dmsg)"},{"line_number":4418,"context_line":"                elif self._helpers.is_data_reduction_pool(dest_pool):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_3d9d4157","line":4415,"range":{"start_line":4415,"start_character":74,"end_line":4415,"end_character":78},"updated":"2018-06-04 19:12:17.000000000","message":"data","commit_id":"7a2e4b73a54d88c5348af75c131152a94e6df8c8"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"60189cb51b9c1e5c8a6a07a16cb0f2daf02907ae","unresolved":false,"context_lines":[{"line_number":1541,"context_line":"    def is_volume_type_dr_pools(self, pool, opts, rep_type\u003dNone,"},{"line_number":1542,"context_line":"                                rep_target_pool\u003dNone):"},{"line_number":1543,"context_line":"        \"\"\"Check every configured pools is data reduction pool.\"\"\""},{"line_number":1544,"context_line":"        is_dr_pool \u003d False"},{"line_number":1545,"context_line":"        if self.is_data_reduction_pool(pool):"},{"line_number":1546,"context_line":"            is_dr_pool \u003d True"},{"line_number":1547,"context_line":"            LOG.debug(\u0027The configured pool %s is a data reduction pool.\u0027, pool)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_0f03c243","line":1544,"range":{"start_line":1544,"start_character":8,"end_line":1544,"end_character":19},"updated":"2018-06-12 10:09:56.000000000","message":"We don\u0027t need this variable at all","commit_id":"1c19fc7ae5040a3e0cb914e1626ee8e5c93f7e66"},{"author":{"_account_id":11186,"name":"yixuan zhang","email":"yixuan_z@hotmail.com","username":"yixuanzhang"},"change_message_id":"90873c8d27d48e118e6e5b6f9807dd1163d80f12","unresolved":false,"context_lines":[{"line_number":1541,"context_line":"    def is_volume_type_dr_pools(self, pool, opts, rep_type\u003dNone,"},{"line_number":1542,"context_line":"                                rep_target_pool\u003dNone):"},{"line_number":1543,"context_line":"        \"\"\"Check every configured pools is data reduction pool.\"\"\""},{"line_number":1544,"context_line":"        is_dr_pool \u003d False"},{"line_number":1545,"context_line":"        if self.is_data_reduction_pool(pool):"},{"line_number":1546,"context_line":"            is_dr_pool \u003d True"},{"line_number":1547,"context_line":"            LOG.debug(\u0027The configured pool %s is a data reduction pool.\u0027, pool)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_cc06e1ce","line":1544,"range":{"start_line":1544,"start_character":8,"end_line":1544,"end_character":19},"in_reply_to":"5f7c97a3_0f03c243","updated":"2018-06-15 09:34:37.000000000","message":"Hi Ivan, thanks a lot for your comments, it is addressed in the new patch.","commit_id":"1c19fc7ae5040a3e0cb914e1626ee8e5c93f7e66"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"60189cb51b9c1e5c8a6a07a16cb0f2daf02907ae","unresolved":false,"context_lines":[{"line_number":1544,"context_line":"        is_dr_pool \u003d False"},{"line_number":1545,"context_line":"        if self.is_data_reduction_pool(pool):"},{"line_number":1546,"context_line":"            is_dr_pool \u003d True"},{"line_number":1547,"context_line":"            LOG.debug(\u0027The configured pool %s is a data reduction pool.\u0027, pool)"},{"line_number":1548,"context_line":""},{"line_number":1549,"context_line":"        elif opts[\u0027mirror_pool\u0027] and self.is_data_reduction_pool("},{"line_number":1550,"context_line":"                opts[\u0027mirror_pool\u0027]):"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_cff86a4b","line":1547,"updated":"2018-06-12 10:09:56.000000000","message":"It\u0027s enough to have \u0027return True\u0027 here","commit_id":"1c19fc7ae5040a3e0cb914e1626ee8e5c93f7e66"},{"author":{"_account_id":11186,"name":"yixuan zhang","email":"yixuan_z@hotmail.com","username":"yixuanzhang"},"change_message_id":"90873c8d27d48e118e6e5b6f9807dd1163d80f12","unresolved":false,"context_lines":[{"line_number":1544,"context_line":"        is_dr_pool \u003d False"},{"line_number":1545,"context_line":"        if self.is_data_reduction_pool(pool):"},{"line_number":1546,"context_line":"            is_dr_pool \u003d True"},{"line_number":1547,"context_line":"            LOG.debug(\u0027The configured pool %s is a data reduction pool.\u0027, pool)"},{"line_number":1548,"context_line":""},{"line_number":1549,"context_line":"        elif opts[\u0027mirror_pool\u0027] and self.is_data_reduction_pool("},{"line_number":1550,"context_line":"                opts[\u0027mirror_pool\u0027]):"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_4cf2d1e5","line":1547,"in_reply_to":"5f7c97a3_cff86a4b","updated":"2018-06-15 09:34:37.000000000","message":"Done","commit_id":"1c19fc7ae5040a3e0cb914e1626ee8e5c93f7e66"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"60189cb51b9c1e5c8a6a07a16cb0f2daf02907ae","unresolved":false,"context_lines":[{"line_number":1563,"context_line":"            LOG.debug(\u0027The replica target pool %s is a data reduction pool.\u0027,"},{"line_number":1564,"context_line":"                      rep_target_pool)"},{"line_number":1565,"context_line":""},{"line_number":1566,"context_line":"        return is_dr_pool"},{"line_number":1567,"context_line":""},{"line_number":1568,"context_line":"    @staticmethod"},{"line_number":1569,"context_line":"    def _get_vdisk_create_params(opts, is_dr_pool, add_copies\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_eff52652","line":1566,"updated":"2018-06-12 10:09:56.000000000","message":"It\u0027s enough to have \u0027return False\u0027 here","commit_id":"1c19fc7ae5040a3e0cb914e1626ee8e5c93f7e66"},{"author":{"_account_id":11186,"name":"yixuan zhang","email":"yixuan_z@hotmail.com","username":"yixuanzhang"},"change_message_id":"90873c8d27d48e118e6e5b6f9807dd1163d80f12","unresolved":false,"context_lines":[{"line_number":1563,"context_line":"            LOG.debug(\u0027The replica target pool %s is a data reduction pool.\u0027,"},{"line_number":1564,"context_line":"                      rep_target_pool)"},{"line_number":1565,"context_line":""},{"line_number":1566,"context_line":"        return is_dr_pool"},{"line_number":1567,"context_line":""},{"line_number":1568,"context_line":"    @staticmethod"},{"line_number":1569,"context_line":"    def _get_vdisk_create_params(opts, is_dr_pool, add_copies\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_0cfcd9b3","line":1566,"in_reply_to":"5f7c97a3_eff52652","updated":"2018-06-15 09:34:37.000000000","message":"Done","commit_id":"1c19fc7ae5040a3e0cb914e1626ee8e5c93f7e66"}]}