)]}'
{"cinder/message/message_field.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"95a85c4ce5a808d833eb3a1dcb1db3f4323df235","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        _(\"Nova failed to perform extend volume event.\"))"},{"line_number":76,"context_line":"    DRIVER_FAILED_EXTEND \u003d ("},{"line_number":77,"context_line":"        \u0027010\u0027,"},{"line_number":78,"context_line":"        _(\"Driver failed to extend volume.\"))"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    ALL \u003d (UNKNOWN_ERROR,"},{"line_number":81,"context_line":"           DRIVER_NOT_INITIALIZED,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_9a239fa7","line":78,"updated":"2018-05-29 19:37:53.000000000","message":"This should indicate \"Volume driver\" rather than just \"Driver\".","commit_id":"e86f55f48aba493f05aff31bf6048634d699f0b9"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"5f0e708b4e4596fd4583e3a16d460f94f27bfd5f","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        _(\"Unmanaging encrypted volumes is not supported.\"))"},{"line_number":73,"context_line":"    NOTIFY_NOVA_FAILED \u003d ("},{"line_number":74,"context_line":"        \u0027009\u0027,"},{"line_number":75,"context_line":"        _(\"Nova failed to perform extend volume event.\"))"},{"line_number":76,"context_line":"    DRIVER_FAILED_EXTEND \u003d ("},{"line_number":77,"context_line":"        \u0027010\u0027,"},{"line_number":78,"context_line":"        _(\"Volume Driver failed to extend volume.\"))"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_93c7fc96","line":75,"updated":"2018-05-30 14:07:51.000000000","message":"Should this messaging refer to something more generic than Nova like Compute Service?  I\u0027m wondering about reuse for Ironic...","commit_id":"ef1e474919ee819a470840da50824690e025ef62"}],"cinder/scheduler/manager.py":[{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"58fb652beca553e6c2089f5be3b2ba152863f27b","unresolved":false,"context_lines":[{"line_number":451,"context_line":"            QUOTAS.rollback(context, reservations,"},{"line_number":452,"context_line":"                            project_id\u003dvolume.project_id)"},{"line_number":453,"context_line":"            _extend_volume_set_error(self, context, ex, request_spec)"},{"line_number":454,"context_line":"            self.message_api.create("},{"line_number":455,"context_line":"                context,"},{"line_number":456,"context_line":"                message_field.Action.EXTEND_VOLUME,"},{"line_number":457,"context_line":"                resource_uuid\u003dvolume.id,"},{"line_number":458,"context_line":"                exception\u003dex)"},{"line_number":459,"context_line":""},{"line_number":460,"context_line":"    def _set_volume_state_and_notify(self, method, updates, context, ex,"},{"line_number":461,"context_line":"                                     request_spec, msg\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_09fb90bd","line":458,"range":{"start_line":454,"start_character":0,"end_line":458,"end_character":29},"updated":"2018-06-01 13:54:32.000000000","message":"-1: You should add this in the _set_volume_state_and_notify function, so, other operations like migrate, retype, etc also get proper user errors.","commit_id":"3aec5274da29c81c76bb7f87317160e32f9780ff"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"a2ae9f64627927399ab90499e241cf99272f3f86","unresolved":false,"context_lines":[{"line_number":451,"context_line":"            QUOTAS.rollback(context, reservations,"},{"line_number":452,"context_line":"                            project_id\u003dvolume.project_id)"},{"line_number":453,"context_line":"            _extend_volume_set_error(self, context, ex, request_spec)"},{"line_number":454,"context_line":"            self.message_api.create("},{"line_number":455,"context_line":"                context,"},{"line_number":456,"context_line":"                message_field.Action.EXTEND_VOLUME,"},{"line_number":457,"context_line":"                resource_uuid\u003dvolume.id,"},{"line_number":458,"context_line":"                exception\u003dex)"},{"line_number":459,"context_line":""},{"line_number":460,"context_line":"    def _set_volume_state_and_notify(self, method, updates, context, ex,"},{"line_number":461,"context_line":"                                     request_spec, msg\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_6911cdaf","line":458,"range":{"start_line":454,"start_character":0,"end_line":458,"end_character":29},"in_reply_to":"5f7c97a3_09fb90bd","updated":"2018-06-04 03:06:46.000000000","message":"Yeah, we could move this into the set and notify method, which can benefits several different actions, but considering we have to add three more parameters(message.action, message.detail and resource id) to this util method as well as we still need to define more constants when adding user message support for migrate, retype I personally would prefer to leave as it is.:)","commit_id":"3aec5274da29c81c76bb7f87317160e32f9780ff"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"c9d5cac063649910ab0cb4a15ee395af88a231e6","unresolved":false,"context_lines":[{"line_number":451,"context_line":"            QUOTAS.rollback(context, reservations,"},{"line_number":452,"context_line":"                            project_id\u003dvolume.project_id)"},{"line_number":453,"context_line":"            _extend_volume_set_error(self, context, ex, request_spec)"},{"line_number":454,"context_line":"            self.message_api.create("},{"line_number":455,"context_line":"                context,"},{"line_number":456,"context_line":"                message_field.Action.EXTEND_VOLUME,"},{"line_number":457,"context_line":"                resource_uuid\u003dvolume.id,"},{"line_number":458,"context_line":"                exception\u003dex)"},{"line_number":459,"context_line":""},{"line_number":460,"context_line":"    def _set_volume_state_and_notify(self, method, updates, context, ex,"},{"line_number":461,"context_line":"                                     request_spec, msg\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_78598733","line":458,"range":{"start_line":454,"start_character":0,"end_line":458,"end_character":29},"in_reply_to":"5f7c97a3_6911cdaf","updated":"2018-06-04 19:56:14.000000000","message":"Hmm, ok, that would work as well. We can work on improve the other messages in a later time.","commit_id":"3aec5274da29c81c76bb7f87317160e32f9780ff"}]}