)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"4d026e53218e028266c5b09a238cb02396c7d483","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Silvan Kaiser \u003csilvan@quobyte.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-05-30 18:43:56 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[WIP] Add _context to online snapshots in remotefs driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fetches _context from obj_context property during online snapshots"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5f7c97a3_598071be","line":7,"updated":"2018-07-10 13:52:31.000000000","message":"Should update the summary line to match the code","commit_id":"f4d2473d6118b641de1bd4d0eed20eee6c84a9a2"}],"cinder/volume/driver.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"38ef89f091ca102c621caadddca6a80fd16148c8","unresolved":false,"context_lines":[{"line_number":1318,"context_line":"        temp_vol_ref \u003d self._create_temp_volume(context, volume)"},{"line_number":1319,"context_line":"        try:"},{"line_number":1320,"context_line":"            # NOTE(kaisers): add context to volume, req. by remotefs driver"},{"line_number":1321,"context_line":"            volume.context \u003d context"},{"line_number":1322,"context_line":"            model_update \u003d self.create_cloned_volume(temp_vol_ref, volume)"},{"line_number":1323,"context_line":"            if model_update:"},{"line_number":1324,"context_line":"                temp_vol_ref.update(model_update)"}],"source_content_type":"text/x-python","patch_set":17,"id":"5fc1f717_bd846f0c","line":1321,"updated":"2019-04-05 14:11:17.000000000","message":"volume here should be an object that already has a context associated with it.  If not, we need to fix this further up the stack somewhere.","commit_id":"e1b6782adf9d1499267ad3c2951d02e308a7c04d"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"9cb2d2a57a14ea507544f838b0cc4cb0f0e2ab06","unresolved":false,"context_lines":[{"line_number":1318,"context_line":"        temp_vol_ref \u003d self._create_temp_volume(context, volume)"},{"line_number":1319,"context_line":"        try:"},{"line_number":1320,"context_line":"            # NOTE(kaisers): add context to volume, req. by remotefs driver"},{"line_number":1321,"context_line":"            volume.context \u003d context"},{"line_number":1322,"context_line":"            model_update \u003d self.create_cloned_volume(temp_vol_ref, volume)"},{"line_number":1323,"context_line":"            if model_update:"},{"line_number":1324,"context_line":"                temp_vol_ref.update(model_update)"}],"source_content_type":"text/x-python","patch_set":17,"id":"3fce034c_168f002b","line":1321,"in_reply_to":"5fc1f717_bd846f0c","updated":"2019-04-12 10:39:02.000000000","message":"Moved this to the object fetching in line 1191.","commit_id":"e1b6782adf9d1499267ad3c2951d02e308a7c04d"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"00b70478c4f24341addf40928f2a22150321c157","unresolved":false,"context_lines":[{"line_number":1189,"context_line":"        \"\"\""},{"line_number":1190,"context_line":"        volume \u003d objects.Volume.get_by_id(context, backup.volume_id)"},{"line_number":1191,"context_line":"        # NOTE(kaisers): add context to volume, req. by remotefs driver"},{"line_number":1192,"context_line":"        volume.context \u003d context"},{"line_number":1193,"context_line":"        snapshot \u003d None"},{"line_number":1194,"context_line":"        if backup.snapshot_id:"},{"line_number":1195,"context_line":"            snapshot \u003d objects.Snapshot.get_by_id(context, backup.snapshot_id)"}],"source_content_type":"text/x-python","patch_set":23,"id":"9fb8cfa7_71563a5f","line":1192,"updated":"2019-06-07 14:21:33.000000000","message":"This still isn\u0027t the right way to do this -- if this is a volume object returned by Volume.get_by_id(), we can just use volume.obj_context() rather than adding context into the object manually like this.","commit_id":"33046411a3d7fbc30bac700886c6fd461642178e"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"fd3cc59df4bdb9f1ec3ac4a677b41a8185c10606","unresolved":false,"context_lines":[{"line_number":1189,"context_line":"        \"\"\""},{"line_number":1190,"context_line":"        volume \u003d objects.Volume.get_by_id(context, backup.volume_id)"},{"line_number":1191,"context_line":"        # NOTE(kaisers): add context to volume, req. by remotefs driver"},{"line_number":1192,"context_line":"        volume.context \u003d context"},{"line_number":1193,"context_line":"        snapshot \u003d None"},{"line_number":1194,"context_line":"        if backup.snapshot_id:"},{"line_number":1195,"context_line":"            snapshot \u003d objects.Snapshot.get_by_id(context, backup.snapshot_id)"}],"source_content_type":"text/x-python","patch_set":23,"id":"9fb8cfa7_b36a4c7e","line":1192,"in_reply_to":"9fb8cfa7_71563a5f","updated":"2019-06-11 07:54:17.000000000","message":"Done","commit_id":"33046411a3d7fbc30bac700886c6fd461642178e"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"3ba1e11797d6488281ecb61227313990a173a6e6","unresolved":false,"context_lines":[{"line_number":1312,"context_line":"        kwargs.update(volume_options or {})"},{"line_number":1313,"context_line":"        temp_vol_ref \u003d objects.Volume(context\u003dcontext.elevated(), **kwargs)"},{"line_number":1314,"context_line":"        temp_vol_ref.create()"},{"line_number":1315,"context_line":"        temp_vol_ref.context \u003d context"},{"line_number":1316,"context_line":"        return temp_vol_ref"},{"line_number":1317,"context_line":""},{"line_number":1318,"context_line":"    def _create_temp_cloned_volume(self, context, volume):"}],"source_content_type":"text/x-python","patch_set":25,"id":"9fb8cfa7_33ab6ad6","line":1315,"range":{"start_line":1315,"start_character":8,"end_line":1315,"end_character":28},"updated":"2019-07-01 18:24:57.000000000","message":"Shouldn\u0027t this not be needed now? The point of using the obj_context field was to avoid manually adding this...","commit_id":"6897a33a22072c294816aa71284da73ef7755015"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"054ce4c87926b466cf532cf2bdb204f100c58f01","unresolved":false,"context_lines":[{"line_number":1312,"context_line":"        kwargs.update(volume_options or {})"},{"line_number":1313,"context_line":"        temp_vol_ref \u003d objects.Volume(context\u003dcontext.elevated(), **kwargs)"},{"line_number":1314,"context_line":"        temp_vol_ref.create()"},{"line_number":1315,"context_line":"        temp_vol_ref.context \u003d context"},{"line_number":1316,"context_line":"        return temp_vol_ref"},{"line_number":1317,"context_line":""},{"line_number":1318,"context_line":"    def _create_temp_cloned_volume(self, context, volume):"}],"source_content_type":"text/x-python","patch_set":25,"id":"7faddb67_823144a5","line":1315,"range":{"start_line":1315,"start_character":8,"end_line":1315,"end_character":28},"in_reply_to":"9fb8cfa7_33ab6ad6","updated":"2019-07-10 08:41:55.000000000","message":"Done","commit_id":"6897a33a22072c294816aa71284da73ef7755015"}],"cinder/volume/drivers/quobyte.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"df76daabacef280cee13c03fe22273c5b5fcc3fa","unresolved":false,"context_lines":[{"line_number":315,"context_line":"            force_share\u003dTrue)"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"    @utils.synchronized(\u0027quobyte\u0027, external\u003dFalse)"},{"line_number":318,"context_line":"    def create_cloned_volume(self, volume, src_vref, context):"},{"line_number":319,"context_line":"        \"\"\"Creates a clone of the specified volume.\"\"\""},{"line_number":320,"context_line":"        return self._create_cloned_volume(volume, src_vref, context)"},{"line_number":321,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"9fdfeff1_f3c6d649","line":318,"range":{"start_line":318,"start_character":51,"end_line":318,"end_character":60},"updated":"2019-01-24 06:09:41.000000000","message":"can we move this as the second parameter (after self) to maintain consistency with other functions.","commit_id":"29c73ef8cddf3e952328c14302c72ec4a57768f6"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"00b70478c4f24341addf40928f2a22150321c157","unresolved":false,"context_lines":[{"line_number":325,"context_line":"    @utils.synchronized(\u0027quobyte\u0027, external\u003dFalse)"},{"line_number":326,"context_line":"    def create_cloned_volume(self, volume, src_vref):"},{"line_number":327,"context_line":"        \"\"\"Creates a clone of the specified volume.\"\"\""},{"line_number":328,"context_line":"        return self._create_cloned_volume(volume, src_vref, src_vref.context)"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"    @coordination.synchronized("},{"line_number":331,"context_line":"        \u0027{self.driver_prefix}-{snapshot.id}-{volume.id}\u0027)"}],"source_content_type":"text/x-python","patch_set":23,"id":"9fb8cfa7_11cb3e1e","line":328,"range":{"start_line":328,"start_character":60,"end_line":328,"end_character":76},"updated":"2019-06-07 14:21:33.000000000","message":"src_vref.obj_context() ?","commit_id":"33046411a3d7fbc30bac700886c6fd461642178e"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"fd3cc59df4bdb9f1ec3ac4a677b41a8185c10606","unresolved":false,"context_lines":[{"line_number":325,"context_line":"    @utils.synchronized(\u0027quobyte\u0027, external\u003dFalse)"},{"line_number":326,"context_line":"    def create_cloned_volume(self, volume, src_vref):"},{"line_number":327,"context_line":"        \"\"\"Creates a clone of the specified volume.\"\"\""},{"line_number":328,"context_line":"        return self._create_cloned_volume(volume, src_vref, src_vref.context)"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"    @coordination.synchronized("},{"line_number":331,"context_line":"        \u0027{self.driver_prefix}-{snapshot.id}-{volume.id}\u0027)"}],"source_content_type":"text/x-python","patch_set":23,"id":"9fb8cfa7_730614d1","line":328,"range":{"start_line":328,"start_character":60,"end_line":328,"end_character":76},"in_reply_to":"9fb8cfa7_11cb3e1e","updated":"2019-06-11 07:54:17.000000000","message":"Done","commit_id":"33046411a3d7fbc30bac700886c6fd461642178e"}],"cinder/volume/drivers/remotefs.py":[{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"3b4b1799de3d01d34cfba69217b8e7e12d6ec622","unresolved":false,"context_lines":[{"line_number":1039,"context_line":"                self._snapshots_exist(src_vref)):"},{"line_number":1040,"context_line":"            snap_attrs \u003d [\u0027volume_name\u0027, \u0027volume_size\u0027, \u0027name\u0027,"},{"line_number":1041,"context_line":"                          \u0027volume_id\u0027, \u0027id\u0027, \u0027volume\u0027, \u0027_context\u0027]"},{"line_number":1042,"context_line":"            Snapshot \u003d collections.namedtuple(\u0027Snapshot\u0027, snap_attrs)"},{"line_number":1043,"context_line":"            temp_snapshot \u003d Snapshot(volume_name\u003dvolume_name,"},{"line_number":1044,"context_line":"                                     volume_size\u003dsrc_vref.size,"},{"line_number":1045,"context_line":"                                     name\u003d\u0027clone-snap-%s\u0027 % src_vref.id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_e379dac4","line":1042,"updated":"2018-05-29 10:23:42.000000000","message":"Issue: namedtuple creation is not working as this class does not accept underscore led field names. I\u0027m currently looking for a solution to build the tuple w/o the namedtuple crapping out because of the _context field name.\n\nCIs should show this issue in their logs once this is run.","commit_id":"f49bd95fbf0c81b96e333e011f1b4e614b34aa86"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"734dd04ab1396bcb7c8a0186e00fe43f4bb51989","unresolved":false,"context_lines":[{"line_number":1039,"context_line":"                self._snapshots_exist(src_vref)):"},{"line_number":1040,"context_line":"            snap_attrs \u003d [\u0027volume_name\u0027, \u0027volume_size\u0027, \u0027name\u0027,"},{"line_number":1041,"context_line":"                          \u0027volume_id\u0027, \u0027id\u0027, \u0027volume\u0027, \u0027_context\u0027]"},{"line_number":1042,"context_line":"            Snapshot \u003d collections.namedtuple(\u0027Snapshot\u0027, snap_attrs)"},{"line_number":1043,"context_line":"            temp_snapshot \u003d Snapshot(volume_name\u003dvolume_name,"},{"line_number":1044,"context_line":"                                     volume_size\u003dsrc_vref.size,"},{"line_number":1045,"context_line":"                                     name\u003d\u0027clone-snap-%s\u0027 % src_vref.id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_482b06ea","line":1042,"in_reply_to":"5f7c97a3_9e515d39","updated":"2018-05-29 13:53:33.000000000","message":"As \u0027src_vref\u0027 contains the \u0027_context\u0027 and is handed through as \u0027volume\u0027, couldn\u0027t we simply use that down in \u0027_create_snapshot_online\u0027?","commit_id":"f49bd95fbf0c81b96e333e011f1b4e614b34aa86"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"03e55f1d0e910fa5e2eacbb444365f94ff5f86b3","unresolved":false,"context_lines":[{"line_number":1039,"context_line":"                self._snapshots_exist(src_vref)):"},{"line_number":1040,"context_line":"            snap_attrs \u003d [\u0027volume_name\u0027, \u0027volume_size\u0027, \u0027name\u0027,"},{"line_number":1041,"context_line":"                          \u0027volume_id\u0027, \u0027id\u0027, \u0027volume\u0027, \u0027_context\u0027]"},{"line_number":1042,"context_line":"            Snapshot \u003d collections.namedtuple(\u0027Snapshot\u0027, snap_attrs)"},{"line_number":1043,"context_line":"            temp_snapshot \u003d Snapshot(volume_name\u003dvolume_name,"},{"line_number":1044,"context_line":"                                     volume_size\u003dsrc_vref.size,"},{"line_number":1045,"context_line":"                                     name\u003d\u0027clone-snap-%s\u0027 % src_vref.id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_9e515d39","line":1042,"in_reply_to":"5f7c97a3_e379dac4","updated":"2018-05-29 11:24:34.000000000","message":"There is another solution that we can make it an explicit argument for the method \u0027_create_snapshot_online\u0027, anyway it\u0027s already been specified in the method \u0027_delete_snapshot_online\u0027 [1].\n\n[1]: https://github.com/openstack/cinder/blob/5dcf4f52ada36b98d08584cd31a55698006d9e35/cinder/volume/drivers/remotefs.py#L1517","commit_id":"f49bd95fbf0c81b96e333e011f1b4e614b34aa86"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"bd21e1a2cce5cd6eada76484ad655c1a1bb46486","unresolved":false,"context_lines":[{"line_number":1445,"context_line":"    def _create_snapshot_online(self, snapshot, backing_filename,"},{"line_number":1446,"context_line":"                                new_snap_path):"},{"line_number":1447,"context_line":"        # Perform online snapshot via Nova"},{"line_number":1448,"context_line":"        context \u003d snapshot.volume._context"},{"line_number":1449,"context_line":""},{"line_number":1450,"context_line":"        self._do_create_snapshot(snapshot,"},{"line_number":1451,"context_line":"                                 backing_filename,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_5c62e83f","line":1448,"range":{"start_line":1448,"start_character":18,"end_line":1448,"end_character":42},"updated":"2018-05-29 17:32:59.000000000","message":"I think this can be snapshot.obj_context().","commit_id":"db846680428fef253d5d444fac8842a58d7508fc"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"332d751607b4586ef7133ba609a9b8832915aa47","unresolved":false,"context_lines":[{"line_number":1445,"context_line":"    def _create_snapshot_online(self, snapshot, backing_filename,"},{"line_number":1446,"context_line":"                                new_snap_path):"},{"line_number":1447,"context_line":"        # Perform online snapshot via Nova"},{"line_number":1448,"context_line":"        context \u003d snapshot.volume._context"},{"line_number":1449,"context_line":""},{"line_number":1450,"context_line":"        self._do_create_snapshot(snapshot,"},{"line_number":1451,"context_line":"                                 backing_filename,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_2197aeee","line":1448,"range":{"start_line":1448,"start_character":18,"end_line":1448,"end_character":42},"in_reply_to":"5f7c97a3_5c62e83f","updated":"2018-05-30 16:13:09.000000000","message":"Done","commit_id":"db846680428fef253d5d444fac8842a58d7508fc"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"00b70478c4f24341addf40928f2a22150321c157","unresolved":false,"context_lines":[{"line_number":1069,"context_line":"            temp_snapshot \u003d objects.Snapshot(context\u003dcontext,"},{"line_number":1070,"context_line":"                                             **kwargs)"},{"line_number":1071,"context_line":"            temp_snapshot.create()"},{"line_number":1072,"context_line":"            temp_snapshot.context \u003d context"},{"line_number":1073,"context_line":""},{"line_number":1074,"context_line":"            self._create_snapshot(temp_snapshot)"},{"line_number":1075,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":23,"id":"9fb8cfa7_91d64ec3","line":1072,"updated":"2019-06-07 14:21:33.000000000","message":"Should not be needed, can use temp_snapshot.obj_context() like I mentioned for the volume object above.","commit_id":"33046411a3d7fbc30bac700886c6fd461642178e"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"fd3cc59df4bdb9f1ec3ac4a677b41a8185c10606","unresolved":false,"context_lines":[{"line_number":1069,"context_line":"            temp_snapshot \u003d objects.Snapshot(context\u003dcontext,"},{"line_number":1070,"context_line":"                                             **kwargs)"},{"line_number":1071,"context_line":"            temp_snapshot.create()"},{"line_number":1072,"context_line":"            temp_snapshot.context \u003d context"},{"line_number":1073,"context_line":""},{"line_number":1074,"context_line":"            self._create_snapshot(temp_snapshot)"},{"line_number":1075,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":23,"id":"9fb8cfa7_769cc2bf","line":1072,"in_reply_to":"9fb8cfa7_91d64ec3","updated":"2019-06-11 07:54:17.000000000","message":"Done","commit_id":"33046411a3d7fbc30bac700886c6fd461642178e"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"fd3cc59df4bdb9f1ec3ac4a677b41a8185c10606","unresolved":false,"context_lines":[{"line_number":1078,"context_line":"                                                volume.size)"},{"line_number":1079,"context_line":"                # remove temp snapshot after the cloning is done"},{"line_number":1080,"context_line":"                temp_snapshot.status \u003d fields.SnapshotStatus.DELETING"},{"line_number":1081,"context_line":"                temp_snapshot.context \u003d context.elevated()"},{"line_number":1082,"context_line":"                temp_snapshot.save()"},{"line_number":1083,"context_line":"            finally:"},{"line_number":1084,"context_line":"                self._delete_snapshot(temp_snapshot)"}],"source_content_type":"text/x-python","patch_set":23,"id":"9fb8cfa7_d6b24e49","line":1081,"updated":"2019-06-11 07:54:17.000000000","message":"@Eric: I\u0027m unsure, is there a replacement here, too.\nIiuc the elevated context is required removing the snapshot.","commit_id":"33046411a3d7fbc30bac700886c6fd461642178e"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"a25c908e2501afcfcc9c8720962acc0ce8aecb83","unresolved":false,"context_lines":[{"line_number":1053,"context_line":"                self._snapshots_exist(src_vref)):"},{"line_number":1054,"context_line":"            kwargs \u003d {"},{"line_number":1055,"context_line":"                \u0027volume_id\u0027: src_vref.id,"},{"line_number":1056,"context_line":"                \u0027cgsnapshot_id\u0027: None,"},{"line_number":1057,"context_line":"                \u0027user_id\u0027: context.user_id,"},{"line_number":1058,"context_line":"                \u0027project_id\u0027: context.project_id,"},{"line_number":1059,"context_line":"                \u0027status\u0027: fields.SnapshotStatus.CREATING,"}],"source_content_type":"text/x-python","patch_set":25,"id":"9fb8cfa7_33660aef","line":1056,"range":{"start_line":1056,"start_character":16,"end_line":1056,"end_character":37},"updated":"2019-07-01 18:23:20.000000000","message":"unneeded?","commit_id":"6897a33a22072c294816aa71284da73ef7755015"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"054ce4c87926b466cf532cf2bdb204f100c58f01","unresolved":false,"context_lines":[{"line_number":1053,"context_line":"                self._snapshots_exist(src_vref)):"},{"line_number":1054,"context_line":"            kwargs \u003d {"},{"line_number":1055,"context_line":"                \u0027volume_id\u0027: src_vref.id,"},{"line_number":1056,"context_line":"                \u0027cgsnapshot_id\u0027: None,"},{"line_number":1057,"context_line":"                \u0027user_id\u0027: context.user_id,"},{"line_number":1058,"context_line":"                \u0027project_id\u0027: context.project_id,"},{"line_number":1059,"context_line":"                \u0027status\u0027: fields.SnapshotStatus.CREATING,"}],"source_content_type":"text/x-python","patch_set":25,"id":"7faddb67_62d3e839","line":1056,"range":{"start_line":1056,"start_character":16,"end_line":1056,"end_character":37},"in_reply_to":"9fb8cfa7_33660aef","updated":"2019-07-10 08:41:55.000000000","message":"Done","commit_id":"6897a33a22072c294816aa71284da73ef7755015"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"a25c908e2501afcfcc9c8720962acc0ce8aecb83","unresolved":false,"context_lines":[{"line_number":1058,"context_line":"                \u0027project_id\u0027: context.project_id,"},{"line_number":1059,"context_line":"                \u0027status\u0027: fields.SnapshotStatus.CREATING,"},{"line_number":1060,"context_line":"                \u0027progress\u0027: \u00270%\u0027,"},{"line_number":1061,"context_line":"                \u0027volume_size\u0027: src_vref[\u0027size\u0027],"},{"line_number":1062,"context_line":"                \u0027display_name\u0027: \u0027tmp-snap-%s\u0027 % src_vref[\u0027id\u0027],"},{"line_number":1063,"context_line":"                \u0027display_description\u0027: None,"},{"line_number":1064,"context_line":"                \u0027volume_type_id\u0027: src_vref[\u0027volume_type_id\u0027],"}],"source_content_type":"text/x-python","patch_set":25,"id":"9fb8cfa7_934ed66c","line":1061,"range":{"start_line":1061,"start_character":31,"end_line":1061,"end_character":47},"updated":"2019-07-01 18:23:20.000000000","message":"Should use\n    src_vref.size\ninstead of the dict view.","commit_id":"6897a33a22072c294816aa71284da73ef7755015"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"054ce4c87926b466cf532cf2bdb204f100c58f01","unresolved":false,"context_lines":[{"line_number":1058,"context_line":"                \u0027project_id\u0027: context.project_id,"},{"line_number":1059,"context_line":"                \u0027status\u0027: fields.SnapshotStatus.CREATING,"},{"line_number":1060,"context_line":"                \u0027progress\u0027: \u00270%\u0027,"},{"line_number":1061,"context_line":"                \u0027volume_size\u0027: src_vref[\u0027size\u0027],"},{"line_number":1062,"context_line":"                \u0027display_name\u0027: \u0027tmp-snap-%s\u0027 % src_vref[\u0027id\u0027],"},{"line_number":1063,"context_line":"                \u0027display_description\u0027: None,"},{"line_number":1064,"context_line":"                \u0027volume_type_id\u0027: src_vref[\u0027volume_type_id\u0027],"}],"source_content_type":"text/x-python","patch_set":25,"id":"7faddb67_c2165cf2","line":1061,"range":{"start_line":1061,"start_character":31,"end_line":1061,"end_character":47},"in_reply_to":"9fb8cfa7_934ed66c","updated":"2019-07-10 08:41:55.000000000","message":"Done","commit_id":"6897a33a22072c294816aa71284da73ef7755015"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"a25c908e2501afcfcc9c8720962acc0ce8aecb83","unresolved":false,"context_lines":[{"line_number":1059,"context_line":"                \u0027status\u0027: fields.SnapshotStatus.CREATING,"},{"line_number":1060,"context_line":"                \u0027progress\u0027: \u00270%\u0027,"},{"line_number":1061,"context_line":"                \u0027volume_size\u0027: src_vref[\u0027size\u0027],"},{"line_number":1062,"context_line":"                \u0027display_name\u0027: \u0027tmp-snap-%s\u0027 % src_vref[\u0027id\u0027],"},{"line_number":1063,"context_line":"                \u0027display_description\u0027: None,"},{"line_number":1064,"context_line":"                \u0027volume_type_id\u0027: src_vref[\u0027volume_type_id\u0027],"},{"line_number":1065,"context_line":"                \u0027encryption_key_id\u0027: src_vref["}],"source_content_type":"text/x-python","patch_set":25,"id":"9fb8cfa7_b3519a10","line":1062,"range":{"start_line":1062,"start_character":48,"end_line":1062,"end_character":62},"updated":"2019-07-01 18:23:20.000000000","message":"src_vref.id","commit_id":"6897a33a22072c294816aa71284da73ef7755015"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"054ce4c87926b466cf532cf2bdb204f100c58f01","unresolved":false,"context_lines":[{"line_number":1059,"context_line":"                \u0027status\u0027: fields.SnapshotStatus.CREATING,"},{"line_number":1060,"context_line":"                \u0027progress\u0027: \u00270%\u0027,"},{"line_number":1061,"context_line":"                \u0027volume_size\u0027: src_vref[\u0027size\u0027],"},{"line_number":1062,"context_line":"                \u0027display_name\u0027: \u0027tmp-snap-%s\u0027 % src_vref[\u0027id\u0027],"},{"line_number":1063,"context_line":"                \u0027display_description\u0027: None,"},{"line_number":1064,"context_line":"                \u0027volume_type_id\u0027: src_vref[\u0027volume_type_id\u0027],"},{"line_number":1065,"context_line":"                \u0027encryption_key_id\u0027: src_vref["}],"source_content_type":"text/x-python","patch_set":25,"id":"7faddb67_a21b2019","line":1062,"range":{"start_line":1062,"start_character":48,"end_line":1062,"end_character":62},"in_reply_to":"9fb8cfa7_b3519a10","updated":"2019-07-10 08:41:55.000000000","message":"Done","commit_id":"6897a33a22072c294816aa71284da73ef7755015"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"a25c908e2501afcfcc9c8720962acc0ce8aecb83","unresolved":false,"context_lines":[{"line_number":1061,"context_line":"                \u0027volume_size\u0027: src_vref[\u0027size\u0027],"},{"line_number":1062,"context_line":"                \u0027display_name\u0027: \u0027tmp-snap-%s\u0027 % src_vref[\u0027id\u0027],"},{"line_number":1063,"context_line":"                \u0027display_description\u0027: None,"},{"line_number":1064,"context_line":"                \u0027volume_type_id\u0027: src_vref[\u0027volume_type_id\u0027],"},{"line_number":1065,"context_line":"                \u0027encryption_key_id\u0027: src_vref["},{"line_number":1066,"context_line":"                    \u0027encryption_key_id\u0027],"},{"line_number":1067,"context_line":"                \u0027metadata\u0027: {},"}],"source_content_type":"text/x-python","patch_set":25,"id":"9fb8cfa7_7357a202","line":1064,"range":{"start_line":1064,"start_character":34,"end_line":1064,"end_character":60},"updated":"2019-07-01 18:23:20.000000000","message":"src_vref.volume_type_id","commit_id":"6897a33a22072c294816aa71284da73ef7755015"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"054ce4c87926b466cf532cf2bdb204f100c58f01","unresolved":false,"context_lines":[{"line_number":1061,"context_line":"                \u0027volume_size\u0027: src_vref[\u0027size\u0027],"},{"line_number":1062,"context_line":"                \u0027display_name\u0027: \u0027tmp-snap-%s\u0027 % src_vref[\u0027id\u0027],"},{"line_number":1063,"context_line":"                \u0027display_description\u0027: None,"},{"line_number":1064,"context_line":"                \u0027volume_type_id\u0027: src_vref[\u0027volume_type_id\u0027],"},{"line_number":1065,"context_line":"                \u0027encryption_key_id\u0027: src_vref["},{"line_number":1066,"context_line":"                    \u0027encryption_key_id\u0027],"},{"line_number":1067,"context_line":"                \u0027metadata\u0027: {},"}],"source_content_type":"text/x-python","patch_set":25,"id":"7faddb67_021d540e","line":1064,"range":{"start_line":1064,"start_character":34,"end_line":1064,"end_character":60},"in_reply_to":"9fb8cfa7_7357a202","updated":"2019-07-10 08:41:55.000000000","message":"Done","commit_id":"6897a33a22072c294816aa71284da73ef7755015"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"a25c908e2501afcfcc9c8720962acc0ce8aecb83","unresolved":false,"context_lines":[{"line_number":1062,"context_line":"                \u0027display_name\u0027: \u0027tmp-snap-%s\u0027 % src_vref[\u0027id\u0027],"},{"line_number":1063,"context_line":"                \u0027display_description\u0027: None,"},{"line_number":1064,"context_line":"                \u0027volume_type_id\u0027: src_vref[\u0027volume_type_id\u0027],"},{"line_number":1065,"context_line":"                \u0027encryption_key_id\u0027: src_vref["},{"line_number":1066,"context_line":"                    \u0027encryption_key_id\u0027],"},{"line_number":1067,"context_line":"                \u0027metadata\u0027: {},"},{"line_number":1068,"context_line":"            }"},{"line_number":1069,"context_line":"            temp_snapshot \u003d objects.Snapshot(context\u003dcontext,"}],"source_content_type":"text/x-python","patch_set":25,"id":"9fb8cfa7_f342b23a","line":1066,"range":{"start_line":1065,"start_character":37,"end_line":1066,"end_character":40},"updated":"2019-07-01 18:23:20.000000000","message":"src_vref.encryption_key_id","commit_id":"6897a33a22072c294816aa71284da73ef7755015"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"054ce4c87926b466cf532cf2bdb204f100c58f01","unresolved":false,"context_lines":[{"line_number":1062,"context_line":"                \u0027display_name\u0027: \u0027tmp-snap-%s\u0027 % src_vref[\u0027id\u0027],"},{"line_number":1063,"context_line":"                \u0027display_description\u0027: None,"},{"line_number":1064,"context_line":"                \u0027volume_type_id\u0027: src_vref[\u0027volume_type_id\u0027],"},{"line_number":1065,"context_line":"                \u0027encryption_key_id\u0027: src_vref["},{"line_number":1066,"context_line":"                    \u0027encryption_key_id\u0027],"},{"line_number":1067,"context_line":"                \u0027metadata\u0027: {},"},{"line_number":1068,"context_line":"            }"},{"line_number":1069,"context_line":"            temp_snapshot \u003d objects.Snapshot(context\u003dcontext,"}],"source_content_type":"text/x-python","patch_set":25,"id":"7faddb67_e221184f","line":1066,"range":{"start_line":1065,"start_character":37,"end_line":1066,"end_character":40},"in_reply_to":"9fb8cfa7_f342b23a","updated":"2019-07-10 08:41:55.000000000","message":"Done","commit_id":"6897a33a22072c294816aa71284da73ef7755015"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"a25c908e2501afcfcc9c8720962acc0ce8aecb83","unresolved":false,"context_lines":[{"line_number":1064,"context_line":"                \u0027volume_type_id\u0027: src_vref[\u0027volume_type_id\u0027],"},{"line_number":1065,"context_line":"                \u0027encryption_key_id\u0027: src_vref["},{"line_number":1066,"context_line":"                    \u0027encryption_key_id\u0027],"},{"line_number":1067,"context_line":"                \u0027metadata\u0027: {},"},{"line_number":1068,"context_line":"            }"},{"line_number":1069,"context_line":"            temp_snapshot \u003d objects.Snapshot(context\u003dcontext,"},{"line_number":1070,"context_line":"                                             **kwargs)"}],"source_content_type":"text/x-python","patch_set":25,"id":"9fb8cfa7_536dbec9","line":1067,"range":{"start_line":1067,"start_character":16,"end_line":1067,"end_character":30},"updated":"2019-07-01 18:23:20.000000000","message":"unneeded?","commit_id":"6897a33a22072c294816aa71284da73ef7755015"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"054ce4c87926b466cf532cf2bdb204f100c58f01","unresolved":false,"context_lines":[{"line_number":1064,"context_line":"                \u0027volume_type_id\u0027: src_vref[\u0027volume_type_id\u0027],"},{"line_number":1065,"context_line":"                \u0027encryption_key_id\u0027: src_vref["},{"line_number":1066,"context_line":"                    \u0027encryption_key_id\u0027],"},{"line_number":1067,"context_line":"                \u0027metadata\u0027: {},"},{"line_number":1068,"context_line":"            }"},{"line_number":1069,"context_line":"            temp_snapshot \u003d objects.Snapshot(context\u003dcontext,"},{"line_number":1070,"context_line":"                                             **kwargs)"}],"source_content_type":"text/x-python","patch_set":25,"id":"7faddb67_422b4c2f","line":1067,"range":{"start_line":1067,"start_character":16,"end_line":1067,"end_character":30},"in_reply_to":"9fb8cfa7_536dbec9","updated":"2019-07-10 08:41:55.000000000","message":"Done","commit_id":"6897a33a22072c294816aa71284da73ef7755015"}]}