)]}'
{"cinder/scheduler/base_weight.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"9f5b673876630b992eeabed1693559d4c5714011","unresolved":false,"context_lines":[{"line_number":146,"context_line":"                obj \u003d weighed_objs[i]"},{"line_number":147,"context_line":"                obj.weight +\u003d weigher.weight_multiplier() * weight"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"            LOG.debug(\"Filter %(cls_name)s returned \""},{"line_number":150,"context_line":"                      \"%(obj_len)d host(s)\","},{"line_number":151,"context_line":"                      {\u0027cls_name\u0027: weigher_cls.__name__,"},{"line_number":152,"context_line":"                       \u0027obj_len\u0027: len(obj_list)})"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_67d6ac2a","line":149,"updated":"2018-06-05 18:19:38.000000000","message":"This isn\u0027t a filter, right?\n\nDoes this message actually tell us anything?  Isn\u0027t the weighed list always the same length as the original list?","commit_id":"6a3da8629352c95dcf58158ca1b77570835c4f05"},{"author":{"_account_id":25456,"name":"junboli","email":"junbo85.li@gmail.com","username":"junboli"},"change_message_id":"c7c73c9a57143885b376a761a7acc487c47d484a","unresolved":false,"context_lines":[{"line_number":146,"context_line":"                obj \u003d weighed_objs[i]"},{"line_number":147,"context_line":"                obj.weight +\u003d weigher.weight_multiplier() * weight"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"            LOG.debug(\"Filter %(cls_name)s returned \""},{"line_number":150,"context_line":"                      \"%(obj_len)d host(s)\","},{"line_number":151,"context_line":"                      {\u0027cls_name\u0027: weigher_cls.__name__,"},{"line_number":152,"context_line":"                       \u0027obj_len\u0027: len(obj_list)})"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_1f5e14e9","line":149,"in_reply_to":"5f7c97a3_67d6ac2a","updated":"2018-06-06 06:46:12.000000000","message":"This message is necessary, we can see the weigher info from this debug log, similarly as the log of CapacityFilter, AvailabilityZoneFilter, CapabilitiesFilter. I make small changes of this message and print the weigher values.","commit_id":"6a3da8629352c95dcf58158ca1b77570835c4f05"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"dd5f210605e66e74a2ddaf40d29129002b4bb954","unresolved":false,"context_lines":[{"line_number":149,"context_line":"            LOG.debug(\"Weigher %(cls_name)s returned, \""},{"line_number":150,"context_line":"                      \"weigher value is {max: %(maxval)s, min: %(minval)s}\","},{"line_number":151,"context_line":"                      {\u0027cls_name\u0027: weigher_cls.__name__,"},{"line_number":152,"context_line":"                       \u0027maxval\u0027: weigher.__dict__[\u0027maxval\u0027],"},{"line_number":153,"context_line":"                       \u0027minval\u0027: weigher.__dict__[\u0027minval\u0027]})"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"        return sorted(weighed_objs, key\u003dlambda x: x.weight, reverse\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_4d046118","line":152,"updated":"2018-06-12 12:35:56.000000000","message":"Can we use weigher.minval and weigher.maxval here?","commit_id":"7df644ca36152226467439e36cba3d3602a4ba04"},{"author":{"_account_id":25456,"name":"junboli","email":"junbo85.li@gmail.com","username":"junboli"},"change_message_id":"7c21e5debb705c54c85641391c178ef8a7aa929c","unresolved":false,"context_lines":[{"line_number":149,"context_line":"            LOG.debug(\"Weigher %(cls_name)s returned, \""},{"line_number":150,"context_line":"                      \"weigher value is {max: %(maxval)s, min: %(minval)s}\","},{"line_number":151,"context_line":"                      {\u0027cls_name\u0027: weigher_cls.__name__,"},{"line_number":152,"context_line":"                       \u0027maxval\u0027: weigher.__dict__[\u0027maxval\u0027],"},{"line_number":153,"context_line":"                       \u0027minval\u0027: weigher.__dict__[\u0027minval\u0027]})"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"        return sorted(weighed_objs, key\u003dlambda x: x.weight, reverse\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_0132a4a7","line":152,"in_reply_to":"5f7c97a3_4d046118","updated":"2018-06-13 00:39:42.000000000","message":"Yes, this looks better.","commit_id":"7df644ca36152226467439e36cba3d3602a4ba04"}],"cinder/scheduler/host_manager.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"41148c5b00ee3c69cf6c400df2a9a6ca825c54d6","unresolved":false,"context_lines":[{"line_number":496,"context_line":"        weighed_backends \u003d self.weight_handler.get_weighed_objects("},{"line_number":497,"context_line":"            weigher_classes, backends, weight_properties)"},{"line_number":498,"context_line":""},{"line_number":499,"context_line":"        LOG.debug(\"Filtered %s\", weighed_backends)"},{"line_number":500,"context_line":"        return weighed_backends"},{"line_number":501,"context_line":""},{"line_number":502,"context_line":"    def update_service_capabilities(self, service_name, host, capabilities,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_ee77489f","line":499,"range":{"start_line":499,"start_character":19,"end_line":499,"end_character":27},"updated":"2018-05-31 19:22:23.000000000","message":"Isn\u0027t this weighed and not filtered?","commit_id":"970526c7e3459e938ca407f162d7345a39e4c881"},{"author":{"_account_id":25456,"name":"junboli","email":"junbo85.li@gmail.com","username":"junboli"},"change_message_id":"7b08ba444ca13463902619eba730e007a8677ee6","unresolved":false,"context_lines":[{"line_number":496,"context_line":"        weighed_backends \u003d self.weight_handler.get_weighed_objects("},{"line_number":497,"context_line":"            weigher_classes, backends, weight_properties)"},{"line_number":498,"context_line":""},{"line_number":499,"context_line":"        LOG.debug(\"Filtered %s\", weighed_backends)"},{"line_number":500,"context_line":"        return weighed_backends"},{"line_number":501,"context_line":""},{"line_number":502,"context_line":"    def update_service_capabilities(self, service_name, host, capabilities,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_97b6e8f8","line":499,"range":{"start_line":499,"start_character":19,"end_line":499,"end_character":27},"in_reply_to":"5f7c97a3_ee77489f","updated":"2018-06-01 00:22:13.000000000","message":"Yes, it\u0027s weighed.","commit_id":"970526c7e3459e938ca407f162d7345a39e4c881"}]}