)]}'
{"cinder/tests/unit/volume/drivers/solidfire/test_solidfire.py":[{"author":{"_account_id":11884,"name":"Masaki Kanno","email":"kanno.masaki@jp.fujitsu.com","username":"Kanno"},"change_message_id":"c41900834d6b7caf0a357ed2e40e71cb2a123d7d","unresolved":false,"context_lines":[{"line_number":519,"context_line":"        vol_id \u003d \u0027a720b3c0-d1f0-11e1-9b23-0800200c9a66\u0027"},{"line_number":520,"context_line":"        testvol \u003d test_utils.create_volume("},{"line_number":521,"context_line":"            self.ctxt,"},{"line_number":522,"context_line":"            id\u003dvol_id,"},{"line_number":523,"context_line":"            display_name\u003d\u0027test_volume\u0027,"},{"line_number":524,"context_line":"            provider_id\u003d\u00271 5 None\u0027,"},{"line_number":525,"context_line":"            multiattach\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_b3455817","line":522,"updated":"2018-06-25 10:40:49.000000000","message":"Should \"id\" argument not be specified in Ocata?","commit_id":"1a709d5371d76e4ca6f1716a47e3d5e9518ff971"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"b2caca95f71f9192ab952a9e3dff3bb5f91e9d07","unresolved":false,"context_lines":[{"line_number":519,"context_line":"        vol_id \u003d \u0027a720b3c0-d1f0-11e1-9b23-0800200c9a66\u0027"},{"line_number":520,"context_line":"        testvol \u003d test_utils.create_volume("},{"line_number":521,"context_line":"            self.ctxt,"},{"line_number":522,"context_line":"            id\u003dvol_id,"},{"line_number":523,"context_line":"            display_name\u003d\u0027test_volume\u0027,"},{"line_number":524,"context_line":"            provider_id\u003d\u00271 5 None\u0027,"},{"line_number":525,"context_line":"            multiattach\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_4112dcfe","line":522,"in_reply_to":"5f7c97a3_b3455817","updated":"2018-06-25 22:06:52.000000000","message":"Bahhh!  You were absolutely correct!!!  The object/volumes.py in Ocata raises an exception if you try and force in the ID here.  My local environment had an outdated branch checked out and that\u0027s why it was passing :)","commit_id":"1a709d5371d76e4ca6f1716a47e3d5e9518ff971"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"835a9741c76194709ef8cc5e751d87728ca4bd99","unresolved":false,"context_lines":[{"line_number":519,"context_line":"        vol_id \u003d \u0027a720b3c0-d1f0-11e1-9b23-0800200c9a66\u0027"},{"line_number":520,"context_line":"        testvol \u003d test_utils.create_volume("},{"line_number":521,"context_line":"            self.ctxt,"},{"line_number":522,"context_line":"            id\u003dvol_id,"},{"line_number":523,"context_line":"            display_name\u003d\u0027test_volume\u0027,"},{"line_number":524,"context_line":"            provider_id\u003d\u00271 5 None\u0027,"},{"line_number":525,"context_line":"            multiattach\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_2f28f083","line":522,"in_reply_to":"5f7c97a3_b3455817","updated":"2018-06-25 16:15:24.000000000","message":"Yeah, the function in utils doesn\u0027t take it explicitly, but it accepts it as a kwarg and should set that appropriately when iterating through the keys.\n\nWhat I\u0027ve been trying to figure out is that I can run this locally on an Ocata deployment but it was failing in the gate.  Going to try one more recheck then I\u0027ll dig in to that object a bit more and see if that\u0027s something I can address.","commit_id":"1a709d5371d76e4ca6f1716a47e3d5e9518ff971"}],"cinder/volume/drivers/solidfire.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"8445c37b9ebe750321a0bc7e759c5fc14567d9b5","unresolved":false,"context_lines":[{"line_number":1399,"context_line":"            vols \u003d self._get_volumes_for_account(acc[\u0027accountID\u0027],"},{"line_number":1400,"context_line":"                                                 volume.name_id)"},{"line_number":1401,"context_line":"            # Check for migration magic here"},{"line_number":1402,"context_line":"            if (not vols and (volume.name_id !\u003d volume.id)):"},{"line_number":1403,"context_line":"                vols \u003d self._get_volumes_for_account(acc[\u0027accountID\u0027],"},{"line_number":1404,"context_line":"                                                     volume.id)"},{"line_number":1405,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_4a62faaf","line":1402,"updated":"2018-05-30 23:47:46.000000000","message":"I don\u0027t think any of these parenthesis are needed.","commit_id":"5cfb3a35fe1915ec94b705d98d7f480c86a53f61"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"ac8e33b3aa89cf2cf7fb1c9f236651656572c606","unresolved":false,"context_lines":[{"line_number":1399,"context_line":"            vols \u003d self._get_volumes_for_account(acc[\u0027accountID\u0027],"},{"line_number":1400,"context_line":"                                                 volume.name_id)"},{"line_number":1401,"context_line":"            # Check for migration magic here"},{"line_number":1402,"context_line":"            if (not vols and (volume.name_id !\u003d volume.id)):"},{"line_number":1403,"context_line":"                vols \u003d self._get_volumes_for_account(acc[\u0027accountID\u0027],"},{"line_number":1404,"context_line":"                                                     volume.id)"},{"line_number":1405,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_da6d6e03","line":1402,"in_reply_to":"5f7c97a3_4a62faaf","updated":"2018-05-31 16:13:11.000000000","message":"But but but... I LIKE parenthesis!!!  :)","commit_id":"5cfb3a35fe1915ec94b705d98d7f480c86a53f61"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"ac8e33b3aa89cf2cf7fb1c9f236651656572c606","unresolved":false,"context_lines":[{"line_number":1450,"context_line":"                                            params,"},{"line_number":1451,"context_line":"                                            version\u003d\u00276.0\u0027)"},{"line_number":1452,"context_line":"                    return"},{"line_number":1453,"context_line":"        LOG.warning("},{"line_number":1454,"context_line":"            \"Snapshot %s not found, old style clones may not be deleted.\","},{"line_number":1455,"context_line":"            snapshot.id)"},{"line_number":1456,"context_line":""},{"line_number":1457,"context_line":"    def create_snapshot(self, snapshot):"},{"line_number":1458,"context_line":"        sfaccount \u003d self._get_sfaccount(snapshot[\u0027project_id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_9a7376e7","line":1455,"range":{"start_line":1453,"start_character":8,"end_line":1455,"end_character":24},"updated":"2018-05-31 16:13:11.000000000","message":"Oh yeah!  Reminders of the trials and tribulations of the old days.","commit_id":"5cfb3a35fe1915ec94b705d98d7f480c86a53f61"}]}
