)]}'
{"cinder/volume/drivers/ibm/ibm_storage/ibm_storage.py":[{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"6b43bca47840520361f6f5450851793d18dd66e8","unresolved":true,"context_lines":[{"line_number":79,"context_line":"              - Support Consistency groups replication"},{"line_number":80,"context_line":"    \"\"\""},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    VERSION \u003d \"2.1.0\""},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    # ThirdPartySystems wiki page"},{"line_number":85,"context_line":"    CI_WIKI_NAME \u003d \"IBM_STORAGE_CI\""}],"source_content_type":"text/x-python","patch_set":4,"id":"7ac164e5_ffa7a8eb","line":82,"updated":"2023-07-03 13:34:47.000000000","message":"Adding a new method should bump the version here and a comment.","commit_id":"456ab7ac0b4979c34b75abfb093edea8db57602f"}],"cinder/volume/drivers/ibm/ibm_storage/xiv_proxy.py":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"d011d59bb15f56e5a90ed93d6970c12b1d303a7a","unresolved":false,"context_lines":[{"line_number":1234,"context_line":"        \"\"\"Rename and return model update from XIV for migrated volume.\"\"\""},{"line_number":1235,"context_line":""},{"line_number":1236,"context_line":"        LOG.debug(\u0027Attempt rename of %(cur)s to original name %(orig)s\u0027,"},{"line_number":1237,"context_line":"                  dict(cur\u003dnew_volume.name, orig\u003dvolume.name))"},{"line_number":1238,"context_line":"        try:"},{"line_number":1239,"context_line":"            self._call_xiv_xcli(\"vol_rename\", vol\u003dnew_volume.name,"},{"line_number":1240,"context_line":"                                new_name\u003dvolume.name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_b29740ec","line":1237,"range":{"start_line":1237,"start_character":18,"end_line":1237,"end_character":22},"updated":"2018-06-04 18:32:14.000000000","message":"Why are we using dict() here instead of {} like elsewhere?","commit_id":"de38e9b073499976e12e7c88216364555c508a0b"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"d011d59bb15f56e5a90ed93d6970c12b1d303a7a","unresolved":false,"context_lines":[{"line_number":1241,"context_line":"        except errors.XCLIError as e:"},{"line_number":1242,"context_line":"            LOG.error(\u0027Unable to rename the logical volume for volume\u0027"},{"line_number":1243,"context_line":"                      \u0027%(vol)s ERROR: %(err)s\u0027,"},{"line_number":1244,"context_line":"                      dict(vol\u003dvolume.id,"},{"line_number":1245,"context_line":"                           err\u003dself._get_code_and_status_or_message(e)))"},{"line_number":1246,"context_line":"            return {\u0027_name_id\u0027: new_volume[\u0027_name_id\u0027] or new_volume.id}"},{"line_number":1247,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_72a1a846","line":1244,"range":{"start_line":1244,"start_character":21,"end_line":1244,"end_character":27},"updated":"2018-06-04 18:32:14.000000000","message":"same comment here.","commit_id":"de38e9b073499976e12e7c88216364555c508a0b"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"7e97d833d3b26d3b7886f35006140cb000484fc1","unresolved":false,"context_lines":[{"line_number":1239,"context_line":"            self._call_xiv_xcli(\"vol_rename\", vol\u003dnew_volume.name,"},{"line_number":1240,"context_line":"                                new_name\u003dvolume.name)"},{"line_number":1241,"context_line":"        except errors.XCLIError as e:"},{"line_number":1242,"context_line":"            LOG.error(\u0027Unable to rename the logical volume for volume\u0027"},{"line_number":1243,"context_line":"                      \u0027%(vol)s ERROR: %(err)s\u0027,"},{"line_number":1244,"context_line":"                      {\u0027vol\u0027: volume.id,"},{"line_number":1245,"context_line":"                       \u0027err\u0027: self._get_code_and_status_or_message(e)})"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_2d8ec52d","line":1242,"range":{"start_line":1242,"start_character":0,"end_line":1242,"end_character":1},"updated":"2018-06-12 12:18:22.000000000","message":"Should we use LOG.exception here?","commit_id":"ffcd371c288b4a81b381dd2d0f3525736fb16e28"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"538b337211c0abbb2b6e0e101549eaad9ff78968","unresolved":false,"context_lines":[{"line_number":1239,"context_line":"            self._call_xiv_xcli(\"vol_rename\", vol\u003dnew_volume.name,"},{"line_number":1240,"context_line":"                                new_name\u003dvolume.name)"},{"line_number":1241,"context_line":"        except errors.XCLIError as e:"},{"line_number":1242,"context_line":"            LOG.error(\u0027Unable to rename the logical volume for volume\u0027"},{"line_number":1243,"context_line":"                      \u0027%(vol)s ERROR: %(err)s\u0027,"},{"line_number":1244,"context_line":"                      {\u0027vol\u0027: volume.id,"},{"line_number":1245,"context_line":"                       \u0027err\u0027: self._get_code_and_status_or_message(e)})"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_96fa8a72","line":1242,"range":{"start_line":1242,"start_character":0,"end_line":1242,"end_character":1},"in_reply_to":"5f7c97a3_2d8ec52d","updated":"2018-06-12 14:40:19.000000000","message":"+1","commit_id":"ffcd371c288b4a81b381dd2d0f3525736fb16e28"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"6b43bca47840520361f6f5450851793d18dd66e8","unresolved":true,"context_lines":[{"line_number":112,"context_line":"      2.0 - First open source driver version"},{"line_number":113,"context_line":"      2.1.0 - Support Consistency groups through Generic volume groups"},{"line_number":114,"context_line":"            - Support XIV/A9000 Volume independent QoS"},{"line_number":115,"context_line":"            - Support groups replication"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    \"\"\""},{"line_number":118,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"b44d87fe_19590fc0","line":115,"updated":"2023-07-03 13:34:47.000000000","message":"should bump this as well.","commit_id":"456ab7ac0b4979c34b75abfb093edea8db57602f"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"e0197c945d95ad5a3d59e6210c27a1c6ab47264a","unresolved":false,"context_lines":[{"line_number":1233,"context_line":"                               original_volume_status):"},{"line_number":1234,"context_line":"        \"\"\"Rename and return model update from XIV for migrated volume.\"\"\""},{"line_number":1235,"context_line":""},{"line_number":1236,"context_line":"        volume_name \u003d \u0027volume-%s\u0027 % volume.id if volume._name_id \\"},{"line_number":1237,"context_line":"            else volume.name"},{"line_number":1238,"context_line":"        LOG.debug(\u0027Attempt rename of %(cur)s to original name %(orig)s\u0027,"},{"line_number":1239,"context_line":"                  {\u0027cur\u0027: new_volume.name, \u0027orig\u0027: volume_name})"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_d0522813","line":1236,"range":{"start_line":1236,"start_character":65,"end_line":1236,"end_character":66},"updated":"2018-08-15 12:48:33.000000000","message":"Please avoid using \\ to span multiple lines. Wrap the assignment in () instead.","commit_id":"456ab7ac0b4979c34b75abfb093edea8db57602f"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"e0197c945d95ad5a3d59e6210c27a1c6ab47264a","unresolved":false,"context_lines":[{"line_number":1242,"context_line":"                                new_name\u003dvolume_name)"},{"line_number":1243,"context_line":"        except errors.XCLIError as e:"},{"line_number":1244,"context_line":"            LOG.exception(\u0027Unable to rename the logical volume for volume: \u0027"},{"line_number":1245,"context_line":"                          \u0027%(vol)s ERROR: %(err)s, use _name_id to record the \u0027"},{"line_number":1246,"context_line":"                          \u0027mapping relationship between the volume id and the \u0027"},{"line_number":1247,"context_line":"                          \u0027back-end volume\u0027,"},{"line_number":1248,"context_line":"                          {\u0027vol\u0027: volume.id,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_105d0014","line":1245,"range":{"start_line":1245,"start_character":51,"end_line":1245,"end_character":54},"updated":"2018-08-15 12:48:33.000000000","message":"s/use/using/\n\nThis is an error message that will appear in the log, and it sounds like you are instructing the operator to set some value which they will have no idea about.\n\nI don\u0027t think LOG.exception makes sense here. There is no action the operator needs to take, it\u0027s just noting that the driver had to do something different than the preferred path, so it should not be logged at an ERROR level. This should be LOG.debug so it can be traced and troubleshooting can figure out what path the driver ended up taking, but not appear like something that the operator needs to do something about.","commit_id":"456ab7ac0b4979c34b75abfb093edea8db57602f"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"387408f3e40334e960292393fd23b1e5fd665551","unresolved":false,"context_lines":[{"line_number":1242,"context_line":"                                new_name\u003dvolume_name)"},{"line_number":1243,"context_line":"        except errors.XCLIError as e:"},{"line_number":1244,"context_line":"            LOG.exception(\u0027Unable to rename the logical volume for volume: \u0027"},{"line_number":1245,"context_line":"                          \u0027%(vol)s ERROR: %(err)s, use _name_id to record the \u0027"},{"line_number":1246,"context_line":"                          \u0027mapping relationship between the volume id and the \u0027"},{"line_number":1247,"context_line":"                          \u0027back-end volume\u0027,"},{"line_number":1248,"context_line":"                          {\u0027vol\u0027: volume.id,"}],"source_content_type":"text/x-python","patch_set":4,"id":"5fc1f717_ce830da9","line":1245,"range":{"start_line":1245,"start_character":51,"end_line":1245,"end_character":54},"in_reply_to":"3f79a3b5_105d0014","updated":"2019-04-02 14:17:07.000000000","message":"+1 to Sean\u0027s comment here","commit_id":"456ab7ac0b4979c34b75abfb093edea8db57602f"}]}