)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"480de2ee68b168b65d52ed2c22bca83a00891aa0","unresolved":false,"context_lines":[{"line_number":18,"context_line":"* Update volume API will require minimum one parameter in request"},{"line_number":19,"context_line":"  body otherwise it will raise 400 error."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"APIImpact :"},{"line_number":22,"context_line":"Before 3.53 version, create volume allows additional properties,"},{"line_number":23,"context_line":"but now it will raise 400 error."},{"line_number":24,"context_line":"Also before 3.53 version, update volume allows empty body {},"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5f7c97a3_e16a2d19","line":21,"updated":"2018-06-22 19:16:58.000000000","message":"Please, remove the space if you do one more path","commit_id":"af41f51d6ddf47b562dc8241f5d8007ae60bdb85"}],"cinder/api/contrib/scheduler_hints.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"b6db6bb1a0da3cf4267724fd2483b8e596059689","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from cinder.api import validation"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class SchedulerHintsController(wsgi.Controller):"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    @validation.schema(scheduler_hints.create)"},{"line_number":24,"context_line":"    def _extract_scheduler_hints(self, req, body):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_e9ab2b85","side":"PARENT","line":21,"range":{"start_line":21,"start_character":6,"end_line":21,"end_character":30},"updated":"2018-06-20 13:43:38.000000000","message":"Functional tests failing due to this being removed.","commit_id":"1aa9231cb2c8ee26ac4a114291cd16e1891b9beb"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"2cff6fed24b2b55977a054495b512ba5329ffa02","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from cinder.api import validation"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"alias \u003d \"OS-SCH-HNT\""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"def create(req, body):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_82b18d04","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":5},"updated":"2018-06-28 11:53:59.000000000","message":"Constants should be all upper case.\n\nThough I only see it being used in the one spot below, so I think this should just be removed and this value should just be put directly in the string below. Or the \":scheduler_hints\" part moved up here to be a constant if it is expected that this will be used in more places in the future.","commit_id":"af41f51d6ddf47b562dc8241f5d8007ae60bdb85"}],"cinder/api/openstack/api_version_request.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"2cff6fed24b2b55977a054495b512ba5329ffa02","unresolved":false,"context_lines":[{"line_number":134,"context_line":"_MIN_API_VERSION \u003d \"3.0\""},{"line_number":135,"context_line":"_MAX_API_VERSION \u003d \"3.53\""},{"line_number":136,"context_line":"_LEGACY_API_VERSION2 \u003d \"2.0\""},{"line_number":137,"context_line":"UPDATED \u003d \"2017-09-19T20:18:14Z\""},{"line_number":138,"context_line":""},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"# NOTE(cyeoh): min and max versions declared as functions so we can"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_e2a161aa","line":137,"range":{"start_line":137,"start_character":0,"end_line":137,"end_character":7},"updated":"2018-06-28 11:53:59.000000000","message":"If you do an update, can you give this a more recent timestamp?","commit_id":"af41f51d6ddf47b562dc8241f5d8007ae60bdb85"}],"cinder/api/openstack/rest_api_version_history.rst":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"2cff6fed24b2b55977a054495b512ba5329ffa02","unresolved":false,"context_lines":[{"line_number":429,"context_line":"    it will raise badRequest error."},{"line_number":430,"context_line":""},{"line_number":431,"context_line":"- Update volume API"},{"line_number":432,"context_line":"    Before 3.53, even if user don\u0027t pass any valid parameters in the request body,"},{"line_number":433,"context_line":"    the volume was updated."},{"line_number":434,"context_line":"    But in 3.53, user will need to pass at least one valid parameter in the request"},{"line_number":435,"context_line":"    body otherwise it will return 400 error."}],"source_content_type":"text/x-rst","patch_set":3,"id":"5f7c97a3_628d5134","line":432,"range":{"start_line":432,"start_character":30,"end_line":432,"end_character":35},"updated":"2018-06-28 11:53:59.000000000","message":"didn\u0027t or doesn\u0027t","commit_id":"af41f51d6ddf47b562dc8241f5d8007ae60bdb85"}],"cinder/api/v2/volumes.py":[{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"317200581ce6b917540a3e6dbfcf6a95e2ed9412","unresolved":false,"context_lines":[{"line_number":175,"context_line":"        raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"    @wsgi.response(http_client.ACCEPTED)"},{"line_number":178,"context_line":"    def create(self, req, body):"},{"line_number":179,"context_line":"        \"\"\"Creates a new volume.\"\"\""},{"line_number":180,"context_line":"        self.assert_valid_body(body, \u0027volume\u0027)"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"        LOG.debug(\u0027Create volume request body: %s\u0027, body)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_ea4818b4","line":179,"range":{"start_line":178,"start_character":3,"end_line":179,"end_character":35},"updated":"2018-06-07 07:26:01.000000000","message":"where is the schema validation for this method?","commit_id":"e3fcfccacabf16ee9796e7c6cab777b267d5cf11"}],"cinder/api/v3/volumes.py":[{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"317200581ce6b917540a3e6dbfcf6a95e2ed9412","unresolved":false,"context_lines":[{"line_number":226,"context_line":"            return image_snapshot"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"    @wsgi.response(http_client.ACCEPTED)"},{"line_number":229,"context_line":"    @validation.schema(volumes.create, \u00272.0\u0027, \u00273.12\u0027)"},{"line_number":230,"context_line":"    @validation.schema(volumes.create_volume_v313, \u00273.13\u0027, \u00273.46\u0027)"},{"line_number":231,"context_line":"    @validation.schema(volumes.create_volume_v347, \u00273.47\u0027)"},{"line_number":232,"context_line":"    def create(self, req, body):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_aac8e020","line":229,"range":{"start_line":229,"start_character":39,"end_line":229,"end_character":53},"updated":"2018-06-07 07:26:01.000000000","message":"should it start from 3.0?","commit_id":"e3fcfccacabf16ee9796e7c6cab777b267d5cf11"}]}