)]}'
{"cinder/tests/unit/volume/drivers/dell_emc/sc/test_scapi.py":[{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"176c0a28e3731d2b512a2cab86d2c52a794a704f","unresolved":false,"context_lines":[{"line_number":1293,"context_line":"                     u\u0027name\u0027: u\u00275000d31000fcbe36\u0027,"},{"line_number":1294,"context_line":"                     u\u0027parent\u0027:"},{"line_number":1295,"context_line":"                         {u\u0027instanceId\u0027: u\u002764702.5764839588723736093.57\u0027,"},{"line_number":1296,"context_line":"                             u\u0027instanceName\u0027: u\u00275000D31000FCBE1D\u0027,"},{"line_number":1297,"context_line":"                          u\u0027objectType\u0027: u\u0027ScControllerPort\u0027},"},{"line_number":1298,"context_line":"                     u\u0027iscsiGateway\u0027: u\u00270.0.0.0\u0027,"},{"line_number":1299,"context_line":"                     u\u0027instanceId\u0027: u\u002764702.5764839588723736118.50\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_c0f90bc8","line":1296,"range":{"start_line":1296,"start_character":52,"end_line":1296,"end_character":64},"updated":"2018-06-12 20:54:31.000000000","message":"should this be lower case also?","commit_id":"15bdded3d00268b9f5b8523613436cfcb29adb69"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"176c0a28e3731d2b512a2cab86d2c52a794a704f","unresolved":false,"context_lines":[{"line_number":1327,"context_line":"         u\u0027name\u0027: u\u00275000d31000fcbe36\u0027,"},{"line_number":1328,"context_line":"         u\u0027parent\u0027:"},{"line_number":1329,"context_line":"         {u\u0027instanceId\u0027: u\u002764702.5764839588723736093.57\u0027,"},{"line_number":1330,"context_line":"          u\u0027instanceName\u0027: u\u00275000D31000FCBE1D\u0027,"},{"line_number":1331,"context_line":"          u\u0027objectType\u0027: u\u0027ScControllerPort\u0027},"},{"line_number":1332,"context_line":"         u\u0027iscsiGateway\u0027: u\u00270.0.0.0\u0027,"},{"line_number":1333,"context_line":"         u\u0027instanceId\u0027: u\u002764702.5764839588723736118.50\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_80ff93a9","line":1330,"range":{"start_line":1330,"start_character":29,"end_line":1330,"end_character":45},"updated":"2018-06-12 20:54:31.000000000","message":"ditto","commit_id":"15bdded3d00268b9f5b8523613436cfcb29adb69"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"176c0a28e3731d2b512a2cab86d2c52a794a704f","unresolved":false,"context_lines":[{"line_number":1609,"context_line":"            u\u002721000024ff30441d\u0027]"},{"line_number":1610,"context_line":""},{"line_number":1611,"context_line":"    # Used to test finding no match in find_wwns"},{"line_number":1612,"context_line":"    WWNS_NO_MATCH \u003d [u\u002721000024FF30451C\u0027,"},{"line_number":1613,"context_line":"                     u\u002721000024FF30451D\u0027]"},{"line_number":1614,"context_line":""},{"line_number":1615,"context_line":"    FLDR_PATH \u003d \u0027StorageCenter/ScVolumeFolder/\u0027"},{"line_number":1616,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_0025c35b","line":1613,"range":{"start_line":1612,"start_character":19,"end_line":1613,"end_character":41},"updated":"2018-06-12 20:54:31.000000000","message":"also?","commit_id":"15bdded3d00268b9f5b8523613436cfcb29adb69"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"637e6a0ffebe96c1b74ec55f31e1d6f6ae928f56","unresolved":false,"context_lines":[{"line_number":755,"context_line":"                                   u\u0027objectType\u0027: u\u0027ScServerHba\u0027},"},{"line_number":756,"context_line":"                    u\u0027path\u0027:"},{"line_number":757,"context_line":"                        {u\u0027instanceId\u0027: u\u002764702.64702.64703.28.76\u0027,"},{"line_number":758,"context_line":"                         u\u0027instanceName\u0027: u\u002721000024ff30441d-5000D31000FCBE3E\u0027,"},{"line_number":759,"context_line":"                         u\u0027objectType\u0027: u\u0027ScServerHbaPath\u0027},"},{"line_number":760,"context_line":"                    u\u0027controllerPort\u0027: {u\u0027instanceId\u0027:"},{"line_number":761,"context_line":"                                        u\u002764702.5764839588723736126.60\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_c9091895","line":758,"range":{"start_line":758,"start_character":24,"end_line":758,"end_character":79},"updated":"2018-06-13 23:02:05.000000000","message":"do you need to lowercase second half of instanceName 5000D31000FCBE3E?","commit_id":"484e576b39d9d116135d55251e429603ee5477a2"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"289c5026d323106d5d4fd83bfe3f2125f4c3556b","unresolved":false,"context_lines":[{"line_number":755,"context_line":"                                   u\u0027objectType\u0027: u\u0027ScServerHba\u0027},"},{"line_number":756,"context_line":"                    u\u0027path\u0027:"},{"line_number":757,"context_line":"                        {u\u0027instanceId\u0027: u\u002764702.64702.64703.28.76\u0027,"},{"line_number":758,"context_line":"                         u\u0027instanceName\u0027: u\u002721000024ff30441d-5000D31000FCBE3E\u0027,"},{"line_number":759,"context_line":"                         u\u0027objectType\u0027: u\u0027ScServerHbaPath\u0027},"},{"line_number":760,"context_line":"                    u\u0027controllerPort\u0027: {u\u0027instanceId\u0027:"},{"line_number":761,"context_line":"                                        u\u002764702.5764839588723736126.60\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_24223353","line":758,"range":{"start_line":758,"start_character":24,"end_line":758,"end_character":79},"in_reply_to":"5f7c97a3_c9091895","updated":"2018-06-13 23:40:27.000000000","message":"The API response from the backend is in the lower level code. It is mocked in all these test cases. I ran the unit tests and it didn\u0027t matter. I would wait for the CI to pass","commit_id":"484e576b39d9d116135d55251e429603ee5477a2"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"637e6a0ffebe96c1b74ec55f31e1d6f6ae928f56","unresolved":false,"context_lines":[{"line_number":859,"context_line":"                            u\u0027objectType\u0027: u\u0027ScServerHba\u0027},"},{"line_number":860,"context_line":"             u\u0027path\u0027:"},{"line_number":861,"context_line":"                        {u\u0027instanceId\u0027: u\u002764702.64702.64703.28.76\u0027,"},{"line_number":862,"context_line":"                         u\u0027instanceName\u0027: u\u002721000024ff30441d-5000D31000FCBE3E\u0027,"},{"line_number":863,"context_line":"                         u\u0027objectType\u0027: u\u0027ScServerHbaPath\u0027},"},{"line_number":864,"context_line":"             u\u0027controllerPort\u0027: {u\u0027instanceId\u0027:"},{"line_number":865,"context_line":"                                 u\u002764702.5764839588723736126.60\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_e9d654f2","line":862,"range":{"start_line":862,"start_character":40,"end_line":862,"end_character":79},"updated":"2018-06-13 23:02:05.000000000","message":"do you need to lower cases the second part of instanceName?","commit_id":"484e576b39d9d116135d55251e429603ee5477a2"}],"cinder/volume/drivers/dell_emc/sc/storagecenter_api.py":[{"author":{"_account_id":28517,"name":"Tom Swanson","email":"tweb@smrlabs.com"},"change_message_id":"0fbf7a27e329708250ff98ff433c06380f6dd991","unresolved":false,"context_lines":[{"line_number":1716,"context_line":"        for key in itmap.keys():"},{"line_number":1717,"context_line":"            itmap_new[key.lower()] \u003d [v.lower() for v in itmap[key]]"},{"line_number":1718,"context_line":""},{"line_number":1719,"context_line":"        LOG.debug(\u0027*** To lower ***: wwns_new - %s\u0027, wwns_new)"},{"line_number":1720,"context_line":"        LOG.debug(\u0027*** To lower ***: itmap_new - %s\u0027, itmap_new)"},{"line_number":1721,"context_line":"        return lun, wwns_new, itmap_new"},{"line_number":1722,"context_line":""},{"line_number":1723,"context_line":"    def _find_active_controller(self, scvolume):"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_1d57bc28","line":1720,"range":{"start_line":1719,"start_character":1,"end_line":1720,"end_character":64},"updated":"2018-06-20 20:59:19.000000000","message":"Do you want this merged?","commit_id":"cabb6d8b7fb5fb0eb5cb46b0d8ce68c5d42efe08"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"08c31bb369d3267ff755b53f73f807b09004ea51","unresolved":false,"context_lines":[{"line_number":1716,"context_line":"        for key in itmap.keys():"},{"line_number":1717,"context_line":"            itmap_new[key.lower()] \u003d [v.lower() for v in itmap[key]]"},{"line_number":1718,"context_line":""},{"line_number":1719,"context_line":"        LOG.debug(\u0027*** To lower ***: wwns_new - %s\u0027, wwns_new)"},{"line_number":1720,"context_line":"        LOG.debug(\u0027*** To lower ***: itmap_new - %s\u0027, itmap_new)"},{"line_number":1721,"context_line":"        return lun, wwns_new, itmap_new"},{"line_number":1722,"context_line":""},{"line_number":1723,"context_line":"    def _find_active_controller(self, scvolume):"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_e5a4a6bb","line":1720,"range":{"start_line":1719,"start_character":1,"end_line":1720,"end_character":64},"in_reply_to":"5f7c97a3_1d57bc28","updated":"2018-06-20 21:25:20.000000000","message":"Good question. Planning to remove it when the CI passes. Thanks","commit_id":"cabb6d8b7fb5fb0eb5cb46b0d8ce68c5d42efe08"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"94c2d8315a39682c6a1bdd5e10cdb819b3632b77","unresolved":false,"context_lines":[{"line_number":1682,"context_line":"            if controllerport is not None:"},{"line_number":1683,"context_line":"                # This changed case at one point or another."},{"line_number":1684,"context_line":"                # Look for both keys."},{"line_number":1685,"context_line":"                wwn \u003d self._get_wwn(controllerport)"},{"line_number":1686,"context_line":"                if wwn:"},{"line_number":1687,"context_line":"                    serverhba \u003d mapping.get(\u0027serverHba\u0027)"},{"line_number":1688,"context_line":"                    if serverhba:"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_df79202f","line":1685,"updated":"2018-06-21 20:57:37.000000000","message":"Seems like it would be more straight forward to add .toLower() here.","commit_id":"30182a55d5055e0885969d2bd3452217b30f5892"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"1afb5d82e756bb757ee32b5dd6beaec9ebb5640e","unresolved":false,"context_lines":[{"line_number":1682,"context_line":"            if controllerport is not None:"},{"line_number":1683,"context_line":"                # This changed case at one point or another."},{"line_number":1684,"context_line":"                # Look for both keys."},{"line_number":1685,"context_line":"                wwn \u003d self._get_wwn(controllerport)"},{"line_number":1686,"context_line":"                if wwn:"},{"line_number":1687,"context_line":"                    serverhba \u003d mapping.get(\u0027serverHba\u0027)"},{"line_number":1688,"context_line":"                    if serverhba:"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_7e77a109","line":1685,"in_reply_to":"5f7c97a3_df79202f","updated":"2018-06-22 13:59:41.000000000","message":"Yes, will do , waiting for CI to pass","commit_id":"30182a55d5055e0885969d2bd3452217b30f5892"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"94c2d8315a39682c6a1bdd5e10cdb819b3632b77","unresolved":false,"context_lines":[{"line_number":1686,"context_line":"                if wwn:"},{"line_number":1687,"context_line":"                    serverhba \u003d mapping.get(\u0027serverHba\u0027)"},{"line_number":1688,"context_line":"                    if serverhba:"},{"line_number":1689,"context_line":"                        hbaname \u003d serverhba.get(\u0027instanceName\u0027)"},{"line_number":1690,"context_line":"                        if hbaname in initiators:"},{"line_number":1691,"context_line":"                            if itmap.get(hbaname) is None:"},{"line_number":1692,"context_line":"                                itmap[hbaname] \u003d []"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_7f724c4c","line":1689,"updated":"2018-06-21 20:57:37.000000000","message":"and here","commit_id":"30182a55d5055e0885969d2bd3452217b30f5892"}]}