)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"5ee8412e66a9845a7d648eb5843ad92070bb4fb4","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Report SolidFire the number of object info to scheduler"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The SolidFire has a hardlimit for the number of volumes and accounts."},{"line_number":10,"context_line":"If it exceeded, The SolidFire return xExceededLimit error, As a result cinder volume create will have failed in spite of the SolidFire backend has sufficient available capacity."},{"line_number":11,"context_line":"After that, Cinder scheduler choose same backend because Cinder scheduler uses CapacityWeigher by default."},{"line_number":12,"context_line":"As a result, It will be fail \"cinder volume create\" operation again."},{"line_number":13,"context_line":"To avoid such problems, To avoid such problems, Cinder administrator need be able to specify the number of volumes and accounts in goodness_function."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f7c97a3_6cefff86","line":10,"updated":"2018-06-11 11:04:15.000000000","message":"Commit msg lines should be wrapped at 72 characters.\nKindly refer:\nhttps://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"9490597b13853ddfd505b1e6cd1bab81f926d940"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"9264d57c81f5598f1964244546e3739a56e82698","unresolved":false,"context_lines":[{"line_number":14,"context_line":"because Cinder scheduler uses CapacityWeigher by default."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"As a result, It will be fail \"cinder volume create\" operation again."},{"line_number":17,"context_line":"To avoid such problems, To avoid such problems,"},{"line_number":18,"context_line":"Cinder administrator need be able to specify"},{"line_number":19,"context_line":"the number of volumes and accounts in goodness_function."},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5f7c97a3_5306cd87","line":17,"updated":"2018-07-12 19:19:31.000000000","message":"probably should fix this.","commit_id":"8ea67e6eaaa0cfeb84f65e0ab53f86a363d9b6a3"}],"cinder/volume/drivers/solidfire.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"bc0393befb41b043400eede7a4ca3caa077cc958","unresolved":false,"context_lines":[{"line_number":1900,"context_line":"        except exception.SolidFireAPIException:"},{"line_number":1901,"context_line":"            data[\u0027total_capacity_gb\u0027] \u003d 0"},{"line_number":1902,"context_line":"            data[\u0027free_capacity_gb\u0027] \u003d 0"},{"line_number":1903,"context_line":"            data[\u0027total_volumes\u0027] \u003d 0"},{"line_number":1904,"context_line":"            data[\u0027free_volumes\u0027] \u003d 0"},{"line_number":1905,"context_line":"            data[\u0027total_accounts\u0027] \u003d 0"},{"line_number":1906,"context_line":"            data[\u0027free_accounts\u0027] \u003d 0"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_f37d99e6","line":1903,"updated":"2018-07-12 19:27:11.000000000","message":"You should really have separate exception blocks for each call here so that reasonable values can be filled in if the api call fails.\n\nI suspect that if you fail to count the number of volumes, free_volumes should actually report a higher number than 0, so that volume creation doesn\u0027t needlessly fail.","commit_id":"8ea67e6eaaa0cfeb84f65e0ab53f86a363d9b6a3"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"bc0393befb41b043400eede7a4ca3caa077cc958","unresolved":false,"context_lines":[{"line_number":1903,"context_line":"            data[\u0027total_volumes\u0027] \u003d 0"},{"line_number":1904,"context_line":"            data[\u0027free_volumes\u0027] \u003d 0"},{"line_number":1905,"context_line":"            data[\u0027total_accounts\u0027] \u003d 0"},{"line_number":1906,"context_line":"            data[\u0027free_accounts\u0027] \u003d 0"},{"line_number":1907,"context_line":"            self.cluster_stats \u003d data"},{"line_number":1908,"context_line":"            return"},{"line_number":1909,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_138375cd","line":1906,"updated":"2018-07-12 19:27:11.000000000","message":"How are the accounts counts useful to Cinder?  There is no explanation of this in the commit message etc.","commit_id":"8ea67e6eaaa0cfeb84f65e0ab53f86a363d9b6a3"}]}