)]}'
{"cinder/volume/drivers/dell_emc/vmax/metadata.py":[{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"ad73e9faf5bf13759e69c08562b268da63c18cb3","unresolved":false,"context_lines":[{"line_number":315,"context_line":"        :param model_update: model update dict"},{"line_number":316,"context_line":"        \"\"\""},{"line_number":317,"context_line":"        try:"},{"line_number":318,"context_line":"            volume.update(model_update)"},{"line_number":319,"context_line":"            volume.save()"},{"line_number":320,"context_line":"        except Exception as e:"},{"line_number":321,"context_line":"            LOG.warning(\"Volume metadata update failed. \""},{"line_number":322,"context_line":"                        \"Exception is : %(e)s. \", {\u0027e\u0027: e})"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_4fccfe89","line":319,"range":{"start_line":318,"start_character":0,"end_line":319,"end_character":25},"updated":"2018-06-15 14:32:24.000000000","message":"Touching the database from the driver breaks Cinder driver model. Please see more on that on my review of your other patch[1].\n[1] https://review.openstack.org/#/c/557448/","commit_id":"2bdf507793163f201f93c380895aa98dba4b0bc2"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"346f230f104d927c6ff67211972dab20450a65a5","unresolved":false,"context_lines":[{"line_number":315,"context_line":"        :param model_update: model update dict"},{"line_number":316,"context_line":"        \"\"\""},{"line_number":317,"context_line":"        try:"},{"line_number":318,"context_line":"            volume.update(model_update)"},{"line_number":319,"context_line":"            volume.save()"},{"line_number":320,"context_line":"        except Exception as e:"},{"line_number":321,"context_line":"            LOG.warning(\"Volume metadata update failed. \""},{"line_number":322,"context_line":"                        \"Exception is : %(e)s. \", {\u0027e\u0027: e})"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_db9c50c1","line":319,"range":{"start_line":318,"start_character":0,"end_line":319,"end_character":25},"in_reply_to":"5f7c97a3_4fccfe89","updated":"2018-06-15 17:05:31.000000000","message":"Thanks Erlon,\nI will abandon this patch until I can find an alternative to updating metadata on an extend, attach and detach operation.\nAny suggestions most welcome.\nThank you\nHelen","commit_id":"2bdf507793163f201f93c380895aa98dba4b0bc2"}]}