)]}'
{"cinder/volume/drivers/nec/volume_helper.py":[{"author":{"_account_id":23885,"name":"Shunei Shiono","email":"shunei.shiono@gmail.com","username":"s-shiono"},"change_message_id":"f0a8ba6b5eb36bd183dd61c59491e6a31bc7e403","unresolved":false,"context_lines":[{"line_number":1129,"context_line":"        provider_location \u003d provider_location.split()"},{"line_number":1130,"context_line":"        info \u003d {\u0027driver_volume_type\u0027: \u0027iscsi\u0027,"},{"line_number":1131,"context_line":"                \u0027data\u0027: {\u0027target_portal\u0027:"},{"line_number":1132,"context_line":"                         provider_location[0][0:-2].split(\";\")[0],"},{"line_number":1133,"context_line":"                         \u0027target_iqn\u0027: provider_location[1],"},{"line_number":1134,"context_line":"                         \u0027target_lun\u0027: int(provider_location[2]),"},{"line_number":1135,"context_line":"                         \u0027target_discovered\u0027: False,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_0f423010","line":1132,"range":{"start_line":1132,"start_character":62,"end_line":1132,"end_character":65},"updated":"2018-06-20 08:31:02.000000000","message":"Always using the first portal is not good in point of load balancing.\nIn addition, this patch has no effect on multi-path configuration.","commit_id":"de5b3f5a064a534419c16bbeeb2e292918d48c4a"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"955decde40fc049f7d9bae4758a50d12aa7a49e1","unresolved":false,"context_lines":[{"line_number":1129,"context_line":"        provider_location \u003d provider_location.split()"},{"line_number":1130,"context_line":"        info \u003d {\u0027driver_volume_type\u0027: \u0027iscsi\u0027,"},{"line_number":1131,"context_line":"                \u0027data\u0027: {\u0027target_portal\u0027:"},{"line_number":1132,"context_line":"                         provider_location[0][0:-2].split(\";\")[0],"},{"line_number":1133,"context_line":"                         \u0027target_iqn\u0027: provider_location[1],"},{"line_number":1134,"context_line":"                         \u0027target_lun\u0027: int(provider_location[2]),"},{"line_number":1135,"context_line":"                         \u0027target_discovered\u0027: False,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_b237e44b","line":1132,"range":{"start_line":1132,"start_character":62,"end_line":1132,"end_character":65},"in_reply_to":"5f7c97a3_0f423010","updated":"2018-06-20 10:06:34.000000000","message":"Thanks for review. In non multipath situation, the target portal is a single value, so it seems random choice unnecessary?\nIn multipath, the target_portal will replaced with target_portals.","commit_id":"de5b3f5a064a534419c16bbeeb2e292918d48c4a"},{"author":{"_account_id":23885,"name":"Shunei Shiono","email":"shunei.shiono@gmail.com","username":"s-shiono"},"change_message_id":"98dd4883901c5c34409262dafd326f0ad350c17a","unresolved":false,"context_lines":[{"line_number":1129,"context_line":"        provider_location \u003d provider_location.split()"},{"line_number":1130,"context_line":"        info \u003d {\u0027driver_volume_type\u0027: \u0027iscsi\u0027,"},{"line_number":1131,"context_line":"                \u0027data\u0027: {\u0027target_portal\u0027:"},{"line_number":1132,"context_line":"                         provider_location[0][0:-2].split(\";\")[0],"},{"line_number":1133,"context_line":"                         \u0027target_iqn\u0027: provider_location[1],"},{"line_number":1134,"context_line":"                         \u0027target_lun\u0027: int(provider_location[2]),"},{"line_number":1135,"context_line":"                         \u0027target_discovered\u0027: False,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_118ebf2d","line":1132,"range":{"start_line":1132,"start_character":62,"end_line":1132,"end_character":65},"in_reply_to":"5f7c97a3_b237e44b","updated":"2018-06-21 08:53:43.000000000","message":"\u003e Thanks for review. In non multipath situation, the target portal is\n \u003e a single value, so it seems random choice unnecessary?\n\nNo, we have to select one portal in single-path because multiple portals can be available.\nThe selection should be balanced among the available portals.\n\n \u003e In multipath, the target_portal will replaced with target_portals.\n\nYes, target_portals is used in multipath.\nCurrently, the driver randomly selects portals in _enumerate_iscsi_portals().","commit_id":"de5b3f5a064a534419c16bbeeb2e292918d48c4a"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"608b29e7220d6c4281698334a10b5c9aa6ee2ad0","unresolved":false,"context_lines":[{"line_number":291,"context_line":"                    len(dirportal) \u003e self._properties[\u0027portal_number\u0027]):"},{"line_number":292,"context_line":"                nominated.extend("},{"line_number":293,"context_line":"                    dirportal[0:self._properties[\u0027portal_number\u0027]])"},{"line_number":294,"context_line":"            else:"},{"line_number":295,"context_line":"                nominated.extend(dirportal)"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"        if len(nominated) \u003d\u003d 0:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_3f20a2b1","line":294,"range":{"start_line":294,"start_character":16,"end_line":294,"end_character":17},"updated":"2018-07-13 13:17:00.000000000","message":"this looks ok to me, but do you need to do the same around line 1112?","commit_id":"5a22d265093eec760de98a8fe7b16c52a83f27a3"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"f5aa87831c7fbe677c69ffc2d62520b2ab6a71a7","unresolved":false,"context_lines":[{"line_number":291,"context_line":"                    len(dirportal) \u003e self._properties[\u0027portal_number\u0027]):"},{"line_number":292,"context_line":"                nominated.extend("},{"line_number":293,"context_line":"                    dirportal[0:self._properties[\u0027portal_number\u0027]])"},{"line_number":294,"context_line":"            else:"},{"line_number":295,"context_line":"                nominated.extend(dirportal)"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"        if len(nominated) \u003d\u003d 0:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_5bb8f7e6","line":294,"range":{"start_line":294,"start_character":16,"end_line":294,"end_character":17},"in_reply_to":"5f7c97a3_3f20a2b1","updated":"2018-07-16 01:54:14.000000000","message":"Thanks for review, what do you mean here?","commit_id":"5a22d265093eec760de98a8fe7b16c52a83f27a3"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"f19fe6997caa8a37b21686fe0d1882f08b8c51e3","unresolved":false,"context_lines":[{"line_number":291,"context_line":"                    len(dirportal) \u003e self._properties[\u0027portal_number\u0027]):"},{"line_number":292,"context_line":"                nominated.extend("},{"line_number":293,"context_line":"                    dirportal[0:self._properties[\u0027portal_number\u0027]])"},{"line_number":294,"context_line":"            else:"},{"line_number":295,"context_line":"                nominated.extend(dirportal)"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"        if len(nominated) \u003d\u003d 0:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_cf23d757","line":294,"range":{"start_line":294,"start_character":16,"end_line":294,"end_character":17},"in_reply_to":"5f7c97a3_5bb8f7e6","updated":"2018-07-17 01:31:19.000000000","message":"On line 1112 it uses:\n\n\u0027data\u0027: {\u0027target_portal\u0027: random.choice(\n1114                     provider_location[0][0:-2].split(\";\")),\n\nDoes this need to be changed as well?","commit_id":"5a22d265093eec760de98a8fe7b16c52a83f27a3"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"b43c1b0e664e090a677f2d6e5db3881044677bcd","unresolved":false,"context_lines":[{"line_number":291,"context_line":"                    len(dirportal) \u003e self._properties[\u0027portal_number\u0027]):"},{"line_number":292,"context_line":"                nominated.extend("},{"line_number":293,"context_line":"                    dirportal[0:self._properties[\u0027portal_number\u0027]])"},{"line_number":294,"context_line":"            else:"},{"line_number":295,"context_line":"                nominated.extend(dirportal)"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"        if len(nominated) \u003d\u003d 0:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_96663cee","line":294,"range":{"start_line":294,"start_character":16,"end_line":294,"end_character":17},"in_reply_to":"5f7c97a3_99019b06","updated":"2018-07-17 12:43:43.000000000","message":"ok cool","commit_id":"5a22d265093eec760de98a8fe7b16c52a83f27a3"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"3cf37dace0bcfe2d1a2e5fd24b717def990f93bb","unresolved":false,"context_lines":[{"line_number":291,"context_line":"                    len(dirportal) \u003e self._properties[\u0027portal_number\u0027]):"},{"line_number":292,"context_line":"                nominated.extend("},{"line_number":293,"context_line":"                    dirportal[0:self._properties[\u0027portal_number\u0027]])"},{"line_number":294,"context_line":"            else:"},{"line_number":295,"context_line":"                nominated.extend(dirportal)"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"        if len(nominated) \u003d\u003d 0:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_99019b06","line":294,"range":{"start_line":294,"start_character":16,"end_line":294,"end_character":17},"in_reply_to":"5f7c97a3_cf23d757","updated":"2018-07-17 02:05:35.000000000","message":"OK, I understood now. Please see Shunei Shiono\u0027s comment in PS1.","commit_id":"5a22d265093eec760de98a8fe7b16c52a83f27a3"}]}