)]}'
{"cinder/tests/unit/volume/drivers/test_remotefs.py":[{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"368b63d0b03ee8e50d1040d2be175e2144603820","unresolved":false,"context_lines":[{"line_number":681,"context_line":"        share_total_gb \u003d 3"},{"line_number":682,"context_line":"        share_free_gb \u003d 2"},{"line_number":683,"context_line":"        share_used_gb \u003d 4  # provisioned space"},{"line_number":684,"context_line":"        expected_allocated_gb \u003d share_total_gb - share_free_gb"},{"line_number":685,"context_line":""},{"line_number":686,"context_line":"        self._driver._mounted_shares \u003d [mock.sentinel.share]"},{"line_number":687,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_4a99fecc","line":684,"updated":"2018-07-26 09:13:12.000000000","message":"pl remove this variable also as it is in no use.","commit_id":"c42faee47866ae40c7bcfa5418cfb937869346e5"},{"author":{"_account_id":19844,"name":"Kien Ha","email":"kienha9922@gmail.com","username":"kien.ha"},"change_message_id":"e45fc24bcc4aac66a562dd3b0202492e3c75efef","unresolved":false,"context_lines":[{"line_number":681,"context_line":"        share_total_gb \u003d 3"},{"line_number":682,"context_line":"        share_free_gb \u003d 2"},{"line_number":683,"context_line":"        share_used_gb \u003d 4  # provisioned space"},{"line_number":684,"context_line":"        expected_allocated_gb \u003d share_total_gb - share_free_gb"},{"line_number":685,"context_line":""},{"line_number":686,"context_line":"        self._driver._mounted_shares \u003d [mock.sentinel.share]"},{"line_number":687,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_12ceaf2b","line":684,"in_reply_to":"5f7c97a3_4a99fecc","updated":"2018-07-29 00:32:18.000000000","message":"Done","commit_id":"c42faee47866ae40c7bcfa5418cfb937869346e5"}],"cinder/volume/drivers/remotefs.py":[{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"30a8a5706b7a686b67276bc4c373ff1cf79822fc","unresolved":false,"context_lines":[{"line_number":1740,"context_line":"                    \u0027total_capacity_gb\u0027: share_capacity / float(units.Gi),"},{"line_number":1741,"context_line":"                    \u0027free_capacity_gb\u0027: share_free / float(units.Gi),"},{"line_number":1742,"context_line":"                    \u0027provisioned_capacity_gb\u0027: self._get_provisioned_capacity,"},{"line_number":1743,"context_line":"                    \u0027allocated_capacity_gb\u0027: ("},{"line_number":1744,"context_line":"                        share_capacity - share_free) / float(units.Gi),"},{"line_number":1745,"context_line":"                    \u0027reserved_percentage\u0027: ("},{"line_number":1746,"context_line":"                        self.configuration.reserved_percentage),"},{"line_number":1747,"context_line":"                    \u0027max_over_subscription_ratio\u0027: ("}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_9d9c2c0f","line":1744,"range":{"start_line":1743,"start_character":20,"end_line":1744,"end_character":71},"updated":"2018-06-20 20:53:24.000000000","message":"-1: allocated_capacity_gb should not be reported by drivers.","commit_id":"18053f0f3fce5b1ffc0910dabc8816c2e78f55a6"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"787a8d6afc9688231aac1a60601b0466e3152c42","unresolved":false,"context_lines":[{"line_number":1732,"context_line":"        self._ensure_shares_mounted()"},{"line_number":1733,"context_line":""},{"line_number":1734,"context_line":"        for share in self._mounted_shares:"},{"line_number":1735,"context_line":"            (share_capacity,"},{"line_number":1736,"context_line":"             share_free,"},{"line_number":1737,"context_line":"             share_used) \u003d self._get_capacity_info(share)"},{"line_number":1738,"context_line":""},{"line_number":1739,"context_line":"            pool \u003d {\u0027pool_name\u0027: self._get_pool_name_from_share(share),"},{"line_number":1740,"context_line":"                    \u0027total_capacity_gb\u0027: share_capacity / float(units.Gi),"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_178fc12f","line":1737,"range":{"start_line":1735,"start_character":13,"end_line":1737,"end_character":23},"updated":"2018-07-25 19:32:11.000000000","message":"Hi Kien, yes this is confuse. Here is what each of these means:\n  share_capacity - Total capacity of the share. This is what you see in the \u0027size\u0027 column when you run \u0027df -h\u0027.\n  share_free - If you have a share let\u0027s say with 50GB, you might create a 20GB volume, but not start using, so it does not consume space. In this case, share free would be 50GB.\n  share_used - This name is not proper here. This variable should be \u0027share_allocated\u0027 or share provisioned. In the previous example, this would be 20GB.","commit_id":"240df8836aac934bf2daeececa0ea7b8c03ab1c9"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"4c8ec7ee49297cad24b9ab16517fd36fabbfc5c4","unresolved":false,"context_lines":[{"line_number":1739,"context_line":"            pool \u003d {\u0027pool_name\u0027: self._get_pool_name_from_share(share),"},{"line_number":1740,"context_line":"                    \u0027total_capacity_gb\u0027: share_capacity / float(units.Gi),"},{"line_number":1741,"context_line":"                    \u0027free_capacity_gb\u0027: share_free / float(units.Gi),"},{"line_number":1742,"context_line":"                    \u0027provisioned_capacity_gb\u0027: self._get_provisioned_capacity,"},{"line_number":1743,"context_line":"                    \u0027reserved_percentage\u0027: ("},{"line_number":1744,"context_line":"                        self.configuration.reserved_percentage),"},{"line_number":1745,"context_line":"                    \u0027max_over_subscription_ratio\u0027: ("}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_7b0dfc3e","line":1742,"range":{"start_line":1742,"start_character":47,"end_line":1742,"end_character":77},"updated":"2018-07-23 19:34:37.000000000","message":"This is a method...?","commit_id":"240df8836aac934bf2daeececa0ea7b8c03ab1c9"},{"author":{"_account_id":19844,"name":"Kien Ha","email":"kienha9922@gmail.com","username":"kien.ha"},"change_message_id":"f3f27c40cb83e277562023bb4d9623e6b5c9915a","unresolved":false,"context_lines":[{"line_number":1739,"context_line":"            pool \u003d {\u0027pool_name\u0027: self._get_pool_name_from_share(share),"},{"line_number":1740,"context_line":"                    \u0027total_capacity_gb\u0027: share_capacity / float(units.Gi),"},{"line_number":1741,"context_line":"                    \u0027free_capacity_gb\u0027: share_free / float(units.Gi),"},{"line_number":1742,"context_line":"                    \u0027provisioned_capacity_gb\u0027: self._get_provisioned_capacity,"},{"line_number":1743,"context_line":"                    \u0027reserved_percentage\u0027: ("},{"line_number":1744,"context_line":"                        self.configuration.reserved_percentage),"},{"line_number":1745,"context_line":"                    \u0027max_over_subscription_ratio\u0027: ("}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_30146750","line":1742,"range":{"start_line":1742,"start_character":47,"end_line":1742,"end_character":77},"in_reply_to":"5f7c97a3_7b0dfc3e","updated":"2018-07-24 16:59:14.000000000","message":"It most certainly is not. Sorry about this and thanks for pointing this out.","commit_id":"240df8836aac934bf2daeececa0ea7b8c03ab1c9"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"787a8d6afc9688231aac1a60601b0466e3152c42","unresolved":false,"context_lines":[{"line_number":1734,"context_line":"        for share in self._mounted_shares:"},{"line_number":1735,"context_line":"            (share_capacity,"},{"line_number":1736,"context_line":"             share_free,"},{"line_number":1737,"context_line":"             share_used) \u003d self._get_capacity_info(share)"},{"line_number":1738,"context_line":""},{"line_number":1739,"context_line":"            pool \u003d {\u0027pool_name\u0027: self._get_pool_name_from_share(share),"},{"line_number":1740,"context_line":"                    \u0027total_capacity_gb\u0027: share_capacity / float(units.Gi),"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_179d8157","line":1737,"range":{"start_line":1737,"start_character":13,"end_line":1737,"end_character":23},"updated":"2018-07-25 19:32:11.000000000","message":"rename this to total_allocated","commit_id":"c42faee47866ae40c7bcfa5418cfb937869346e5"},{"author":{"_account_id":19844,"name":"Kien Ha","email":"kienha9922@gmail.com","username":"kien.ha"},"change_message_id":"e45fc24bcc4aac66a562dd3b0202492e3c75efef","unresolved":false,"context_lines":[{"line_number":1734,"context_line":"        for share in self._mounted_shares:"},{"line_number":1735,"context_line":"            (share_capacity,"},{"line_number":1736,"context_line":"             share_free,"},{"line_number":1737,"context_line":"             share_used) \u003d self._get_capacity_info(share)"},{"line_number":1738,"context_line":""},{"line_number":1739,"context_line":"            pool \u003d {\u0027pool_name\u0027: self._get_pool_name_from_share(share),"},{"line_number":1740,"context_line":"                    \u0027total_capacity_gb\u0027: share_capacity / float(units.Gi),"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_b2d6dbc3","line":1737,"range":{"start_line":1737,"start_character":13,"end_line":1737,"end_character":23},"in_reply_to":"5f7c97a3_179d8157","updated":"2018-07-29 00:32:18.000000000","message":"Done","commit_id":"c42faee47866ae40c7bcfa5418cfb937869346e5"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"787a8d6afc9688231aac1a60601b0466e3152c42","unresolved":false,"context_lines":[{"line_number":1739,"context_line":"            pool \u003d {\u0027pool_name\u0027: self._get_pool_name_from_share(share),"},{"line_number":1740,"context_line":"                    \u0027total_capacity_gb\u0027: share_capacity / float(units.Gi),"},{"line_number":1741,"context_line":"                    \u0027free_capacity_gb\u0027: share_free / float(units.Gi),"},{"line_number":1742,"context_line":"                    \u0027provisioned_capacity_gb\u0027: (share_capacity - share_free) / float(units.Gi),"},{"line_number":1743,"context_line":"                    \u0027reserved_percentage\u0027: ("},{"line_number":1744,"context_line":"                        self.configuration.reserved_percentage),"},{"line_number":1745,"context_line":"                    \u0027max_over_subscription_ratio\u0027: ("}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_d7a629ad","line":1742,"range":{"start_line":1742,"start_character":47,"end_line":1742,"end_character":76},"updated":"2018-07-25 19:32:11.000000000","message":"\u0027provisioned_capacity_gb\u0027: total_allocated / float(units.Gi),","commit_id":"c42faee47866ae40c7bcfa5418cfb937869346e5"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"b807631811404af7f527bbb62c236b0f37ce7fd6","unresolved":false,"context_lines":[{"line_number":1739,"context_line":"            pool \u003d {\u0027pool_name\u0027: self._get_pool_name_from_share(share),"},{"line_number":1740,"context_line":"                    \u0027total_capacity_gb\u0027: share_capacity / float(units.Gi),"},{"line_number":1741,"context_line":"                    \u0027free_capacity_gb\u0027: share_free / float(units.Gi),"},{"line_number":1742,"context_line":"                    \u0027provisioned_capacity_gb\u0027: (share_capacity - share_free) / float(units.Gi),"},{"line_number":1743,"context_line":"                    \u0027reserved_percentage\u0027: ("},{"line_number":1744,"context_line":"                        self.configuration.reserved_percentage),"},{"line_number":1745,"context_line":"                    \u0027max_over_subscription_ratio\u0027: ("}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_b524bcc4","line":1742,"range":{"start_line":1742,"start_character":47,"end_line":1742,"end_character":76},"in_reply_to":"5f7c97a3_d7a629ad","updated":"2018-07-26 06:47:48.000000000","message":"+1","commit_id":"c42faee47866ae40c7bcfa5418cfb937869346e5"},{"author":{"_account_id":19844,"name":"Kien Ha","email":"kienha9922@gmail.com","username":"kien.ha"},"change_message_id":"e45fc24bcc4aac66a562dd3b0202492e3c75efef","unresolved":false,"context_lines":[{"line_number":1739,"context_line":"            pool \u003d {\u0027pool_name\u0027: self._get_pool_name_from_share(share),"},{"line_number":1740,"context_line":"                    \u0027total_capacity_gb\u0027: share_capacity / float(units.Gi),"},{"line_number":1741,"context_line":"                    \u0027free_capacity_gb\u0027: share_free / float(units.Gi),"},{"line_number":1742,"context_line":"                    \u0027provisioned_capacity_gb\u0027: (share_capacity - share_free) / float(units.Gi),"},{"line_number":1743,"context_line":"                    \u0027reserved_percentage\u0027: ("},{"line_number":1744,"context_line":"                        self.configuration.reserved_percentage),"},{"line_number":1745,"context_line":"                    \u0027max_over_subscription_ratio\u0027: ("}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_92d95ff2","line":1742,"range":{"start_line":1742,"start_character":47,"end_line":1742,"end_character":76},"in_reply_to":"5f7c97a3_d7a629ad","updated":"2018-07-29 00:32:18.000000000","message":"Done","commit_id":"c42faee47866ae40c7bcfa5418cfb937869346e5"}]}