)]}'
{"cinder/volume/drivers/netapp/utils.py":[{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"96a29806c7609b6f541ce09c91f4c17d4797b8f8","unresolved":false,"context_lines":[{"line_number":263,"context_line":"    # If the configuration parameter is specified as an empty string"},{"line_number":264,"context_line":"    # (interpreted as matching all pools), we replace it here with"},{"line_number":265,"context_line":"    # (.+) to be explicit with CSV compatibility support implemented below."},{"line_number":266,"context_line":"    pool_patterns \u003d configuration.netapp_pool_name_search_pattern or r\u0027(.+)\u0027"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"    # Strip whitespace from start/end and then \u0027or\u0027 all regex patterns"},{"line_number":269,"context_line":"    pool_patterns \u003d \u0027|\u0027.join([\u0027^\u0027 + pool_pattern.strip(\u0027^$ \\t\u0027) + \u0027$\u0027 for"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_0213cbb9","line":266,"range":{"start_line":266,"start_character":34,"end_line":266,"end_character":65},"updated":"2018-06-21 11:23:01.000000000","message":"Shouldn\u0027t we re.escape() those patterns receive by parameters?\ncinder/volume/drivers/vmware/vmdk.py:1839 also has something like that.","commit_id":"09654af5180942dc73fe9732331ad9f4aae2d3d2"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"968b90a0ba7e6a9e5f669ff9563ed07954dbac6e","unresolved":false,"context_lines":[{"line_number":263,"context_line":"    # If the configuration parameter is specified as an empty string"},{"line_number":264,"context_line":"    # (interpreted as matching all pools), we replace it here with"},{"line_number":265,"context_line":"    # (.+) to be explicit with CSV compatibility support implemented below."},{"line_number":266,"context_line":"    pool_patterns \u003d configuration.netapp_pool_name_search_pattern or r\u0027(.+)\u0027"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"    # Strip whitespace from start/end and then \u0027or\u0027 all regex patterns"},{"line_number":269,"context_line":"    pool_patterns \u003d \u0027|\u0027.join([\u0027^\u0027 + pool_pattern.strip(\u0027^$ \\t\u0027) + \u0027$\u0027 for"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_c2e4f3aa","line":266,"range":{"start_line":266,"start_character":34,"end_line":266,"end_character":65},"in_reply_to":"5f7c97a3_0213cbb9","updated":"2018-06-21 11:25:45.000000000","message":"I don\u0027t believe so. That would change the behavior by potentially escaping things that were not escaped before. Config settings should be passed through directly.\n\nAt any rate, that\u0027s not really in the scope of what this patch is addressing.","commit_id":"09654af5180942dc73fe9732331ad9f4aae2d3d2"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"ab88b851be8bcc6eabe9ee09fb7e47cc8c86ba6b","unresolved":false,"context_lines":[{"line_number":263,"context_line":"    # If the configuration parameter is specified as an empty string"},{"line_number":264,"context_line":"    # (interpreted as matching all pools), we replace it here with"},{"line_number":265,"context_line":"    # (.+) to be explicit with CSV compatibility support implemented below."},{"line_number":266,"context_line":"    pool_patterns \u003d configuration.netapp_pool_name_search_pattern or r\u0027(.+)\u0027"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"    # Strip whitespace from start/end and then \u0027or\u0027 all regex patterns"},{"line_number":269,"context_line":"    pool_patterns \u003d \u0027|\u0027.join([\u0027^\u0027 + pool_pattern.strip(\u0027^$ \\t\u0027) + \u0027$\u0027 for"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_628abfbc","line":266,"range":{"start_line":266,"start_character":34,"end_line":266,"end_character":65},"in_reply_to":"5f7c97a3_c2e4f3aa","updated":"2018-06-21 11:27:51.000000000","message":"Hmm, ok, thanks for clarifying.","commit_id":"09654af5180942dc73fe9732331ad9f4aae2d3d2"}]}